@effected/github 0.4.2 → 0.4.3

package/GitHubRepository.js

@@ -29,14 +29,23 @@ const SECURITY_ANALYSIS_STATUS_FIELDS = /* @__PURE__ */ new Set([
 * mapped from snake_case keys to camelCase GraphQL input fields.
 *
 * @remarks
-* GitHub never exposed these two on the REST repository endpoint. Setting
-* either forces a second round trip to learn the repository's node id.
+* GitHub never exposed these on the REST repository endpoint — the
+* `PATCH /repos/{owner}/{repo}` route accepts none of them, and
+* `has_discussions` is the treacherous one: the REST **read** returns it, so
+* routing its write to the PATCH looks symmetric, but the PATCH silently
+* ignores unknown body fields and answers 200 — reported as applied on every
+* run while the repository never changed (effected#358). Setting any of these
+* forces a second round trip to learn the repository's node id.
+*
+* Field names verified against `UpdateRepositoryInput` by live introspection,
+* 2026-08-15.
 *
 * @public
 */
 const GRAPHQL_ONLY_SETTINGS = {
 	has_sponsorships: "hasSponsorshipsEnabled",
-	has_pull_requests: "hasPullRequestsEnabled"
+	has_pull_requests: "hasPullRequestsEnabled",
+	has_discussions: "hasDiscussionsEnabled"
 };
 /** `{ status: "enabled" | "disabled" }` — the form GitHub accepts and the type declares. */
 const isStatusObject = (raw) => {

package/index.d.ts

@@ -2009,6 +2009,19 @@ interface GitHubIssueShape {
    * @remarks
    * The idempotence guard one consumer wrote a bespoke timeline query for,
    * so that re-running a workflow does not comment twice.
+   *
+   * Two hazards before building on it (effected#306):
+   *
+   * - **An issue obtained from `linkedIssues(pr)` answers `true` from the
+   *   outset** — the closing link itself puts a cross-reference on the
+   *   issue's timeline. As a "have I commented yet?" guard on those issues
+   *   the answer is always yes, and the comment is never posted. Guard a
+   *   comment by looking for the comment (a marker in its body), not for a
+   *   cross-reference.
+   * - **It observes `CROSS_REFERENCED_EVENT` only, not `ConnectedEvent`** —
+   *   an issue a human attached through the sidebar's Development section is
+   *   connected, not cross-referenced, and reads `false` here even though
+   *   GitHub's UI shows the link.
    */
   readonly isCrossReferencedBy: (issueNumber: number, prNumber: number) => Effect.Effect<boolean, GitHubGraphQLError, Repo>;
 }
@@ -2166,8 +2179,16 @@ declare const SECURITY_ANALYSIS_STATUS_FIELDS: ReadonlySet<string>;
  * mapped from snake_case keys to camelCase GraphQL input fields.
  *
  * @remarks
- * GitHub never exposed these two on the REST repository endpoint. Setting
- * either forces a second round trip to learn the repository's node id.
+ * GitHub never exposed these on the REST repository endpoint — the
+ * `PATCH /repos/{owner}/{repo}` route accepts none of them, and
+ * `has_discussions` is the treacherous one: the REST **read** returns it, so
+ * routing its write to the PATCH looks symmetric, but the PATCH silently
+ * ignores unknown body fields and answers 200 — reported as applied on every
+ * run while the repository never changed (effected#358). Setting any of these
+ * forces a second round trip to learn the repository's node id.
+ *
+ * Field names verified against `UpdateRepositoryInput` by live introspection,
+ * 2026-08-15.
  *
  * @public
  */

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@effected/github",
-	"version": "0.4.2",
+	"version": "0.4.3",
 	"private": false,
 	"description": "Typed GitHub REST and GraphQL services over the octokit core request surface, with app auth and resource helpers.",
 	"keywords": [