@effected/github 0.4.1 → 0.4.3

package/GitHubIssue.js

@@ -107,6 +107,30 @@ var GitHubIssue = class GitHubIssue extends Context.Service()("@effected/github/
 const unstubbed = (member) => {
 	throw new Error(`GitHubIssue.makeTest: ${member}() was called but not stubbed — pass an override.`);
 };
+/**
+* The REST calendar version this module's requests pin.
+*
+* @remarks
+* The routes are not deprecated — the **default api-version** is. When no
+* `x-github-api-version` header is sent (octokit sends none), GitHub serves
+* calendar version 2022-11-28, which it deprecated when 2026-03-10 shipped and
+* sunsets on 2028-03-10. Every response from an endpoint the new version
+* changed then carries a `Deprecation` header, which `@octokit/request` prints
+* straight to the consumer's console — the constructor's `log` option cannot
+* silence it, because the fetch wrapper resolves `request.log ?? console`.
+* `PATCH /repos/{owner}/{repo}/issues/{issue_number}` is on that list (the
+* singular `assignee` parameter was removed), so every `close` warned once per
+* issue in consumer workflow logs (effected#189).
+*
+* Nothing this module sends or reads changed in 2026-03-10: `state` and
+* `state_reason` are untouched, and the projections read only fields both
+* versions carry. Pinning the current version is therefore the whole fix, and
+* it deliberately does **not** hide future deprecations — when GitHub
+* deprecates 2026-03-10 in turn, the header comes back and octokit warns
+* again. Verified live 2026-08-14: the pinned request answers with no
+* `Deprecation`/`Sunset` headers.
+*/
+const API_VERSION_HEADERS = { "x-github-api-version": "2026-03-10" };
 /** GitHub sends a label as either a string or an object; callers want the name. */
 const labelNames = (labels) => labels.flatMap((label) => typeof label === "string" ? [label] : label.name !== void 0 ? [label.name] : []);
 const project = (raw) => IssueInfo.make({
@@ -128,7 +152,8 @@ const make = (client) => ({
 		const raw = yield* client.request("GET /repos/{owner}/{repo}/issues/{issue_number}", {
 			owner,
 			repo,
-			issue_number: number
+			issue_number: number,
+			headers: API_VERSION_HEADERS
 		});
 		return project(raw);
 	}),
@@ -142,7 +167,8 @@ const make = (client) => ({
 			owner,
 			repo,
 			...options?.state !== void 0 ? { state: options.state } : {},
-			...options?.labels !== void 0 ? { labels: options.labels.join(",") } : {}
+			...options?.labels !== void 0 ? { labels: options.labels.join(",") } : {},
+			headers: API_VERSION_HEADERS
 		}, options?.page)).map(project);
 	}),
 	close: Effect.fn("GitHubIssue.close")(function* (number, reason) {
@@ -157,7 +183,8 @@ const make = (client) => ({
 			repo,
 			issue_number: number,
 			state: "closed",
-			...reason !== void 0 ? { state_reason: reason } : {}
+			...reason !== void 0 ? { state_reason: reason } : {},
+			headers: API_VERSION_HEADERS
 		});
 	}),
 	comment: Effect.fn("GitHubIssue.comment")(function* (number, body) {
@@ -171,7 +198,8 @@ const make = (client) => ({
 			owner,
 			repo,
 			issue_number: number,
-			body
+			body,
+			headers: API_VERSION_HEADERS
 		})).id;
 	}),
 	linkedIssues: Effect.fn("GitHubIssue.linkedIssues")(function* (prNumber) {

package/GitHubRepository.js

@@ -29,14 +29,23 @@ const SECURITY_ANALYSIS_STATUS_FIELDS = /* @__PURE__ */ new Set([
 * mapped from snake_case keys to camelCase GraphQL input fields.
 *
 * @remarks
-* GitHub never exposed these two on the REST repository endpoint. Setting
-* either forces a second round trip to learn the repository's node id.
+* GitHub never exposed these on the REST repository endpoint — the
+* `PATCH /repos/{owner}/{repo}` route accepts none of them, and
+* `has_discussions` is the treacherous one: the REST **read** returns it, so
+* routing its write to the PATCH looks symmetric, but the PATCH silently
+* ignores unknown body fields and answers 200 — reported as applied on every
+* run while the repository never changed (effected#358). Setting any of these
+* forces a second round trip to learn the repository's node id.
+*
+* Field names verified against `UpdateRepositoryInput` by live introspection,
+* 2026-08-15.
 *
 * @public
 */
 const GRAPHQL_ONLY_SETTINGS = {
 	has_sponsorships: "hasSponsorshipsEnabled",
-	has_pull_requests: "hasPullRequestsEnabled"
+	has_pull_requests: "hasPullRequestsEnabled",
+	has_discussions: "hasDiscussionsEnabled"
 };
 /** `{ status: "enabled" | "disabled" }` — the form GitHub accepts and the type declares. */
 const isStatusObject = (raw) => {

package/index.d.ts

@@ -2009,6 +2009,19 @@ interface GitHubIssueShape {
    * @remarks
    * The idempotence guard one consumer wrote a bespoke timeline query for,
    * so that re-running a workflow does not comment twice.
+   *
+   * Two hazards before building on it (effected#306):
+   *
+   * - **An issue obtained from `linkedIssues(pr)` answers `true` from the
+   *   outset** — the closing link itself puts a cross-reference on the
+   *   issue's timeline. As a "have I commented yet?" guard on those issues
+   *   the answer is always yes, and the comment is never posted. Guard a
+   *   comment by looking for the comment (a marker in its body), not for a
+   *   cross-reference.
+   * - **It observes `CROSS_REFERENCED_EVENT` only, not `ConnectedEvent`** —
+   *   an issue a human attached through the sidebar's Development section is
+   *   connected, not cross-referenced, and reads `false` here even though
+   *   GitHub's UI shows the link.
    */
   readonly isCrossReferencedBy: (issueNumber: number, prNumber: number) => Effect.Effect<boolean, GitHubGraphQLError, Repo>;
 }
@@ -2166,8 +2179,16 @@ declare const SECURITY_ANALYSIS_STATUS_FIELDS: ReadonlySet<string>;
  * mapped from snake_case keys to camelCase GraphQL input fields.
  *
  * @remarks
- * GitHub never exposed these two on the REST repository endpoint. Setting
- * either forces a second round trip to learn the repository's node id.
+ * GitHub never exposed these on the REST repository endpoint — the
+ * `PATCH /repos/{owner}/{repo}` route accepts none of them, and
+ * `has_discussions` is the treacherous one: the REST **read** returns it, so
+ * routing its write to the PATCH looks symmetric, but the PATCH silently
+ * ignores unknown body fields and answers 200 — reported as applied on every
+ * run while the repository never changed (effected#358). Setting any of these
+ * forces a second round trip to learn the repository's node id.
+ *
+ * Field names verified against `UpdateRepositoryInput` by live introspection,
+ * 2026-08-15.
  *
  * @public
  */

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@effected/github",
-	"version": "0.4.1",
+	"version": "0.4.3",
 	"private": false,
 	"description": "Typed GitHub REST and GraphQL services over the octokit core request surface, with app auth and resource helpers.",
 	"keywords": [