@effected/github 0.4.0 → 0.4.1

package/index.d.ts

@@ -1165,6 +1165,15 @@ interface CodeScanningShape {
    * The endpoint answers **202 Accepted** and configures asynchronously.
    * Nothing here polls: a successful call means GitHub accepted the request,
    * not that scanning is running.
+   *
+   * **Turning it back off does not undo everything it did.** Setting `state`
+   * to `not-configured` stops default setup, but the synthetic CodeQL workflow
+   * GitHub created when it was enabled **survives** — it remains listed among
+   * the repository's workflows afterwards. A caller that treats "default setup
+   * is off" as "no CodeQL workflow exists" will be wrong, and one that counts
+   * workflows to decide whether a repository has any CI will count that one.
+   * Reported by `@spencerbeggs/reposets` (dogfood round 8, 2026-08-14) from a
+   * real organization, not inferred from the API description.
    */
   readonly configure: (setup: CodeScanningSetup) => Effect.Effect<void, GitHubError, Repo>;
   /**
@@ -2827,6 +2836,18 @@ interface RepositoryVariableShape {
    * `notFound` is absorbed — a 403 from a mis-scoped token still fails, where
    * treating any error as absence would turn a permissions problem into a
    * spurious create.
+   *
+   * **The 404-for-absent behaviour is documented, not probed.** Neither this
+   * suite nor the first consumer's has issued this read against real GitHub —
+   * both run against doubles.
+   *
+   * Only `notFound` selects the create branch: a successful read selects the
+   * update branch, and any other failure propagates rather than being guessed
+   * at. So if GitHub answers something *other* than 404 for an absent
+   * variable, the write does not silently take the wrong branch — it either
+   * `PATCH`es a variable that is not there, or fails with the error GitHub
+   * actually sent. Read either as evidence about this assumption rather than
+   * about the caller.
    */
   readonly set: (name: string, value: string) => Effect.Effect<void, GitHubError, Repo>;
   /** The repository's variables, with their values. */

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@effected/github",
-	"version": "0.4.0",
+	"version": "0.4.1",
 	"private": false,
 	"description": "Typed GitHub REST and GraphQL services over the octokit core request surface, with app auth and resource helpers.",
 	"keywords": [