@effect/language-service 0.80.0 → 0.81.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@effect/language-service",
-  "version": "0.80.0",
+  "version": "0.81.0",
   "description": "A Language-Service Plugin to Refactor and Diagnostic effect-ts projects",
   "main": "index.cjs",
   "bin": {

package/transform.js

@@ -5269,6 +5269,7 @@ var anyUnknownInErrorContext = createDiagnostic({
   name: "anyUnknownInErrorContext",
   code: 28,
   description: "Detects 'any' or 'unknown' types in Effect error or requirements channels",
+  group: "correctness",
   severity: "off",
   fixable: false,
   supportedEffect: ["v3", "v4"],
@@ -5374,6 +5375,7 @@ var catchAllToMapError = createDiagnostic({
   name: "catchAllToMapError",
   code: 39,
   description: "Suggests using Effect.mapError instead of Effect.catchAll when the callback only wraps the error with Effect.fail",
+  group: "style",
   severity: "suggestion",
   fixable: true,
   supportedEffect: ["v3", "v4"],
@@ -5473,6 +5475,7 @@ var catchUnfailableEffect = createDiagnostic({
   name: "catchUnfailableEffect",
   code: 2,
   description: "Warns when using error handling on Effects that never fail (error type is 'never')",
+  group: "antipattern",
   severity: "suggestion",
   fixable: false,
   supportedEffect: ["v3", "v4"],
@@ -5524,6 +5527,7 @@ var classSelfMismatch = createDiagnostic({
   name: "classSelfMismatch",
   code: 20,
   description: "Ensures Self type parameter matches the class name in Service/Tag/Schema classes",
+  group: "correctness",
   severity: "error",
   fixable: true,
   supportedEffect: ["v3", "v4"],
@@ -5664,6 +5668,7 @@ var deterministicKeys = createDiagnostic({
   name: "deterministicKeys",
   code: 25,
   description: "Enforces deterministic naming for service/tag/error identifiers based on class names",
+  group: "style",
   severity: "off",
   fixable: true,
   supportedEffect: ["v3", "v4"],
@@ -5783,6 +5788,7 @@ var duplicatePackage = createDiagnostic({
   name: "duplicatePackage",
   code: 6,
   description: "Detects when multiple versions of the same Effect package are loaded",
+  group: "correctness",
   severity: "warning",
   fixable: false,
   supportedEffect: ["v3", "v4"],
@@ -5814,6 +5820,7 @@ var effectFnIife = createDiagnostic({
   name: "effectFnIife",
   code: 46,
   description: "Effect.fn or Effect.fnUntraced is called as an IIFE (Immediately Invoked Function Expression). Use Effect.gen instead.",
+  group: "antipattern",
   severity: "warning",
   fixable: true,
   supportedEffect: ["v3", "v4"],
@@ -5918,6 +5925,7 @@ var effectFnOpportunity = createDiagnostic({
   name: "effectFnOpportunity",
   code: 41,
   description: "Suggests using Effect.fn for functions that returns an Effect",
+  group: "style",
   severity: "suggestion",
   fixable: true,
   supportedEffect: ["v3", "v4"],
@@ -6512,6 +6520,7 @@ var effectGenUsesAdapter = createDiagnostic({
   name: "effectGenUsesAdapter",
   code: 23,
   description: "Warns when using the deprecated adapter parameter in Effect.gen",
+  group: "antipattern",
   severity: "warning",
   fixable: false,
   supportedEffect: ["v3", "v4"],
@@ -6552,6 +6561,7 @@ var effectInFailure = createDiagnostic({
   name: "effectInFailure",
   code: 49,
   description: "Warns when an Effect is used inside an Effect failure channel",
+  group: "antipattern",
   severity: "warning",
   fixable: false,
   supportedEffect: ["v3", "v4"],
@@ -6618,6 +6628,7 @@ var effectInVoidSuccess = createDiagnostic({
   name: "effectInVoidSuccess",
   code: 14,
   description: "Detects nested Effects in void success channels that may cause unexecuted effects",
+  group: "antipattern",
   severity: "warning",
   fixable: false,
   supportedEffect: ["v3", "v4"],
@@ -6669,6 +6680,7 @@ var effectMapVoid = createDiagnostic({
   name: "effectMapVoid",
   code: 40,
   description: "Suggests using Effect.asVoid instead of Effect.map(() => void 0), Effect.map(() => undefined), or Effect.map(() => {})",
+  group: "style",
   severity: "suggestion",
   fixable: true,
   supportedEffect: ["v3", "v4"],
@@ -6735,6 +6747,7 @@ var effectSucceedWithVoid = createDiagnostic({
   name: "effectSucceedWithVoid",
   code: 47,
   description: "Suggests using Effect.void instead of Effect.succeed(undefined) or Effect.succeed(void 0)",
+  group: "style",
   severity: "suggestion",
   fixable: true,
   supportedEffect: ["v3", "v4"],
@@ -6788,6 +6801,7 @@ var extendsNativeError = createDiagnostic({
   name: "extendsNativeError",
   code: 50,
   description: "Warns when a class directly extends the native Error class",
+  group: "effectNative",
   severity: "off",
   fixable: false,
   supportedEffect: ["v3", "v4"],
@@ -6840,6 +6854,7 @@ var floatingEffect = createDiagnostic({
   name: "floatingEffect",
   code: 3,
   description: "Ensures Effects are yielded or assigned to variables, not left floating",
+  group: "correctness",
   severity: "error",
   fixable: false,
   supportedEffect: ["v3", "v4"],
@@ -6893,6 +6908,7 @@ var genericEffectServices = createDiagnostic({
   name: "genericEffectServices",
   code: 10,
   description: "Prevents services with type parameters that cannot be discriminated at runtime",
+  group: "correctness",
   severity: "warning",
   fixable: false,
   supportedEffect: ["v3", "v4"],
@@ -6942,6 +6958,7 @@ var globalErrorInEffectCatch = createDiagnostic({
   name: "globalErrorInEffectCatch",
   code: 36,
   description: "Warns when catch callbacks return global Error type instead of typed errors",
+  group: "antipattern",
   severity: "warning",
   fixable: false,
   supportedEffect: ["v3", "v4"],
@@ -7004,6 +7021,7 @@ var globalErrorInEffectFailure = createDiagnostic({
   name: "globalErrorInEffectFailure",
   code: 35,
   description: "Warns when the global Error type is used in an Effect failure channel",
+  group: "antipattern",
   severity: "warning",
   fixable: false,
   supportedEffect: ["v3", "v4"],
@@ -7054,11 +7072,54 @@ var globalErrorInEffectFailure = createDiagnostic({
   })
 });
 
+// src/diagnostics/globalFetch.ts
+var globalFetch = createDiagnostic({
+  name: "globalFetch",
+  code: 53,
+  description: "Warns when using the global fetch function instead of the Effect HTTP client",
+  group: "effectNative",
+  severity: "off",
+  fixable: false,
+  supportedEffect: ["v3", "v4"],
+  apply: fn("globalFetch.apply")(function* (sourceFile, report) {
+    const ts = yield* service(TypeScriptApi);
+    const typeChecker = yield* service(TypeCheckerApi);
+    const typeParser = yield* service(TypeParser);
+    const fetchSymbol = typeChecker.resolveName("fetch", void 0, ts.SymbolFlags.Value, false);
+    if (!fetchSymbol) return;
+    const effectVersion = typeParser.supportedEffect();
+    const packageName = effectVersion === "v3" ? "@effect/platform" : "effect/unstable/http";
+    const messageText = `Prefer using HttpClient from ${packageName} instead of the global 'fetch' function.`;
+    const nodeToVisit = [];
+    const appendNodeToVisit = (node) => {
+      nodeToVisit.push(node);
+      return void 0;
+    };
+    ts.forEachChild(sourceFile, appendNodeToVisit);
+    while (nodeToVisit.length > 0) {
+      const node = nodeToVisit.shift();
+      if (ts.isCallExpression(node)) {
+        const symbol3 = typeChecker.getSymbolAtLocation(node.expression);
+        const resolvedSymbol = symbol3 && symbol3.flags & ts.SymbolFlags.Alias ? typeChecker.getAliasedSymbol(symbol3) : symbol3;
+        if (resolvedSymbol === fetchSymbol) {
+          report({
+            location: node.expression,
+            messageText,
+            fixes: []
+          });
+        }
+      }
+      ts.forEachChild(node, appendNodeToVisit);
+    }
+  })
+});
+
 // src/diagnostics/importFromBarrel.ts
 var importFromBarrel = createDiagnostic({
   name: "importFromBarrel",
   code: 12,
   description: "Suggests importing from specific module paths instead of barrel exports",
+  group: "style",
   severity: "off",
   fixable: true,
   supportedEffect: ["v3", "v4"],
@@ -7201,6 +7262,7 @@ var instanceOfSchema = createDiagnostic({
   name: "instanceOfSchema",
   code: 45,
   description: "Suggests using Schema.is instead of instanceof for Effect Schema types",
+  group: "effectNative",
   severity: "off",
   fixable: true,
   supportedEffect: ["v3", "v4"],
@@ -7266,6 +7328,7 @@ var layerMergeAllWithDependencies = createDiagnostic({
   name: "layerMergeAllWithDependencies",
   code: 37,
   description: "Detects interdependencies in Layer.mergeAll calls where one layer provides a service that another layer requires",
+  group: "antipattern",
   severity: "warning",
   fixable: true,
   supportedEffect: ["v3", "v4"],
@@ -7381,6 +7444,7 @@ var leakingRequirements = createDiagnostic({
   name: "leakingRequirements",
   code: 8,
   description: "Detects implementation services leaked in service methods",
+  group: "antipattern",
   severity: "suggestion",
   fixable: false,
   supportedEffect: ["v3", "v4"],
@@ -7537,6 +7601,7 @@ var missedPipeableOpportunity = createDiagnostic({
   name: "missedPipeableOpportunity",
   code: 26,
   description: "Enforces the use of pipeable style for nested function calls",
+  group: "style",
   severity: "off",
   fixable: true,
   supportedEffect: ["v3", "v4"],
@@ -7719,6 +7784,7 @@ var missingEffectContext = createDiagnostic({
   name: "missingEffectContext",
   code: 1,
   description: "Reports missing service requirements in Effect context channel",
+  group: "correctness",
   severity: "error",
   fixable: false,
   supportedEffect: ["v3", "v4"],
@@ -7770,6 +7836,7 @@ var missingEffectError = createDiagnostic({
   name: "missingEffectError",
   code: 1,
   description: "Reports missing error types in Effect error channel",
+  group: "correctness",
   severity: "error",
   fixable: true,
   supportedEffect: ["v3", "v4"],
@@ -7913,6 +7980,7 @@ var missingEffectServiceDependency = createDiagnostic({
   name: "missingEffectServiceDependency",
   code: 22,
   description: "Checks that Effect.Service dependencies satisfy all required layer inputs",
+  group: "style",
   severity: "off",
   fixable: false,
   supportedEffect: ["v3"],
@@ -8009,6 +8077,7 @@ var missingLayerContext = createDiagnostic({
   name: "missingLayerContext",
   code: 38,
   description: "Reports missing service requirements in Layer context channel",
+  group: "correctness",
   severity: "error",
   fixable: false,
   supportedEffect: ["v3", "v4"],
@@ -8060,6 +8129,7 @@ var missingReturnYieldStar = createDiagnostic({
   name: "missingReturnYieldStar",
   code: 7,
   description: "Suggests using 'return yield*' for Effects with never success for better type narrowing",
+  group: "correctness",
   severity: "error",
   fixable: true,
   supportedEffect: ["v3", "v4"],
@@ -8112,6 +8182,7 @@ var missingStarInYieldEffectGen = createDiagnostic({
   name: "missingStarInYieldEffectGen",
   code: 4,
   description: "Enforces using 'yield*' instead of 'yield' when yielding Effects in generators",
+  group: "correctness",
   severity: "error",
   fixable: true,
   supportedEffect: ["v3", "v4"],
@@ -8189,6 +8260,7 @@ var multipleEffectProvide = createDiagnostic({
   name: "multipleEffectProvide",
   code: 18,
   description: "Warns against chaining Effect.provide calls which can cause service lifecycle issues",
+  group: "antipattern",
   severity: "warning",
   fixable: true,
   supportedEffect: ["v3", "v4"],
@@ -8291,7 +8363,11 @@ var moduleAlternativesV3 = /* @__PURE__ */ new Map([
   ["path/win32", { alternative: "Path", module: "path", package: "@effect/platform" }],
   ["node:path/win32", { alternative: "Path", module: "path", package: "@effect/platform" }],
   ["child_process", { alternative: "CommandExecutor", module: "child_process", package: "@effect/platform" }],
-  ["node:child_process", { alternative: "CommandExecutor", module: "child_process", package: "@effect/platform" }]
+  ["node:child_process", { alternative: "CommandExecutor", module: "child_process", package: "@effect/platform" }],
+  ["http", { alternative: "HttpClient", module: "http", package: "@effect/platform" }],
+  ["node:http", { alternative: "HttpClient", module: "http", package: "@effect/platform" }],
+  ["https", { alternative: "HttpClient", module: "https", package: "@effect/platform" }],
+  ["node:https", { alternative: "HttpClient", module: "https", package: "@effect/platform" }]
 ]);
 var moduleAlternativesV4 = /* @__PURE__ */ new Map([
   ["fs", { alternative: "FileSystem", module: "fs", package: "effect" }],
@@ -8305,12 +8381,17 @@ var moduleAlternativesV4 = /* @__PURE__ */ new Map([
   ["path/win32", { alternative: "Path", module: "path", package: "effect" }],
   ["node:path/win32", { alternative: "Path", module: "path", package: "effect" }],
   ["child_process", { alternative: "ChildProcess", module: "child_process", package: "effect" }],
-  ["node:child_process", { alternative: "ChildProcess", module: "child_process", package: "effect" }]
+  ["node:child_process", { alternative: "ChildProcess", module: "child_process", package: "effect" }],
+  ["http", { alternative: "HttpClient", module: "http", package: "effect/unstable/http" }],
+  ["node:http", { alternative: "HttpClient", module: "http", package: "effect/unstable/http" }],
+  ["https", { alternative: "HttpClient", module: "https", package: "effect/unstable/http" }],
+  ["node:https", { alternative: "HttpClient", module: "https", package: "effect/unstable/http" }]
 ]);
 var nodeBuiltinImport = createDiagnostic({
   name: "nodeBuiltinImport",
   code: 52,
   description: "Warns when importing Node.js built-in modules that have Effect-native counterparts",
+  group: "effectNative",
   severity: "off",
   fixable: false,
   supportedEffect: ["v3", "v4"],
@@ -8354,6 +8435,7 @@ var nonObjectEffectServiceType = createDiagnostic({
   name: "nonObjectEffectServiceType",
   code: 24,
   description: "Ensures Effect.Service types are objects, not primitives",
+  group: "correctness",
   severity: "error",
   fixable: false,
   supportedEffect: ["v3"],
@@ -9138,6 +9220,7 @@ var outdatedApi = createDiagnostic({
   name: "outdatedApi",
   code: 48,
   description: "Detects usage of APIs that have been removed or renamed in Effect v4",
+  group: "correctness",
   severity: "warning",
   fixable: false,
   supportedEffect: ["v4"],
@@ -10276,6 +10359,7 @@ var outdatedEffectCodegen = createDiagnostic({
   name: "outdatedEffectCodegen",
   code: 19,
   description: "Detects when generated code is outdated and needs to be regenerated",
+  group: "correctness",
   severity: "warning",
   fixable: true,
   supportedEffect: ["v3", "v4"],
@@ -10324,6 +10408,7 @@ var overriddenSchemaConstructor = createDiagnostic({
   name: "overriddenSchemaConstructor",
   code: 30,
   description: "Prevents overriding constructors in Schema classes which breaks decoding behavior",
+  group: "correctness",
   severity: "error",
   fixable: true,
   supportedEffect: ["v3", "v4"],
@@ -10463,6 +10548,7 @@ var preferSchemaOverJson = createDiagnostic({
   name: "preferSchemaOverJson",
   code: 44,
   description: "Suggests using Effect Schema for JSON operations instead of JSON.parse/JSON.stringify which may throw",
+  group: "effectNative",
   severity: "suggestion",
   fixable: false,
   supportedEffect: ["v3", "v4"],
@@ -10575,6 +10661,7 @@ var redundantSchemaTagIdentifier = createDiagnostic({
   name: "redundantSchemaTagIdentifier",
   code: 42,
   description: "Suggests removing redundant identifier argument when it equals the tag value in Schema.TaggedClass/TaggedError/TaggedRequest",
+  group: "style",
   severity: "suggestion",
   fixable: true,
   supportedEffect: ["v3", "v4"],
@@ -10627,6 +10714,7 @@ var returnEffectInGen = createDiagnostic({
   name: "returnEffectInGen",
   code: 11,
   description: "Warns when returning an Effect in a generator causes nested Effect<Effect<...>>",
+  group: "antipattern",
   severity: "suggestion",
   fixable: true,
   supportedEffect: ["v3", "v4"],
@@ -10698,6 +10786,7 @@ var runEffectInsideEffect = createDiagnostic({
   name: "runEffectInsideEffect",
   code: 32,
   description: "Suggests using Runtime methods instead of Effect.run* inside Effect contexts",
+  group: "antipattern",
   severity: "suggestion",
   fixable: true,
   supportedEffect: ["v3"],
@@ -10824,6 +10913,7 @@ var schemaStructWithTag = createDiagnostic({
   name: "schemaStructWithTag",
   code: 34,
   description: "Suggests using Schema.TaggedStruct instead of Schema.Struct with _tag field",
+  group: "style",
   severity: "suggestion",
   fixable: true,
   supportedEffect: ["v3", "v4"],
@@ -10918,9 +11008,10 @@ var schemaSyncInEffect = createDiagnostic({
   name: "schemaSyncInEffect",
   code: 43,
   description: "Suggests using Effect-based Schema methods instead of sync methods inside Effect generators",
+  group: "antipattern",
   severity: "suggestion",
   fixable: false,
-  supportedEffect: ["v3", "v4"],
+  supportedEffect: ["v3"],
   apply: fn("schemaSyncInEffect.apply")(function* (sourceFile, report) {
     const ts = yield* service(TypeScriptApi);
     const typeParser = yield* service(TypeParser);
@@ -10969,6 +11060,7 @@ var schemaUnionOfLiterals = createDiagnostic({
   name: "schemaUnionOfLiterals",
   code: 33,
   description: "Simplifies Schema.Union of multiple Schema.Literal calls into single Schema.Literal",
+  group: "style",
   severity: "off",
   fixable: true,
   supportedEffect: ["v3"],
@@ -11046,6 +11138,7 @@ var scopeInLayerEffect = createDiagnostic({
   name: "scopeInLayerEffect",
   code: 13,
   description: "Suggests using Layer.scoped instead of Layer.effect when Scope is in requirements",
+  group: "antipattern",
   severity: "warning",
   fixable: true,
   supportedEffect: ["v3"],
@@ -11143,6 +11236,7 @@ var serviceNotAsClass = createDiagnostic({
   name: "serviceNotAsClass",
   code: 51,
   description: "Warns when ServiceMap.Service is used as a variable instead of a class declaration",
+  group: "style",
   severity: "off",
   fixable: true,
   supportedEffect: ["v4"],
@@ -11220,6 +11314,7 @@ var strictBooleanExpressions = createDiagnostic({
   name: "strictBooleanExpressions",
   code: 17,
   description: "Enforces boolean types in conditional expressions for type safety",
+  group: "style",
   severity: "off",
   fixable: false,
   supportedEffect: ["v3", "v4"],
@@ -11293,6 +11388,7 @@ var strictEffectProvide = createDiagnostic({
   name: "strictEffectProvide",
   code: 27,
   description: "Warns when using Effect.provide with layers outside of application entry points",
+  group: "antipattern",
   severity: "off",
   fixable: false,
   supportedEffect: ["v3", "v4"],
@@ -11346,6 +11442,7 @@ var tryCatchInEffectGen = createDiagnostic({
   name: "tryCatchInEffectGen",
   code: 15,
   description: "Discourages try/catch in Effect generators in favor of Effect error handling",
+  group: "antipattern",
   severity: "suggestion",
   fixable: false,
   supportedEffect: ["v3", "v4"],
@@ -11405,6 +11502,7 @@ var unknownInEffectCatch = createDiagnostic({
   name: "unknownInEffectCatch",
   code: 31,
   description: "Warns when catch callbacks return unknown instead of typed errors",
+  group: "antipattern",
   severity: "warning",
   fixable: false,
   supportedEffect: ["v3", "v4"],
@@ -11468,6 +11566,7 @@ var unnecessaryEffectGen = createDiagnostic({
   name: "unnecessaryEffectGen",
   code: 5,
   description: "Suggests removing Effect.gen when it contains only a single return statement",
+  group: "style",
   severity: "suggestion",
   fixable: true,
   supportedEffect: ["v3", "v4"],
@@ -11514,6 +11613,7 @@ var unnecessaryFailYieldableError = createDiagnostic({
   name: "unnecessaryFailYieldableError",
   code: 29,
   description: "Suggests yielding yieldable errors directly instead of wrapping with Effect.fail",
+  group: "style",
   severity: "suggestion",
   fixable: true,
   supportedEffect: ["v3", "v4"],
@@ -11575,6 +11675,7 @@ var unnecessaryPipe = createDiagnostic({
   name: "unnecessaryPipe",
   code: 9,
   description: "Removes pipe calls with no arguments",
+  group: "style",
   severity: "suggestion",
   fixable: true,
   supportedEffect: ["v3", "v4"],
@@ -11623,6 +11724,7 @@ var unnecessaryPipeChain = createDiagnostic({
   name: "unnecessaryPipeChain",
   code: 16,
   description: "Simplifies chained pipe calls into a single pipe call",
+  group: "style",
   severity: "suggestion",
   fixable: true,
   supportedEffect: ["v3", "v4"],
@@ -11700,6 +11802,7 @@ var unsupportedServiceAccessors = createDiagnostic({
   name: "unsupportedServiceAccessors",
   code: 21,
   description: "Warns about service accessors that need codegen due to generic/complex signatures",
+  group: "correctness",
   severity: "warning",
   fixable: true,
   supportedEffect: ["v3", "v4"],
@@ -11777,6 +11880,7 @@ var diagnostics = [
   leakingRequirements,
   unnecessaryPipe,
   genericEffectServices,
+  globalFetch,
   returnEffectInGen,
   tryCatchInEffectGen,
   importFromBarrel,