@effect/language-service 0.33.2 → 0.35.0

package/README.md

@@ -53,6 +53,7 @@ And you're done! You'll now be able to use a set of refactors and diagnostics th
 - Detect unnecessary pipe chains like `X.pipe(Y).pipe(Z)`
 - Warn when using `Effect.Service` with `accessors: true` but methods have generics or multiple signatures
 - Warn on missing service dependencies in `Effect.Service` declarations
+- Warn when schema classes override the default constructor behavior
 
 ### Completions
 
@@ -68,6 +69,8 @@ And you're done! You'll now be able to use a set of refactors and diagnostics th
 
 - Transform an async function definition, into an Effect by using Effect.gen.
 - Transform an async function definition, into an Effect by using Effect.gen, and generating a tagged error for each promise call.
+- Transform an async function definition, into an Effect by using Effect.fn.
+- Transform an async function definition, into an Effect by using Effect.fn, and generating a tagged error for each promise call.
 - Transform a function returning an Effect.gen into a Effect.fn
 - Implement Service accessors in an `Effect.Service` or `Context.Tag` declaration
 - Function calls to pipe: Transform a set of function calls to a pipe() call.
@@ -137,9 +140,8 @@ Your `tsconfig.json` should look like this:
 To get diagnostics you need to install `ts-patch` which will make it possible to run `tspc`.
 
 Running `tspc` in your project will now also run the plugin and give you the error diagnostics at compile time.
-Effect diagnostics in watch mode with noEmit enabled are not supported by ts-patch unfortunately.
-
-If you use incremental builds, after enabling ts-patch, a full rebuild may be necessary to invalidate the previous diagnostics cache.
+Effect error diagnostics will be shown only after standard TypeScript diagnostics have been satisfied.
+Beware that setting noEmit will completely skip the effect diagnostics.
 
 ```ts
 $ npx tspc
@@ -148,7 +150,7 @@ index.ts:3:1 - error TS3: Effect must be yielded or assigned to a variable.
 3 Effect.succeed(1)
   ~~~~~~~~~~~~~~~~~
 
-Found 1 error in index.ts:3 
+Found 1 error in index.ts:3 
 ```
 
 ## Configuring diagnostics

package/cli.js

@@ -28495,6 +28495,31 @@ var NanoTag = class {
   }
 };
 var Tag4 = (identifier2) => new NanoTag(identifier2);
+var SingleShotGen3 = class _SingleShotGen {
+  called = false;
+  self;
+  constructor(self) {
+    this.self = self;
+  }
+  /**
+   * @since 2.0.0
+   */
+  next(a) {
+    return this.called ? {
+      value: a,
+      done: true
+    } : (this.called = true, {
+      value: this.self,
+      done: false
+    });
+  }
+  /**
+   * @since 2.0.0
+   */
+  [Symbol.iterator]() {
+    return new _SingleShotGen(this.self);
+  }
+};
 var evaluate2 = Symbol.for("Nano.evaluate");
 var contA = Symbol.for("Nano.contA");
 var contE = Symbol.for("Nano.contE");
@@ -28509,7 +28534,7 @@ var NanoDefectException = class {
 };
 var PrimitiveProto = {
   [Symbol.iterator]() {
-    return new SingleShotGen(new YieldWrap(this));
+    return new SingleShotGen3(this);
   }
 };
 var SucceedProto = {
@@ -28632,7 +28657,7 @@ var FromIteratorProto = {
     const state = this[args2][0].next(value5);
     if (state.done) return succeed17(state.value);
     fiber._stack.push(this);
-    return yieldWrapGet(state.value);
+    return state.value;
   },
   [evaluate2](fiber) {
     return this[contA](this[args2][1], fiber);
@@ -28961,7 +28986,7 @@ function makeTypeScriptUtils(ts2) {
   function isNodeInRange(textRange) {
     return (node) => node.pos <= textRange.pos && node.end >= textRange.end;
   }
-  function transformAsyncAwaitToEffectGen(node, effectModuleName, onAwait) {
+  function transformAsyncAwaitToEffectGeneratorBody(body, onAwait) {
     function visitor(_) {
       if (ts2.isAwaitExpression(_)) {
         const expression = ts2.visitEachChild(_.expression, visitor, ts2.nullTransformationContext);
@@ -28972,7 +28997,44 @@ function makeTypeScriptUtils(ts2) {
       }
       return ts2.visitEachChild(_, visitor, ts2.nullTransformationContext);
     }
-    const generatorBody = visitor(node.body);
+    return visitor(body);
+  }
+  function transformAsyncAwaitToEffectFn(node, effectModuleName, onAwait) {
+    const generatorBody = transformAsyncAwaitToEffectGeneratorBody(node.body, onAwait);
+    const fnName = node.name && ts2.isIdentifier(node.name) ? node.name : ts2.isVariableDeclaration(node.parent) && ts2.isIdentifier(node.parent.name) && node.parent.initializer === node ? node.parent.name : void 0;
+    let fnCall = ts2.factory.createPropertyAccessExpression(
+      ts2.factory.createIdentifier(effectModuleName),
+      "fn"
+    );
+    if (fnName) {
+      fnCall = ts2.factory.createCallExpression(
+        fnName,
+        void 0,
+        [ts2.factory.createStringLiteral(fnName.text)]
+      );
+    }
+    return tryPreserveDeclarationSemantics(
+      node,
+      ts2.factory.createCallExpression(
+        fnCall,
+        void 0,
+        [
+          ts2.factory.createFunctionExpression(
+            void 0,
+            ts2.factory.createToken(ts2.SyntaxKind.AsteriskToken),
+            void 0,
+            node.typeParameters,
+            node.parameters,
+            void 0,
+            ts2.isBlock(generatorBody) ? generatorBody : ts2.factory.createBlock([ts2.factory.createReturnStatement(generatorBody)])
+          )
+        ]
+      ),
+      true
+    );
+  }
+  function transformAsyncAwaitToEffectGen(node, effectModuleName, onAwait) {
+    const generatorBody = transformAsyncAwaitToEffectGeneratorBody(node.body, onAwait);
     const effectGenCallExp = createEffectGenCallExpression(effectModuleName, generatorBody);
     let currentFlags = ts2.getCombinedModifierFlags(node);
     currentFlags &= ~ts2.ModifierFlags.Async;
@@ -29076,12 +29138,15 @@ function makeTypeScriptUtils(ts2) {
     }
     return typeNode;
   }
-  function tryPreserveDeclarationSemantics(nodeToReplace, node) {
+  function tryPreserveDeclarationSemantics(nodeToReplace, node, dropAsync) {
     if (!ts2.isExpression(node)) return node;
     if (ts2.isFunctionDeclaration(nodeToReplace)) {
       if (!nodeToReplace.name) return node;
+      let currentFlags = ts2.getCombinedModifierFlags(nodeToReplace);
+      currentFlags &= ~ts2.ModifierFlags.Async;
+      const newModifiers = dropAsync ? ts2.factory.createModifiersFromModifierFlags(currentFlags) : nodeToReplace.modifiers;
       return ts2.factory.createVariableStatement(
-        nodeToReplace.modifiers,
+        newModifiers,
         ts2.factory.createVariableDeclarationList(
           [ts2.factory.createVariableDeclaration(
             nodeToReplace.name,
@@ -29093,8 +29158,11 @@ function makeTypeScriptUtils(ts2) {
         )
       );
     } else if (ts2.isMethodDeclaration(nodeToReplace)) {
+      let currentFlags = ts2.getCombinedModifierFlags(nodeToReplace);
+      currentFlags &= ~ts2.ModifierFlags.Async;
+      const newModifiers = dropAsync ? ts2.factory.createModifiersFromModifierFlags(currentFlags) : nodeToReplace.modifiers;
       return ts2.factory.createPropertyDeclaration(
-        nodeToReplace.modifiers,
+        newModifiers,
         nodeToReplace.name,
         void 0,
         void 0,
@@ -29197,6 +29265,7 @@ function makeTypeScriptUtils(ts2) {
     getAncestorNodesInRange,
     toTextRange,
     isNodeInRange,
+    transformAsyncAwaitToEffectFn,
     transformAsyncAwaitToEffectGen,
     findImportedModuleIdentifierByPackageAndNameOrBarrel,
     simplifyTypeNode,
@@ -31969,6 +32038,68 @@ var outdatedEffectCodegen = createDiagnostic({
   })
 });
 
+// src/diagnostics/overriddenSchemaConstructor.ts
+var overriddenSchemaConstructor = createDiagnostic({
+  name: "overriddenSchemaConstructor",
+  code: 30,
+  severity: "error",
+  apply: fn("overriddenSchemaConstructor.apply")(function* (sourceFile, report) {
+    const ts2 = yield* service2(TypeScriptApi);
+    const typeParser = yield* service2(TypeParser);
+    const typeChecker = yield* service2(TypeCheckerApi);
+    const nodeToVisit = [];
+    const appendNodeToVisit = (node) => {
+      nodeToVisit.push(node);
+      return void 0;
+    };
+    ts2.forEachChild(sourceFile, appendNodeToVisit);
+    while (nodeToVisit.length > 0) {
+      const node = nodeToVisit.shift();
+      if (ts2.isClassDeclaration(node) && node.heritageClauses) {
+        let extendsSchema = false;
+        for (const heritageClause of node.heritageClauses) {
+          if (heritageClause.token === ts2.SyntaxKind.ExtendsKeyword) {
+            for (const type2 of heritageClause.types) {
+              const typeAtLocation = typeChecker.getTypeAtLocation(type2.expression);
+              const isSchema2 = yield* pipe(
+                typeParser.effectSchemaType(typeAtLocation, type2.expression),
+                map33(() => true),
+                orElse14(() => succeed17(false))
+              );
+              if (isSchema2) {
+                extendsSchema = true;
+                break;
+              }
+            }
+          }
+          if (extendsSchema) break;
+        }
+        if (extendsSchema) {
+          const members = node.members;
+          for (const member of members) {
+            if (ts2.isConstructorDeclaration(member)) {
+              report({
+                location: member,
+                messageText: "Classes extending Schema must not override the constructor",
+                fixes: [{
+                  fixName: "overriddenSchemaConstructor_fix",
+                  description: "Remove the constructor override",
+                  apply: gen3(function* () {
+                    const changeTracker = yield* service2(ChangeTracker);
+                    changeTracker.delete(sourceFile, member);
+                  })
+                }]
+              });
+              break;
+            }
+          }
+        }
+      }
+      ts2.forEachChild(node, appendNodeToVisit);
+    }
+  })
+});
+
 // src/diagnostics/returnEffectInGen.ts
 var returnEffectInGen = createDiagnostic({
   name: "returnEffectInGen",
@@ -32487,6 +32618,7 @@ var diagnostics = [
   strictBooleanExpressions,
   multipleEffectProvide,
   outdatedEffectCodegen,
+  overriddenSchemaConstructor,
   unsupportedServiceAccessors
 ];