@effect/language-service 0.26.0 → 0.27.1

package/README.md

@@ -32,7 +32,7 @@ And you're done! You'll now be able to use a set of refactors and diagnostics th
 ### Quickinfo
 
 - Show the extended type of the current Effect
-- Hovering `yield\*` of `Effect.gen` will show the Effect type parameters
+- Hovering `yield*` of `Effect.gen` will show the Effect type parameters
 - Hovering a variable assignment of a type Layer, will show info on how each service got involved
 - Hovering a layer, will attempt to produce a graph
 
@@ -56,6 +56,7 @@ And you're done! You'll now be able to use a set of refactors and diagnostics th
 - Autocomplete `Effect.fn` with the span name given by the exported member
 - Completions for DurationInput string millis/seconds/etc...
 - Allow to configure packages to be imported with namespace style `import * as Effect from "effect"`
+- Suggest brand when using `Schema.brand`
 - Effect comment directives
 
 ### Refactors

package/cli.js

@@ -30284,7 +30284,11 @@ var createDiagnosticExecutor = fn("LSP.createCommentDirectivesProcessor")(
       const diagnostics2 = [];
       const codeFixes = [];
       const ruleNameLowered = rule.name.toLowerCase();
+      const defaultLevel = pluginOptions.diagnosticSeverity[ruleNameLowered] || rule.severity;
       if (skippedRules.indexOf(ruleNameLowered) > -1) return { diagnostics: diagnostics2, codeFixes };
+      if (defaultLevel === "off" && (lineOverrides[ruleNameLowered] || sectionOverrides[ruleNameLowered] || []).length === 0) {
+        return { diagnostics: diagnostics2, codeFixes };
+      }
       const fixByDisableNextLine = (_) => ({
         fixName: rule.name + "_skipNextLine",
         description: "Disable " + rule.name + " for this line",
@@ -30325,7 +30329,7 @@ var createDiagnosticExecutor = fn("LSP.createCommentDirectivesProcessor")(
         });
       });
       for (const emitted of applicableDiagnostics.slice(0)) {
-        let newLevel = pluginOptions.diagnosticSeverity[ruleNameLowered] || rule.severity;
+        let newLevel = defaultLevel;
         const lineOverride = (lineOverrides[ruleNameLowered] || []).find(
           (_) => _.pos < emitted.node.getStart(sourceFile) && _.end >= emitted.node.getEnd()
         );
@@ -32410,6 +32414,73 @@ Consider using "scoped" instead to get rid of the scope in the requirements.`,
   })
 });
 
+// src/diagnostics/strictBooleanExpressions.ts
+var strictBooleanExpressions = createDiagnostic({
+  name: "strictBooleanExpressions",
+  code: 17,
+  severity: "off",
+  apply: fn("strictBooleanExpressions.apply")(function* (sourceFile, report) {
+    const ts2 = yield* service2(TypeScriptApi);
+    const typeChecker = yield* service2(TypeCheckerApi);
+    const conditionChecks = /* @__PURE__ */ new WeakMap();
+    const nodeToVisit = [];
+    const appendNodeToVisit = (node) => {
+      nodeToVisit.push(node);
+      return void 0;
+    };
+    ts2.forEachChild(sourceFile, appendNodeToVisit);
+    while (nodeToVisit.length > 0) {
+      const node = nodeToVisit.shift();
+      ts2.forEachChild(node, appendNodeToVisit);
+      const nodes = [];
+      if (ts2.isIfStatement(node)) {
+        conditionChecks.set(node, true);
+        nodes.push(node.expression);
+      } else if (ts2.isWhileStatement(node)) {
+        conditionChecks.set(node, true);
+        nodes.push(node.expression);
+      } else if (ts2.isConditionalExpression(node)) {
+        conditionChecks.set(node, true);
+        nodes.push(node.condition);
+      } else if (ts2.isPrefixUnaryExpression(node) && node.operator === ts2.SyntaxKind.ExclamationToken) {
+        conditionChecks.set(node, true);
+        nodes.push(node.operand);
+      } else if (ts2.isBinaryExpression(node) && node.operatorToken.kind === ts2.SyntaxKind.BarBarToken) {
+        if (conditionChecks.has(node.parent)) conditionChecks.set(node, true);
+        nodes.push(node.left);
+        nodes.push(node.right);
+      } else if (ts2.isBinaryExpression(node) && node.operatorToken.kind === ts2.SyntaxKind.AmpersandAmpersandToken) {
+        if (conditionChecks.has(node.parent)) conditionChecks.set(node, true);
+        nodes.push(node.left);
+        nodes.push(node.right);
+      }
+      for (const nodeToCheck of nodes) {
+        if (!nodeToCheck) continue;
+        if (!conditionChecks.has(nodeToCheck.parent)) continue;
+        const nodeType = typeChecker.getTypeAtLocation(nodeToCheck);
+        const constrainedType = typeChecker.getBaseConstraintOfType(nodeType);
+        let typesToCheck = [constrainedType || nodeType];
+        while (typesToCheck.length > 0) {
+          const type2 = typesToCheck.pop();
+          if (type2.isUnion()) {
+            typesToCheck = typesToCheck.concat(type2.types);
+            continue;
+          }
+          if (type2.flags & ts2.TypeFlags.Boolean) continue;
+          if (type2.flags & ts2.TypeFlags.Never) continue;
+          if (type2.flags & ts2.TypeFlags.BooleanLiteral) continue;
+          const typeName = typeChecker.typeToString(type2);
+          report({
+            node: nodeToCheck,
+            messageText: `Unexpected \`${typeName}\` type in condition, expected strictly a boolean instead.`,
+            fixes: []
+          });
+        }
+      }
+    }
+  })
+});
+
 // src/diagnostics/tryCatchInEffectGen.ts
 var tryCatchInEffectGen = createDiagnostic({
   name: "tryCatchInEffectGen",
@@ -32634,7 +32705,8 @@ var diagnostics = [
   importFromBarrel,
   scopeInLayerEffect,
   effectInVoidSuccess,
-  unnecessaryPipeChain
+  unnecessaryPipeChain,
+  strictBooleanExpressions
 ];
 
 // src/cli.ts