@effect/language-service 0.25.1 → 0.27.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@effect/language-service",
-  "version": "0.25.1",
+  "version": "0.27.0",
   "description": "A Language-Service Plugin to Refactor and Diagnostic effect-ts projects",
   "main": "index.cjs",
   "bin": {

package/transform.js

@@ -2499,11 +2499,16 @@ function make2(ts, typeChecker) {
   const pipeCall = cachedBy(
     function(node) {
       if (ts.isCallExpression(node) && ts.isPropertyAccessExpression(node.expression) && ts.isIdentifier(node.expression.name) && node.expression.name.text === "pipe") {
-        return succeed({ node, subject: node.expression.expression, args: Array.from(node.arguments) });
+        return succeed({
+          node,
+          subject: node.expression.expression,
+          args: Array.from(node.arguments),
+          kind: "pipeable"
+        });
       }
       if (ts.isCallExpression(node) && ts.isIdentifier(node.expression) && node.expression.text === "pipe" && node.arguments.length > 0) {
         const [subject, ...args2] = node.arguments;
-        return succeed({ node, subject, args: args2 });
+        return succeed({ node, subject, args: args2, kind: "pipe" });
       }
       return typeParserIssue("Node is not a pipe call", void 0, node);
     },
@@ -2542,6 +2547,7 @@ function make2(ts, typeChecker) {
     unnecessaryEffectGen: unnecessaryEffectGen2,
     effectSchemaType,
     contextTag,
+    pipeableType,
     pipeCall,
     scopeType
   };
@@ -3475,10 +3481,77 @@ Consider using "scoped" instead to get rid of the scope in the requirements.`,
   })
 });
 
+// src/diagnostics/strictBooleanExpressions.ts
+var strictBooleanExpressions = createDiagnostic({
+  name: "strictBooleanExpressions",
+  code: 17,
+  severity: "off",
+  apply: fn("strictBooleanExpressions.apply")(function* (sourceFile, report) {
+    const ts = yield* service(TypeScriptApi);
+    const typeChecker = yield* service(TypeCheckerApi);
+    const conditionChecks = /* @__PURE__ */ new WeakMap();
+    const nodeToVisit = [];
+    const appendNodeToVisit = (node) => {
+      nodeToVisit.push(node);
+      return void 0;
+    };
+    ts.forEachChild(sourceFile, appendNodeToVisit);
+    while (nodeToVisit.length > 0) {
+      const node = nodeToVisit.shift();
+      ts.forEachChild(node, appendNodeToVisit);
+      const nodes = [];
+      if (ts.isIfStatement(node)) {
+        conditionChecks.set(node, true);
+        nodes.push(node.expression);
+      } else if (ts.isWhileStatement(node)) {
+        conditionChecks.set(node, true);
+        nodes.push(node.expression);
+      } else if (ts.isConditionalExpression(node)) {
+        conditionChecks.set(node, true);
+        nodes.push(node.condition);
+      } else if (ts.isPrefixUnaryExpression(node) && node.operator === ts.SyntaxKind.ExclamationToken) {
+        conditionChecks.set(node, true);
+        nodes.push(node.operand);
+      } else if (ts.isBinaryExpression(node) && node.operatorToken.kind === ts.SyntaxKind.BarBarToken) {
+        if (conditionChecks.has(node.parent)) conditionChecks.set(node, true);
+        nodes.push(node.left);
+        nodes.push(node.right);
+      } else if (ts.isBinaryExpression(node) && node.operatorToken.kind === ts.SyntaxKind.AmpersandAmpersandToken) {
+        if (conditionChecks.has(node.parent)) conditionChecks.set(node, true);
+        nodes.push(node.left);
+        nodes.push(node.right);
+      }
+      for (const nodeToCheck of nodes) {
+        if (!nodeToCheck) continue;
+        if (!conditionChecks.has(nodeToCheck.parent)) continue;
+        const nodeType = typeChecker.getTypeAtLocation(nodeToCheck);
+        const constrainedType = typeChecker.getBaseConstraintOfType(nodeType);
+        let typesToCheck = [constrainedType || nodeType];
+        while (typesToCheck.length > 0) {
+          const type = typesToCheck.pop();
+          if (type.isUnion()) {
+            typesToCheck = typesToCheck.concat(type.types);
+            continue;
+          }
+          if (type.flags & ts.TypeFlags.Boolean) continue;
+          if (type.flags & ts.TypeFlags.Never) continue;
+          if (type.flags & ts.TypeFlags.BooleanLiteral) continue;
+          const typeName = typeChecker.typeToString(type);
+          report({
+            node: nodeToCheck,
+            messageText: `Unexpected \`${typeName}\` type in condition, expected strictly a boolean instead.`,
+            fixes: []
+          });
+        }
+      }
+    }
+  })
+});
+
 // src/diagnostics/tryCatchInEffectGen.ts
 var tryCatchInEffectGen = createDiagnostic({
   name: "tryCatchInEffectGen",
-  code: 12,
+  code: 15,
   severity: "suggestion",
   apply: fn("tryCatchInEffectGen.apply")(function* (sourceFile, report) {
     const ts = yield* service(TypeScriptApi);
@@ -3608,6 +3681,80 @@ var unnecessaryPipe = createDiagnostic({
   })
 });
 
+// src/diagnostics/unnecessaryPipeChain.ts
+var unnecessaryPipeChain = createDiagnostic({
+  name: "unnecessaryPipeChain",
+  code: 16,
+  severity: "suggestion",
+  apply: fn("unnecessaryPipeChain.apply")(function* (sourceFile, report) {
+    const ts = yield* service(TypeScriptApi);
+    const typeParser = yield* service(TypeParser);
+    const nodeToVisit = [];
+    const appendNodeToVisit = (node) => {
+      nodeToVisit.push(node);
+      return void 0;
+    };
+    ts.forEachChild(sourceFile, appendNodeToVisit);
+    while (nodeToVisit.length > 0) {
+      const node = nodeToVisit.shift();
+      ts.forEachChild(node, appendNodeToVisit);
+      if (ts.isCallExpression(node)) {
+        yield* pipe(
+          typeParser.pipeCall(node),
+          flatMap2(
+            (pipeCall) => map3(typeParser.pipeCall(pipeCall.subject), (innerCall) => ({ pipeCall, innerCall }))
+          ),
+          map3(({ innerCall, pipeCall }) => {
+            report({
+              node,
+              messageText: `Chained pipe calls can be simplified to a single pipe call`,
+              fixes: [{
+                fixName: "unnecessaryPipeChain_fix",
+                description: "Rewrite as single pipe call",
+                apply: gen(function* () {
+                  const changeTracker = yield* service(
+                    ChangeTracker
+                  );
+                  switch (innerCall.kind) {
+                    case "pipe": {
+                      changeTracker.replaceNode(
+                        sourceFile,
+                        node,
+                        ts.factory.createCallExpression(
+                          ts.factory.createIdentifier("pipe"),
+                          void 0,
+                          [innerCall.subject, ...innerCall.args, ...pipeCall.args]
+                        )
+                      );
+                      break;
+                    }
+                    case "pipeable": {
+                      changeTracker.replaceNode(
+                        sourceFile,
+                        node,
+                        ts.factory.createCallExpression(
+                          ts.factory.createPropertyAccessExpression(
+                            innerCall.subject,
+                            "pipe"
+                          ),
+                          void 0,
+                          [...innerCall.args, ...pipeCall.args]
+                        )
+                      );
+                      break;
+                    }
+                  }
+                })
+              }]
+            });
+          }),
+          ignore
+        );
+      }
+    }
+  })
+});
+
 // src/diagnostics.ts
 var diagnostics = [
   duplicatePackage,
@@ -3624,7 +3771,9 @@ var diagnostics = [
   tryCatchInEffectGen,
   importFromBarrel,
   scopeInLayerEffect,
-  effectInVoidSuccess
+  effectInVoidSuccess,
+  unnecessaryPipeChain,
+  strictBooleanExpressions
 ];
 
 // src/transform.ts