@effect/language-service 0.25.0 → 0.26.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@effect/language-service",
-  "version": "0.25.0",
+  "version": "0.26.0",
   "description": "A Language-Service Plugin to Refactor and Diagnostic effect-ts projects",
   "main": "index.cjs",
   "bin": {

package/transform.js

@@ -902,6 +902,7 @@ var NanoFiber = class {
   _stack = [];
   _yielded = void 0;
   _services = {};
+  _cache = {};
   runLoop(nano) {
     let current = nano;
     while (true) {
@@ -1052,8 +1053,32 @@ var service = (tag) => {
   nano[args] = tag;
   return nano;
 };
-function cachedBy(fa, _key, _lookupKey) {
-  return (...args2) => fa(...args2);
+var CachedProto = {
+  ...PrimitiveProto,
+  [evaluate](fiber) {
+    const [fa, type, key] = this[args];
+    const cache = fiber._cache[type] || /* @__PURE__ */ new WeakMap();
+    fiber._cache[type] = cache;
+    const cached2 = cache.get(key);
+    if (cached2) return cached2;
+    return match2(fa, {
+      onSuccess: (_) => {
+        cache.set(key, succeed(_));
+        return succeed(_);
+      },
+      onFailure: (_) => {
+        cache.set(key, fail(_));
+        return fail(_);
+      }
+    });
+  }
+};
+function cachedBy(fa, type, lookupKey) {
+  return (...p) => {
+    const nano = Object.create(CachedProto);
+    nano[args] = [fa(...p), type, lookupKey(...p)];
+    return nano;
+  };
 }
 var option = (fa) => {
   const nano = Object.create(MatchProto);
@@ -1630,8 +1655,7 @@ var unrollUnionMembers = (type) => {
 var appendToUniqueTypesMap = fn(
   "TypeCheckerApi.appendToUniqueTypesMap"
 )(
-  function* (memory, initialType, excludeNever) {
-    const ts = yield* service(TypeScriptApi);
+  function* (memory, initialType, shouldExclude) {
     const typeChecker = yield* service(TypeCheckerApi);
     const newIndexes = /* @__PURE__ */ new Set();
     const knownIndexes = /* @__PURE__ */ new Set();
@@ -1639,7 +1663,7 @@ var appendToUniqueTypesMap = fn(
     while (toTest.length > 0) {
       const type = toTest.pop();
       if (!type) break;
-      if (excludeNever && type.flags & ts.TypeFlags.Never) {
+      if (yield* shouldExclude(type)) {
         continue;
       }
       if (type.isUnion()) {
@@ -2475,11 +2499,16 @@ function make2(ts, typeChecker) {
   const pipeCall = cachedBy(
     function(node) {
       if (ts.isCallExpression(node) && ts.isPropertyAccessExpression(node.expression) && ts.isIdentifier(node.expression.name) && node.expression.name.text === "pipe") {
-        return succeed({ node, subject: node.expression.expression, args: Array.from(node.arguments) });
+        return succeed({
+          node,
+          subject: node.expression.expression,
+          args: Array.from(node.arguments),
+          kind: "pipeable"
+        });
       }
       if (ts.isCallExpression(node) && ts.isIdentifier(node.expression) && node.expression.text === "pipe" && node.arguments.length > 0) {
         const [subject, ...args2] = node.arguments;
-        return succeed({ node, subject, args: args2 });
+        return succeed({ node, subject, args: args2, kind: "pipe" });
       }
       return typeParserIssue("Node is not a pipe call", void 0, node);
     },
@@ -2518,6 +2547,7 @@ function make2(ts, typeChecker) {
     unnecessaryEffectGen: unnecessaryEffectGen2,
     effectSchemaType,
     contextTag,
+    pipeableType,
     pipeCall,
     scopeType
   };
@@ -2887,7 +2917,18 @@ var leakingRequirements = createDiagnostic({
             );
             if (effectContextType) {
               effectMembers++;
-              const { allIndexes } = yield* appendToUniqueTypesMap(memory, effectContextType, true);
+              const { allIndexes } = yield* appendToUniqueTypesMap(
+                memory,
+                effectContextType,
+                (type) => {
+                  if (type.flags & ts.TypeFlags.Never) return succeed(true);
+                  return pipe(
+                    typeParser.scopeType(type, atLocation),
+                    map3(() => true),
+                    orElse2(() => succeed(false))
+                  );
+                }
+              );
               if (!sharedRequirementsKeys) {
                 sharedRequirementsKeys = allIndexes;
               } else {
@@ -3443,8 +3484,8 @@ Consider using "scoped" instead to get rid of the scope in the requirements.`,
 // src/diagnostics/tryCatchInEffectGen.ts
 var tryCatchInEffectGen = createDiagnostic({
   name: "tryCatchInEffectGen",
-  code: 12,
-  severity: "warning",
+  code: 15,
+  severity: "suggestion",
   apply: fn("tryCatchInEffectGen.apply")(function* (sourceFile, report) {
     const ts = yield* service(TypeScriptApi);
     const typeParser = yield* service(TypeParser);
@@ -3573,6 +3614,80 @@ var unnecessaryPipe = createDiagnostic({
   })
 });
 
+// src/diagnostics/unnecessaryPipeChain.ts
+var unnecessaryPipeChain = createDiagnostic({
+  name: "unnecessaryPipeChain",
+  code: 16,
+  severity: "suggestion",
+  apply: fn("unnecessaryPipeChain.apply")(function* (sourceFile, report) {
+    const ts = yield* service(TypeScriptApi);
+    const typeParser = yield* service(TypeParser);
+    const nodeToVisit = [];
+    const appendNodeToVisit = (node) => {
+      nodeToVisit.push(node);
+      return void 0;
+    };
+    ts.forEachChild(sourceFile, appendNodeToVisit);
+    while (nodeToVisit.length > 0) {
+      const node = nodeToVisit.shift();
+      ts.forEachChild(node, appendNodeToVisit);
+      if (ts.isCallExpression(node)) {
+        yield* pipe(
+          typeParser.pipeCall(node),
+          flatMap2(
+            (pipeCall) => map3(typeParser.pipeCall(pipeCall.subject), (innerCall) => ({ pipeCall, innerCall }))
+          ),
+          map3(({ innerCall, pipeCall }) => {
+            report({
+              node,
+              messageText: `Chained pipe calls can be simplified to a single pipe call`,
+              fixes: [{
+                fixName: "unnecessaryPipeChain_fix",
+                description: "Rewrite as single pipe call",
+                apply: gen(function* () {
+                  const changeTracker = yield* service(
+                    ChangeTracker
+                  );
+                  switch (innerCall.kind) {
+                    case "pipe": {
+                      changeTracker.replaceNode(
+                        sourceFile,
+                        node,
+                        ts.factory.createCallExpression(
+                          ts.factory.createIdentifier("pipe"),
+                          void 0,
+                          [innerCall.subject, ...innerCall.args, ...pipeCall.args]
+                        )
+                      );
+                      break;
+                    }
+                    case "pipeable": {
+                      changeTracker.replaceNode(
+                        sourceFile,
+                        node,
+                        ts.factory.createCallExpression(
+                          ts.factory.createPropertyAccessExpression(
+                            innerCall.subject,
+                            "pipe"
+                          ),
+                          void 0,
+                          [...innerCall.args, ...pipeCall.args]
+                        )
+                      );
+                      break;
+                    }
+                  }
+                })
+              }]
+            });
+          }),
+          ignore
+        );
+      }
+    }
+  })
+});
+
 // src/diagnostics.ts
 var diagnostics = [
   duplicatePackage,
@@ -3589,7 +3704,8 @@ var diagnostics = [
   tryCatchInEffectGen,
   importFromBarrel,
   scopeInLayerEffect,
-  effectInVoidSuccess
+  effectInVoidSuccess,
+  unnecessaryPipeChain
 ];
 
 // src/transform.ts