@effect-agent/storage-memory 0.1.0-beta.41 → 0.1.0-beta.44

package/src/memory-subscription-store.ts

@@ -106,6 +106,7 @@ const candidateIndexKey = (record: SubscriptionRecord): string =>
     record.configuration.source.version,
     record.configuration.matchingKey,
   ]);
+
 const eventCandidateIndexKey = (event: AcceptedEvent): string =>
   JSON.stringify([event.source.name, event.source.version, event.matchingKey]);
 
@@ -129,6 +130,7 @@ const makeMemorySubscriptionStore = Effect.fn("makeMemorySubscriptionStore")(fun
   ownedPartition: SourcePartition,
 ) {
   const partition = yield* validate(SourcePartition, ownedPartition, "partition");
+
   const state = yield* Ref.make<MemorySubscriptionState>({
     sequence: 0,
     registrations: new Map(),
@@ -142,6 +144,7 @@ const makeMemorySubscriptionStore = Effect.fn("makeMemorySubscriptionStore")(fun
     ownerDeliveryCounts: new Map(),
     scanCursors: { events: "", deliveries: "", recovery: 0 },
   });
+
   const failpoint = yield* SubscriptionFailpoint;
 
   const requirePartition = <A extends { readonly partition: SourcePartition }>(
@@ -162,8 +165,10 @@ const makeMemorySubscriptionStore = Effect.fn("makeMemorySubscriptionStore")(fun
   )(function* (input, inputLimits) {
     const record = yield* validate(SubscriptionRecord, input, "register-record");
     const limits = yield* validate(SubscriptionLimits, inputLimits, "register-limits");
+
     yield* requirePartition(record.key, "register-partition");
     yield* failpoint.hit("subscription:register:before");
+
     const result = yield* Effect.uninterruptible(
       Ref.modify(
         state,
@@ -175,9 +180,12 @@ const makeMemorySubscriptionStore = Effect.fn("makeMemorySubscriptionStore")(fun
         ] => {
           const key = subscriptionKeyString(record.key);
           const existingText = current.registrations.get(key);
+
           if (existingText !== undefined) {
             const existing = decode(SubscriptionRecord, existingText, "register-existing");
+
             if (Result.isFailure(existing)) return [Result.fail(existing.failure), current];
+
             return existing.success.creationFingerprint === record.creationFingerprint
               ? [Result.succeed(existing.success), current]
               : [Result.fail(error("conflict", "registration-identity")), current];
@@ -194,14 +202,18 @@ const makeMemorySubscriptionStore = Effect.fn("makeMemorySubscriptionStore")(fun
           if (current.registrations.size >= limits.maxRegistrations)
             return [Result.fail(error("capacity", "registrations")), current];
           const ownerCount = current.ownerRegistrationCounts.get(record.key.ownerId) ?? 0;
+
           if (ownerCount >= limits.maxRegistrationsPerOwner)
             return [Result.fail(error("capacity", "owner-registrations")), current];
           const assigned = { ...record, ordinal: current.sequence + 1 };
           const encoded = encode(SubscriptionRecord, assigned, "register-encode");
+
           if (Result.isFailure(encoded)) return [Result.fail(encoded.failure), current];
           const registrations = new Map(current.registrations);
+
           registrations.set(key, encoded.success);
           const registrationIndex = new Map(current.registrationIndex);
+
           registrationIndex.set(key, {
             key: assigned.key,
             ordinal: assigned.ordinal,
@@ -210,9 +222,12 @@ const makeMemorySubscriptionStore = Effect.fn("makeMemorySubscriptionStore")(fun
           });
           const candidateIndex = new Map(current.candidateIndex);
           const candidateKey = candidateIndexKey(assigned);
+
           candidateIndex.set(candidateKey, [...(candidateIndex.get(candidateKey) ?? []), key]);
           const ownerRegistrationCounts = new Map(current.ownerRegistrationCounts);
+
           ownerRegistrationCounts.set(assigned.key.ownerId, ownerCount + 1);
+
           return [
             Result.succeed(assigned),
             {
@@ -227,7 +242,9 @@ const makeMemorySubscriptionStore = Effect.fn("makeMemorySubscriptionStore")(fun
         },
       ),
     ).pipe(Effect.flatMap(Effect.fromResult));
+
     yield* failpoint.hit("subscription:register:after");
+
     return result;
   });
 
@@ -235,6 +252,7 @@ const makeMemorySubscriptionStore = Effect.fn("makeMemorySubscriptionStore")(fun
     function* (input) {
       const key = yield* requireKey(input, "get-key");
       const text = (yield* Ref.get(state)).registrations.get(subscriptionKeyString(key));
+
       return text === undefined
         ? null
         : yield* decodeEffect(SubscriptionRecord, text, "get-record");
@@ -247,13 +265,16 @@ const makeMemorySubscriptionStore = Effect.fn("makeMemorySubscriptionStore")(fun
         return yield* error("validation", "list-page");
       const current = yield* Ref.get(state);
       const records: Array<SubscriptionRecord> = [];
+
       for (const [storageKey, indexed] of current.registrationIndex) {
         if (indexed.key.ownerId !== ownerId || indexed.ordinal <= after) continue;
         const text = current.registrations.get(storageKey);
+
         if (text === undefined) return yield* error("corrupt", "list-index");
         records.push(yield* decodeEffect(SubscriptionRecord, text, "list-record"));
       }
       records.sort((a, b) => a.ordinal - b.ordinal);
+
       return records.slice(0, limit);
     },
   );
@@ -262,7 +283,9 @@ const makeMemorySubscriptionStore = Effect.fn("makeMemorySubscriptionStore")(fun
     "MemorySubscriptionStore.cancel",
   )(function* (input) {
     const key = yield* requireKey(input, "cancel-key");
+
     yield* failpoint.hit("subscription:cancel:before");
+
     const result = yield* Effect.uninterruptible(
       Ref.modify(
         state,
@@ -274,26 +297,34 @@ const makeMemorySubscriptionStore = Effect.fn("makeMemorySubscriptionStore")(fun
         ] => {
           const storageKey = subscriptionKeyString(key);
           const text = current.registrations.get(storageKey);
+
           if (text === undefined) return [Result.fail(error("not-found", "subscription")), current];
           const decoded = decode(SubscriptionRecord, text, "cancel-record");
+
           if (Result.isFailure(decoded)) return [decoded, current];
           if (decoded.success.state === "cancelled")
             return [Result.succeed(decoded.success), current];
           const cancelled = { ...decoded.success, state: "cancelled" as const, recovery: null };
           const encoded = encode(SubscriptionRecord, cancelled, "cancel-encode");
+
           if (Result.isFailure(encoded)) return [Result.fail(encoded.failure), current];
           const registrations = new Map(current.registrations);
+
           registrations.set(storageKey, encoded.success);
           const registrationIndex = new Map(current.registrationIndex);
           const indexed = registrationIndex.get(storageKey);
+
           if (indexed === undefined)
             return [Result.fail(error("corrupt", "cancel-index")), current];
           registrationIndex.set(storageKey, { ...indexed, state: "cancelled", recoveryAt: null });
+
           return [Result.succeed(cancelled), { ...current, registrations, registrationIndex }];
         },
       ),
     ).pipe(Effect.flatMap(Effect.fromResult));
+
     yield* failpoint.hit("subscription:cancel:after");
+
     return result;
   });
 
@@ -302,8 +333,10 @@ const makeMemorySubscriptionStore = Effect.fn("makeMemorySubscriptionStore")(fun
   )(function* (input, inputLimits) {
     const event = yield* validate(AcceptedEvent, input, "accept-event");
     const limits = yield* validate(SubscriptionLimits, inputLimits, "accept-limits");
+
     yield* requirePartition(event, "accept-partition");
     yield* failpoint.hit("subscription:accept:before");
+
     const result = yield* Effect.uninterruptible(
       Ref.modify(
         state,
@@ -311,9 +344,12 @@ const makeMemorySubscriptionStore = Effect.fn("makeMemorySubscriptionStore")(fun
           current,
         ): readonly [Result.Result<AcceptedEvent, SubscriptionError>, MemorySubscriptionState] => {
           const existingText = current.events.get(event.eventId);
+
           if (existingText !== undefined) {
             const existing = decode(AcceptedEvent, existingText, "accept-existing");
+
             if (Result.isFailure(existing)) return [Result.fail(existing.failure), current];
+
             return sameEventIdentity(existing.success, event)
               ? [Result.succeed(existing.success), current]
               : [Result.fail(error("conflict", "event-identity")), current];
@@ -322,6 +358,7 @@ const makeMemorySubscriptionStore = Effect.fn("makeMemorySubscriptionStore")(fun
             return [Result.fail(error("capacity", "payload-bytes")), current];
           if (current.events.size >= limits.maxEvents)
             return [Result.fail(error("capacity", "events")), current];
+
           const accepted: AcceptedEvent = {
             ...event,
             cutoff: current.sequence + 1,
@@ -329,15 +366,20 @@ const makeMemorySubscriptionStore = Effect.fn("makeMemorySubscriptionStore")(fun
             routingComplete: false,
             routingFailure: null,
           };
+
           const encoded = encode(AcceptedEvent, accepted, "accept-encode");
+
           if (Result.isFailure(encoded)) return [Result.fail(encoded.failure), current];
           const events = new Map(current.events);
+
           events.set(accepted.eventId, encoded.success);
           const eventIndex = new Map(current.eventIndex);
+
           eventIndex.set(accepted.eventId, {
             routingComplete: false,
             nextAttemptAtMillis: accepted.nextAttemptAtMillis,
           });
+
           return [
             Result.succeed(accepted),
             { ...current, sequence: accepted.cutoff, events, eventIndex },
@@ -345,13 +387,16 @@ const makeMemorySubscriptionStore = Effect.fn("makeMemorySubscriptionStore")(fun
         },
       ),
     ).pipe(Effect.flatMap(Effect.fromResult));
+
     yield* failpoint.hit("subscription:accept:after");
+
     return result;
   });
 
   const event: SubscriptionStore["Service"]["event"] = Effect.fn("MemorySubscriptionStore.event")(
     function* (eventId) {
       const text = (yield* Ref.get(state)).events.get(eventId);
+
       return text === undefined ? null : yield* decodeEffect(AcceptedEvent, text, "event-record");
     },
   );
@@ -360,6 +405,7 @@ const makeMemorySubscriptionStore = Effect.fn("makeMemorySubscriptionStore")(fun
     "MemorySubscriptionStore.pendingEvents",
   )(function* (nowMillis, after, limit) {
     const events: Array<string> = [];
+
     for (const [eventId, indexed] of (yield* Ref.get(state)).eventIndex) {
       if (
         !indexed.routingComplete &&
@@ -369,6 +415,7 @@ const makeMemorySubscriptionStore = Effect.fn("makeMemorySubscriptionStore")(fun
         events.push(eventId);
     }
     events.sort(compareScheduleNames);
+
     return events.slice(0, limit);
   });
 
@@ -376,21 +423,27 @@ const makeMemorySubscriptionStore = Effect.fn("makeMemorySubscriptionStore")(fun
     "MemorySubscriptionStore.candidates",
   )(function* (input, limit) {
     const accepted = yield* validate(AcceptedEvent, input, "candidates-event");
+
     yield* requirePartition(accepted, "candidates-partition");
     const stored = yield* event(accepted.eventId);
+
     if (stored === null || !sameEventIdentity(stored, accepted))
       return yield* error(stored === null ? "not-found" : "conflict", "event");
     const current = yield* Ref.get(state);
     const records: Array<SubscriptionRecord> = [];
+
     for (const storageKey of current.candidateIndex.get(eventCandidateIndexKey(stored)) ?? []) {
       const indexed = current.registrationIndex.get(storageKey);
+
       if (indexed === undefined) return yield* error("corrupt", "candidate-index");
       if (indexed.ordinal <= stored.cursor || indexed.ordinal > stored.cutoff) continue;
       const text = current.registrations.get(storageKey);
+
       if (text === undefined) return yield* error("corrupt", "candidate-record");
       records.push(yield* decodeEffect(SubscriptionRecord, text, "candidate-record"));
     }
     records.sort((a, b) => a.ordinal - b.ordinal);
+
     return records.slice(0, limit);
   });
 
@@ -398,24 +451,31 @@ const makeMemorySubscriptionStore = Effect.fn("makeMemorySubscriptionStore")(fun
     "MemorySubscriptionStore.select",
   )(function* (inputEvent, inputDeliveries, cursor, complete, nowMillis, inputLimits) {
     const suppliedEvent = yield* validate(AcceptedEvent, inputEvent, "select-event");
+
     const deliveries = yield* validate(
       Schema.Array(SubscriptionDelivery),
       inputDeliveries,
       "select-deliveries",
     );
+
     const limits = yield* validate(SubscriptionLimits, inputLimits, "select-limits");
+
     yield* requirePartition(suppliedEvent, "select-partition");
     yield* failpoint.hit("subscription:select:before");
     const effectiveNowMillis = Math.max(nowMillis, yield* Clock.currentTimeMillis);
+
     yield* Effect.uninterruptible(
       Ref.modify(
         state,
         (current): readonly [Result.Result<void, SubscriptionError>, MemorySubscriptionState] => {
           const eventText = current.events.get(suppliedEvent.eventId);
+
           if (eventText === undefined) return [Result.fail(error("not-found", "event")), current];
           const decodedEvent = decode(AcceptedEvent, eventText, "select-event-record");
+
           if (Result.isFailure(decodedEvent)) return [Result.fail(decodedEvent.failure), current];
           const accepted = decodedEvent.success;
+
           if (
             !sameEventIdentity(accepted, suppliedEvent) ||
             suppliedEvent.cursor !== accepted.cursor
@@ -436,13 +496,16 @@ const makeMemorySubscriptionStore = Effect.fn("makeMemorySubscriptionStore")(fun
           const additionIndex: Array<readonly [string, DeliveryIndex, string]> = [];
           const registrationUpdates: Array<readonly [string, RegistrationIndex]> = [];
           const owners = new Map(current.ownerDeliveryCounts);
+
           for (const delivery of deliveries) {
             const recordText = current.registrations.get(
               subscriptionKeyString(delivery.key.subscription),
             );
+
             if (recordText === undefined)
               return [Result.fail(error("not-found", "subscription")), current];
             const record = decode(SubscriptionRecord, recordText, "select-registration");
+
             if (Result.isFailure(record)) return [Result.fail(record.failure), current];
             if (
               !deliveryBelongsTo(delivery, record.success, accepted) ||
@@ -455,18 +518,22 @@ const makeMemorySubscriptionStore = Effect.fn("makeMemorySubscriptionStore")(fun
               continue;
             const deliveryKey = subscriptionDeliveryKeyString(delivery.key);
             const existingText = current.deliveries.get(deliveryKey);
+
             if (existingText !== undefined) {
               const existing = decode(SubscriptionDelivery, existingText, "select-existing");
+
               if (Result.isFailure(existing)) return [Result.fail(existing.failure), current];
               if (!sameDeliveryIdentity(existing.success, delivery))
                 return [Result.fail(error("conflict", "delivery-identity")), current];
               continue;
             }
+
             const encodedDelivery = encode(
               SubscriptionDelivery,
               delivery,
               "select-delivery-encode",
             );
+
             if (Result.isFailure(encodedDelivery))
               return [Result.fail(encodedDelivery.failure), current];
             additions.push([deliveryKey, encodedDelivery.success]);
@@ -480,21 +547,26 @@ const makeMemorySubscriptionStore = Effect.fn("makeMemorySubscriptionStore")(fun
               record.success.key.ownerId,
             ]);
             const ownerId = record.success.key.ownerId;
+
             owners.set(ownerId, (owners.get(ownerId) ?? 0) + 1);
             if ((owners.get(ownerId) ?? 0) > limits.maxDeliveriesPerOwner)
               return [Result.fail(error("capacity", "owner-deliveries")), current];
             if (record.success.configuration.mode === "once") {
               const consumed = { ...record.success, state: "consumed" as const, recovery: null };
+
               const encodedRecord = encode(
                 SubscriptionRecord,
                 consumed,
                 "select-registration-encode",
               );
+
               if (Result.isFailure(encodedRecord))
                 return [Result.fail(encodedRecord.failure), current];
               const consumedKey = subscriptionKeyString(consumed.key);
+
               updates.push([consumedKey, encodedRecord.success]);
               const indexed = current.registrationIndex.get(consumedKey);
+
               if (indexed === undefined)
                 return [Result.fail(error("corrupt", "selection-index")), current];
               registrationUpdates.push([
@@ -506,28 +578,38 @@ const makeMemorySubscriptionStore = Effect.fn("makeMemorySubscriptionStore")(fun
           if (current.deliveries.size + additions.length > limits.maxDeliveries)
             return [Result.fail(error("capacity", "deliveries")), current];
           const registrations = new Map(current.registrations);
+
           for (const [key, value] of updates) registrations.set(key, value);
           const nextDeliveries = new Map(current.deliveries);
+
           for (const [key, value] of additions) nextDeliveries.set(key, value);
           const deliveryIndex = new Map(current.deliveryIndex);
+
           for (const [key, value] of additionIndex) deliveryIndex.set(key, value);
           const registrationIndex = new Map(current.registrationIndex);
+
           for (const [key, value] of registrationUpdates) registrationIndex.set(key, value);
+
           const nextEvent: AcceptedEvent = {
             ...accepted,
             cursor,
             routingComplete: complete,
             routingFailure: null,
           };
+
           const encodedEvent = encode(AcceptedEvent, nextEvent, "select-event-encode");
+
           if (Result.isFailure(encodedEvent)) return [Result.fail(encodedEvent.failure), current];
           const events = new Map(current.events);
+
           events.set(nextEvent.eventId, encodedEvent.success);
           const eventIndex = new Map(current.eventIndex);
+
           eventIndex.set(nextEvent.eventId, {
             routingComplete: nextEvent.routingComplete,
             nextAttemptAtMillis: nextEvent.nextAttemptAtMillis,
           });
+
           return [
             Result.void,
             {
@@ -553,25 +635,31 @@ const makeMemorySubscriptionStore = Effect.fn("makeMemorySubscriptionStore")(fun
     const suppliedEvent = yield* validate(AcceptedEvent, inputEvent, "catch-up-event");
     const delivery = yield* validate(SubscriptionDelivery, inputDelivery, "catch-up-delivery");
     const limits = yield* validate(SubscriptionLimits, inputLimits, "catch-up-limits");
+
     yield* requirePartition(suppliedEvent, "catch-up-partition");
     yield* failpoint.hit("subscription:catch-up:before");
     const effectiveNowMillis = Math.max(nowMillis, yield* Clock.currentTimeMillis);
+
     yield* Effect.uninterruptible(
       Ref.modify(
         state,
         (current): readonly [Result.Result<void, SubscriptionError>, MemorySubscriptionState] => {
           const eventText = current.events.get(suppliedEvent.eventId);
+
           const recordText = current.registrations.get(
             subscriptionKeyString(delivery.key.subscription),
           );
+
           if (eventText === undefined || recordText === undefined)
             return [
               Result.fail(error("not-found", eventText === undefined ? "event" : "subscription")),
               current,
             ];
           const accepted = decode(AcceptedEvent, eventText, "catch-up-event-record");
+
           if (Result.isFailure(accepted)) return [Result.fail(accepted.failure), current];
           const record = decode(SubscriptionRecord, recordText, "catch-up-registration");
+
           if (Result.isFailure(record)) return [Result.fail(record.failure), current];
           if (
             !sameEventIdentity(accepted.success, suppliedEvent) ||
@@ -582,9 +670,12 @@ const makeMemorySubscriptionStore = Effect.fn("makeMemorySubscriptionStore")(fun
             return [Result.fail(error("conflict", "catch-up-identity")), current];
           const key = subscriptionDeliveryKeyString(delivery.key);
           const existingText = current.deliveries.get(key);
+
           if (existingText !== undefined) {
             const existing = decode(SubscriptionDelivery, existingText, "catch-up-existing");
+
             if (Result.isFailure(existing)) return [Result.fail(existing.failure), current];
+
             return sameDeliveryIdentity(existing.success, delivery)
               ? [Result.void, current]
               : [Result.fail(error("conflict", "delivery-identity")), current];
@@ -594,40 +685,51 @@ const makeMemorySubscriptionStore = Effect.fn("makeMemorySubscriptionStore")(fun
           if (current.deliveries.size >= limits.maxDeliveries)
             return [Result.fail(error("capacity", "deliveries")), current];
           const ownerCount = current.ownerDeliveryCounts.get(record.success.key.ownerId) ?? 0;
+
           if (ownerCount >= limits.maxDeliveriesPerOwner)
             return [Result.fail(error("capacity", "owner-deliveries")), current];
+
           const encodedDelivery = encode(
             SubscriptionDelivery,
             delivery,
             "catch-up-delivery-encode",
           );
+
           if (Result.isFailure(encodedDelivery))
             return [Result.fail(encodedDelivery.failure), current];
           const consumed = { ...record.success, state: "consumed" as const, recovery: null };
+
           const encodedRecord = encode(
             SubscriptionRecord,
             consumed,
             "catch-up-registration-encode",
           );
+
           if (Result.isFailure(encodedRecord)) return [Result.fail(encodedRecord.failure), current];
           const deliveries = new Map(current.deliveries);
+
           deliveries.set(key, encodedDelivery.success);
           const registrations = new Map(current.registrations);
           const consumedKey = subscriptionKeyString(consumed.key);
+
           registrations.set(consumedKey, encodedRecord.success);
           const registrationIndex = new Map(current.registrationIndex);
           const indexed = registrationIndex.get(consumedKey);
+
           if (indexed === undefined)
             return [Result.fail(error("corrupt", "catch-up-index")), current];
           registrationIndex.set(consumedKey, { ...indexed, state: "consumed", recoveryAt: null });
           const deliveryIndex = new Map(current.deliveryIndex);
+
           deliveryIndex.set(key, {
             key: delivery.key,
             state: delivery.state,
             nextAttemptAtMillis: delivery.retry.nextAttemptAtMillis,
           });
           const ownerDeliveryCounts = new Map(current.ownerDeliveryCounts);
+
           ownerDeliveryCounts.set(consumed.key.ownerId, ownerCount + 1);
+
           return [
             Result.void,
             {
@@ -652,25 +754,32 @@ const makeMemorySubscriptionStore = Effect.fn("makeMemorySubscriptionStore")(fun
       code === undefined
         ? "routing-failed"
         : yield* validate(SubscriptionName, code, "routing-failure");
+
     yield* failpoint.hit("subscription:defer-event:before");
     yield* Effect.uninterruptible(
       Ref.modify(
         state,
         (current): readonly [Result.Result<void, SubscriptionError>, MemorySubscriptionState] => {
           const text = current.events.get(eventId);
+
           if (text === undefined) return [Result.fail(error("not-found", "event")), current];
           const accepted = decode(AcceptedEvent, text, "defer-event-record");
+
           if (Result.isFailure(accepted)) return [Result.fail(accepted.failure), current];
           const updated = { ...accepted.success, nextAttemptAtMillis, routingFailure };
           const encoded = encode(AcceptedEvent, updated, "defer-event-encode");
+
           if (Result.isFailure(encoded)) return [Result.fail(encoded.failure), current];
           const events = new Map(current.events);
+
           events.set(eventId, encoded.success);
           const eventIndex = new Map(current.eventIndex);
           const indexed = eventIndex.get(eventId);
+
           if (indexed === undefined)
             return [Result.fail(error("corrupt", "defer-event-index")), current];
           eventIndex.set(eventId, { ...indexed, nextAttemptAtMillis });
+
           return [Result.void, { ...current, events, eventIndex }];
         },
       ),
@@ -682,8 +791,10 @@ const makeMemorySubscriptionStore = Effect.fn("makeMemorySubscriptionStore")(fun
     "MemorySubscriptionStore.delivery",
   )(function* (input) {
     const key = yield* validate(SubscriptionDeliveryKey, input, "delivery-key");
+
     yield* requirePartition(key.subscription, "delivery-partition");
     const text = (yield* Ref.get(state)).deliveries.get(subscriptionDeliveryKeyString(key));
+
     return text === undefined
       ? null
       : yield* decodeEffect(SubscriptionDelivery, text, "delivery-record");
@@ -693,6 +804,7 @@ const makeMemorySubscriptionStore = Effect.fn("makeMemorySubscriptionStore")(fun
     "MemorySubscriptionStore.pendingDeliveries",
   )(function* (nowMillis, after, limit) {
     const items: Array<SubscriptionDeliveryKey> = [];
+
     for (const [storageKey, item] of (yield* Ref.get(state)).deliveryIndex) {
       if (
         item.state !== "delivered" &&
@@ -705,6 +817,7 @@ const makeMemorySubscriptionStore = Effect.fn("makeMemorySubscriptionStore")(fun
     items.sort((a, b) =>
       compareScheduleNames(subscriptionDeliveryKeyString(a), subscriptionDeliveryKeyString(b)),
     );
+
     return items.slice(0, limit);
   });
 
@@ -713,9 +826,11 @@ const makeMemorySubscriptionStore = Effect.fn("makeMemorySubscriptionStore")(fun
   )(function* (input, after, limit) {
     const key = yield* requireKey(input, "list-deliveries-key");
     const items: Array<SubscriptionDelivery> = [];
+
     for (const text of (yield* Ref.get(state)).deliveries.values()) {
       const item = yield* decodeEffect(SubscriptionDelivery, text, "list-delivery");
       const itemKey = subscriptionDeliveryKeyString(item.key);
+
       if (
         subscriptionKeyString(item.key.subscription) === subscriptionKeyString(key) &&
         compareScheduleNames(itemKey, after) > 0
@@ -728,6 +843,7 @@ const makeMemorySubscriptionStore = Effect.fn("makeMemorySubscriptionStore")(fun
         subscriptionDeliveryKeyString(b.key),
       ),
     );
+
     return items.slice(0, limit);
   });
 
@@ -737,12 +853,15 @@ const makeMemorySubscriptionStore = Effect.fn("makeMemorySubscriptionStore")(fun
     const key = yield* validate(SubscriptionDeliveryKey, inputKey, "change-delivery-key");
     const deliveryId = yield* validate(Digest, inputDeliveryId, "change-delivery-id");
     const change = yield* validate(DeliveryChange, inputChange, "change-delivery-change");
+
     yield* requirePartition(key.subscription, "change-delivery-partition");
     yield* failpoint.hit(`subscription:delivery-${change._tag.toLowerCase()}:before`);
+
     const effectiveChange =
       change._tag === "Prepare"
         ? { ...change, nowMillis: Math.max(change.nowMillis, yield* Clock.currentTimeMillis) }
         : change;
+
     const result = yield* Effect.uninterruptible(
       Ref.modify(
         state,
@@ -754,36 +873,47 @@ const makeMemorySubscriptionStore = Effect.fn("makeMemorySubscriptionStore")(fun
         ] => {
           const storageKey = subscriptionDeliveryKeyString(key);
           const text = current.deliveries.get(storageKey);
+
           if (text === undefined) return [Result.fail(error("not-found", "delivery")), current];
           const decoded = decode(SubscriptionDelivery, text, "change-delivery-record");
+
           if (Result.isFailure(decoded)) return [decoded, current];
+
           const registrationText = current.registrations.get(
             subscriptionKeyString(key.subscription),
           );
+
           if (registrationText === undefined)
             return [Result.fail(error("corrupt", "delivery-registration")), current];
+
           const registration = decode(
             SubscriptionRecord,
             registrationText,
             "delivery-registration",
           );
+
           if (Result.isFailure(registration)) return [Result.fail(registration.failure), current];
+
           const transition = applySubscriptionDeliveryChange(
             decoded.success,
             registration.success,
             deliveryId,
             effectiveChange,
           );
+
           if (Result.isFailure(transition)) return [Result.fail(transition.failure), current];
           if (transition.success === decoded.success)
             return [Result.succeed(decoded.success), current];
           const updated = transition.success;
           const encoded = encode(SubscriptionDelivery, updated, "change-delivery-encode");
+
           if (Result.isFailure(encoded)) return [Result.fail(encoded.failure), current];
           const deliveries = new Map(current.deliveries);
+
           deliveries.set(storageKey, encoded.success);
           const deliveryIndex = new Map(current.deliveryIndex);
           const indexed = deliveryIndex.get(storageKey);
+
           if (indexed === undefined)
             return [Result.fail(error("corrupt", "delivery-index")), current];
           deliveryIndex.set(storageKey, {
@@ -791,11 +921,14 @@ const makeMemorySubscriptionStore = Effect.fn("makeMemorySubscriptionStore")(fun
             state: updated.state,
             nextAttemptAtMillis: updated.retry.nextAttemptAtMillis,
           });
+
           return [Result.succeed(updated), { ...current, deliveries, deliveryIndex }];
         },
       ),
     ).pipe(Effect.flatMap(Effect.fromResult));
+
     yield* failpoint.hit(`subscription:delivery-${change._tag.toLowerCase()}:after`);
+
     return result;
   });
 
@@ -803,6 +936,7 @@ const makeMemorySubscriptionStore = Effect.fn("makeMemorySubscriptionStore")(fun
     "MemorySubscriptionStore.recovering",
   )(function* (nowMillis, after, limit) {
     const records: Array<{ readonly key: SubscriptionKey; readonly ordinal: number }> = [];
+
     for (const item of (yield* Ref.get(state)).registrationIndex.values()) {
       if (
         item.ordinal > after &&
@@ -813,6 +947,7 @@ const makeMemorySubscriptionStore = Effect.fn("makeMemorySubscriptionStore")(fun
         records.push({ key: item.key, ordinal: item.ordinal });
     }
     records.sort((a, b) => a.ordinal - b.ordinal);
+
     return records.slice(0, limit);
   });
 
@@ -820,6 +955,7 @@ const makeMemorySubscriptionStore = Effect.fn("makeMemorySubscriptionStore")(fun
     "MemorySubscriptionStore.deferRecovery",
   )(function* (input, recovery) {
     const key = yield* requireKey(input, "defer-recovery-key");
+
     yield* failpoint.hit("subscription:defer-recovery:before");
     yield* Effect.uninterruptible(
       Ref.modify(
@@ -827,25 +963,33 @@ const makeMemorySubscriptionStore = Effect.fn("makeMemorySubscriptionStore")(fun
         (current): readonly [Result.Result<void, SubscriptionError>, MemorySubscriptionState] => {
           const storageKey = subscriptionKeyString(key);
           const text = current.registrations.get(storageKey);
+
           if (text === undefined) return [Result.fail(error("not-found", "subscription")), current];
           const record = decode(SubscriptionRecord, text, "defer-recovery-record");
+
           if (Result.isFailure(record)) return [Result.fail(record.failure), current];
+
           const updated = {
             ...record.success,
             recovery: record.success.state === "active" ? recovery : null,
           };
+
           const encoded = encode(SubscriptionRecord, updated, "defer-recovery-encode");
+
           if (Result.isFailure(encoded)) return [Result.fail(encoded.failure), current];
           const registrations = new Map(current.registrations);
+
           registrations.set(storageKey, encoded.success);
           const registrationIndex = new Map(current.registrationIndex);
           const indexed = registrationIndex.get(storageKey);
+
           if (indexed === undefined)
             return [Result.fail(error("corrupt", "recovery-index")), current];
           registrationIndex.set(storageKey, {
             ...indexed,
             recoveryAt: updated.recovery?.nextAttemptAtMillis ?? null,
           });
+
           return [Result.void, { ...current, registrations, registrationIndex }];
         },
       ),
@@ -861,6 +1005,7 @@ const makeMemorySubscriptionStore = Effect.fn("makeMemorySubscriptionStore")(fun
     "MemorySubscriptionStore.advanceScanCursors",
   )(function* (input) {
     const cursors = yield* validate(SubscriptionScanCursors, input, "scan-cursors");
+
     yield* failpoint.hit("subscription:advance-scan-cursors:before");
     yield* Effect.uninterruptible(
       Ref.update(state, (current) => ({ ...current, scanCursors: cursors })),
@@ -871,15 +1016,18 @@ const makeMemorySubscriptionStore = Effect.fn("makeMemorySubscriptionStore")(fun
   const nextDeadline = Effect.gen(function* () {
     let deadline: number | null = null;
     const current = yield* Ref.get(state);
+
     if (
       current.scanCursors.events !== "" ||
       current.scanCursors.deliveries !== "" ||
       current.scanCursors.recovery !== 0
     )
       return 0;
+
     const consider = (value: number) => {
       if (deadline === null || value < deadline) deadline = value;
     };
+
     for (const accepted of current.eventIndex.values())
       if (!accepted.routingComplete) consider(accepted.nextAttemptAtMillis);
     for (const item of current.deliveryIndex.values())
@@ -887,6 +1035,7 @@ const makeMemorySubscriptionStore = Effect.fn("makeMemorySubscriptionStore")(fun
         consider(item.nextAttemptAtMillis);
     for (const record of current.registrationIndex.values())
       if (record.state === "active" && record.recoveryAt !== null) consider(record.recoveryAt);
+
     return deadline;
   }).pipe(Effect.withSpan("MemorySubscriptionStore.nextDeadline"));