@effect-agent/pr-review 0.1.0-beta.6 → 0.1.0-beta.60

package/src/internal/fan-out.ts

@@ -1,459 +0,0 @@
-import { Effect, Schema } from "effect";
-import {
-  Agent,
-  AgentPolicy,
-  AgentSpawner,
-  IdGenerator,
-  RunEventSink,
-  Subagent,
-  SubagentBudgetExhausted,
-  SubagentDurability,
-  SubagentDurabilityError,
-  SubagentExecutionFailure,
-  SubagentPolicy,
-  SubagentPrestartDenied,
-  SubagentProjectionFailure,
-  SubagentRuntime,
-  ToolCallWaiting,
-  ToolExecutionClass,
-  type RuntimeBinding,
-} from "effect-agent";
-import { Tool, Toolkit } from "effect/unstable/ai";
-
-import { ChangedPath } from "./diff.ts";
-import {
-  clampMaxFindings,
-  CodeReview,
-  MAX_CONCERNS,
-  ReadFile,
-  ReadFileDiff,
-  readFileDiffHandler,
-  readFileHandler,
-  ReviewConcern,
-  ReviewFinding,
-  ReviewMission,
-} from "./review-agent.ts";
-import {
-  MAX_REVIEW_UNITS,
-  MAX_UNIT_FILES,
-  planReviewUnits,
-  ReviewUnitId,
-  ReviewUnitPlan,
-} from "./review-units.ts";
-import { PullRequestSource, PullRequestSourceFailure } from "./source.ts";
-
-// ---------------------------------------------------------------------------
-// The fan-out reviewer: the same review contract as the flat reviewer, but
-// the diff reading happens in bounded delegated children (S1 attached
-// ephemeral delegation) so no single context window has to hold every diff.
-// A coordinator lists the changeset as deterministic review units, delegates
-// one `delegate_file_review` call per unit, then merges the children's
-// bounded findings into one `CodeReview`. Publication and anchor validation
-// are unchanged: child output is untrusted input like everything else and
-// crosses to the host only through the same fail-closed planPublication path.
-// ---------------------------------------------------------------------------
-
-/** One child returns at most this many findings; the merge caps the total. */
-export const MAX_CHILD_FINDINGS = 8;
-
-/** One child returns at most this many non-anchored concerns. */
-export const MAX_CHILD_CONCERNS = 3;
-
-/**
- * One mandatory diff read plus one bounded context read for every path in a
- * maximum-size unit. Keep the child and delegation reservation aligned.
- */
-export const MAX_FILE_REVIEW_TOOL_CALLS = MAX_UNIT_FILES * 2;
-
-// ---------------------------------------------------------------------------
-// The child: a file reviewer over one unit. Its toolkit is intentionally
-// smaller than the flat reviewer's — diff and head-file reads only, no
-// changeset listing — so a child can never roam beyond its briefed unit
-// despite its observation surface being the whole changeset port.
-// ---------------------------------------------------------------------------
-
-export const FileReviewToolkit = Toolkit.make(ReadFileDiff, ReadFile);
-
-export const FileReviewToolkitLayer = FileReviewToolkit.toLayer({
-  read_file_diff: readFileDiffHandler,
-  read_file: readFileHandler,
-});
-
-const UnitPaths = Schema.Array(ChangedPath)
-  .check(Schema.isMinLength(1))
-  .check(Schema.isMaxLength(MAX_UNIT_FILES));
-
-/** The child Agent input: one briefed unit of the changeset. */
-export class FileReviewBrief extends Schema.Class<FileReviewBrief>(
-  "@effect-agent/pr-review/FileReviewBrief",
-)({
-  unitId: ReviewUnitId,
-  paths: UnitPaths,
-  focus: Schema.NonEmptyString.check(Schema.isMaxLength(200)),
-}) {}
-
-/** The child Agent output: the briefed unit's bounded findings and concerns. */
-export class FileReviewReport extends Schema.Class<FileReviewReport>(
-  "@effect-agent/pr-review/FileReviewReport",
-)({
-  unitId: ReviewUnitId,
-  findings: Schema.Array(ReviewFinding).check(Schema.isMaxLength(MAX_CHILD_FINDINGS)),
-  /** Unit-scoped concerns with no diff line to anchor to. */
-  concerns: Schema.optionalKey(
-    Schema.Array(ReviewConcern).check(Schema.isMaxLength(MAX_CHILD_CONCERNS)),
-  ),
-}) {}
-
-/**
- * Guidance for delegated children must be static: child instructions are a
- * pure function of the brief, and the coordinator's mission never crosses the
- * delegation boundary (context isolation), so mission-dependent guidance
- * cannot be resolved for a child.
- */
-export interface FanOutInstructionOptions {
-  readonly guidance?: string | ReadonlyArray<string> | undefined;
-}
-
-const staticGuidanceLines = (
-  guidance: string | ReadonlyArray<string> | undefined,
-): ReadonlyArray<string> => {
-  if (guidance === undefined) return [];
-  const lines = typeof guidance === "string" ? [guidance] : guidance;
-  return lines.filter((line) => line.length > 0);
-};
-
-/** Build the child file-reviewer instructions with optional static guidance. */
-export const makeFileReviewerInstructions =
-  (options: FanOutInstructionOptions = {}) =>
-  (brief: FileReviewBrief): string =>
-    [
-      `You are a code reviewer for one unit of a pull request: unit ${brief.unitId}, covering exactly these changed files: ${brief.paths.join(", ")}. Focus: ${brief.focus}.`,
-      ...staticGuidanceLines(options.guidance),
-      "Work in this order:",
-      "1. Call read_file_diff for every file in your unit. In its output, only lines marked R<number> exist in the new version; those numbers are the only valid values for startLine and endLine. Never anchor a finding to a removed (-) line.",
-      "2. Call read_file when you need surrounding context the diff does not show. ONLY files in the changeset are readable: a request for any other path (an import, a neighbor, a config) returns a failed result — do not retry it; reason from the diff instead and note the gap in your report when it matters.",
-      "3. Review for real defects first: correctness, security, concurrency, resource leaks, error handling, API misuse. Style nits are least important. Do not praise; do not restate the diff.",
-      "When the diff adds or changes a test, check that it can actually fail: a test that would still pass with the bug present is theatre, not coverage. The usual tell is a loose assertion standing where an exact one belongs — >= or a truthiness check over an expected value, or a snapshot that absorbs whatever it is handed.",
-      "Drop bloat-shaped findings before reporting: defensive checks for cases that cannot happen, abstractions used once, comments restating obvious code, tests asserting tautologies, just-in-case guards. A finding must be sound, correct, and worth acting on; prefer an explicit keep over an invented finding.",
-      `4. Then return ONLY a JSON object — no Markdown fences, no prose before or after — exactly this shape: {"unitId": ${JSON.stringify(brief.unitId)}, "findings": [{"path": <string, a file in your unit>, "startLine": <integer, an R-marked new-file line>, "endLine": <integer, >= startLine, same file, R-marked>, "severity": <"blocking" | "important" | "nit">, "title": <string, <= 120 chars>, "body": <string, why it matters and what to do>, "suggestion": <string, OPTIONAL: replacement text for exactly lines startLine..endLine, ready to commit>}], "concerns": <array, OPTIONAL: [{"severity": <"blocking" | "important" | "nit">, "title": <string, <= 120 chars>, "body": <string>}], only for concerns about YOUR unit's files with no valid line anchor (a missing cleanup, a coverage gap the diff implies, sequencing the diff leaves open) — never duplicate a finding here>}.`,
-      `Report at most ${MAX_CHILD_FINDINGS} findings and at most ${MAX_CHILD_CONCERNS} concerns; prefer the most important ones. An empty findings array is a valid report. Never report on files outside your unit. Line anchors you invent will be discarded, so copy R-numbers from read_file_diff output.`,
-    ].join("\n");
-
-export const fileReviewerInstructions = makeFileReviewerInstructions();
-
-/** The default per-unit child execution bounds. */
-export const defaultFileReviewerPolicy = AgentPolicy.make({
-  maxTurns: 8,
-  maxToolCalls: MAX_FILE_REVIEW_TOOL_CALLS,
-  maxDuration: "4 minutes",
-  toolConcurrency: 2,
-  tokenBudget: 200_000,
-  // S1 soft landing is not yet adopted here: the fan-out contract pins the
-  // typed "unit unreviewed" failure flow until the containment slice reworks
-  // it (planned S2/S3 of the budget arc).
-  onExhaustion: "fail",
-});
-
-// ---------------------------------------------------------------------------
-// The delegation: one Effect AI Tool per review unit, with explicit
-// projections and finite bounds (SUB-009). `projectResult` is the
-// declassification boundary — the parent sees the child's bounded findings,
-// never its transcript or the diffs it read.
-// ---------------------------------------------------------------------------
-
-/** The model-decoded delegation parameters: which unit to review. */
-export class FileReviewRequest extends Schema.Class<FileReviewRequest>(
-  "@effect-agent/pr-review/FileReviewRequest",
-)({
-  unitId: ReviewUnitId,
-  paths: UnitPaths,
-}) {}
-
-/** The bounded parent-visible result of one delegated unit review. */
-export class FileReviewUnitResult extends Schema.Class<FileReviewUnitResult>(
-  "@effect-agent/pr-review/FileReviewUnitResult",
-)({
-  unitId: ReviewUnitId,
-  findings: Schema.Array(ReviewFinding).check(Schema.isMaxLength(MAX_CHILD_FINDINGS)),
-  /** Unit-scoped concerns with no diff line to anchor to. */
-  concerns: Schema.optionalKey(
-    Schema.Array(ReviewConcern).check(Schema.isMaxLength(MAX_CHILD_CONCERNS)),
-  ),
-}) {}
-
-/**
- * One unit's review failed: the child Run ended in a typed failure (policy
- * bound, output violation, model fault). The marker is bounded and carries no
- * child transcript content beyond the failure tag and message.
- */
-export class FileReviewUnitFailed extends Schema.TaggedError<FileReviewUnitFailed>()(
-  "FileReviewUnitFailed",
-  {
-    childErrorTag: Schema.NonEmptyString.check(Schema.isMaxLength(256)),
-    message: Schema.String.check(Schema.isMaxLength(400)),
-  },
-) {}
-
-/**
- * Finite per-invocation bounds (SUB-009), aligned with the child's own
- * AgentPolicy: the child's policy is the limit that trips typed; the
- * reservation mirrors it so parent-side accounting stays honest.
- */
-export const fileReviewPolicy = SubagentPolicy.make({
-  maxChildren: MAX_REVIEW_UNITS,
-  maxConcurrency: 3,
-  maxTurns: 8,
-  maxToolCalls: MAX_FILE_REVIEW_TOOL_CALLS,
-  maxDuration: "4 minutes",
-});
-
-const delegationDescription =
-  "Delegate the review of one planned unit to a bounded file-reviewer child and return its line-anchored findings. Call it exactly once per unit from list_review_units; never retry a failed unit.";
-
-/**
- * Total mapping from every expected child Run failure to the declared unit
- * failure (SUB-028): the tag plus a bounded message, nothing else crosses.
- */
-export const mapFileReviewChildFailure = (failure: {
-  readonly _tag: string;
-  readonly message?: string;
-}): FileReviewUnitFailed =>
-  FileReviewUnitFailed.make({
-    childErrorTag: failure._tag,
-    message: (failure.message ?? "").slice(0, 400),
-  });
-
-// ---------------------------------------------------------------------------
-// The parent-facing view of the delegation Tool.
-//
-// `Subagent.define` fixes `failureMode: "error"`, so a failed child would
-// fail the WHOLE parent Run typed — one unreviewable unit would abort the
-// entire fan-out review. This coordinator wants partial results with honest
-// reporting instead, so its Toolkit carries a same-name Tool value with the
-// identical parameter/success/failure Schemas but `failureMode: "return"`:
-// Effect AI resolves handlers by Tool NAME, so the real S1 delegation handler
-// from `SubagentRuntime.layer` still executes, and a typed unit failure
-// reaches the model as a failed tool result (bounded, encoded through the
-// declared failure union) instead of aborting the Run.
-// ---------------------------------------------------------------------------
-
-/** Exactly the failure union `Subagent.define` declares for this delegation. */
-export const FileReviewDelegationFailure = Schema.Union([
-  FileReviewUnitFailed,
-  SubagentPrestartDenied,
-  SubagentBudgetExhausted,
-  SubagentProjectionFailure,
-  SubagentExecutionFailure,
-  ToolCallWaiting,
-  SubagentDurabilityError,
-]);
-
-export const DelegateFileReview = Tool.make("delegate_file_review", {
-  description: delegationDescription,
-  parameters: FileReviewRequest,
-  success: FileReviewUnitResult,
-  failure: FileReviewDelegationFailure,
-  failureMode: "return",
-})
-  .addDependency(AgentSpawner)
-  .addDependency(RunEventSink)
-  .addDependency(SubagentDurability)
-  .addDependency(IdGenerator)
-  // The delegated child's whole tool surface is read-only.
-  .annotate(ToolExecutionClass, "readonly");
-
-// ---------------------------------------------------------------------------
-// The coordinator's own tool: the deterministic unit plan over the changeset.
-// Grouping is host code (review-units.ts), not model prose, so fan-out shape
-// and budget honesty stay pinnable in tests.
-// ---------------------------------------------------------------------------
-
-export class ListReviewUnitsQuery extends Schema.Class<ListReviewUnitsQuery>(
-  "@effect-agent/pr-review/ListReviewUnitsQuery",
-)({
-  /** Explicit constant keeps the zero-choice operation compatible with strict provider schemas. */
-  scope: Schema.Literal("all"),
-}) {}
-
-export const ListReviewUnits = Tool.make("list_review_units", {
-  description:
-    "List this pull request's changeset grouped into bounded review units (size-budgeted, directory-affine), plus the files no unit can cover.",
-  parameters: ListReviewUnitsQuery,
-  success: ReviewUnitPlan,
-  failure: PullRequestSourceFailure,
-  failureMode: "error",
-  dependencies: [PullRequestSource],
-}).annotate(ToolExecutionClass, "readonly");
-
-export const FanOutCoordinatorToolkit = Toolkit.make(ListReviewUnits);
-
-export const FanOutCoordinatorToolkitLayer = FanOutCoordinatorToolkit.toLayer({
-  list_review_units: () =>
-    Effect.gen(function* () {
-      const source = yield* PullRequestSource;
-      const files = yield* source.changedFiles;
-      const metadata = yield* source.metadata;
-      return planReviewUnits(files, { totalChangedFiles: metadata.totalChangedFiles });
-    }),
-});
-
-// ---------------------------------------------------------------------------
-// The coordinator Agent Definition: same mission input and CodeReview output
-// contract as the flat reviewer, so planPublication and anchor validation
-// apply unchanged.
-// ---------------------------------------------------------------------------
-
-export const FanOutReviewToolkit = Toolkit.make(ListReviewUnits, DelegateFileReview);
-
-/**
- * Build the coordinator's instructions. The same consumer guidance the
- * children receive is injected between the mission framing and the procedure
- * so the merged summary and verdict are shaped by the same review profile,
- * and the configured findings bound reaches the merge step instead of only
- * the host-side trim.
- */
-export const makeFanOutReviewInstructions =
-  (options: FanOutInstructionOptions & { readonly maxFindings?: number | undefined } = {}) =>
-  (mission: ReviewMission): string => {
-    const maxFindings = clampMaxFindings(options.maxFindings);
-    return [
-      `You coordinate the review of pull request #${mission.number} ("${mission.title}") in ${mission.repository}, merging ${mission.headRef} into ${mission.baseRef}. It changes ${mission.changedFileCount} file(s).`,
-      mission.body.length > 0
-        ? `Author description:\n${mission.body}`
-        : "The author provided no description.",
-      ...staticGuidanceLines(options.guidance),
-      "Work in this order:",
-      "1. Call list_review_units once to get the planned review units.",
-      "2. Call delegate_file_review EXACTLY once per unit, passing each unit's unitId and paths verbatim. Prefer declaring all delegation calls in one batch. Never review files yourself and never invent units.",
-      '3. A delegation result with "_tag" is a FAILED unit. Never retry it; instead your summary MUST name it honestly, e.g. "unit-002 unreviewed: AgentPolicyError". The plan\'s undiffablePaths and unassignedPaths must also be named as not reviewed when present.',
-      `4. Merge the successful units' findings: drop duplicates sharing the same path and line range keeping the most severe, rank blocking > important > nit, and keep at most ${maxFindings} findings. Drop bloat-shaped findings during the merge — defensive checks for cases that cannot happen, abstractions used once, comments restating obvious code, tests asserting tautologies; children bias toward recommending changes, and a finding must be sound, correct, and worth acting on to survive.`,
-      `5. Merge the units' concerns the same way: drop duplicates keeping the most severe, and keep at most ${MAX_CONCERNS}.`,
-      '6. Then return ONLY a JSON object — no Markdown fences, no prose before or after — exactly this shape: {"summary": <string, 1-3 paragraphs of overall assessment, including every unreviewed unit or file>, "verdict": <"approve" | "comment" | "request-changes">, "findings": [{"path": <string>, "startLine": <integer>, "endLine": <integer>, "severity": <"blocking" | "important" | "nit">, "title": <string, <= 120 chars>, "body": <string>, "suggestion": <string, OPTIONAL>}], "concerns": <array, OPTIONAL: [{"severity": <"blocking" | "important" | "nit">, "title": <string, <= 120 chars>, "body": <string>}], the merged unit concerns>}. Copy findings and concerns verbatim from the delegation results; never invent or edit anchors.',
-      'Use verdict "request-changes" only when at least one finding or concern is "blocking". An empty findings array with verdict "approve" is a valid review when every unit succeeded and found nothing.',
-    ].join("\n");
-  };
-
-export const fanOutReviewInstructions = makeFanOutReviewInstructions();
-
-/** The default fan-out coordinator execution bounds. */
-export const defaultFanOutPolicy = AgentPolicy.make({
-  maxTurns: 6,
-  maxToolCalls: 1 + MAX_REVIEW_UNITS,
-  maxDuration: "15 minutes",
-  toolConcurrency: 3,
-  // One declared batch may legitimately contain a failed result for every
-  // review unit. Leave the coordinator one turn to report all of them, while
-  // still stopping a model that declares another failed delegation.
-  repeatedFailureLimit: MAX_REVIEW_UNITS + 1,
-  tokenBudget: 300_000,
-  // See defaultFileReviewerPolicy: soft-landing adoption is the S2/S3 rework.
-  onExhaustion: "fail",
-});
-
-/** Everything one fan-out configuration is made of, built as one unit so the
- * delegation always targets exactly the child definition that will run. */
-export interface FanOutReviewSuite {
-  readonly child: ReturnType<typeof makeFileReviewerDefinition>;
-  readonly parent: ReturnType<typeof makeFanOutReviewerDefinition>;
-  readonly delegation: ReturnType<typeof makeFileReviewDelegation>;
-}
-
-const makeFileReviewerDefinition = (options: FanOutInstructionOptions = {}) =>
-  Agent.define("pr-file-reviewer", {
-    input: FileReviewBrief,
-    output: FileReviewReport,
-    instructions: makeFileReviewerInstructions(options),
-    toolkit: FileReviewToolkit,
-    policy: defaultFileReviewerPolicy,
-    description:
-      "Review one bounded unit of a pull request's changeset read-only and return line-anchored findings for exactly those files.",
-    metadata: { deploymentClass: "E", surface: "read-only" },
-  });
-
-/** Options for one coherent fan-out suite: shared guidance plus the merge bound. */
-export interface FanOutSuiteOptions extends FanOutInstructionOptions {
-  readonly maxFindings?: number | undefined;
-}
-
-const makeFanOutReviewerDefinition = (options: FanOutSuiteOptions = {}) =>
-  Agent.define("pr-fanout-reviewer", {
-    input: ReviewMission,
-    output: CodeReview,
-    instructions: makeFanOutReviewInstructions(options),
-    toolkit: FanOutReviewToolkit,
-    policy: defaultFanOutPolicy,
-    description:
-      "Coordinate one pull-request review by fanning bounded per-unit file reviews out to delegated children and merging their findings into one structured review.",
-    metadata: { deploymentClass: "E", surface: "read-only", delegation: "S1-attached" },
-  });
-
-const makeFileReviewDelegation = (child: ReturnType<typeof makeFileReviewerDefinition>) =>
-  Subagent.define("delegate_file_review", {
-    description: delegationDescription,
-    target: child,
-    parameters: FileReviewRequest,
-    success: FileReviewUnitResult,
-    failure: FileReviewUnitFailed,
-    prepareInput: (request) =>
-      Effect.succeed(
-        FileReviewBrief.make({
-          unitId: request.unitId,
-          paths: request.paths,
-          focus: "defects-first: correctness, security, concurrency, resources, error handling",
-        }),
-      ),
-    // The explicit declassification boundary (SUB-015): exactly the bounded
-    // findings and concerns cross to the parent. Whether findings may anchor
-    // anywhere is decided host-side by planPublication against the real diff.
-    projectResult: (report) =>
-      Effect.succeed(
-        FileReviewUnitResult.make({
-          unitId: report.unitId,
-          findings: report.findings,
-          ...(report.concerns !== undefined ? { concerns: report.concerns } : {}),
-        }),
-      ),
-    policy: fileReviewPolicy,
-  });
-
-/** Build one coherent fan-out suite: child, coordinator, and delegation. */
-export const makeFanOutReviewSuite = (options: FanOutSuiteOptions = {}): FanOutReviewSuite => {
-  const child = makeFileReviewerDefinition({ guidance: options.guidance });
-  return {
-    child,
-    parent: makeFanOutReviewerDefinition(options),
-    delegation: makeFileReviewDelegation(child),
-  };
-};
-
-const defaultSuite = makeFanOutReviewSuite();
-
-/** The default child Agent Definition. */
-export const FileReviewer = defaultSuite.child;
-
-/** The default coordinator Agent Definition. */
-export const FanOutReviewer = defaultSuite.parent;
-
-/** The default delegation over the default child. */
-export const fileReviewDelegation = defaultSuite.delegation;
-
-/** Runtime wiring: one delegation plus one explicit child Binding. */
-export const fanOutHandlersLayerFor =
-  (delegation: ReturnType<typeof makeFileReviewDelegation>) =>
-  <Provider, ModelProvides, ModelRequires>(
-    childBinding: RuntimeBinding<
-      typeof FileReviewBrief,
-      typeof FileReviewReport,
-      ReturnType<typeof makeFileReviewerInstructions>,
-      Toolkit.Tools<typeof FileReviewToolkit>,
-      Provider,
-      ModelProvides,
-      ModelRequires
-    >,
-  ) =>
-    SubagentRuntime.layer(delegation, childBinding, {
-      mapChildFailure: mapFileReviewChildFailure,
-    });
-
-/** Runtime wiring over the default delegation, mirroring the leaf example. */
-export const fanOutHandlersLayer = fanOutHandlersLayerFor(fileReviewDelegation);

package/src/internal/fingerprint.ts

@@ -1,74 +0,0 @@
-import { Effect } from "effect";
-
-import type { ChangedFile } from "./diff.ts";
-
-// ---------------------------------------------------------------------------
-// Changeset fingerprinting: dedupe re-reviews of an UNCHANGED effective diff.
-// Repositories that auto-merge the base branch into open pull requests fire
-// `synchronize` on every base update; the head SHA moves but the three-dot
-// changeset the reviewer reads is byte-identical. The fingerprint hashes the
-// (ignore-filtered) changeset together with a prompt signature — everything
-// that shapes the review — so a rebase with no content change skips, while a
-// real change, a conflict resolution, or a guidance change reviews again.
-//
-// The reviewer is deployment class E and owns no storage: the fingerprint is
-// embedded in the posted review body as an invisible HTML comment, so the
-// published review itself is the deduplication state.
-// ---------------------------------------------------------------------------
-
-const MARKER_PREFIX = "<!-- effect-agent-pr-review fingerprint=sha256:";
-const MARKER_SUFFIX = " -->";
-const MARKER_PATTERN = /<!-- effect-agent-pr-review fingerprint=sha256:([0-9a-f]{64}) -->/g;
-
-/** Render the invisible review-body marker for one fingerprint. */
-export const renderFingerprintMarker = (fingerprint: string): string =>
-  `${MARKER_PREFIX}${fingerprint}${MARKER_SUFFIX}`;
-
-/** The rendered marker length is fixed; publication reserves room for it. */
-export const FINGERPRINT_MARKER_LENGTH = renderFingerprintMarker("0".repeat(64)).length;
-
-/** Extract the last fingerprint marker in one review body, if any. */
-export const extractFingerprint = (body: string): string | undefined => {
-  let last: string | undefined;
-  for (const match of body.matchAll(MARKER_PATTERN)) {
-    last = match[1];
-  }
-  return last;
-};
-
-/** WebCrypto SHA-256; unavailable crypto is a defect, not an expected failure. */
-const sha256Hex = (text: string): Effect.Effect<string> =>
-  Effect.promise(async () => {
-    const digest = await globalThis.crypto.subtle.digest("SHA-256", new TextEncoder().encode(text));
-    return Array.from(new Uint8Array(digest))
-      .map((byte) => byte.toString(16).padStart(2, "0"))
-      .join("");
-  });
-
-const FIELD = "\u0000";
-const RECORD = "\u0001";
-const SECTION = "\u0002";
-
-/**
- * Canonical changeset encoding: sorted by path so provider ordering never
- * matters, with every review-relevant field of every file.
- */
-const canonicalChangeset = (files: ReadonlyArray<ChangedFile>): string =>
-  files
-    .map(
-      (file) =>
-        `${file.path}${FIELD}${file.status}${FIELD}${String(file.additions)}${FIELD}${String(file.deletions)}${FIELD}${file.patch ?? ""}`,
-    )
-    .sort()
-    .join(RECORD);
-
-/**
- * Fingerprint one review's complete input surface: the (already
- * ignore-filtered) changeset plus the caller's prompt signature — the
- * rendered instructions and any review-shaping options the instructions do
- * not carry.
- */
-export const computeChangesetFingerprint = (
-  files: ReadonlyArray<ChangedFile>,
-  signature: string,
-): Effect.Effect<string> => sha256Hex(`${canonicalChangeset(files)}${SECTION}${signature}`);

package/src/internal/fixtures.ts

@@ -1,127 +0,0 @@
-import { Effect, Layer, Option, Ref, Schema } from "effect";
-
-import { ChangedFile } from "./diff.ts";
-import {
-  PriorReviewLookupFailure,
-  PriorReviews,
-  PublishedReview,
-  ReviewPublisher,
-} from "./github.ts";
-import type { ReviewPublicationPlan } from "./render.ts";
-import type { ReviewHeadComparison, ReviewState } from "./review-state.ts";
-import {
-  MAX_CHANGED_FILES,
-  MAX_FILE_CHARS,
-  normalizeRepoRelativePath,
-  PullRequestMetadata,
-  PullRequestSource,
-  ReviewInputViolation,
-} from "./source.ts";
-
-// ---------------------------------------------------------------------------
-// Deterministic in-memory adapters for both ports: a fixture pull request
-// serving the PullRequestSource, and a collecting ReviewPublisher recording
-// every plan. Tests, dry runs, and live smokes run against these with no
-// network and no credentials.
-// ---------------------------------------------------------------------------
-
-/** One fixture file: its changeset entry plus optional head content. */
-export class FixtureFile extends Schema.Class<FixtureFile>("@effect-agent/pr-review/FixtureFile")({
-  file: ChangedFile,
-  headContent: Schema.optionalKey(Schema.String.check(Schema.isMaxLength(MAX_FILE_CHARS))),
-}) {}
-
-/** A complete in-memory pull request for tests, dry runs, and live smokes. */
-export class FixturePullRequest extends Schema.Class<FixturePullRequest>(
-  "@effect-agent/pr-review/FixturePullRequest",
-)({
-  metadata: PullRequestMetadata,
-  files: Schema.Array(FixtureFile).check(Schema.isMaxLength(MAX_CHANGED_FILES)),
-}) {}
-
-const requireChanged = (
-  fixture: FixturePullRequest,
-  path: string,
-): Effect.Effect<FixtureFile, ReviewInputViolation> => {
-  const entry = fixture.files.find((candidate) => candidate.file.path === path);
-  return entry === undefined
-    ? Effect.fail(
-        ReviewInputViolation.make({
-          input: path,
-          reason: "Path is not part of this pull request's changeset.",
-        }),
-      )
-    : Effect.succeed(entry);
-};
-
-/** Deterministic `PullRequestSource` over one fixture pull request. */
-export const fixturePullRequestSourceLayer = (
-  fixture: FixturePullRequest,
-): Layer.Layer<PullRequestSource> =>
-  Layer.succeed(PullRequestSource)(
-    PullRequestSource.of({
-      metadata: Effect.succeed(fixture.metadata),
-      changedFiles: Effect.succeed(fixture.files.map((entry) => entry.file)),
-      anchorFiles: Effect.succeed(fixture.files.map((entry) => entry.file)),
-      readFile: (path) =>
-        Effect.gen(function* () {
-          const relative = yield* normalizeRepoRelativePath(path);
-          const entry = yield* requireChanged(fixture, relative);
-          if (entry.headContent === undefined) {
-            return yield* ReviewInputViolation.make({
-              input: relative,
-              reason: "No head content is available for this file.",
-            });
-          }
-          return entry.headContent;
-        }),
-    }),
-  );
-
-/** In-memory publisher: records every plan and mints a deterministic receipt. */
-export const collectingReviewPublisherLayer = (
-  published: Ref.Ref<ReadonlyArray<ReviewPublicationPlan>>,
-): Layer.Layer<ReviewPublisher> =>
-  Layer.succeed(ReviewPublisher)(
-    ReviewPublisher.of({
-      publish: (plan) =>
-        Ref.update(published, (plans) => [...plans, plan]).pipe(
-          Effect.flatMap(() => Ref.get(published)),
-          Effect.map((plans) =>
-            PublishedReview.make({
-              reviewId: plans.length,
-              url: `memory://review/${plans.length}`,
-              event: plan.event,
-              inlineComments: plan.comments.length,
-            }),
-          ),
-        ),
-    }),
-  );
-
-/** Static `PriorReviews` service for tests: fixed history and comparisons. */
-export const staticPriorReviews = (
-  fingerprint: Option.Option<string>,
-  options: {
-    readonly state?: Option.Option<ReviewState> | undefined;
-    readonly comparison?: ReviewHeadComparison | undefined;
-  } = {},
-): PriorReviews["Service"] =>
-  PriorReviews.of({
-    latestFingerprint: Effect.succeed(fingerprint),
-    latestState: Effect.succeed(options.state ?? Option.none()),
-    compareHeads: () =>
-      options.comparison === undefined
-        ? Effect.fail(PriorReviewLookupFailure.make({ reason: "no fixture comparison" }))
-        : Effect.succeed(options.comparison),
-  });
-
-/** Layer form for consumers whose Effect explicitly requires `PriorReviews`. */
-export const staticPriorReviewsLayer = (
-  fingerprint: Option.Option<string>,
-  options: {
-    readonly state?: Option.Option<ReviewState> | undefined;
-    readonly comparison?: ReviewHeadComparison | undefined;
-  } = {},
-): Layer.Layer<PriorReviews> =>
-  Layer.succeed(PriorReviews)(staticPriorReviews(fingerprint, options));