@effect-agent/pr-review 0.1.0-beta.30 → 0.1.0-beta.32

package/dist/index.mjs

@@ -79,7 +79,8 @@ const reviewPolicy = AgentPolicy.make({
 	tokenBudget: 56e3,
 	completionReserveTokens: 8e3,
 	contextTokenLimit: 48e3,
-	onExhaustion: "fail"
+	onExhaustion: "fail",
+	runStatus: "off"
 });
 const makeDefinition = (guidance) => Agent.define("pr-review", {
 	input: ReviewRequest,
@@ -131,17 +132,18 @@ const sanitizeReviewReport = (request, report) => {
 		const patch = patches.get(finding.path);
 		if (patch === void 0) continue;
 		const line = finding.line !== void 0 && isCommentableLine(patch, finding.line) ? finding.line : void 0;
-		const key = `${finding.path}\u0000${String(line ?? "")}\u0000${finding.title.trim().toLowerCase()}`;
-		if (seen.has(key)) continue;
-		seen.add(key);
-		findings.push(ReviewFinding.make({
+		const sanitized = ReviewFinding.make({
 			path: finding.path,
 			...line === void 0 ? {} : { line },
 			severity: finding.severity,
 			category: finding.category,
 			title: finding.title,
 			body: finding.body
-		}));
+		});
+		const key = JSON.stringify(sanitized);
+		if (seen.has(key)) continue;
+		seen.add(key);
+		findings.push(sanitized);
 	}
 	return ReviewReport.make({
 		summary: report.summary,

package/dist/index.mjs.map

@@ -1 +1 @@
-{"version":3,"file":"index.mjs","names":[],"sources":["../src/review.ts"],"sourcesContent":["import { Effect, Schema } from \"effect\";\nimport {\n  Agent,\n  AgentPolicy,\n  AgentRuntime,\n  IdGenerator,\n  makeUsageBudget,\n  type RunCostEstimator,\n  toRunBudgetHook,\n  UsageBudgetLimits,\n} from \"effect-agent\";\nimport { type LanguageModel, type Model, Toolkit } from \"effect/unstable/ai\";\n\nexport type { RunCostEstimator };\n\nconst ReviewPath = Schema.NonEmptyString.check(Schema.isMaxLength(512));\nconst Revision = Schema.NonEmptyString.check(Schema.isMaxLength(128));\n\n/** One complete textual patch supplied by the host. */\nexport class ReviewChange extends Schema.Class<ReviewChange>(\n  \"@effect-agent/pr-review/ReviewChange\",\n)({\n  path: ReviewPath,\n  patch: Schema.NonEmptyString.check(Schema.isMaxLength(80_000)),\n}) {}\n\n/** The provider-neutral input to one review pass. */\nexport class ReviewRequest extends Schema.Class<ReviewRequest>(\n  \"@effect-agent/pr-review/ReviewRequest\",\n)({\n  title: Schema.String.check(Schema.isMaxLength(1_000)),\n  description: Schema.String.check(Schema.isMaxLength(20_000)),\n  baseRevision: Revision,\n  headRevision: Revision,\n  changes: Schema.Array(ReviewChange).check(Schema.isMaxLength(100)),\n  unreviewedPaths: Schema.Array(ReviewPath).check(Schema.isMaxLength(300)),\n}) {}\n\nexport const ReviewSeverity = Schema.Literals([\"blocking\", \"important\", \"nit\"]);\nexport type ReviewSeverity = typeof ReviewSeverity.Type;\n\n/** A model-claimed problem kind used only to label findings for readers. */\nexport const ReviewCategory = Schema.Literals([\n  \"correctness\",\n  \"security\",\n  \"concurrency\",\n  \"performance\",\n  \"resources\",\n  \"reliability\",\n  \"error-handling\",\n  \"testing\",\n  \"maintainability\",\n  \"style\",\n  \"docs\",\n]);\nexport type ReviewCategory = typeof ReviewCategory.Type;\n\n/** One actionable defect. `line` is a RIGHT-side line in the supplied patch. */\nexport class ReviewFinding extends Schema.Class<ReviewFinding>(\n  \"@effect-agent/pr-review/ReviewFinding\",\n)({\n  path: ReviewPath,\n  line: Schema.optionalKey(Schema.Int.check(Schema.isGreaterThan(0))),\n  severity: ReviewSeverity,\n  /** Presentation label only; it never changes review admission or failure policy. */\n  category: ReviewCategory,\n  title: Schema.NonEmptyString.check(Schema.isMaxLength(200)),\n  body: Schema.NonEmptyString.check(Schema.isMaxLength(2_000)),\n}) {}\n\n/** The only model-authored output. An empty findings array is a successful review. */\nexport class ReviewReport extends Schema.Class<ReviewReport>(\n  \"@effect-agent/pr-review/ReviewReport\",\n)({\n  summary: Schema.NonEmptyString.check(Schema.isMaxLength(6_000)),\n  findings: Schema.Array(ReviewFinding).check(Schema.isMaxLength(12)),\n}) {}\n\nconst ReviewUsageFields = Schema.Struct({\n  inputTokens: Schema.Natural,\n  uncachedInputTokens: Schema.Natural,\n  cachedInputTokens: Schema.Natural,\n  cacheWriteInputTokens: Schema.Natural,\n  outputTokens: Schema.Natural,\n  estimatedCostMicrousd: Schema.optionalKey(Schema.Natural),\n}).check(\n  Schema.makeFilter(\n    (usage) =>\n      usage.inputTokens ===\n      usage.uncachedInputTokens + usage.cachedInputTokens + usage.cacheWriteInputTokens,\n    { title: \"Input token total equals uncached, cached, and cache-write components\" },\n  ),\n);\n\nexport class ReviewUsage extends Schema.Class<ReviewUsage>(\"@effect-agent/pr-review/ReviewUsage\")(\n  ReviewUsageFields,\n) {}\n\nexport class ReviewOutcome extends Schema.Class<ReviewOutcome>(\n  \"@effect-agent/pr-review/ReviewOutcome\",\n)({\n  report: ReviewReport,\n  turns: Schema.Natural,\n  usage: ReviewUsage,\n}) {}\n\nconst BASE_INSTRUCTIONS = `Review the supplied pull-request diff once.\n\nReport only concrete correctness, security, reliability, or maintainability defects that the author should act on. Do not praise, restate the change, invent missing repository context, or ask for speculative cleanup. An empty findings array is valid.\n\nEvery finding must use an exact supplied path. Set line only to a RIGHT-side added or context line visible in that path's unified patch; otherwise omit line. Use blocking only for a defect that should prevent shipping. Classify each finding with the closest available category. Treat unreviewedPaths as unavailable scope and never imply that you inspected it. A changed file absent from changes may have been withheld by the host; never infer that it was not changed, and report only defects proven by the supplied patches.`;\n\nexport const reviewPolicy = AgentPolicy.make({\n  maxTurns: 1,\n  maxToolCalls: 1,\n  maxDuration: \"5 minutes\",\n  toolConcurrency: 1,\n  tokenBudget: 56_000,\n  completionReserveTokens: 8_000,\n  contextTokenLimit: 48_000,\n  onExhaustion: \"fail\",\n});\n\nconst makeDefinition = (guidance?: string) =>\n  Agent.define(\"pr-review\", {\n    input: ReviewRequest,\n    output: ReviewReport,\n    instructions:\n      guidance === undefined || guidance.trim().length === 0\n        ? BASE_INSTRUCTIONS\n        : `${BASE_INSTRUCTIONS}\\n\\nRepository guidance:\\n${guidance.trim()}`,\n    toolkit: Toolkit.empty,\n    policy: reviewPolicy,\n    description: \"Review one supplied pull-request diff in a single model call.\",\n    metadata: { deploymentClass: \"E\", surface: \"read-only\" },\n  });\n\nexport const reviewBudgetLimits = UsageBudgetLimits.make({\n  maxInputTokens: 48_000,\n  maxOutputTokens: 8_000,\n  maxToolCalls: 0,\n  maxDurationMillis: 300_000,\n});\n\n/** Return every RIGHT-side line on which GitHub can place a diff comment. */\nexport const commentableLines = (patch: string): ReadonlySet<number> => {\n  const lines = new Set<number>();\n  let right: number | undefined;\n  for (const text of patch.split(\"\\n\")) {\n    const hunk = /^@@ -\\d+(?:,\\d+)? \\+(\\d+)(?:,\\d+)? @@/.exec(text);\n    if (hunk !== null) {\n      right = Number(hunk[1]);\n      continue;\n    }\n    if (right === undefined || text.startsWith(\"\\\\\")) continue;\n    if (text.startsWith(\"-\")) continue;\n    if (text.startsWith(\"+\") || text.startsWith(\" \")) {\n      lines.add(right);\n      right += 1;\n    }\n  }\n  return lines;\n};\n\nexport const isCommentableLine = (patch: string, line: number): boolean =>\n  commentableLines(patch).has(line);\n\n/**\n * Treat model output as untrusted: remove unknown paths, demote invalid line\n * anchors to top-level findings, and collapse exact duplicates.\n */\nexport const sanitizeReviewReport = (\n  request: Pick<ReviewRequest, \"changes\">,\n  report: ReviewReport,\n): ReviewReport => {\n  const patches = new Map(request.changes.map((change) => [change.path, change.patch] as const));\n  const seen = new Set<string>();\n  const findings: Array<ReviewFinding> = [];\n  for (const finding of report.findings) {\n    const patch = patches.get(finding.path);\n    if (patch === undefined) continue;\n    const line =\n      finding.line !== undefined && isCommentableLine(patch, finding.line)\n        ? finding.line\n        : undefined;\n    const key = `${finding.path}\\u0000${String(line ?? \"\")}\\u0000${finding.title.trim().toLowerCase()}`;\n    if (seen.has(key)) continue;\n    seen.add(key);\n    findings.push(\n      ReviewFinding.make({\n        path: finding.path,\n        ...(line === undefined ? {} : { line }),\n        severity: finding.severity,\n        category: finding.category,\n        title: finding.title,\n        body: finding.body,\n      }),\n    );\n  }\n  return ReviewReport.make({ summary: report.summary, findings });\n};\n\nexport interface ReviewerOptions<Provider, ModelProvides, ModelRequires> {\n  readonly model: Model.Model<Provider, LanguageModel.LanguageModel | ModelProvides, ModelRequires>;\n  readonly guidance?: string | undefined;\n  readonly estimateCostMicrousd?: RunCostEstimator | undefined;\n}\n\n/** Build a provider-neutral reviewer. The returned `review` performs exactly one Run. */\nexport const makeReviewer = <Provider, ModelProvides, ModelRequires>(\n  options: ReviewerOptions<Provider, ModelProvides, ModelRequires>,\n) => {\n  const definition = makeDefinition(options.guidance);\n  const binding = Agent.withModel(definition, options.model);\n  const review = (request: ReviewRequest) =>\n    Effect.gen(function* () {\n      const budget = yield* makeUsageBudget(reviewBudgetLimits);\n      const result = yield* AgentRuntime.run(binding, request, {\n        budget: toRunBudgetHook(budget),\n        ...(options.estimateCostMicrousd === undefined\n          ? {}\n          : { estimateCostMicrousd: options.estimateCostMicrousd }),\n      });\n      const usage = yield* budget.snapshot;\n      return ReviewOutcome.make({\n        report: sanitizeReviewReport(request, result.output),\n        turns: result.turns,\n        usage: ReviewUsage.make({\n          inputTokens: usage.inputTokens,\n          uncachedInputTokens: Math.max(\n            0,\n            usage.inputTokens - usage.cacheReadInputTokens - usage.cacheWriteInputTokens,\n          ),\n          cachedInputTokens: usage.cacheReadInputTokens,\n          cacheWriteInputTokens: usage.cacheWriteInputTokens,\n          outputTokens: usage.outputTokens,\n          ...(options.estimateCostMicrousd === undefined\n            ? {}\n            : { estimatedCostMicrousd: usage.costMicrousd }),\n        }),\n      });\n    }).pipe(Effect.provide(IdGenerator.layer), Effect.scoped);\n  return { definition, binding, review } as const;\n};\n"],"mappings":";;;;AAeA,MAAM,aAAa,OAAO,eAAe,MAAM,OAAO,YAAY,GAAG,CAAC;AACtE,MAAM,WAAW,OAAO,eAAe,MAAM,OAAO,YAAY,GAAG,CAAC;;AAGpE,IAAa,eAAb,cAAkC,OAAO,MACvC,sCACF,CAAC,CAAC;CACA,MAAM;CACN,OAAO,OAAO,eAAe,MAAM,OAAO,YAAY,GAAM,CAAC;AAC/D,CAAC,CAAC,CAAC,CAAC;;AAGJ,IAAa,gBAAb,cAAmC,OAAO,MACxC,uCACF,CAAC,CAAC;CACA,OAAO,OAAO,OAAO,MAAM,OAAO,YAAY,GAAK,CAAC;CACpD,aAAa,OAAO,OAAO,MAAM,OAAO,YAAY,GAAM,CAAC;CAC3D,cAAc;CACd,cAAc;CACd,SAAS,OAAO,MAAM,YAAY,CAAC,CAAC,MAAM,OAAO,YAAY,GAAG,CAAC;CACjE,iBAAiB,OAAO,MAAM,UAAU,CAAC,CAAC,MAAM,OAAO,YAAY,GAAG,CAAC;AACzE,CAAC,CAAC,CAAC,CAAC;AAEJ,MAAa,iBAAiB,OAAO,SAAS;CAAC;CAAY;CAAa;AAAK,CAAC;;AAI9E,MAAa,iBAAiB,OAAO,SAAS;CAC5C;CACA;CACA;CACA;CACA;CACA;CACA;CACA;CACA;CACA;CACA;AACF,CAAC;;AAID,IAAa,gBAAb,cAAmC,OAAO,MACxC,uCACF,CAAC,CAAC;CACA,MAAM;CACN,MAAM,OAAO,YAAY,OAAO,IAAI,MAAM,OAAO,cAAc,CAAC,CAAC,CAAC;CAClE,UAAU;;CAEV,UAAU;CACV,OAAO,OAAO,eAAe,MAAM,OAAO,YAAY,GAAG,CAAC;CAC1D,MAAM,OAAO,eAAe,MAAM,OAAO,YAAY,GAAK,CAAC;AAC7D,CAAC,CAAC,CAAC,CAAC;;AAGJ,IAAa,eAAb,cAAkC,OAAO,MACvC,sCACF,CAAC,CAAC;CACA,SAAS,OAAO,eAAe,MAAM,OAAO,YAAY,GAAK,CAAC;CAC9D,UAAU,OAAO,MAAM,aAAa,CAAC,CAAC,MAAM,OAAO,YAAY,EAAE,CAAC;AACpE,CAAC,CAAC,CAAC,CAAC;AAEJ,MAAM,oBAAoB,OAAO,OAAO;CACtC,aAAa,OAAO;CACpB,qBAAqB,OAAO;CAC5B,mBAAmB,OAAO;CAC1B,uBAAuB,OAAO;CAC9B,cAAc,OAAO;CACrB,uBAAuB,OAAO,YAAY,OAAO,OAAO;AAC1D,CAAC,CAAC,CAAC,MACD,OAAO,YACJ,UACC,MAAM,gBACN,MAAM,sBAAsB,MAAM,oBAAoB,MAAM,uBAC9D,EAAE,OAAO,wEAAwE,CACnF,CACF;AAEA,IAAa,cAAb,cAAiC,OAAO,MAAmB,qCAAqC,CAAC,CAC/F,iBACF,CAAC,CAAC,CAAC;AAEH,IAAa,gBAAb,cAAmC,OAAO,MACxC,uCACF,CAAC,CAAC;CACA,QAAQ;CACR,OAAO,OAAO;CACd,OAAO;AACT,CAAC,CAAC,CAAC,CAAC;AAEJ,MAAM,oBAAoB;;;;;AAM1B,MAAa,eAAe,YAAY,KAAK;CAC3C,UAAU;CACV,cAAc;CACd,aAAa;CACb,iBAAiB;CACjB,aAAa;CACb,yBAAyB;CACzB,mBAAmB;CACnB,cAAc;AAChB,CAAC;AAED,MAAM,kBAAkB,aACtB,MAAM,OAAO,aAAa;CACxB,OAAO;CACP,QAAQ;CACR,cACE,aAAa,KAAA,KAAa,SAAS,KAAK,CAAC,CAAC,WAAW,IACjD,oBACA,GAAG,kBAAkB,4BAA4B,SAAS,KAAK;CACrE,SAAS,QAAQ;CACjB,QAAQ;CACR,aAAa;CACb,UAAU;EAAE,iBAAiB;EAAK,SAAS;CAAY;AACzD,CAAC;AAEH,MAAa,qBAAqB,kBAAkB,KAAK;CACvD,gBAAgB;CAChB,iBAAiB;CACjB,cAAc;CACd,mBAAmB;AACrB,CAAC;;AAGD,MAAa,oBAAoB,UAAuC;CACtE,MAAM,wBAAQ,IAAI,IAAY;CAC9B,IAAI;CACJ,KAAK,MAAM,QAAQ,MAAM,MAAM,IAAI,GAAG;EACpC,MAAM,OAAO,wCAAwC,KAAK,IAAI;EAC9D,IAAI,SAAS,MAAM;GACjB,QAAQ,OAAO,KAAK,EAAE;GACtB;EACF;EACA,IAAI,UAAU,KAAA,KAAa,KAAK,WAAW,IAAI,GAAG;EAClD,IAAI,KAAK,WAAW,GAAG,GAAG;EAC1B,IAAI,KAAK,WAAW,GAAG,KAAK,KAAK,WAAW,GAAG,GAAG;GAChD,MAAM,IAAI,KAAK;GACf,SAAS;EACX;CACF;CACA,OAAO;AACT;AAEA,MAAa,qBAAqB,OAAe,SAC/C,iBAAiB,KAAK,CAAC,CAAC,IAAI,IAAI;;;;;AAMlC,MAAa,wBACX,SACA,WACiB;CACjB,MAAM,UAAU,IAAI,IAAI,QAAQ,QAAQ,KAAK,WAAW,CAAC,OAAO,MAAM,OAAO,KAAK,CAAU,CAAC;CAC7F,MAAM,uBAAO,IAAI,IAAY;CAC7B,MAAM,WAAiC,CAAC;CACxC,KAAK,MAAM,WAAW,OAAO,UAAU;EACrC,MAAM,QAAQ,QAAQ,IAAI,QAAQ,IAAI;EACtC,IAAI,UAAU,KAAA,GAAW;EACzB,MAAM,OACJ,QAAQ,SAAS,KAAA,KAAa,kBAAkB,OAAO,QAAQ,IAAI,IAC/D,QAAQ,OACR,KAAA;EACN,MAAM,MAAM,GAAG,QAAQ,KAAK,QAAQ,OAAO,QAAQ,EAAE,EAAE,QAAQ,QAAQ,MAAM,KAAK,CAAC,CAAC,YAAY;EAChG,IAAI,KAAK,IAAI,GAAG,GAAG;EACnB,KAAK,IAAI,GAAG;EACZ,SAAS,KACP,cAAc,KAAK;GACjB,MAAM,QAAQ;GACd,GAAI,SAAS,KAAA,IAAY,CAAC,IAAI,EAAE,KAAK;GACrC,UAAU,QAAQ;GAClB,UAAU,QAAQ;GAClB,OAAO,QAAQ;GACf,MAAM,QAAQ;EAChB,CAAC,CACH;CACF;CACA,OAAO,aAAa,KAAK;EAAE,SAAS,OAAO;EAAS;CAAS,CAAC;AAChE;;AASA,MAAa,gBACX,YACG;CACH,MAAM,aAAa,eAAe,QAAQ,QAAQ;CAClD,MAAM,UAAU,MAAM,UAAU,YAAY,QAAQ,KAAK;CACzD,MAAM,UAAU,YACd,OAAO,IAAI,aAAa;EACtB,MAAM,SAAS,OAAO,gBAAgB,kBAAkB;EACxD,MAAM,SAAS,OAAO,aAAa,IAAI,SAAS,SAAS;GACvD,QAAQ,gBAAgB,MAAM;GAC9B,GAAI,QAAQ,yBAAyB,KAAA,IACjC,CAAC,IACD,EAAE,sBAAsB,QAAQ,qBAAqB;EAC3D,CAAC;EACD,MAAM,QAAQ,OAAO,OAAO;EAC5B,OAAO,cAAc,KAAK;GACxB,QAAQ,qBAAqB,SAAS,OAAO,MAAM;GACnD,OAAO,OAAO;GACd,OAAO,YAAY,KAAK;IACtB,aAAa,MAAM;IACnB,qBAAqB,KAAK,IACxB,GACA,MAAM,cAAc,MAAM,uBAAuB,MAAM,qBACzD;IACA,mBAAmB,MAAM;IACzB,uBAAuB,MAAM;IAC7B,cAAc,MAAM;IACpB,GAAI,QAAQ,yBAAyB,KAAA,IACjC,CAAC,IACD,EAAE,uBAAuB,MAAM,aAAa;GAClD,CAAC;EACH,CAAC;CACH,CAAC,CAAC,CAAC,KAAK,OAAO,QAAQ,YAAY,KAAK,GAAG,OAAO,MAAM;CAC1D,OAAO;EAAE;EAAY;EAAS;CAAO;AACvC"}
+{"version":3,"file":"index.mjs","names":[],"sources":["../src/review.ts"],"sourcesContent":["import { Effect, Schema } from \"effect\";\nimport {\n  Agent,\n  AgentPolicy,\n  AgentRuntime,\n  IdGenerator,\n  makeUsageBudget,\n  type RunCostEstimator,\n  toRunBudgetHook,\n  UsageBudgetLimits,\n} from \"effect-agent\";\nimport { type LanguageModel, type Model, Toolkit } from \"effect/unstable/ai\";\n\nexport type { RunCostEstimator };\n\nconst ReviewPath = Schema.NonEmptyString.check(Schema.isMaxLength(512));\nconst Revision = Schema.NonEmptyString.check(Schema.isMaxLength(128));\n\n/** One complete textual patch supplied by the host. */\nexport class ReviewChange extends Schema.Class<ReviewChange>(\n  \"@effect-agent/pr-review/ReviewChange\",\n)({\n  path: ReviewPath,\n  patch: Schema.NonEmptyString.check(Schema.isMaxLength(80_000)),\n}) {}\n\n/** The provider-neutral input to one review pass. */\nexport class ReviewRequest extends Schema.Class<ReviewRequest>(\n  \"@effect-agent/pr-review/ReviewRequest\",\n)({\n  title: Schema.String.check(Schema.isMaxLength(1_000)),\n  description: Schema.String.check(Schema.isMaxLength(20_000)),\n  baseRevision: Revision,\n  headRevision: Revision,\n  changes: Schema.Array(ReviewChange).check(Schema.isMaxLength(100)),\n  unreviewedPaths: Schema.Array(ReviewPath).check(Schema.isMaxLength(300)),\n}) {}\n\nexport const ReviewSeverity = Schema.Literals([\"blocking\", \"important\", \"nit\"]);\nexport type ReviewSeverity = typeof ReviewSeverity.Type;\n\n/** A model-claimed problem kind used only to label findings for readers. */\nexport const ReviewCategory = Schema.Literals([\n  \"correctness\",\n  \"security\",\n  \"concurrency\",\n  \"performance\",\n  \"resources\",\n  \"reliability\",\n  \"error-handling\",\n  \"testing\",\n  \"maintainability\",\n  \"style\",\n  \"docs\",\n]);\nexport type ReviewCategory = typeof ReviewCategory.Type;\n\n/** One actionable defect. `line` is a RIGHT-side line in the supplied patch. */\nexport class ReviewFinding extends Schema.Class<ReviewFinding>(\n  \"@effect-agent/pr-review/ReviewFinding\",\n)({\n  path: ReviewPath,\n  line: Schema.optionalKey(Schema.Int.check(Schema.isGreaterThan(0))),\n  severity: ReviewSeverity,\n  /** Presentation label only; it never changes review admission or failure policy. */\n  category: ReviewCategory,\n  title: Schema.NonEmptyString.check(Schema.isMaxLength(200)),\n  body: Schema.NonEmptyString.check(Schema.isMaxLength(2_000)),\n}) {}\n\n/** The only model-authored output. An empty findings array is a successful review. */\nexport class ReviewReport extends Schema.Class<ReviewReport>(\n  \"@effect-agent/pr-review/ReviewReport\",\n)({\n  summary: Schema.NonEmptyString.check(Schema.isMaxLength(6_000)),\n  findings: Schema.Array(ReviewFinding).check(Schema.isMaxLength(12)),\n}) {}\n\nconst ReviewUsageFields = Schema.Struct({\n  inputTokens: Schema.Natural,\n  uncachedInputTokens: Schema.Natural,\n  cachedInputTokens: Schema.Natural,\n  cacheWriteInputTokens: Schema.Natural,\n  outputTokens: Schema.Natural,\n  estimatedCostMicrousd: Schema.optionalKey(Schema.Natural),\n}).check(\n  Schema.makeFilter(\n    (usage) =>\n      usage.inputTokens ===\n      usage.uncachedInputTokens + usage.cachedInputTokens + usage.cacheWriteInputTokens,\n    { title: \"Input token total equals uncached, cached, and cache-write components\" },\n  ),\n);\n\nexport class ReviewUsage extends Schema.Class<ReviewUsage>(\"@effect-agent/pr-review/ReviewUsage\")(\n  ReviewUsageFields,\n) {}\n\nexport class ReviewOutcome extends Schema.Class<ReviewOutcome>(\n  \"@effect-agent/pr-review/ReviewOutcome\",\n)({\n  report: ReviewReport,\n  turns: Schema.Natural,\n  usage: ReviewUsage,\n}) {}\n\nconst BASE_INSTRUCTIONS = `Review the supplied pull-request diff once.\n\nReport only concrete correctness, security, reliability, or maintainability defects that the author should act on. Do not praise, restate the change, invent missing repository context, or ask for speculative cleanup. An empty findings array is valid.\n\nEvery finding must use an exact supplied path. Set line only to a RIGHT-side added or context line visible in that path's unified patch; otherwise omit line. Use blocking only for a defect that should prevent shipping. Classify each finding with the closest available category. Treat unreviewedPaths as unavailable scope and never imply that you inspected it. A changed file absent from changes may have been withheld by the host; never infer that it was not changed, and report only defects proven by the supplied patches.`;\n\nexport const reviewPolicy = AgentPolicy.make({\n  maxTurns: 1,\n  maxToolCalls: 1,\n  maxDuration: \"5 minutes\",\n  toolConcurrency: 1,\n  tokenBudget: 56_000,\n  completionReserveTokens: 8_000,\n  contextTokenLimit: 48_000,\n  onExhaustion: \"fail\",\n  runStatus: \"off\",\n});\n\nconst makeDefinition = (guidance?: string) =>\n  Agent.define(\"pr-review\", {\n    input: ReviewRequest,\n    output: ReviewReport,\n    instructions:\n      guidance === undefined || guidance.trim().length === 0\n        ? BASE_INSTRUCTIONS\n        : `${BASE_INSTRUCTIONS}\\n\\nRepository guidance:\\n${guidance.trim()}`,\n    toolkit: Toolkit.empty,\n    policy: reviewPolicy,\n    description: \"Review one supplied pull-request diff in a single model call.\",\n    metadata: { deploymentClass: \"E\", surface: \"read-only\" },\n  });\n\nexport const reviewBudgetLimits = UsageBudgetLimits.make({\n  maxInputTokens: 48_000,\n  maxOutputTokens: 8_000,\n  maxToolCalls: 0,\n  maxDurationMillis: 300_000,\n});\n\n/** Return every RIGHT-side line on which GitHub can place a diff comment. */\nexport const commentableLines = (patch: string): ReadonlySet<number> => {\n  const lines = new Set<number>();\n  let right: number | undefined;\n  for (const text of patch.split(\"\\n\")) {\n    const hunk = /^@@ -\\d+(?:,\\d+)? \\+(\\d+)(?:,\\d+)? @@/.exec(text);\n    if (hunk !== null) {\n      right = Number(hunk[1]);\n      continue;\n    }\n    if (right === undefined || text.startsWith(\"\\\\\")) continue;\n    if (text.startsWith(\"-\")) continue;\n    if (text.startsWith(\"+\") || text.startsWith(\" \")) {\n      lines.add(right);\n      right += 1;\n    }\n  }\n  return lines;\n};\n\nexport const isCommentableLine = (patch: string, line: number): boolean =>\n  commentableLines(patch).has(line);\n\n/**\n * Treat model output as untrusted: remove unknown paths, demote invalid line\n * anchors to top-level findings, and collapse exact duplicates.\n */\nexport const sanitizeReviewReport = (\n  request: Pick<ReviewRequest, \"changes\">,\n  report: ReviewReport,\n): ReviewReport => {\n  const patches = new Map(request.changes.map((change) => [change.path, change.patch] as const));\n  const seen = new Set<string>();\n  const findings: Array<ReviewFinding> = [];\n  for (const finding of report.findings) {\n    const patch = patches.get(finding.path);\n    if (patch === undefined) continue;\n    const line =\n      finding.line !== undefined && isCommentableLine(patch, finding.line)\n        ? finding.line\n        : undefined;\n    const sanitized = ReviewFinding.make({\n      path: finding.path,\n      ...(line === undefined ? {} : { line }),\n      severity: finding.severity,\n      category: finding.category,\n      title: finding.title,\n      body: finding.body,\n    });\n    const key = JSON.stringify(sanitized);\n    if (seen.has(key)) continue;\n    seen.add(key);\n    findings.push(sanitized);\n  }\n  return ReviewReport.make({ summary: report.summary, findings });\n};\n\nexport interface ReviewerOptions<Provider, ModelProvides, ModelRequires> {\n  readonly model: Model.Model<Provider, LanguageModel.LanguageModel | ModelProvides, ModelRequires>;\n  readonly guidance?: string | undefined;\n  readonly estimateCostMicrousd?: RunCostEstimator | undefined;\n}\n\n/** Build a provider-neutral reviewer. The returned `review` performs exactly one Run. */\nexport const makeReviewer = <Provider, ModelProvides, ModelRequires>(\n  options: ReviewerOptions<Provider, ModelProvides, ModelRequires>,\n) => {\n  const definition = makeDefinition(options.guidance);\n  const binding = Agent.withModel(definition, options.model);\n  const review = (request: ReviewRequest) =>\n    Effect.gen(function* () {\n      const budget = yield* makeUsageBudget(reviewBudgetLimits);\n      const result = yield* AgentRuntime.run(binding, request, {\n        budget: toRunBudgetHook(budget),\n        ...(options.estimateCostMicrousd === undefined\n          ? {}\n          : { estimateCostMicrousd: options.estimateCostMicrousd }),\n      });\n      const usage = yield* budget.snapshot;\n      return ReviewOutcome.make({\n        report: sanitizeReviewReport(request, result.output),\n        turns: result.turns,\n        usage: ReviewUsage.make({\n          inputTokens: usage.inputTokens,\n          uncachedInputTokens: Math.max(\n            0,\n            usage.inputTokens - usage.cacheReadInputTokens - usage.cacheWriteInputTokens,\n          ),\n          cachedInputTokens: usage.cacheReadInputTokens,\n          cacheWriteInputTokens: usage.cacheWriteInputTokens,\n          outputTokens: usage.outputTokens,\n          ...(options.estimateCostMicrousd === undefined\n            ? {}\n            : { estimatedCostMicrousd: usage.costMicrousd }),\n        }),\n      });\n    }).pipe(Effect.provide(IdGenerator.layer), Effect.scoped);\n  return { definition, binding, review } as const;\n};\n"],"mappings":";;;;AAeA,MAAM,aAAa,OAAO,eAAe,MAAM,OAAO,YAAY,GAAG,CAAC;AACtE,MAAM,WAAW,OAAO,eAAe,MAAM,OAAO,YAAY,GAAG,CAAC;;AAGpE,IAAa,eAAb,cAAkC,OAAO,MACvC,sCACF,CAAC,CAAC;CACA,MAAM;CACN,OAAO,OAAO,eAAe,MAAM,OAAO,YAAY,GAAM,CAAC;AAC/D,CAAC,CAAC,CAAC,CAAC;;AAGJ,IAAa,gBAAb,cAAmC,OAAO,MACxC,uCACF,CAAC,CAAC;CACA,OAAO,OAAO,OAAO,MAAM,OAAO,YAAY,GAAK,CAAC;CACpD,aAAa,OAAO,OAAO,MAAM,OAAO,YAAY,GAAM,CAAC;CAC3D,cAAc;CACd,cAAc;CACd,SAAS,OAAO,MAAM,YAAY,CAAC,CAAC,MAAM,OAAO,YAAY,GAAG,CAAC;CACjE,iBAAiB,OAAO,MAAM,UAAU,CAAC,CAAC,MAAM,OAAO,YAAY,GAAG,CAAC;AACzE,CAAC,CAAC,CAAC,CAAC;AAEJ,MAAa,iBAAiB,OAAO,SAAS;CAAC;CAAY;CAAa;AAAK,CAAC;;AAI9E,MAAa,iBAAiB,OAAO,SAAS;CAC5C;CACA;CACA;CACA;CACA;CACA;CACA;CACA;CACA;CACA;CACA;AACF,CAAC;;AAID,IAAa,gBAAb,cAAmC,OAAO,MACxC,uCACF,CAAC,CAAC;CACA,MAAM;CACN,MAAM,OAAO,YAAY,OAAO,IAAI,MAAM,OAAO,cAAc,CAAC,CAAC,CAAC;CAClE,UAAU;;CAEV,UAAU;CACV,OAAO,OAAO,eAAe,MAAM,OAAO,YAAY,GAAG,CAAC;CAC1D,MAAM,OAAO,eAAe,MAAM,OAAO,YAAY,GAAK,CAAC;AAC7D,CAAC,CAAC,CAAC,CAAC;;AAGJ,IAAa,eAAb,cAAkC,OAAO,MACvC,sCACF,CAAC,CAAC;CACA,SAAS,OAAO,eAAe,MAAM,OAAO,YAAY,GAAK,CAAC;CAC9D,UAAU,OAAO,MAAM,aAAa,CAAC,CAAC,MAAM,OAAO,YAAY,EAAE,CAAC;AACpE,CAAC,CAAC,CAAC,CAAC;AAEJ,MAAM,oBAAoB,OAAO,OAAO;CACtC,aAAa,OAAO;CACpB,qBAAqB,OAAO;CAC5B,mBAAmB,OAAO;CAC1B,uBAAuB,OAAO;CAC9B,cAAc,OAAO;CACrB,uBAAuB,OAAO,YAAY,OAAO,OAAO;AAC1D,CAAC,CAAC,CAAC,MACD,OAAO,YACJ,UACC,MAAM,gBACN,MAAM,sBAAsB,MAAM,oBAAoB,MAAM,uBAC9D,EAAE,OAAO,wEAAwE,CACnF,CACF;AAEA,IAAa,cAAb,cAAiC,OAAO,MAAmB,qCAAqC,CAAC,CAC/F,iBACF,CAAC,CAAC,CAAC;AAEH,IAAa,gBAAb,cAAmC,OAAO,MACxC,uCACF,CAAC,CAAC;CACA,QAAQ;CACR,OAAO,OAAO;CACd,OAAO;AACT,CAAC,CAAC,CAAC,CAAC;AAEJ,MAAM,oBAAoB;;;;;AAM1B,MAAa,eAAe,YAAY,KAAK;CAC3C,UAAU;CACV,cAAc;CACd,aAAa;CACb,iBAAiB;CACjB,aAAa;CACb,yBAAyB;CACzB,mBAAmB;CACnB,cAAc;CACd,WAAW;AACb,CAAC;AAED,MAAM,kBAAkB,aACtB,MAAM,OAAO,aAAa;CACxB,OAAO;CACP,QAAQ;CACR,cACE,aAAa,KAAA,KAAa,SAAS,KAAK,CAAC,CAAC,WAAW,IACjD,oBACA,GAAG,kBAAkB,4BAA4B,SAAS,KAAK;CACrE,SAAS,QAAQ;CACjB,QAAQ;CACR,aAAa;CACb,UAAU;EAAE,iBAAiB;EAAK,SAAS;CAAY;AACzD,CAAC;AAEH,MAAa,qBAAqB,kBAAkB,KAAK;CACvD,gBAAgB;CAChB,iBAAiB;CACjB,cAAc;CACd,mBAAmB;AACrB,CAAC;;AAGD,MAAa,oBAAoB,UAAuC;CACtE,MAAM,wBAAQ,IAAI,IAAY;CAC9B,IAAI;CACJ,KAAK,MAAM,QAAQ,MAAM,MAAM,IAAI,GAAG;EACpC,MAAM,OAAO,wCAAwC,KAAK,IAAI;EAC9D,IAAI,SAAS,MAAM;GACjB,QAAQ,OAAO,KAAK,EAAE;GACtB;EACF;EACA,IAAI,UAAU,KAAA,KAAa,KAAK,WAAW,IAAI,GAAG;EAClD,IAAI,KAAK,WAAW,GAAG,GAAG;EAC1B,IAAI,KAAK,WAAW,GAAG,KAAK,KAAK,WAAW,GAAG,GAAG;GAChD,MAAM,IAAI,KAAK;GACf,SAAS;EACX;CACF;CACA,OAAO;AACT;AAEA,MAAa,qBAAqB,OAAe,SAC/C,iBAAiB,KAAK,CAAC,CAAC,IAAI,IAAI;;;;;AAMlC,MAAa,wBACX,SACA,WACiB;CACjB,MAAM,UAAU,IAAI,IAAI,QAAQ,QAAQ,KAAK,WAAW,CAAC,OAAO,MAAM,OAAO,KAAK,CAAU,CAAC;CAC7F,MAAM,uBAAO,IAAI,IAAY;CAC7B,MAAM,WAAiC,CAAC;CACxC,KAAK,MAAM,WAAW,OAAO,UAAU;EACrC,MAAM,QAAQ,QAAQ,IAAI,QAAQ,IAAI;EACtC,IAAI,UAAU,KAAA,GAAW;EACzB,MAAM,OACJ,QAAQ,SAAS,KAAA,KAAa,kBAAkB,OAAO,QAAQ,IAAI,IAC/D,QAAQ,OACR,KAAA;EACN,MAAM,YAAY,cAAc,KAAK;GACnC,MAAM,QAAQ;GACd,GAAI,SAAS,KAAA,IAAY,CAAC,IAAI,EAAE,KAAK;GACrC,UAAU,QAAQ;GAClB,UAAU,QAAQ;GAClB,OAAO,QAAQ;GACf,MAAM,QAAQ;EAChB,CAAC;EACD,MAAM,MAAM,KAAK,UAAU,SAAS;EACpC,IAAI,KAAK,IAAI,GAAG,GAAG;EACnB,KAAK,IAAI,GAAG;EACZ,SAAS,KAAK,SAAS;CACzB;CACA,OAAO,aAAa,KAAK;EAAE,SAAS,OAAO;EAAS;CAAS,CAAC;AAChE;;AASA,MAAa,gBACX,YACG;CACH,MAAM,aAAa,eAAe,QAAQ,QAAQ;CAClD,MAAM,UAAU,MAAM,UAAU,YAAY,QAAQ,KAAK;CACzD,MAAM,UAAU,YACd,OAAO,IAAI,aAAa;EACtB,MAAM,SAAS,OAAO,gBAAgB,kBAAkB;EACxD,MAAM,SAAS,OAAO,aAAa,IAAI,SAAS,SAAS;GACvD,QAAQ,gBAAgB,MAAM;GAC9B,GAAI,QAAQ,yBAAyB,KAAA,IACjC,CAAC,IACD,EAAE,sBAAsB,QAAQ,qBAAqB;EAC3D,CAAC;EACD,MAAM,QAAQ,OAAO,OAAO;EAC5B,OAAO,cAAc,KAAK;GACxB,QAAQ,qBAAqB,SAAS,OAAO,MAAM;GACnD,OAAO,OAAO;GACd,OAAO,YAAY,KAAK;IACtB,aAAa,MAAM;IACnB,qBAAqB,KAAK,IACxB,GACA,MAAM,cAAc,MAAM,uBAAuB,MAAM,qBACzD;IACA,mBAAmB,MAAM;IACzB,uBAAuB,MAAM;IAC7B,cAAc,MAAM;IACpB,GAAI,QAAQ,yBAAyB,KAAA,IACjC,CAAC,IACD,EAAE,uBAAuB,MAAM,aAAa;GAClD,CAAC;EACH,CAAC;CACH,CAAC,CAAC,CAAC,KAAK,OAAO,QAAQ,YAAY,KAAK,GAAG,OAAO,MAAM;CAC1D,OAAO;EAAE;EAAY;EAAS;CAAO;AACvC"}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@effect-agent/pr-review",
-  "version": "0.1.0-beta.30",
+  "version": "0.1.0-beta.32",
   "exports": {
     ".": {
       "types": "./dist/index.d.mts",
@@ -9,7 +9,7 @@
   },
   "dependencies": {
     "effect": "4.0.0-rc.110",
-    "effect-agent": "0.1.0-beta.30"
+    "effect-agent": "0.1.0-beta.32"
   },
   "description": "A provider-neutral, single-pass pull-request review agent.",
   "license": "MIT",

package/src/review.ts

@@ -119,6 +119,7 @@ export const reviewPolicy = AgentPolicy.make({
   completionReserveTokens: 8_000,
   contextTokenLimit: 48_000,
   onExhaustion: "fail",
+  runStatus: "off",
 });
 
 const makeDefinition = (guidance?: string) =>
@@ -183,19 +184,18 @@ export const sanitizeReviewReport = (
       finding.line !== undefined && isCommentableLine(patch, finding.line)
         ? finding.line
         : undefined;
-    const key = `${finding.path}\u0000${String(line ?? "")}\u0000${finding.title.trim().toLowerCase()}`;
+    const sanitized = ReviewFinding.make({
+      path: finding.path,
+      ...(line === undefined ? {} : { line }),
+      severity: finding.severity,
+      category: finding.category,
+      title: finding.title,
+      body: finding.body,
+    });
+    const key = JSON.stringify(sanitized);
     if (seen.has(key)) continue;
     seen.add(key);
-    findings.push(
-      ReviewFinding.make({
-        path: finding.path,
-        ...(line === undefined ? {} : { line }),
-        severity: finding.severity,
-        category: finding.category,
-        title: finding.title,
-        body: finding.body,
-      }),
-    );
+    findings.push(sanitized);
   }
   return ReviewReport.make({ summary: report.summary, findings });
 };