@effect-agent/pr-review 0.1.0-beta.27 → 0.1.0-beta.29

package/src/internal/scripted.ts

@@ -1,108 +0,0 @@
-import { Effect, Layer, Ref, Schema, Stream } from "effect";
-import { LanguageModel, Model, type Response } from "effect/unstable/ai";
-
-import { CodeReview } from "./review-agent.ts";
-
-// ---------------------------------------------------------------------------
-// Deterministic offline model for the flat reviewer: a prompt-aware scripted
-// model that walks the real tool surface — list, diff, read — then returns
-// the scripted review as its terminal JSON. Decisions key on committed
-// history in the prompt, never on call order, so replays stay honest.
-// ---------------------------------------------------------------------------
-
-export const OFFLINE_LIST_CALL_ID = "list-1";
-export const OFFLINE_DIFF_CALL_ID = "diff-1";
-export const OFFLINE_READ_CALL_ID = "read-1";
-
-/** Usage attached to EVERY scripted model turn; tests pin exact aggregates. */
-export const SCRIPTED_TURN_USAGE = { inputTokens: 64, outputTokens: 48 } as const;
-
-const scriptedUsage = {
-  inputTokens: { total: SCRIPTED_TURN_USAGE.inputTokens },
-  outputTokens: { total: SCRIPTED_TURN_USAGE.outputTokens },
-};
-
-export const scriptedToolTurn = (
-  ...calls: ReadonlyArray<Response.StreamPartEncoded>
-): ReadonlyArray<Response.StreamPartEncoded> => [
-  ...calls,
-  { type: "finish", reason: "tool-calls", usage: scriptedUsage },
-];
-
-export const scriptedFinalParts = (text: string): ReadonlyArray<Response.StreamPartEncoded> => [
-  { type: "text-start", id: "code-review" },
-  { type: "text-delta", id: "code-review", delta: text },
-  { type: "text-end", id: "code-review" },
-  { type: "finish", reason: "stop", usage: scriptedUsage },
-];
-
-/** A prompt-keyed scripted LanguageModel with call and prompt observability. */
-export const makePromptKeyedModel = (
-  name: string,
-  decide: (promptJson: string) => ReadonlyArray<Response.StreamPartEncoded>,
-) =>
-  Effect.gen(function* () {
-    const calls = yield* Ref.make(0);
-    const prompts = yield* Ref.make<ReadonlyArray<string>>([]);
-    const model = Model.make(
-      "scripted",
-      name,
-      Layer.effect(
-        LanguageModel.LanguageModel,
-        LanguageModel.make({
-          generateText: () => Effect.succeed([]),
-          streamText: (request) =>
-            Stream.unwrap(
-              Effect.gen(function* () {
-                yield* Ref.update(calls, (value) => value + 1);
-                const promptJson = JSON.stringify(request.prompt);
-                yield* Ref.update(prompts, (previous) => [...previous, promptJson]);
-                return Stream.fromIterable(decide(promptJson));
-              }),
-            ),
-        }),
-      ),
-    );
-    return { model, calls: Ref.get(calls), prompts: Ref.get(prompts) };
-  });
-
-/**
- * Build the offline scripted reviewer model. Turn 1 lists the changeset,
- * Turn 2 reads one file diff, Turn 3 reads head context, Turn 4 returns the
- * scripted review JSON.
- */
-export const makeOfflineReviewerModel = (script: {
-  readonly diffPath: string;
-  readonly readPath: string;
-  readonly review: CodeReview;
-}) =>
-  makePromptKeyedModel("pr-review-offline", (promptJson) => {
-    if (promptJson.includes(OFFLINE_READ_CALL_ID)) {
-      return scriptedFinalParts(JSON.stringify(Schema.encodeSync(CodeReview)(script.review)));
-    }
-    if (promptJson.includes(OFFLINE_DIFF_CALL_ID)) {
-      return scriptedToolTurn({
-        type: "tool-call",
-        id: OFFLINE_READ_CALL_ID,
-        name: "read_file",
-        params: { path: script.readPath },
-        providerExecuted: false,
-      });
-    }
-    if (promptJson.includes(OFFLINE_LIST_CALL_ID)) {
-      return scriptedToolTurn({
-        type: "tool-call",
-        id: OFFLINE_DIFF_CALL_ID,
-        name: "read_file_diff",
-        params: { path: script.diffPath },
-        providerExecuted: false,
-      });
-    }
-    return scriptedToolTurn({
-      type: "tool-call",
-      id: OFFLINE_LIST_CALL_ID,
-      name: "list_changed_files",
-      params: { scope: "all" },
-      providerExecuted: false,
-    });
-  });

package/src/internal/source.ts

@@ -1,110 +0,0 @@
-import { Context, Effect, Schema } from "effect";
-
-import type { ChangedFile } from "./diff.ts";
-
-// ---------------------------------------------------------------------------
-// The pull-request source port: everything the review tools may observe about
-// one pull request. The live adapter speaks the GitHub REST API; the fixture
-// adapter (testing entry) serves an in-memory pull request so ordinary gates
-// and dry runs need no network or credential.
-// ---------------------------------------------------------------------------
-
-/** Reading a file head version larger than this is refused, never truncated silently. */
-export const MAX_FILE_CHARS = 200_000;
-
-/** The changeset surface is bounded; larger pull requests fail typed. */
-export const MAX_CHANGED_FILES = 300;
-
-/** Pull-request identity and framing shown to the agent as its mission. */
-export class PullRequestMetadata extends Schema.Class<PullRequestMetadata>(
-  "@effect-agent/pr-review/PullRequestMetadata",
-)({
-  /** `owner/name`, exactly as GitHub renders it. */
-  repository: Schema.NonEmptyString.check(Schema.isMaxLength(200)),
-  number: Schema.Int.check(Schema.isGreaterThan(0)),
-  title: Schema.String.check(Schema.isMaxLength(400)),
-  /** Author-provided description; empty when the author left none. */
-  body: Schema.String.check(Schema.isMaxLength(20_000)),
-  baseRef: Schema.NonEmptyString.check(Schema.isMaxLength(300)),
-  /** Exact base commit used to validate persisted incremental-review lineage. */
-  baseSha: Schema.optionalKey(Schema.NonEmptyString.check(Schema.isMaxLength(64))),
-  headRef: Schema.NonEmptyString.check(Schema.isMaxLength(300)),
-  headSha: Schema.NonEmptyString.check(Schema.isMaxLength(64)),
-  /** GitHub's own changed-file total; may exceed what `changedFiles` returns. */
-  totalChangedFiles: Schema.Int.check(Schema.isGreaterThanOrEqualTo(0)),
-}) {}
-
-/** The upstream source failed: API error, network fault, or malformed payload. */
-export class PullRequestSourceFailure extends Schema.TaggedError<PullRequestSourceFailure>()(
-  "PullRequestSourceFailure",
-  {
-    operation: Schema.String,
-    reason: Schema.String,
-  },
-) {
-  override get message() {
-    return `Pull-request source operation '${this.operation}' failed: ${this.reason}`;
-  }
-}
-
-/** A model-supplied path or range was invalid; always fail-closed (SEC-007). */
-export class ReviewInputViolation extends Schema.TaggedError<ReviewInputViolation>()(
-  "ReviewInputViolation",
-  {
-    input: Schema.String,
-    reason: Schema.String,
-  },
-) {
-  override get message() {
-    return `Rejected review input '${this.input}': ${this.reason}`;
-  }
-}
-
-const BACKSLASH = String.fromCharCode(92);
-
-/**
- * Normalize and validate one model-supplied repository-relative path.
- * Absolute paths, drive letters, backslashes, empty segments, `.` and `..`
- * segments are all violations — never silently fixed. The changeset list is
- * the real allowlist; this check is defense in depth for URL construction.
- */
-export const normalizeRepoRelativePath = (
-  path: string,
-): Effect.Effect<string, ReviewInputViolation> => {
-  const fail = (reason: string) => Effect.fail(ReviewInputViolation.make({ input: path, reason }));
-  if (path.length === 0 || path.length > 512) {
-    return fail("Path length is out of bounds.");
-  }
-  if (path.includes(BACKSLASH)) {
-    return fail("Path contains a forbidden backslash.");
-  }
-  if (path.startsWith("/") || /^[A-Za-z]:/.test(path)) {
-    return fail("Path must be repository-relative, not absolute.");
-  }
-  const segments = path.split("/");
-  for (const segment of segments) {
-    if (segment === "" || segment === "." || segment === "..") {
-      return fail("Path segments must not be empty, '.', or '..'.");
-    }
-  }
-  return Effect.succeed(segments.join("/"));
-};
-
-/** Read-only view of one pull request; the only repository access tools get. */
-export class PullRequestSource extends Context.Service<
-  PullRequestSource,
-  {
-    readonly metadata: Effect.Effect<PullRequestMetadata, PullRequestSourceFailure>;
-    /** Files exposed to the model for this run (full PR or selected delta). */
-    readonly changedFiles: Effect.Effect<ReadonlyArray<ChangedFile>, PullRequestSourceFailure>;
-    /** Full current PR diff used only for host-side anchor/state validation. */
-    readonly anchorFiles: Effect.Effect<ReadonlyArray<ChangedFile>, PullRequestSourceFailure>;
-    /**
-     * The head-version content of one CHANGED file. Paths outside the
-     * changeset are violations: the reviewer reads the change, not the tree.
-     */
-    readonly readFile: (
-      path: string,
-    ) => Effect.Effect<string, PullRequestSourceFailure | ReviewInputViolation>;
-  }
->()("@effect-agent/pr-review/PullRequestSource") {}

package/src/testing.ts

@@ -1,8 +0,0 @@
-// Deterministic test helpers: in-memory adapters for both ports and
-// prompt-keyed scripted models that walk the real tool surfaces. Everything
-// here runs with no network and no credentials, so consumers can test their
-// adaptations — guidance, ignore globs, extra tools, custom ports — on every
-// ordinary gate.
-export * from "./internal/fan-out-scripted.ts";
-export * from "./internal/fixtures.ts";
-export * from "./internal/scripted.ts";