@effect-agent/pr-review 0.1.0-beta.22 → 0.1.0-beta.24

package/src/action.ts

@@ -24,6 +24,7 @@ import {
   ReviewExecutionContext,
   ReviewHeadComparison,
   ReviewStateAuthenticator,
+  isLineageAncestor,
   type ReviewMode,
   type ReviewState,
   selectReviewRange,
@@ -51,10 +52,6 @@ import {
 // nothing.
 // ---------------------------------------------------------------------------
 
-/** Deprecated compatibility input; host-derived conclusions are unconditional. */
-export const FailOnPolicy = Schema.Literals(["never", "request-changes"]);
-export type FailOnPolicy = typeof FailOnPolicy.Type;
-
 export const ReviewCheckConclusion = Schema.Literals(["success", "blocking", "incomplete"]);
 export type ReviewCheckConclusion = typeof ReviewCheckConclusion.Type;
 
@@ -96,8 +93,6 @@ export interface ResolvedActionInputs {
   readonly maxFindings: number | undefined;
   readonly maxDurationMinutes: number | undefined;
   readonly reviewMode: ReviewMode;
-  /** Deprecated compatibility input; conclusions are always conservative. */
-  readonly failOn: FailOnPolicy;
   readonly skipUnchanged: boolean;
   readonly retireStaleReviews: boolean;
   readonly progressComment: boolean;
@@ -135,9 +130,6 @@ export const resolveActionInputs = Effect.fn("resolveActionInputs")(function* ()
   const reviewMode = yield* Config.literals(["incremental", "final"], "PR_REVIEW_MODE").pipe(
     Config.withDefault<ReviewMode>("incremental"),
   );
-  const failOn = yield* Config.literals(["never", "request-changes"], "PR_REVIEW_FAIL_ON").pipe(
-    Config.withDefault<FailOnPolicy>("never"),
-  );
   const skipUnchanged = yield* Config.boolean("PR_REVIEW_SKIP_UNCHANGED").pipe(
     Config.withDefault(true),
   );
@@ -163,7 +155,6 @@ export const resolveActionInputs = Effect.fn("resolveActionInputs")(function* ()
     maxFindings: Option.getOrUndefined(maxFindings),
     maxDurationMinutes,
     reviewMode,
-    failOn,
     skipUnchanged,
     retireStaleReviews,
     progressComment,
@@ -276,6 +267,7 @@ const outcomeOutputs = (
   ["inline-comments", String(outcome.plan.comments.length)],
   ["demoted-findings", String(outcome.plan.demoted.length)],
   ["concerns", String(outcome.review.concerns?.length ?? 0)],
+  ["unreviewed-paths", String(outcome.unreviewedPaths.length)],
   ...(outcome.usage === undefined
     ? []
     : ([
@@ -296,14 +288,15 @@ const outcomeSummary = (
   `- Input coverage: **${outcome.inputCoverage.status}** · scope: ${outcome.reviewMode ?? "full"}`,
   `- Review assurance: **${outcome.assurance.status}** · general discovery ${outcome.assurance.completedGeneralDiscoveryPasses}/${outcome.assurance.requiredGeneralDiscoveryPasses} · specialist ${outcome.assurance.completedSpecialistPasses}/${outcome.assurance.requiredSpecialistPasses} · verification ${outcome.assurance.completedVerificationPasses}/${outcome.assurance.requiredVerificationPasses}`,
   `- Inline comments: ${outcome.plan.comments.length} · demoted findings: ${outcome.plan.demoted.length} · concerns: ${outcome.review.concerns?.length ?? 0}`,
-  ...(modelLabel === undefined ? [] : [`- Model: \`${modelLabel}\``]),
-  ...(outcome.usage === undefined
+  ...(outcome.unreviewedPaths.length === 0
     ? []
     : [
-        `- Tokens: ${outcome.usage.inputTokens} in / ${outcome.usage.outputTokens} out${
-          outcome.usageScope === "coordinator" ? " (coordinator)" : ""
-        }`,
+        `- Carried forward: ${outcome.unreviewedPaths.length} unreviewed path(s) retried automatically on the next run (reviewer-side gap, not a code defect)`,
       ]),
+  ...(modelLabel === undefined ? [] : [`- Model: \`${modelLabel}\``]),
+  ...(outcome.usage === undefined
+    ? []
+    : [`- Tokens: ${outcome.usage.inputTokens} in / ${outcome.usage.outputTokens} out`]),
   ...(outcome.published === undefined
     ? ["- Dry run: nothing posted"]
     : [`- Posted: ${outcome.published.url}`]),
@@ -376,32 +369,44 @@ const blockingReasons = (input: {
     .map((concern) => `blocking concern: ${concern.title}`),
 ];
 
-/** Host-derived check conclusion; model verdict prose cannot weaken it. */
+/**
+ * Host-derived check conclusion; model verdict prose cannot weaken it.
+ *
+ * Blocking code findings outrank machinery gaps — they are the actionable
+ * signal. A machinery gap (incomplete input, unsettled passes) concludes
+ * `incomplete` with reasons that explicitly say the failure is reviewer-side
+ * uncertainty carried forward for retry, never an invitation to change code.
+ * The flat reviewer's constant `unverified` assurance is not a gap.
+ */
 export const concludeReviewOutcome = (
   outcome: ReviewRunOutcome,
 ): {
   readonly conclusion: ReviewCheckConclusion;
   readonly reasons: ReadonlyArray<string>;
 } => {
-  if (outcome.inputCoverage.status === "incomplete") {
-    return { conclusion: "incomplete", reasons: outcome.inputCoverage.reasons };
-  }
-  if (outcome.assurance.status !== "settled") {
-    return {
-      conclusion: "incomplete",
-      reasons:
-        outcome.assurance.reasons.length > 0
-          ? outcome.assurance.reasons
-          : ["configured discovery and verification work did not settle"],
-    };
+  const machinery: Array<string> = [];
+  if (outcome.inputCoverage.status === "incomplete" || outcome.assurance.status === "incomplete") {
+    machinery.push(
+      outcome.unreviewedPaths.length > 0
+        ? `review infrastructure did not settle — a reviewer-side gap, not a code defect; ${outcome.unreviewedPaths.length} path(s) are carried forward and retried automatically on the next run`
+        : "review infrastructure did not settle — a reviewer-side gap, not a code defect",
+    );
+    if (outcome.inputCoverage.status === "incomplete") {
+      machinery.push(...outcome.inputCoverage.reasons);
+    }
+    if (outcome.assurance.status === "incomplete") {
+      machinery.push(...outcome.assurance.reasons);
+    }
   }
-  const reasons = blockingReasons({
+  const blocking = blockingReasons({
     findings: outcome.activeFindings,
     concerns: outcome.activeConcerns,
   });
-  return reasons.length > 0
-    ? { conclusion: "blocking", reasons }
-    : { conclusion: "success", reasons };
+  if (blocking.length > 0) {
+    return { conclusion: "blocking", reasons: [...blocking, ...machinery] };
+  }
+  if (machinery.length > 0) return { conclusion: "incomplete", reasons: machinery };
+  return { conclusion: "success", reasons: [] };
 };
 
 const concludeReviewState = (state: ReviewState) => {
@@ -462,7 +467,6 @@ export const runReviewAction = <E, R, FingerprintE = never, FingerprintR = never
   reviewer: HarnessedReviewer<E, R, FingerprintE, FingerprintR>,
   options: {
     readonly post?: boolean | undefined;
-    readonly failOn?: FailOnPolicy | undefined;
     /** Skip model execution when the current head already has complete stored coverage. */
     readonly skipUnchanged?: boolean | undefined;
     /** Incremental by default; `final` deliberately re-reviews the full PR diff. */
@@ -533,6 +537,9 @@ export const runReviewAction = <E, R, FingerprintE = never, FingerprintR = never
           (options.reviewMode ?? "incremental") === "incremental" &&
           options.skipUnchanged !== false &&
           recovered.state !== undefined &&
+          // Only a fully settled run may be skipped over: an unsettled state
+          // carries retryable scope the next run must actually retry.
+          recovered.state.settled &&
           currentFingerprint !== undefined &&
           validateReviewState(recovered.state, metadata, profileFingerprint) === undefined &&
           recovered.state.acceptedScopeFingerprint === currentFingerprint
@@ -552,6 +559,7 @@ export const runReviewAction = <E, R, FingerprintE = never, FingerprintR = never
         }
         let comparison: ReviewHeadComparison | undefined;
         let baseComparison: ReviewHeadComparison | undefined;
+        let contentComparison: ReviewHeadComparison | undefined;
         if (
           (options.reviewMode ?? "incremental") === "incremental" &&
           recovered.state !== undefined
@@ -587,6 +595,21 @@ export const runReviewAction = <E, R, FingerprintE = never, FingerprintR = never
               });
             }
           }
+          if (
+            recovered.state.reviewedHeadSha !== metadata.headSha &&
+            (comparison === undefined ||
+              !isLineageAncestor(comparison, recovered.state, metadata.headSha))
+          ) {
+            contentComparison = yield* history
+              .compareTrees(recovered.state.reviewedHeadSha, metadata.headSha)
+              .pipe(Effect.orElseSucceed(() => undefined));
+            if (contentComparison !== undefined && reviewer.filterFiles !== undefined) {
+              contentComparison = ReviewHeadComparison.make({
+                ...contentComparison,
+                files: reviewer.filterFiles(contentComparison.files),
+              });
+            }
+          }
         }
         selection = {
           ...selectReviewRange({
@@ -597,6 +620,7 @@ export const runReviewAction = <E, R, FingerprintE = never, FingerprintR = never
             priorState: recovered.state,
             comparison,
             baseComparison,
+            contentComparison,
             lookupFailure: recovered.failure,
           }),
           stateAuthenticator,
@@ -605,7 +629,8 @@ export const runReviewAction = <E, R, FingerprintE = never, FingerprintR = never
           options.skipUnchanged !== false &&
           selection.mode === "incremental" &&
           selection.files.length === 0 &&
-          selection.priorState !== undefined
+          selection.priorState !== undefined &&
+          selection.priorState.settled
         ) {
           const reason = "no changed review scope since the last settled review head";
           return yield* skipCoveredReview({
@@ -747,7 +772,6 @@ export const reviewActionProgram = Effect.gen(function* () {
   };
   const harness = {
     post: inputs.post,
-    failOn: inputs.failOn,
     skipUnchanged: inputs.skipUnchanged,
     reviewMode: inputs.reviewMode,
     retireStaleReviews: inputs.retireStaleReviews,

package/src/internal/action-entry.ts

@@ -23,7 +23,6 @@ const INPUT_TO_ENV: ReadonlyArray<readonly [input: string, env: string]> = [
   ["INPUT_IGNORE", "PR_REVIEW_IGNORE"],
   ["INPUT_MAX-FINDINGS", "PR_REVIEW_MAX_FINDINGS"],
   ["INPUT_REVIEW-MODE", "PR_REVIEW_MODE"],
-  ["INPUT_FAIL-ON", "PR_REVIEW_FAIL_ON"],
   ["INPUT_SKIP-UNCHANGED", "PR_REVIEW_SKIP_UNCHANGED"],
   ["INPUT_RETIRE-STALE-REVIEWS", "PR_REVIEW_RETIRE_STALE_REVIEWS"],
   ["INPUT_PROGRESS-COMMENT", "PR_REVIEW_PROGRESS_COMMENT"],