@effect-agent/pr-review 0.1.0-beta.18 → 0.1.0-beta.20

package/dist/testing.mjs

@@ -1,4 +1,4 @@
-import { Cn as ChangedFile, Rt as CodeReview, Sn as normalizeRepoRelativePath, _n as MAX_FILE_CHARS, a as PriorReviews, i as PriorReviewLookupFailure, o as PublishedReview, rt as FileReviewReport, s as ReviewPublisher, vn as PullRequestMetadata, xn as ReviewInputViolation, yn as PullRequestSource } from "./github-mmanX6hk.mjs";
+import { Cn as ChangedFile, Rt as CodeReview, Sn as normalizeRepoRelativePath, _n as MAX_FILE_CHARS, a as PriorReviews, i as PriorReviewLookupFailure, o as PublishedReview, rt as FileReviewReport, s as ReviewPublisher, vn as PullRequestMetadata, xn as ReviewInputViolation, yn as PullRequestSource } from "./github-DnenG3be.mjs";
 import { DateTime, Effect, Layer, Option, Ref, Schema, Stream } from "effect";
 import { LanguageModel, Model } from "effect/unstable/ai";
 //#region src/internal/scripted.ts

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@effect-agent/pr-review",
-  "version": "0.1.0-beta.18",
+  "version": "0.1.0-beta.20",
   "exports": {
     ".": {
       "types": "./dist/index.d.mts",
@@ -20,11 +20,11 @@
     }
   },
   "dependencies": {
-    "@effect/ai-anthropic": "4.0.0-beta.107",
-    "@effect/ai-openai": "4.0.0-beta.107",
-    "@effect/platform-node": "4.0.0-beta.107",
-    "effect": "4.0.0-beta.107",
-    "effect-agent": "0.1.0-beta.18"
+    "@effect/ai-anthropic": "4.0.0-rc.110",
+    "@effect/ai-openai": "4.0.0-rc.110",
+    "@effect/platform-node": "4.0.0-rc.110",
+    "effect": "4.0.0-rc.110",
+    "effect-agent": "0.1.0-beta.20"
   },
   "description": "Bounded, fail-closed GitHub pull-request reviewer built on the effect-agent public surface: schema-first review contracts, read-only tools, GitHub adapters, a configuration factory, and CLI + GitHub Actions entrypoints.",
   "license": "MIT",
@@ -47,7 +47,7 @@
     "test": "vp test --passWithNoTests"
   },
   "devDependencies": {
-    "@effect/vitest": "4.0.0-beta.107",
+    "@effect/vitest": "4.0.0-rc.110",
     "typescript": "7.0.2",
     "vite-plus": "0.2.6"
   }

package/src/action.ts

@@ -28,6 +28,7 @@ import {
   selectReviewRange,
   selectedPullRequestSourceLayer,
   unavailableReviewStateAuthenticatorLayer,
+  validateReviewState,
   webCryptoReviewStateAuthenticatorLayer,
 } from "./internal/review-state.ts";
 import { fanOutReviewBudgetLimits, reviewBudgetLimits } from "./internal/run.ts";
@@ -391,6 +392,39 @@ const concludeReviewState = (state: ReviewState) => {
     : ({ conclusion: "success", reasons: [] } as const);
 };
 
+const skipCoveredReview = Effect.fn("skipCoveredReview")(function* (input: {
+  readonly repository: string;
+  readonly pullRequestNumber: number;
+  readonly reason: string;
+  readonly state: ReviewState;
+  readonly fingerprint?: string | undefined;
+}) {
+  const result = concludeReviewState(input.state);
+  yield* Console.log(
+    `Skipping review of ${input.repository}#${input.pullRequestNumber}: ${input.reason}.`,
+  );
+  yield* writeActionOutputs([
+    ["skipped", "true"],
+    ["skip-reason", input.reason],
+    ...(input.fingerprint === undefined ? [] : ([["fingerprint", input.fingerprint]] as const)),
+    ["conclusion", result.conclusion],
+    ["coverage", "complete"],
+    ["review-mode", "incremental"],
+  ]);
+  yield* writeStepSummary([
+    "### Pull-request review skipped",
+    `- Reason: ${input.reason}`,
+    `- Preserved check conclusion: **${result.conclusion}**`,
+  ]);
+  if (result.conclusion === "blocking") {
+    return yield* ReviewGateFailed.make({
+      conclusion: "blocking",
+      reasons: result.reasons,
+    });
+  }
+  return { _tag: "Skipped", reason: input.reason } satisfies ReviewActionResult;
+});
+
 /**
  * Harness one already-built reviewer inside the Actions environment: resolve
  * the target from the event, provide the GitHub source/publisher/prior
@@ -441,9 +475,15 @@ export const runReviewAction = <E, R, FingerprintE = never, FingerprintR = never
       let selection: ReturnType<typeof selectReviewRange> | undefined;
       if (reviewer.profileFingerprint !== undefined) {
         const source = yield* PullRequestSource;
-        const [snapshot, profileFingerprint] = yield* Effect.all([
+        const [snapshot, profileFingerprint, currentFingerprint] = yield* Effect.all([
           reviewer.snapshot ?? Effect.all({ metadata: source.metadata, files: source.anchorFiles }),
           reviewer.profileFingerprint,
+          reviewer.fingerprint === undefined
+            ? Effect.succeed(undefined)
+            : reviewer.fingerprint.pipe(
+                Effect.map((fingerprint): string | undefined => fingerprint),
+                Effect.orElseSucceed(() => undefined),
+              ),
         ]);
         const { metadata, files: fullFiles } = snapshot;
         const history = options.priorReviews ?? (yield* PriorReviews);
@@ -465,6 +505,27 @@ export const runReviewAction = <E, R, FingerprintE = never, FingerprintR = never
                   }),
                 }),
               );
+        const equivalentPatchState =
+          (options.reviewMode ?? "incremental") === "incremental" &&
+          options.skipUnchanged !== false &&
+          recovered.state !== undefined &&
+          currentFingerprint !== undefined &&
+          validateReviewState(recovered.state, metadata, profileFingerprint) === undefined &&
+          recovered.state.acceptedScopeFingerprint === currentFingerprint
+            ? recovered.state
+            : undefined;
+        if (equivalentPatchState !== undefined) {
+          return yield* skipCoveredReview({
+            repository: target.repository,
+            pullRequestNumber: target.number,
+            reason:
+              equivalentPatchState.reviewedHeadSha === metadata.headSha
+                ? "the current head already has complete stored review coverage"
+                : "the effective pull-request patch is unchanged since the last complete review",
+            state: equivalentPatchState,
+            fingerprint: currentFingerprint,
+          });
+        }
         let comparison: ReviewHeadComparison | undefined;
         let baseComparison: ReviewHeadComparison | undefined;
         if (
@@ -522,30 +583,13 @@ export const runReviewAction = <E, R, FingerprintE = never, FingerprintR = never
           selection.files.length === 0 &&
           selection.priorState !== undefined
         ) {
-          const result = concludeReviewState(selection.priorState);
           const reason = "no changed review scope since the last successfully reviewed head";
-          yield* Console.log(
-            `Skipping review of ${target.repository}#${target.number}: ${reason}.`,
-          );
-          yield* writeActionOutputs([
-            ["skipped", "true"],
-            ["skip-reason", reason],
-            ["conclusion", result.conclusion],
-            ["coverage", "complete"],
-            ["review-mode", "incremental"],
-          ]);
-          yield* writeStepSummary([
-            "### Pull-request review skipped",
-            `- Reason: ${reason}`,
-            `- Preserved check conclusion: **${result.conclusion}**`,
-          ]);
-          if (result.conclusion === "blocking") {
-            return yield* ReviewGateFailed.make({
-              conclusion: "blocking",
-              reasons: result.reasons,
-            });
-          }
-          return { _tag: "Skipped", reason } satisfies ReviewActionResult;
+          return yield* skipCoveredReview({
+            repository: target.repository,
+            pullRequestNumber: target.number,
+            reason,
+            state: selection.priorState,
+          });
         }
       } else if (options.skipUnchanged !== false && reviewer.fingerprint !== undefined) {
         // Preserve the pre-state custom harness contract explicitly. The

package/src/cli.ts

@@ -53,14 +53,17 @@ const effortFlag = Flag.string("effort").pipe(
   ),
 );
 const postFlag = Flag.boolean("post").pipe(
+  Flag.withDefault(false),
   Flag.withDescription("Post the review to GitHub; without it the plan prints to stdout."),
 );
 const applyVerdictFlag = Flag.boolean("apply-verdict").pipe(
+  Flag.withDefault(false),
   Flag.withDescription(
     "Map the model verdict onto APPROVE/REQUEST_CHANGES instead of always COMMENT.",
   ),
 );
 const fanOutFlag = Flag.boolean("fan-out").pipe(
+  Flag.withDefault(false),
   Flag.withDescription(
     "Fan the review out to bounded per-unit subagent reviewers (S1 attached delegation) instead of one flat reviewer.",
   ),
@@ -76,6 +79,7 @@ const maxFindingsFlag = Flag.integer("max-findings").pipe(
   Flag.withDescription("Findings bound (1-20); the schema cap of 20 applies regardless."),
 );
 const skipUnchangedFlag = Flag.boolean("skip-unchanged").pipe(
+  Flag.withDefault(false),
   Flag.withDescription(
     "Skip when the changeset fingerprint matches the last posted review (explicit runs review unconditionally by default).",
   ),

package/src/internal/fingerprint.ts

@@ -49,6 +49,15 @@ const FIELD = "\u0000";
 const RECORD = "\u0001";
 const SECTION = "\u0002";
 
+/**
+ * Unified-diff hunk coordinates describe where a patch applies, not what it
+ * changes. A content-equivalent rebase can shift both coordinates while
+ * leaving every context/addition/deletion line unchanged, so exclude only
+ * those coordinates from the canonical patch representation.
+ */
+const canonicalPatch = (patch: string): string =>
+  patch.replace(/^@@ -\d+(?:,\d+)? \+\d+(?:,\d+)? @@/gm, "@@ -_ +_ @@");
+
 /**
  * Canonical changeset encoding: sorted by path so provider ordering never
  * matters, with every review-relevant field of every file.
@@ -57,7 +66,7 @@ const canonicalChangeset = (files: ReadonlyArray<ChangedFile>): string =>
   files
     .map(
       (file) =>
-        `${file.path}${FIELD}${file.status}${FIELD}${String(file.additions)}${FIELD}${String(file.deletions)}${FIELD}${file.patch ?? ""}${FIELD}${file.reviewBaseContent ?? ""}${FIELD}${file.reviewHeadContent ?? ""}`,
+        `${file.path}${FIELD}${file.status}${FIELD}${String(file.additions)}${FIELD}${String(file.deletions)}${FIELD}${file.patch === undefined ? "" : canonicalPatch(file.patch)}${FIELD}${file.reviewBaseContent ?? ""}${FIELD}${file.reviewHeadContent ?? ""}`,
     )
     .sort()
     .join(RECORD);