@eeacms/volto-tabs-block 9.1.0 → 10.0.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
package/.eslintrc.js CHANGED
@@ -16,7 +16,27 @@ if (configFile) {
16
16
  voltoPath = `./${jsConfig.baseUrl}/${pathsConfig['@plone/volto'][0]}`;
17
17
  }
18
18
 
19
- const AddonConfigurationRegistry = require(`${voltoPath}/addon-registry.js`);
19
+ const registryDistPath = path.join(
20
+ projectRootPath,
21
+ 'node_modules/@plone/registry/dist/addon-registry/addon-registry.cjs',
22
+ );
23
+ const registrySrcPath = path.join(
24
+ projectRootPath,
25
+ 'node_modules/@plone/registry/src/addon-registry',
26
+ );
27
+
28
+ let AddonConfigurationRegistry;
29
+ if (fs.existsSync(registryDistPath)) {
30
+ AddonConfigurationRegistry = require(registryDistPath).AddonRegistry;
31
+ } else if (
32
+ fs.existsSync(registrySrcPath) ||
33
+ fs.existsSync(`${registrySrcPath}.js`)
34
+ ) {
35
+ AddonConfigurationRegistry = require(registrySrcPath);
36
+ } else {
37
+ AddonConfigurationRegistry = require(`${voltoPath}/addon-registry.js`);
38
+ }
39
+
20
40
  const reg = new AddonConfigurationRegistry(projectRootPath);
21
41
 
22
42
  // Extends ESlint configuration for adding the aliases to `src` directories in Volto addons
@@ -26,6 +46,11 @@ const addonAliases = Object.keys(reg.packages).map((o) => [
26
46
  ]);
27
47
 
28
48
  const addonExtenders = reg.getEslintExtenders().map((m) => require(m));
49
+ const voltoSlatePath = fs.existsSync(
50
+ path.join(projectRootPath, 'node_modules/@plone/volto-slate/src'),
51
+ )
52
+ ? '@plone/volto-slate/src'
53
+ : '@plone/volto/packages/volto-slate/src';
29
54
 
30
55
  const defaultConfig = {
31
56
  extends: `${voltoPath}/.eslintrc`,
@@ -34,7 +59,7 @@ const defaultConfig = {
34
59
  alias: {
35
60
  map: [
36
61
  ['@plone/volto', '@plone/volto/src'],
37
- ['@plone/volto-slate', '@plone/volto/packages/volto-slate/src'],
62
+ ['@plone/volto-slate', voltoSlatePath],
38
63
  ...addonAliases,
39
64
  ['@package', `${__dirname}/src`],
40
65
  ['@root', `${__dirname}/src`],
package/CHANGELOG.md CHANGED
@@ -4,6 +4,19 @@ All notable changes to this project will be documented in this file. Dates are d
4
4
 
5
5
  Generated by [`auto-changelog`](https://github.com/CookPete/auto-changelog).
6
6
 
7
+ ### [10.0.0](https://github.com/eea/volto-tabs-block/compare/9.1.0...10.0.0) - 27 March 2026
8
+
9
+ #### :rocket: New Features
10
+
11
+ - feat: Volto 18 support - refs #287700 [Alin Voinea - [`f370bb2`](https://github.com/eea/volto-tabs-block/commit/f370bb24f0a741129c21896338baf19ed4bab030)]
12
+
13
+ #### :house: Internal changes
14
+
15
+
16
+ #### :hammer_and_wrench: Others
17
+
18
+ - test: Fix make test [Alin V. (Claudiu) - [`c29c5bc`](https://github.com/eea/volto-tabs-block/commit/c29c5bcc5f0e24ce636dc12c87a8579eb93bd56d)]
19
+ - tests: Fix Sonar Qube tags - refs #297339 [Alin Voinea - [`89ca2ae`](https://github.com/eea/volto-tabs-block/commit/89ca2ae4bc3821bed8012188e94930ae4457accf)]
7
20
  ### [9.1.0](https://github.com/eea/volto-tabs-block/compare/9.0.3...9.1.0) - 24 July 2025
8
21
 
9
22
  #### :hammer_and_wrench: Others
package/DEVELOP.md CHANGED
@@ -26,21 +26,20 @@
26
26
 
27
27
  ### Or add @eeacms/volto-tabs-block to your Volto project
28
28
 
29
- Before starting make sure your development environment is properly set. See [Volto Developer Documentation](https://docs.voltocms.com/getting-started/install/)
29
+ Before starting make sure your development environment is properly set. See the official Plone documentation for [creating a project with Cookieplone](https://6.docs.plone.org/install/create-project-cookieplone.html) and [installing an add-on in development mode in Volto 18 and 19](https://6.docs.plone.org/volto/development/add-ons/install-an-add-on-dev-18.html).
30
30
 
31
- 1. Make sure you have installed `yo`, `@plone/generator-volto` and `mrs-developer`
31
+ For new Volto 18+ projects, use Cookieplone. It includes `mrs-developer` by default.
32
32
 
33
- npm install -g yo @plone/generator-volto mrs-developer
33
+ 1. Create a new Volto project with Cookieplone
34
34
 
35
- 1. Create new volto app
36
-
37
- yo @plone/volto my-volto-project --addon @eeacms/volto-tabs-block --skip-install
38
- cd my-volto-project
35
+ uvx cookieplone project
36
+ cd project-title
39
37
 
40
38
  1. Add the following to `mrs.developer.json`:
41
39
 
42
40
  {
43
41
  "volto-tabs-block": {
42
+ "output": "packages",
44
43
  "url": "https://github.com/eea/volto-tabs-block.git",
45
44
  "package": "@eeacms/volto-tabs-block",
46
45
  "branch": "develop",
@@ -48,28 +47,31 @@ Before starting make sure your development environment is properly set. See [Vol
48
47
  }
49
48
  }
50
49
 
51
- 1. Install
50
+ 1. Add `@eeacms/volto-tabs-block` to the `addons` key in your project `volto.config.js`
51
+
52
+ 1. Install or refresh the project setup
52
53
 
53
- make develop
54
- yarn
54
+ make install
55
55
 
56
- 1. Start backend
56
+ 1. Start backend in one terminal
57
57
 
58
- docker run --pull always -it --rm --name plone -p 8080:8080 -e SITE=Plone plone/plone-backend
58
+ make backend-start
59
59
 
60
- ...wait for backend to setup and start - `Ready to handle requests`:
60
+ ...wait for backend to setup and start, ending with `Ready to handle requests`
61
61
 
62
62
  ...you can also check http://localhost:8080/Plone
63
63
 
64
- 1. Start frontend
64
+ 1. Start frontend in a second terminal
65
65
 
66
- yarn start
66
+ make frontend-start
67
67
 
68
68
  1. Go to http://localhost:3000
69
69
 
70
70
  1. Happy hacking!
71
71
 
72
- cd src/addons/volto-tabs-block/
72
+ cd packages/volto-tabs-block
73
+
74
+ For legacy Volto 17 projects, keep using the yarn-based workflow from the Volto 17 documentation.
73
75
 
74
76
  ## Cypress
75
77
 
@@ -81,7 +83,7 @@ project where you added `volto-tabs-block` to `mrs.developer.json`
81
83
  Go to:
82
84
 
83
85
  ```BASH
84
- cd src/addons/volto-tabs-block/
86
+ cd packages/volto-tabs-block/
85
87
  ```
86
88
 
87
89
  Start:
package/README.md CHANGED
@@ -3,16 +3,16 @@
3
3
  [![Releases](https://img.shields.io/github/v/release/eea/volto-tabs-block)](https://github.com/eea/volto-tabs-block/releases)
4
4
 
5
5
  [![Pipeline](https://ci.eionet.europa.eu/buildStatus/icon?job=volto-addons%2Fvolto-tabs-block%2Fmaster&subject=master)](https://ci.eionet.europa.eu/view/Github/job/volto-addons/job/volto-tabs-block/job/master/display/redirect)
6
- [![Lines of Code](https://sonarqube.eea.europa.eu/api/project_badges/measure?project=volto-tabs-block-master&metric=ncloc)](https://sonarqube.eea.europa.eu/dashboard?id=volto-tabs-block-master)
7
- [![Coverage](https://sonarqube.eea.europa.eu/api/project_badges/measure?project=volto-tabs-block-master&metric=coverage)](https://sonarqube.eea.europa.eu/dashboard?id=volto-tabs-block-master)
8
- [![Bugs](https://sonarqube.eea.europa.eu/api/project_badges/measure?project=volto-tabs-block-master&metric=bugs)](https://sonarqube.eea.europa.eu/dashboard?id=volto-tabs-block-master)
9
- [![Duplicated Lines (%)](https://sonarqube.eea.europa.eu/api/project_badges/measure?project=volto-tabs-block-master&metric=duplicated_lines_density)](https://sonarqube.eea.europa.eu/dashboard?id=volto-tabs-block-master)
6
+ [![Lines of Code](https://sonarqube.eea.europa.eu/api/project_badges/measure?project=volto-tabs-block&metric=ncloc)](https://sonarqube.eea.europa.eu/dashboard?id=volto-tabs-block)
7
+ [![Coverage](https://sonarqube.eea.europa.eu/api/project_badges/measure?project=volto-tabs-block&metric=coverage)](https://sonarqube.eea.europa.eu/dashboard?id=volto-tabs-block)
8
+ [![Bugs](https://sonarqube.eea.europa.eu/api/project_badges/measure?project=volto-tabs-block&metric=bugs)](https://sonarqube.eea.europa.eu/dashboard?id=volto-tabs-block)
9
+ [![Duplicated Lines (%)](https://sonarqube.eea.europa.eu/api/project_badges/measure?project=volto-tabs-block&metric=duplicated_lines_density)](https://sonarqube.eea.europa.eu/dashboard?id=volto-tabs-block)
10
10
 
11
11
  [![Pipeline](https://ci.eionet.europa.eu/buildStatus/icon?job=volto-addons%2Fvolto-tabs-block%2Fdevelop&subject=develop)](https://ci.eionet.europa.eu/view/Github/job/volto-addons/job/volto-tabs-block/job/develop/display/redirect)
12
- [![Lines of Code](https://sonarqube.eea.europa.eu/api/project_badges/measure?project=volto-tabs-block-develop&metric=ncloc)](https://sonarqube.eea.europa.eu/dashboard?id=volto-tabs-block-develop)
13
- [![Coverage](https://sonarqube.eea.europa.eu/api/project_badges/measure?project=volto-tabs-block-develop&metric=coverage)](https://sonarqube.eea.europa.eu/dashboard?id=volto-tabs-block-develop)
14
- [![Bugs](https://sonarqube.eea.europa.eu/api/project_badges/measure?project=volto-tabs-block-develop&metric=bugs)](https://sonarqube.eea.europa.eu/dashboard?id=volto-tabs-block-develop)
15
- [![Duplicated Lines (%)](https://sonarqube.eea.europa.eu/api/project_badges/measure?project=volto-tabs-block-develop&metric=duplicated_lines_density)](https://sonarqube.eea.europa.eu/dashboard?id=volto-tabs-block-develop)
12
+ [![Lines of Code](https://sonarqube.eea.europa.eu/api/project_badges/measure?project=volto-tabs-block&branch=develop&metric=ncloc)](https://sonarqube.eea.europa.eu/dashboard?id=volto-tabs-block&branch=develop)
13
+ [![Coverage](https://sonarqube.eea.europa.eu/api/project_badges/measure?project=volto-tabs-block&branch=develop&metric=coverage)](https://sonarqube.eea.europa.eu/dashboard?id=volto-tabs-block&branch=develop)
14
+ [![Bugs](https://sonarqube.eea.europa.eu/api/project_badges/measure?project=volto-tabs-block&branch=develop&metric=bugs)](https://sonarqube.eea.europa.eu/dashboard?id=volto-tabs-block&branch=develop)
15
+ [![Duplicated Lines (%)](https://sonarqube.eea.europa.eu/api/project_badges/measure?project=volto-tabs-block&branch=develop&metric=duplicated_lines_density)](https://sonarqube.eea.europa.eu/dashboard?id=volto-tabs-block&branch=develop)
16
16
 
17
17
  [Volto](https://github.com/plone/volto) add-on
18
18
 
@@ -35,6 +35,11 @@
35
35
 
36
36
  Go to http://localhost:3000
37
37
 
38
+ `make start` now defaults to Volto 18. To run the same setup against Volto 17, use:
39
+
40
+ VOLTO_VERSION=17 make
41
+ VOLTO_VERSION=17 make start
42
+
38
43
  ### Add volto-tabs-block to your Volto project
39
44
 
40
45
  1. Make sure you have a [Plone backend](https://plone.org/download) up-and-running at http://localhost:8080/Plone
@@ -48,35 +53,62 @@ Go to http://localhost:3000
48
53
  * If you already have a volto project, just update `package.json`:
49
54
 
50
55
  ```JSON
51
- "addons": [
52
- "@eeacms/volto-tabs-block"
53
- ],
54
-
55
56
  "dependencies": {
56
57
  "@eeacms/volto-tabs-block": "*"
57
58
  }
58
59
  ```
59
60
 
60
- * If not, create one:
61
+ and `volto.config.js`:
62
+
63
+ ```JavaScript
64
+ const addons = ['@eeacms/volto-tabs-block'];
65
+ ```
66
+
67
+ * If not, create one with Cookieplone, as recommended by the official Plone documentation for Volto 18+:
61
68
 
62
69
  ```
63
- npm install -g yo @plone/generator-volto
64
- yo @plone/volto my-volto-project --canary --addon @eeacms/volto-tabs-block
65
- cd my-volto-project
70
+ uvx cookieplone project
71
+ cd project-title
66
72
  ```
67
73
 
68
- 1. Install new add-ons and restart Volto:
74
+ Then install the add-on in your frontend project. For Cookieplone-based Volto 18 and 19 projects, Plone documents `pnpm` usage:
75
+
76
+ ```
77
+ pnpm --filter <name-of-your-policy-add-on> add @eeacms/volto-tabs-block
78
+ ```
79
+
80
+ Then add `@eeacms/volto-tabs-block` to the `addons` key in your project's `package.json` or declare it in `volto.config.js`.
81
+
82
+ 1. Install or update dependencies, then start the project:
69
83
 
70
84
  ```
71
- yarn
72
- yarn start
85
+ make install
73
86
  ```
74
87
 
88
+ For a Cookieplone project, start the backend and frontend in separate terminals:
89
+
90
+ ```
91
+ make backend-start
92
+ make frontend-start
93
+ ```
94
+
95
+ For a legacy Volto 17 project, install the package with `yarn` and restart the frontend as usual.
96
+
75
97
  1. Go to http://localhost:3000
76
98
 
77
99
  1. Happy editing!
78
100
 
79
101
  ## Upgrade
102
+
103
+ ### Upgrading to 10.x
104
+
105
+ > This version requires `Volto >= 17.18` or `Volto 18+`. It removes the custom `EditBlockWrapper` and uses Volto's built-in block chrome provided by `BlocksForm`.
106
+
107
+ #### Breaking changes
108
+
109
+ - **Removed `EditBlockWrapper.jsx`.** Any code importing `EditBlockWrapper` from `@eeacms/volto-tabs-block` will break. Use Volto's built-in `EditBlockWrapper` from `@plone/volto/components/manage/Blocks/Block/EditBlockWrapper` if you need a custom wrapper.
110
+ - **Removed custom edit toolbar styles.** The `edit.less` styles that powered the custom inner block toolbar have been removed. Inner blocks now use Volto's default block chrome.
111
+
80
112
  ### Upgrading to 7.0.0
81
113
  Version 7 introduces the following breaking changes:
82
114
  - The templates are now `variations` of the default template, so if you have custom templates,
package/cypress.config.js CHANGED
@@ -1,9 +1,18 @@
1
1
  const { defineConfig } = require('cypress');
2
2
 
3
+ const apiPath =
4
+ process.env.CYPRESS_API_PATH ||
5
+ process.env.RAZZLE_DEV_PROXY_API_PATH ||
6
+ process.env.RAZZLE_INTERNAL_API_PATH ||
7
+ 'http://localhost:8080/Plone';
8
+
3
9
  module.exports = defineConfig({
4
10
  viewportWidth: 1280,
5
- defaultCommandTimeout: 10000,
11
+ defaultCommandTimeout: 8888,
6
12
  chromeWebSecurity: false,
13
+ env: {
14
+ API_PATH: apiPath,
15
+ },
7
16
  reporter: 'junit',
8
17
  video: false,
9
18
  retries: {
@@ -15,7 +15,7 @@ services:
15
15
  args:
16
16
  ADDON_NAME: "${ADDON_NAME}"
17
17
  ADDON_PATH: "${ADDON_PATH}"
18
- VOLTO_VERSION: ${VOLTO_VERSION:-16}
18
+ VOLTO_VERSION: ${VOLTO_VERSION:-18-yarn}
19
19
  ports:
20
20
  - "3000:3000"
21
21
  - "3001:3001"
@@ -1,4 +1,12 @@
1
1
  require('dotenv').config({ path: __dirname + '/.env' })
2
+ const fs = require('fs')
3
+ const path = require('path')
4
+
5
+ const voltoSlatePath = fs.existsSync(
6
+ path.join(__dirname, '../../../node_modules/@plone/volto-slate/src'),
7
+ )
8
+ ? '<rootDir>/node_modules/@plone/volto-slate/src'
9
+ : '<rootDir>/node_modules/@plone/volto/packages/volto-slate/src'
2
10
 
3
11
  module.exports = {
4
12
  testMatch: ['**/src/addons/**/?(*.)+(spec|test).[jt]s?(x)'],
@@ -17,10 +25,8 @@ module.exports = {
17
25
  '@eeacms/search/(.*)$': '<rootDir>/src/addons/volto-searchlib/searchlib/$1',
18
26
  '@eeacms/search': '<rootDir>/src/addons/volto-searchlib/searchlib',
19
27
  '@eeacms/(.*?)/(.*)$': '<rootDir>/node_modules/@eeacms/$1/src/$2',
20
- '@plone/volto-slate$':
21
- '<rootDir>/node_modules/@plone/volto/packages/volto-slate/src',
22
- '@plone/volto-slate/(.*)$':
23
- '<rootDir>/node_modules/@plone/volto/packages/volto-slate/src/$1',
28
+ '@plone/volto-slate$': voltoSlatePath,
29
+ '@plone/volto-slate/(.*)$': `${voltoSlatePath}/$1`,
24
30
  '~/(.*)$': '<rootDir>/src/$1',
25
31
  'load-volto-addons':
26
32
  '<rootDir>/node_modules/@plone/volto/jest-addons-loader.js',
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "@eeacms/volto-tabs-block",
3
- "version": "9.1.0",
3
+ "version": "10.0.0",
4
4
  "description": "volto-tabs-block: Volto add-on",
5
5
  "main": "src/index.js",
6
6
  "author": "European Environment Agency: IDM2 A-Team",
@@ -212,7 +212,7 @@ const Edit = (props) => {
212
212
  {props.selected ? (
213
213
  <BlocksToolbar
214
214
  formData={tabData}
215
- selectedBlock={activeTab}
215
+ selectedBlock={activeBlock}
216
216
  selectedBlocks={multiSelected}
217
217
  onChangeBlocks={(newBlockData) => {
218
218
  onChangeBlock(block, {
@@ -0,0 +1,226 @@
1
+ import React from 'react';
2
+ import { fireEvent, render, screen } from '@testing-library/react';
3
+ import '@testing-library/jest-dom';
4
+ import configureStore from 'redux-mock-store';
5
+ import { Provider } from 'react-intl-redux';
6
+ import { MemoryRouter } from 'react-router-dom';
7
+ import config from '@plone/volto/registry';
8
+ import Edit from './Edit';
9
+ import { TABS_BLOCK } from '../constants';
10
+
11
+ jest.mock('uuid', () => ({
12
+ v4: () => 'test-uuid-1234',
13
+ }));
14
+
15
+ jest.mock(
16
+ '@eeacms/volto-tabs-block/constants',
17
+ () => ({
18
+ TABS_BLOCK: 'tabs_block',
19
+ }),
20
+ { virtual: true },
21
+ );
22
+
23
+ jest.mock(
24
+ '@eeacms/volto-tabs-block/helpers',
25
+ () => ({
26
+ empty: jest.fn(),
27
+ emptyTab: jest.fn(() => ({})),
28
+ getVariation: jest.fn(() => 'default'),
29
+ }),
30
+ { virtual: true },
31
+ );
32
+
33
+ jest.mock(
34
+ '@eeacms/volto-tabs-block/components',
35
+ () => ({
36
+ AssetTab: ({ tabTitle }) => <span>{tabTitle}</span>,
37
+ }),
38
+ { virtual: true },
39
+ );
40
+
41
+ jest.mock(
42
+ '@eeacms/volto-tabs-block/components/variations/default/schema',
43
+ () => ({
44
+ defaultSchemaEnhancer: jest.fn(({ schema }) => schema),
45
+ }),
46
+ { virtual: true },
47
+ );
48
+
49
+ jest.mock(
50
+ '@eeacms/volto-tabs-block/utils',
51
+ () => ({
52
+ SimpleMarkdown: ({ md, className }) => (
53
+ <div className={className}>{md}</div>
54
+ ),
55
+ getMenuPosition: () => ({}),
56
+ }),
57
+ { virtual: true },
58
+ );
59
+
60
+ jest.mock('@eeacms/volto-tabs-block/less/edit.less', () => ({}), {
61
+ virtual: true,
62
+ });
63
+
64
+ jest.mock('@eeacms/volto-tabs-block/less/tabs.less', () => ({}), {
65
+ virtual: true,
66
+ });
67
+
68
+ jest.mock('@eeacms/volto-tabs-block/less/menu.less', () => ({}), {
69
+ virtual: true,
70
+ });
71
+
72
+ jest.mock('./variations/default', () => ({
73
+ DefaultEdit: jest.requireActual('./variations/default/Edit').default,
74
+ }));
75
+
76
+ jest.mock('@plone/volto/components', () => ({
77
+ BlocksForm: jest.fn(
78
+ ({ multiSelected, onSelectBlock, properties, selectedBlock }) => {
79
+ const blockList = properties.blocks
80
+ ? Object.entries(properties.blocks)
81
+ : [];
82
+
83
+ return (
84
+ <div
85
+ data-testid={`blocks-form-${properties.title || 'untitled'}`}
86
+ data-multi-selected={(multiSelected || []).join(',')}
87
+ data-selected-block={selectedBlock || ''}
88
+ >
89
+ {blockList.map(([blockId]) => (
90
+ <button
91
+ key={blockId}
92
+ type="button"
93
+ aria-label={`Select ${blockId}`}
94
+ onClick={(event) => onSelectBlock?.(blockId, null, event)}
95
+ >
96
+ Select {blockId}
97
+ </button>
98
+ ))}
99
+ </div>
100
+ );
101
+ },
102
+ ),
103
+ SidebarPortal: ({ children }) => <div>{children}</div>,
104
+ BlocksToolbar: ({ selectedBlock, selectedBlocks }) => (
105
+ <div
106
+ data-testid="blocks-toolbar"
107
+ data-selected-block={selectedBlock || ''}
108
+ data-selected-blocks={(selectedBlocks || []).join(',')}
109
+ />
110
+ ),
111
+ BlockDataForm: () => <div>BlockDataForm</div>,
112
+ }));
113
+
114
+ jest.mock(
115
+ '@eeacms/volto-block-style/StyleWrapper',
116
+ () => ({
117
+ StyleWrapperView: ({ children }) => <>{children}</>,
118
+ }),
119
+ { virtual: true },
120
+ );
121
+
122
+ jest.mock(
123
+ '@eeacms/volto-block-style/BlockStyleWrapper',
124
+ () => ({
125
+ BlockStyleWrapperEdit: ({ children }) => <>{children}</>,
126
+ }),
127
+ { virtual: true },
128
+ );
129
+
130
+ const mockStore = configureStore();
131
+ const store = mockStore({
132
+ intl: {
133
+ locale: 'en',
134
+ messages: {},
135
+ },
136
+ screen: {
137
+ page: {
138
+ width: 768,
139
+ },
140
+ },
141
+ });
142
+
143
+ const mockData = {
144
+ title: 'Tabs',
145
+ data: {
146
+ blocks: {
147
+ tab1: {
148
+ '@type': 'tab',
149
+ title: 'Tab 1',
150
+ blocks: {
151
+ block1: {
152
+ '@type': 'text',
153
+ },
154
+ block2: {
155
+ '@type': 'text',
156
+ },
157
+ },
158
+ blocks_layout: {
159
+ items: ['block1', 'block2'],
160
+ },
161
+ },
162
+ },
163
+ blocks_layout: {
164
+ items: ['tab1'],
165
+ },
166
+ },
167
+ };
168
+
169
+ describe('Tabs Edit', () => {
170
+ beforeEach(() => {
171
+ config.blocks.blocksConfig[TABS_BLOCK] = {
172
+ ...config.blocks.blocksConfig[TABS_BLOCK],
173
+ blockSchema: () => ({
174
+ title: 'Tabs',
175
+ properties: {
176
+ data: {
177
+ schema: {},
178
+ },
179
+ },
180
+ }),
181
+ variations: [{ id: 'default' }],
182
+ };
183
+ config.settings = {
184
+ ...config.settings,
185
+ defaultBlockType: 'text',
186
+ };
187
+ });
188
+
189
+ it('forwards nested multi selection and tracks the active inner block in the toolbar', () => {
190
+ render(
191
+ <Provider store={store}>
192
+ <MemoryRouter>
193
+ <Edit
194
+ block="tabs-block"
195
+ data={mockData}
196
+ onChangeBlock={jest.fn()}
197
+ onChangeField={jest.fn()}
198
+ selected={true}
199
+ setSidebarTab={jest.fn()}
200
+ blockNode={{ current: document.createElement('div') }}
201
+ />
202
+ </MemoryRouter>
203
+ </Provider>,
204
+ );
205
+
206
+ fireEvent.click(screen.getByRole('button', { name: 'Select block1' }));
207
+
208
+ expect(screen.getByTestId('blocks-toolbar')).toHaveAttribute(
209
+ 'data-selected-block',
210
+ 'block1',
211
+ );
212
+
213
+ fireEvent.click(screen.getByRole('button', { name: 'Select block2' }), {
214
+ shiftKey: true,
215
+ });
216
+
217
+ expect(screen.getByTestId('blocks-form-Tab 1')).toHaveAttribute(
218
+ 'data-multi-selected',
219
+ 'block1,block2',
220
+ );
221
+ expect(screen.getByTestId('blocks-toolbar')).toHaveAttribute(
222
+ 'data-selected-blocks',
223
+ 'block1,block2',
224
+ );
225
+ });
226
+ });
@@ -1,11 +1,10 @@
1
1
  import React from 'react';
2
2
  import { render, fireEvent } from '@testing-library/react';
3
- import { BrowserRouter as Router } from 'react-router-dom';
4
3
  import View from './View';
5
4
  import config from '@plone/volto/registry';
6
5
  import configureStore from 'redux-mock-store';
7
6
  import { Provider } from 'react-intl-redux';
8
- import '@testing-library/jest-dom/extend-expect';
7
+ import '@testing-library/jest-dom';
9
8
 
10
9
  config.blocks.blocksConfig = {
11
10
  tabs_block: {
@@ -76,9 +75,7 @@ describe('View Component', () => {
76
75
 
77
76
  const { container, getByText } = render(
78
77
  <Provider store={store}>
79
- <Router>
80
- <View data={{ variation: 'default', data: customTabsData }} />
81
- </Router>
78
+ <View data={{ variation: 'default', data: customTabsData }} />
82
79
  </Provider>,
83
80
  );
84
81
  const tabItemsMenu = container.querySelectorAll(
@@ -1,5 +1,7 @@
1
+ import { TABS_BLOCK } from '../constants';
2
+
1
3
  const blocksArray = (config) => {
2
- return Object.keys(config.blocks.blocksConfig)
4
+ const choices = Object.keys(config.blocks.blocksConfig)
3
5
  .map((key) => {
4
6
  if (config.blocks.blocksConfig[key]?.restricted) {
5
7
  return false;
@@ -9,6 +11,12 @@ const blocksArray = (config) => {
9
11
  }
10
12
  })
11
13
  .filter((val) => !!val);
14
+
15
+ if (!choices.some(([id]) => id === TABS_BLOCK)) {
16
+ choices.push([TABS_BLOCK, 'Tabs']);
17
+ }
18
+
19
+ return choices;
12
20
  };
13
21
 
14
22
  const layoutSchema = (config) => ({
@@ -72,7 +80,7 @@ const layoutSchema = (config) => ({
72
80
  },
73
81
  readOnlySettings: {
74
82
  title: 'Read-only settings',
75
- description: 'Disable editing on columns block settings',
83
+ description: 'Disable editing on tabs block settings',
76
84
  type: 'boolean',
77
85
  },
78
86
  },
@@ -6,7 +6,6 @@ import cx from 'classnames';
6
6
  import { Menu, Tab, Input, Container } from 'semantic-ui-react';
7
7
  import { BlocksForm } from '@plone/volto/components';
8
8
  import { emptyBlocksForm } from '@plone/volto/helpers';
9
- import EditBlockWrapper from '@eeacms/volto-tabs-block/components/EditBlockWrapper';
10
9
  import { defaultSchemaEnhancer } from '@eeacms/volto-tabs-block/components/variations/default/schema';
11
10
  import { AssetTab } from '@eeacms/volto-tabs-block/components';
12
11
  import {
@@ -252,6 +251,7 @@ const Edit = (props) => {
252
251
  metadata={metadata}
253
252
  pathname={props.pathname}
254
253
  properties={isEmpty(tabs[tab]) ? emptyBlocksForm() : tabs[tab]}
254
+ multiSelected={selected && activeTab === tab ? multiSelected : []}
255
255
  selected={selected && activeTab === tab && activeBlock}
256
256
  selectedBlock={
257
257
  selected && activeTab === tab && activeBlock
@@ -290,19 +290,7 @@ const Edit = (props) => {
290
290
  );
291
291
  setEditingTab(null);
292
292
  }}
293
- >
294
- {({ draginfo }, editBlock, blockProps) => {
295
- return (
296
- <EditBlockWrapper
297
- blockProps={blockProps}
298
- draginfo={draginfo}
299
- multiSelected={multiSelected.includes(blockProps.block)}
300
- >
301
- {editBlock}
302
- </EditBlockWrapper>
303
- );
304
- }}
305
- </BlocksForm>
293
+ />
306
294
  </Tab.Pane>
307
295
  );
308
296
  },
@@ -9,7 +9,6 @@ import cx from 'classnames';
9
9
  import { Menu, Tab, Container, Dropdown, Input } from 'semantic-ui-react';
10
10
  import { emptyBlocksForm } from '@plone/volto/helpers';
11
11
  import { BlocksForm } from '@plone/volto/components';
12
- import EditBlockWrapper from '@eeacms/volto-tabs-block/components/EditBlockWrapper';
13
12
  import { defaultSchemaEnhancer } from '@eeacms/volto-tabs-block/components/variations/default/schema';
14
13
  import {
15
14
  SimpleMarkdown,
@@ -295,7 +294,6 @@ const Edit = (props) => {
295
294
  activeTabIndex = 0,
296
295
  block = null,
297
296
  activeBlock = null,
298
- multiSelected = [],
299
297
  screen,
300
298
  tabsData = {},
301
299
  emptyTab = () => {},
@@ -304,6 +302,7 @@ const Edit = (props) => {
304
302
  onSelectBlock = noop,
305
303
  setEditingTab = noop,
306
304
  schema,
305
+ multiSelected = [],
307
306
  } = props;
308
307
  const menuPosition = getMenuPosition(data);
309
308
 
@@ -355,6 +354,7 @@ const Edit = (props) => {
355
354
  metadata={metadata}
356
355
  pathname={props.pathname}
357
356
  properties={isEmpty(tabs[tab]) ? emptyBlocksForm() : tabs[tab]}
357
+ multiSelected={selected && activeTab === tab ? multiSelected : []}
358
358
  selected={selected && activeTab === tab && activeBlock}
359
359
  selectedBlock={
360
360
  selected && activeTab === tab && activeBlock
@@ -393,19 +393,7 @@ const Edit = (props) => {
393
393
  );
394
394
  setEditingTab(null);
395
395
  }}
396
- >
397
- {({ draginfo }, editBlock, blockProps) => {
398
- return (
399
- <EditBlockWrapper
400
- blockProps={blockProps}
401
- draginfo={draginfo}
402
- multiSelected={multiSelected.includes(blockProps.block)}
403
- >
404
- {editBlock}
405
- </EditBlockWrapper>
406
- );
407
- }}
408
- </BlocksForm>
396
+ />
409
397
  </div>
410
398
  </Tab.Pane>
411
399
  ),
@@ -0,0 +1,57 @@
1
+ jest.mock(
2
+ '@eeacms/volto-tabs-block/components',
3
+ () => ({
4
+ DefaultEdit: () => null,
5
+ DefaultView: () => null,
6
+ AccordionEdit: () => null,
7
+ AccordionView: () => null,
8
+ HorizontalResponsiveEdit: () => null,
9
+ HorizontalResponsiveView: () => null,
10
+ HorizontalCarouselView: () => null,
11
+ VerticalCarouselView: () => null,
12
+ layoutSchema: require('./components/layoutSchema').default,
13
+ TabsEdit: () => null,
14
+ TabsView: () => null,
15
+ blockSchema: jest.fn(),
16
+ }),
17
+ { virtual: true },
18
+ );
19
+
20
+ jest.mock('@eeacms/volto-tabs-block//icons/tabs.svg', () => 'tabs.svg', {
21
+ virtual: true,
22
+ });
23
+
24
+ jest.mock('./widgets', () => ({
25
+ TabsWidget: () => null,
26
+ }));
27
+
28
+ const applyConfig = require('./index').default;
29
+ const { TABS_BLOCK } = require('./constants');
30
+
31
+ describe('applyConfig', () => {
32
+ it('should include tabs in allowed blocks schema choices', () => {
33
+ const config = {
34
+ blocks: {
35
+ blocksConfig: {
36
+ text: { title: 'Text', restricted: false },
37
+ image: { restricted: false },
38
+ image_test: { title: 'Image', restricted: true },
39
+ },
40
+ },
41
+ widgets: {
42
+ type: {},
43
+ },
44
+ };
45
+
46
+ const newConfig = applyConfig(config);
47
+
48
+ expect(
49
+ newConfig.blocks.blocksConfig[TABS_BLOCK].schema.properties.allowedBlocks
50
+ .items.choices,
51
+ ).toEqual([
52
+ ['text', 'Text'],
53
+ ['image', 'image'],
54
+ [TABS_BLOCK, 'Tabs'],
55
+ ]);
56
+ });
57
+ });
@@ -46,18 +46,7 @@
46
46
  // padding-bottom: 0.1rem;
47
47
  }
48
48
 
49
- .block-wrapper {
50
- &:not(:last-child) {
51
- margin-bottom: 2rem;
52
- }
53
- }
54
-
55
49
  .block {
56
- .block-add-button,
57
- .delete-button {
58
- display: none;
59
- }
60
-
61
50
  .block.selected::before {
62
51
  border-top-left-radius: 0;
63
52
  }
@@ -68,44 +57,9 @@
68
57
  pointer-events: none;
69
58
  }
70
59
 
71
- .block.wrapper.multiSelected {
72
- .block .block::before {
73
- z-index: 1;
74
- background-color: rgba(120, 192, 215, 0.375);
75
- }
76
- }
77
-
78
60
  .blocks-form {
79
61
  margin-top: 0.5rem;
80
62
  }
81
-
82
- .blocks-chooser {
83
- right: 0;
84
- left: auto;
85
- margin-top: 3rem;
86
- }
87
-
88
- .block-toolbar {
89
- position: absolute;
90
- z-index: 3;
91
- right: -9px;
92
- display: flex;
93
- border: none;
94
- border: 1px solid @borderColor;
95
- border-bottom: 1px solid @pageBackground;
96
- margin-top: -45px;
97
- background-color: @pageBackground;
98
- border-top-left-radius: 1rem;
99
- border-top-right-radius: 1rem;
100
-
101
- .ui.basic.button {
102
- padding: 8px 5px;
103
- }
104
-
105
- .ui.basic.button:hover {
106
- background: transparent !important;
107
- }
108
- }
109
63
  }
110
64
 
111
65
  .drag-drop-list-widget {
@@ -1,7 +1,7 @@
1
1
  import React from 'react';
2
2
  import { render } from '@testing-library/react';
3
3
  import SimpleMarkdown from './SimpleMarkdown';
4
- import '@testing-library/jest-dom/extend-expect';
4
+ import '@testing-library/jest-dom';
5
5
 
6
6
  describe('SimpleMarkdown', () => {
7
7
  it('renders empty when no markdown is provided', () => {
@@ -1,172 +0,0 @@
1
- import React from 'react';
2
- import { Icon, BlockChooser } from '@plone/volto/components';
3
- import {
4
- blockHasValue,
5
- buildStyleClassNamesFromData,
6
- } from '@plone/volto/helpers';
7
- import config from '@plone/volto/registry';
8
- import { Button } from 'semantic-ui-react';
9
- import includes from 'lodash/includes';
10
- import isBoolean from 'lodash/isBoolean';
11
- import { defineMessages, injectIntl } from 'react-intl';
12
- import { doesNodeContainClick } from 'semantic-ui-react/dist/commonjs/lib';
13
- import cx from 'classnames';
14
-
15
- import dragSVG from '@plone/volto/icons/drag.svg';
16
- import addSVG from '@plone/volto/icons/circle-plus.svg';
17
- import trashSVG from '@plone/volto/icons/delete.svg';
18
-
19
- const messages = defineMessages({
20
- unknownBlock: {
21
- id: 'Unknown Block',
22
- defaultMessage: 'Unknown Block {block}',
23
- },
24
- delete: {
25
- id: 'delete',
26
- defaultMessage: 'delete',
27
- },
28
- });
29
-
30
- class EditBlockWrapper extends React.Component {
31
- constructor(props) {
32
- super(props);
33
- this.state = {
34
- addNewBlockOpened: false,
35
- };
36
- }
37
-
38
- componentDidMount() {
39
- document.addEventListener('mousedown', this.handleClickOutside, false);
40
- }
41
-
42
- componentWillUnmount() {
43
- document.removeEventListener('mousedown', this.handleClickOutside);
44
- }
45
-
46
- handleClickOutside = (e) => {
47
- if (
48
- this.blockNode.current &&
49
- doesNodeContainClick(this.blockNode.current, e)
50
- ) {
51
- return;
52
- }
53
-
54
- if (this.state.addNewBlockOpened) {
55
- this.setState({
56
- addNewBlockOpened: false,
57
- });
58
- return true;
59
- }
60
- };
61
-
62
- blockNode = React.createRef();
63
-
64
- render() {
65
- const { intl, blockProps, draginfo, extraControls, children } = this.props;
66
-
67
- const {
68
- allowedBlocks,
69
- block,
70
- data,
71
- onDeleteBlock,
72
- onMutateBlock,
73
- selected,
74
- } = blockProps;
75
- const type = data['@type'];
76
- const { disableNewBlocks } = data;
77
- const visible = !data.fixed;
78
-
79
- const required = isBoolean(data.required)
80
- ? data.required
81
- : includes(config.blocks.requiredBlocks, type);
82
-
83
- const styles = buildStyleClassNamesFromData(data.styles);
84
-
85
- return (
86
- <div ref={this.blockNode} className="block-wrapper">
87
- <div
88
- ref={draginfo?.innerRef}
89
- {...(selected ? draginfo?.draggableProps : null)}
90
- className={cx(`block-editor-${data['@type']}`, styles, {
91
- [data.align]: data.align,
92
- })}
93
- >
94
- {!selected && (
95
- <div
96
- style={{
97
- display: 'none',
98
- // keep react-beautiful-dnd happy
99
- }}
100
- {...draginfo.dragHandleProps}
101
- ></div>
102
- )}
103
- {selected && (
104
- <div className="block-toolbar">
105
- <div
106
- style={{
107
- display: visible ? 'inline-block' : 'none',
108
- }}
109
- {...draginfo.dragHandleProps}
110
- className="drag handle wrapper-column-block"
111
- >
112
- <Button icon basic title="Drag and drop">
113
- <Icon name={dragSVG} size="19px" />
114
- </Button>
115
- </div>
116
-
117
- {extraControls}
118
-
119
- {!disableNewBlocks && !blockHasValue(data) && (
120
- <Button
121
- icon
122
- basic
123
- title="Add block"
124
- onClick={() => {
125
- this.setState((prevState) => ({
126
- addNewBlockOpened: !prevState.addNewBlockOpened,
127
- }));
128
- }}
129
- className="column-block-add-button"
130
- >
131
- <Icon name={addSVG} className="" size="19px" />
132
- </Button>
133
- )}
134
- {!required && (
135
- <Button
136
- icon
137
- basic
138
- title="Remove block"
139
- onClick={() => onDeleteBlock(block)}
140
- className="delete-button-column-block"
141
- aria-label={intl.formatMessage(messages.delete)}
142
- >
143
- <Icon name={trashSVG} size="19px" />
144
- </Button>
145
- )}
146
- {this.state.addNewBlockOpened && (
147
- <BlockChooser
148
- onMutateBlock={(id, value) => {
149
- this.setState({ addNewBlockOpened: false });
150
- onMutateBlock(id, value);
151
- }}
152
- currentBlock={block}
153
- allowedBlocks={allowedBlocks}
154
- />
155
- )}
156
- </div>
157
- )}
158
-
159
- <div
160
- className={cx('ui drag block wrapper inner', type, {
161
- multiSelected: this.props.multiSelected,
162
- })}
163
- >
164
- {children}
165
- </div>
166
- </div>
167
- </div>
168
- );
169
- }
170
- }
171
-
172
- export default injectIntl(EditBlockWrapper);