@eeacms/volto-eea-map 3.2.1 → 3.3.1

package/CHANGELOG.md

@@ -4,11 +4,31 @@ All notable changes to this project will be documented in this file. Dates are d
 
 Generated by [`auto-changelog`](https://github.com/CookPete/auto-changelog).
 
-### [3.2.1](https://github.com/eea/volto-eea-map/compare/3.2.0...3.2.1) - 13 December 2023
+### [3.3.1](https://github.com/eea/volto-eea-map/compare/3.3.0...3.3.1) - 23 January 2024
+
+#### :hammer_and_wrench: Others
+
+- fallbacks [Razvan - [`7e37082`](https://github.com/eea/volto-eea-map/commit/7e370820110f07f70dee1f3721b6fd9fa133f888)]
+### [3.3.0](https://github.com/eea/volto-eea-map/compare/3.2.1...3.3.0) - 17 January 2024
+
+#### :rocket: New Features
+
+- feat: show embed error + always show sources [Razvan - [`35f5465`](https://github.com/eea/volto-eea-map/commit/35f546574d347716ce043a482e7eda55a0180d44)]
+
+#### :house: Internal changes
+
+- chore: [JENKINS] add debug [valentinab25 - [`a84b567`](https://github.com/eea/volto-eea-map/commit/a84b5670d8c3c02e8c6371404925f0d18ac1118a)]
+- chore: [JENKINS] add debug [valentinab25 - [`25a5656`](https://github.com/eea/volto-eea-map/commit/25a5656a0e596864f6f2a07d23ca33ec595d2cd2)]
+- chore: [JENKINS] add debug [valentinab25 - [`839b32f`](https://github.com/eea/volto-eea-map/commit/839b32f99ca4e45c0398db2fd58bd575c413b5a7)]
 
 #### :hammer_and_wrench: Others
 
-- fix [Miu Razvan - [`a76939e`](https://github.com/eea/volto-eea-map/commit/a76939e8c317cbcc44874c3f14fd22d7e521c1e9)]
+- Release 3.3.0 [Alin Voinea - [`8b21828`](https://github.com/eea/volto-eea-map/commit/8b2182871b3d13d0e9164d99d2964e3999e8cc48)]
+- use arcgis map for screenshot [andreiggr - [`94cc865`](https://github.com/eea/volto-eea-map/commit/94cc8651667ab351fc761b810634f3b124d6e6bb)]
+- update checks to support older javascript engines(screenshoter) [andreiggr - [`7b58516`](https://github.com/eea/volto-eea-map/commit/7b5851628160a8ff474c6405a0285014eb7da05f)]
+- better check map layers [andreiggr - [`d3e7d6b`](https://github.com/eea/volto-eea-map/commit/d3e7d6bfaa2e06b5de40c1e13bf9d39241d2c0c0)]
+### [3.2.1](https://github.com/eea/volto-eea-map/compare/3.2.0...3.2.1) - 13 December 2023
+
 ### [3.2.0](https://github.com/eea/volto-eea-map/compare/3.1.0...3.2.0) - 13 December 2023
 
 #### :bug: Bug Fixes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@eeacms/volto-eea-map",
-  "version": "3.2.1",
+  "version": "3.3.1",
   "description": "@eeacms/volto-eea-map: Volto add-on",
   "main": "src/index.js",
   "author": "European Environment Agency: IDM2 A-Team",

package/src/components/Blocks/EmbedEEAMap/Edit.jsx

@@ -33,7 +33,6 @@ const Edit = (props) => {
     enable_queries,
     show_legend = true,
     show_note = true,
-    show_sources = true,
     show_more_info = true,
     show_share = true,
     dataprotection = { enabled: true },
@@ -66,7 +65,7 @@ const Edit = (props) => {
 
   useEffect(() => {
     const mapVisId = flattenToAppURL(map_visualization_data['@id'] || '');
-    if (vis_url && vis_url !== mapVisId) {
+    if (!map_visualization_data?.error && vis_url && vis_url !== mapVisId) {
       getContent(vis_url, null, id);
     }
     if (!vis_url) {
@@ -118,7 +117,7 @@ const Edit = (props) => {
               ...data,
               show_legend,
               show_note,
-              show_sources,
+              show_sources: true,
               show_more_info,
               show_share,
               dataprotection,

package/src/components/Blocks/EmbedEEAMap/Schema.js

@@ -86,7 +86,6 @@ export const Schema = (props) => {
           'show_legend',
           'show_viewer',
           'show_note',
-          'show_sources',
           'show_more_info',
           'show_share',
         ],

package/src/components/Blocks/EmbedEEAMap/View.jsx

@@ -13,7 +13,6 @@ const View = (props) => {
     enable_queries,
     show_legend = true,
     show_note = true,
-    show_sources = true,
     show_more_info = true,
     show_share = true,
     dataprotection = { enabled: true },
@@ -35,11 +34,22 @@ const View = (props) => {
     setMapData(updatedMapData);
   }, [map_visualization_data, data_query_params, enable_queries]);
 
+  const mapUrl = map_visualization_data?.layers?.map_layers[0]?.map_layer
+    ?.map_service_url
+    ? `${map_visualization_data.layers.map_layers[0].map_layer.map_service_url}?f=jsapi`
+    : '';
+
+  if (map_visualization_data?.error) {
+    return (
+      <p dangerouslySetInnerHTML={{ __html: map_visualization_data.error }} />
+    );
+  }
+
   return (
     <PrivacyProtection
-      data={data}
       className="embed-map-visualization"
       {...props}
+      data={mapUrl ? { ...data, url: mapUrl } : data}
     >
       {!!mapData && (
         <>
@@ -49,7 +59,7 @@ const View = (props) => {
               ...data,
               show_legend,
               show_note,
-              show_sources,
+              show_sources: true,
               show_more_info,
               show_share,
               dataprotection,

package/src/components/LegendView.jsx

@@ -11,7 +11,10 @@ import codeSVG from '@eeacms/volto-eea-map/static/code-line.svg';
 const LayerLegend = ({ data, show_viewer }) => {
   const [legendRows, setLegendRows] = React.useState([]);
 
-  const { map_service_url = '', layer = {} } = data;
+  const map_service_url =
+    data && data.map_service_url ? data.map_service_url : '';
+
+  const layer = data && data.layer ? data.layer : {};
   const { id, name } = layer || {};
 
   const fetchLegend = async (url, activeLayerID) => {
@@ -23,11 +26,11 @@ const LayerLegend = ({ data, show_viewer }) => {
   };
 
   React.useEffect(() => {
-    if (data.map_service_url && id !== undefined) {
+    if (data?.map_service_url && id !== undefined) {
       fetchLegend(`${data.map_service_url}/legend`, id);
     }
     // eslint-disable-next-line react-hooks/exhaustive-deps
-  }, [id, data.map_service_url]);
+  }, [id, data]);
 
   return (
     <Grid.Column>
@@ -61,7 +64,7 @@ const LayerLegend = ({ data, show_viewer }) => {
           </a>
         )}
       </div>
-      {data.description && serializeNodes(data.description)}
+      {data?.description && serializeNodes(data.description)}
       <div style={{ display: 'flex', flexDirection: 'column' }}>
         {legendRows.length > 0 &&
           legendRows.map((item, i) => {

package/src/components/Webmap.jsx

@@ -21,25 +21,20 @@ const MODULES = [
 ];
 
 const Webmap = (props) => {
-  const { editMode, height, id } = props;
-
-  const device = React.useMemo(() => props.device || {}, [props.device]);
-
-  const data = React.useMemo(() => props.data || {}, [props.data]);
-
-  const layers = React.useMemo(() => props?.data?.layers || {}, [
-    props.data?.layers,
-  ]);
-  const base = React.useMemo(() => props?.data?.base || {}, [props.data.base]);
-
-  const general = React.useMemo(() => props?.data?.general || {}, [
-    props.data?.general,
-  ]);
-  const styles = React.useMemo(() => props?.data?.styles || {}, [
-    props.data?.styles,
-  ]);
-
-  const { base_layer = '' } = base;
+  const editMode = props && props.editMode ? props.editMode : false;
+  const height = props && props.height ? props.height : '';
+  const id = props && props.id ? props.id : '';
+  const device = props && props.device ? props.device : {};
+  const data = props && props.data ? props.data : {};
+
+  const layers =
+    props && props.data && props.data.layers ? props.data.layers : {};
+  const base = props && props.data && props.data.base ? props.data.base : {};
+  const general =
+    props && props.data && props.data.general ? props.data.general : {};
+  const styles =
+    props && props.data && props.data.styles ? props.data.styles : {};
+  const base_layer = base && base.base_layer ? base.base_layer : '';
 
   const map_layers =
     layers &&
@@ -146,7 +141,7 @@ const Webmap = (props) => {
             .map(
               (
                 {
-                  map_service_url,
+                  map_service_url = '',
                   layer,
                   fullLayer,
                   query = '',

package/src/components/visualization/VisualizationEditorWidget.jsx

@@ -10,7 +10,7 @@ const VisualizationEditorWidget = (props) => {
   const [open, setOpen] = React.useState(false);
   const { onChange = {}, id } = props;
   const block = React.useMemo(() => props.block, [props.block]);
-  const value = React.useMemo(() => props.value, [props.value]);
+  const value = React.useMemo(() => props.value || {}, [props.value]);
 
   const [intValue, setIntValue] = React.useState(value);
 

package/src/components/visualization/VisualizationView.jsx

@@ -6,9 +6,12 @@ import Webmap from '../Webmap';
 import ExtraViews from '../ExtraViews';
 
 const VisualizationView = (props) => {
-  const { content = {} } = props;
+  const content = props && props.content ? props.content : {};
 
-  const { map_visualization_data = {} } = content;
+  const map_visualization_data =
+    content && content.map_visualization_data
+      ? content.map_visualization_data
+      : {};
 
   return (
     <div id="page-document" className="view-viewarcgismap">