@eeacms/volto-eea-design-system 1.20.0 → 1.21.0

package/CHANGELOG.md

@@ -4,7 +4,28 @@ All notable changes to this project will be documented in this file. Dates are d
 
 Generated by [`auto-changelog`](https://github.com/CookPete/auto-changelog).
 
-### [1.20.0](https://github.com/eea/volto-eea-design-system/compare/1.19.0...1.20.0) - 1 November 2023
+### [1.21.0](https://github.com/eea/volto-eea-design-system/compare/1.20.0...1.21.0) - 20 November 2023
+
+#### :bug: Bug Fixes
+
+- fix(item): styling difference so that column group or section group flex template match design [David Ichim - [`f57e074`](https://github.com/eea/volto-eea-design-system/commit/f57e0744808df8b467e179b83266e8b2c2398956)]
+
+#### :nail_care: Enhancements
+
+- change(message): Renamed Error to ErrorMessage to avoid special identifier Sonarqube warning [David Ichim - [`09e49ac`](https://github.com/eea/volto-eea-design-system/commit/09e49ac4e71c02b439459eec29266d3f5b884d50)]
+- change(header): dropdowns now auto open and close on focus and blur when using keyboard navigation [David Ichim - [`d558e9b`](https://github.com/eea/volto-eea-design-system/commit/d558e9bf7abba19221744be871759d025ce0f05a)]
+
+#### :hammer_and_wrench: Others
+
+- Release 1.21.0 [Alin Voinea - [`fe39edd`](https://github.com/eea/volto-eea-design-system/commit/fe39edde81fd4f01f7958aee706887a5dedce521)]
+- Modified test to reference ErrorMessage [David Ichim - [`36fefd0`](https://github.com/eea/volto-eea-design-system/commit/36fefd05a6b30d92494a7974c9fb86d35cae5acc)]
+- Lint fix [David Ichim - [`c1fc104`](https://github.com/eea/volto-eea-design-system/commit/c1fc104f1e7be0611de4aa17c55ad9c402c70ff8)]
+- Test Header onBlur [David Ichim - [`42f9c97`](https://github.com/eea/volto-eea-design-system/commit/42f9c97d01f7b59a1c63e42e1825dfa0697f0ef2)]
+- Add dropdown test case to Header component [David Ichim - [`9ea3234`](https://github.com/eea/volto-eea-design-system/commit/9ea3234c2c0f1c819c7c2b54a75c56cda7812c56)]
+- Remove unused import in Header.test.jsx [David Ichim - [`082069e`](https://github.com/eea/volto-eea-design-system/commit/082069e1f057786e0f1fb00c98d54b8e03b5d9c5)]
+- Added some tests for TopDropdownMenu mobile and dropdown interaction [David Ichim - [`9d24488`](https://github.com/eea/volto-eea-design-system/commit/9d24488c1e97b2b1b14bd9bd8cb6f5b68414794b)]
+- Lint fix [David Ichim - [`e29fd50`](https://github.com/eea/volto-eea-design-system/commit/e29fd50ee73477007dcf94a268596e6c11176d7b)]
+### [1.20.0](https://github.com/eea/volto-eea-design-system/compare/1.19.0...1.20.0) - 2 November 2023
 
 #### :rocket: New Features
 

package/cypress.config.js

@@ -2,12 +2,12 @@ const { defineConfig } = require('cypress');
 
 module.exports = defineConfig({
   viewportWidth: 1280,
-  defaultCommandTimeout: 5000,
+  defaultCommandTimeout: 8888,
   chromeWebSecurity: false,
   reporter: 'junit',
-  video: true,
+  video: false,
   retries: {
-    runMode: 1,
+    runMode: 2,
     openMode: 0,
   },
   reporterOptions: {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@eeacms/volto-eea-design-system",
-  "version": "1.20.0",
+  "version": "1.21.0",
   "description": "@eeacms/volto-eea-design-system: Volto add-on",
   "main": "src/index.js",
   "author": "European Environment Agency: IDM2 A-Team",

package/src/ui/Banner/Banner.jsx

@@ -3,6 +3,7 @@ import { Container, Icon, Button, Grid } from 'semantic-ui-react';
 import PropTypes from 'prop-types';
 import { flattenToAppURL } from '@plone/volto/helpers/Url/Url';
 import { formatDate } from '@plone/volto/helpers/Utils/Date';
+import cx from 'classnames';
 import config from '@plone/volto/registry';
 
 Banner.propTypes = {
@@ -44,7 +45,7 @@ export const sharePage = (url, platform) => {
   link.click();
 };
 
-function Banner({ image, metadata, properties, children, ...rest }) {
+function Banner({ image, metadata, properties, children, styles, ...rest }) {
   if (image) {
     //extract Lead image from page content.
     const content = metadata || properties;
@@ -52,7 +53,7 @@ function Banner({ image, metadata, properties, children, ...rest }) {
     return (
       <div className="eea banner">
         <div
-          className={imageUrl ? 'image' : ''}
+          className={cx(imageUrl ? 'image' : '', styles?.bg)}
           style={imageUrl ? { backgroundImage: `url(${imageUrl})` } : {}}
         >
           <div className="gradient">
@@ -72,21 +73,14 @@ function Banner({ image, metadata, properties, children, ...rest }) {
 }
 
 Banner.Action = React.forwardRef(function (
-  { id, title, titleClass, icon, onClick, className, color, ...rest },
+  { title, titleClass, icon, onClick, className, color, ...rest },
   ref,
 ) {
   return (
     <div className="action" ref={ref}>
-      <Button
-        className={className}
-        basic
-        icon
-        inverted
-        onClick={onClick}
-        {...rest}
-      >
-        <Icon className={icon} color={color}></Icon>
-        <span className={titleClass || 'mobile hidden'}>{title}</span>
+      <Button className={className} basic icon inverted onClick={onClick}>
+        <Icon className={icon} color={color} title={title}></Icon>
+        <span className={titleClass || 'mobile-sr-only'}>{title}</span>
       </Button>
     </div>
   );

package/src/ui/Card/Card.stories.jsx

@@ -1,6 +1,8 @@
 import React from 'react';
 import { Card, Image, Grid, Container, Icon, Button } from 'semantic-ui-react';
 import Slider from 'react-slick';
+import TagList from '../TagList/TagList';
+import Tag from '../Tag/Tag';
 
 import 'slick-carousel/slick/slick.css';
 import 'slick-carousel/slick/slick-theme.css';
@@ -8,89 +10,89 @@ import 'slick-carousel/slick/slick-theme.css';
 const tabletBreakpoint = 835;
 const mobileBreakpoint = 480;
 
-const createCardModel = (
-  title,
-  imgUrl,
-  description,
-  meta,
-  metaRight,
-  eventDate,
-  href,
-) => {
-  return {
-    title: title,
-    imgUrl: imgUrl,
-    description: description,
-    meta: meta,
-    metaRight: metaRight,
-    eventDate: eventDate,
-    href: href,
-  };
+// Content for all cards
+let cardData = {
+  cardContent: {
+    title: [
+      'Economy and resources',
+      'Health',
+      'Nature',
+      'Climate',
+      "State of Europe's environment",
+    ],
+    imgUrl: [
+      'https://www.eea.europa.eu/publications/eea-eionet-strategy-2021-2030/image_mini',
+      'https://www.eea.europa.eu/en/topics/at-a-glance/health/@@images/image/preview',
+      'https://www.eea.europa.eu/en/topics/at-a-glance/nature/@@images/image/preview',
+      'https://www.eea.europa.eu/en/topics/at-a-glance/climate/@@images/image/preview',
+      'https://www.eea.europa.eu/en/topics/at-a-glance/state-of-europes-environment/@@images/image/preview',
+    ],
+    description: [
+      'The economy plays a vital role in our lives by providing access to employment, ' +
+        'products and services that help us thrive. Unfortunately, with its key sectors like agriculture,' +
+        ' energy and transport, our economy also harms the environment and causes climate change. ' +
+        'Europe needs a circular, carbon-neutral and zero-pollution economy. ',
+      'By improving air, water, and soil quality and limiting pollution released to nature, ' +
+        'the EU has significantly contributed to enhancing human health in the last five ' +
+        'decades. Yet, many vulnerable groups continue to be impacted by environmental ' +
+        'degradation and climate change. Further improvements can help keep Europeans ' +
+        'healthier and better equipped to cope with climate change impacts.',
+      'Europe’s nature is filled with forests, mountains, vast plains, long rivers, deep blue seas and ' +
+        'refreshing lakes. But it also is under threat. Unsustainable farming and forestry practices, ' +
+        'pollution, climate change and invasive species are stressing and destabilising all natural ' +
+        'systems in Europe. The result is a biodiversity crisis. The EU is taking steps to protect and restore nature.',
+      'Climate change affects us all and is accelerating. Its impacts will become even more severe if ' +
+        'the increase in global temperature is not kept below 1.5°C. The EU and its Member States are ' +
+        'taking important steps to rapidly reduce greenhouse gas emissions and adapt to climate change.',
+      'EU environment and climate policies have delivered substantial benefits over recent ' +
+        'decades, such as cleaner air and water. Nevertheless, Europe, as well as the rest ' +
+        'of the globe, is facing environmental challenges of unprecedented scale and urgency.',
+    ],
+    metaRight: [
+      '20/05/2023',
+      '30/04/2023',
+      '10/04/2023',
+      '02/04/2023',
+      '16/03/2023',
+    ],
+    eventDate: [
+      '20/05/2023',
+      '30/04/2023',
+      '10/04/2023',
+      '02/04/2023',
+      '16/03/2023',
+    ],
+    tags: [
+      { category: 'tag 1', href: '#' },
+      { category: 'tag 2', href: '#' },
+      { category: 'bigger tag', href: '#' },
+      { category: 'tag 3', href: '#' },
+      { category: 'tag 4', href: '#' },
+    ],
+  },
 };
 
-const cardData = [
-  [
-    'Economy and resources',
-    'https://www.eea.europa.eu/publications/eea-eionet-strategy-2021-2030/image_mini',
-    'The economy plays a vital role in our lives by providing access to employment, ' +
-      'products and services that help us thrive. Unfortunately, with its key sectors like agriculture,' +
-      ' energy and transport, our economy also harms the environment and causes climate change. ' +
-      'Europe needs a circular, carbon-neutral and zero-pollution economy. ',
-    'Article',
-    '20/05/2022',
-    '15/10/2023',
-    '/#',
-  ],
-  [
-    'Health',
-    'https://www.eea.europa.eu/en/topics/at-a-glance/health/@@images/image/preview',
-    'By improving air, water, and soil quality and limiting pollution released to nature, ' +
-      'the EU has significantly contributed to enhancing human health in the last five ' +
-      'decades. Yet, many vulnerable groups continue to be impacted by environmental ' +
-      'degradation and climate change. Further improvements can help keep Europeans ' +
-      'healthier and better equipped to cope with climate change impacts.',
-    'Article',
-    '30/06/2023',
-    '03/08/2023',
-    '/#',
-  ],
-  [
-    'Nature',
-    'https://www.eea.europa.eu/en/topics/at-a-glance/nature/@@images/image/preview',
-    "Europe's nature is filled with forests, mountains, vast plains, long rivers, deep blue seas and " +
-      'refreshing lakes. But it also is under threat. Unsustainable farming and forestry practices, ' +
-      'pollution, climate change and invasive species are stressing and destabilising all natural ' +
-      'systems in Europe. The result is a biodiversity crisis. The EU is taking steps to protect and restore nature.',
-    'Article',
-    '10/04/2022',
-    '18/05/2023',
-    '/#',
-  ],
-  [
-    'Climate',
-    'https://www.eea.europa.eu/en/topics/at-a-glance/climate/@@images/image/preview',
-    'Climate change affects us all and is accelerating. Its impacts will become even more severe if ' +
-      'the increase in global temperature is not kept below 1.5°C. The EU and its Member States are ' +
-      'taking important steps to rapidly reduce greenhouse gas emissions and adapt to climate change.',
-    'Article',
-    '20/06/2022',
-    '15/03/2024',
-    '/#',
-  ],
-  [
-    "State of Europe's environment",
-    'https://www.eea.europa.eu/en/topics/at-a-glance/state-of-europes-environment/@@images/image/preview',
-    'EU environment and climate policies have delivered substantial benefits over recent ' +
-      'decades, such as cleaner air and water. Nevertheless, Europe, as well as the rest ' +
-      'of the globe, is facing environmental challenges of unprecedented scale and urgency.',
-    'Article',
-    '16/03/2022',
-    '13/01/2024',
-    '/#',
-  ],
-];
-
-const cardModels = cardData.map((card) => createCardModel(...card));
+// Fill the cardModel array that stories use
+let cardModels = [];
+let tempCardContent = {};
+for (var i = 0; i <= cardData.cardContent.title.length; i++) {
+  tempCardContent = {
+    title: cardData.cardContent.title[i],
+    imgUrl: cardData.cardContent.imgUrl[i],
+    description: cardData.cardContent.description[i],
+    meta: 'Article',
+    metaRight: cardData.cardContent.metaRight[i],
+    eventDate: cardData.cardContent.eventDate[i],
+    href: '/#',
+    tags: [],
+  };
+
+  // Fill cards with random amount of tags
+  for (var j = 0; j < Math.floor(Math.random() * 4 + 1); j++) {
+    tempCardContent.tags.push(cardData.cardContent.tags[j]);
+  }
+  cardModels.push(tempCardContent);
+}
 
 export default {
   title: 'Components/Card/Default',
@@ -203,6 +205,28 @@ export default {
         defaultValue: { summary: ' "" ' },
       },
     },
+    hasTags: {
+      name: 'Tags',
+      table: {
+        defaultValue: { summary: 'false' },
+        type: { summary: 'boolean' },
+        category: 'Tags',
+      },
+    },
+    direction: {
+      name: 'Tags direction',
+      control: { type: 'select' },
+      options: ['right', 'left'],
+      table: {
+        type: {
+          summary: 'string',
+        },
+        defaultValue: {
+          summary: 'left',
+        },
+        category: 'Tags',
+      },
+    },
   },
 };
 
@@ -242,6 +266,8 @@ const CardTemplate = ({
   eventDate,
   fluid,
   card,
+  hasTags,
+  direction,
 }) => (
   <Card
     fluid={fluid}
@@ -288,6 +314,19 @@ const CardTemplate = ({
 
       {/* Description */}
       <Card.Description>{card.description}</Card.Description>
+      {hasTags && (
+        <div className="card-tags">
+          <TagList className={direction}>
+            <TagList.Content>
+              {card.tags.map((tag, index) => [
+                <Tag href={tag.href} key={index}>
+                  {tag.category}
+                </Tag>,
+              ])}
+            </TagList.Content>
+          </TagList>
+        </div>
+      )}
     </Card.Content>
 
     {/* Additional links */}
@@ -322,6 +361,8 @@ Default.args = {
   numberOfCards: 1,
   fluid: false,
   cards: [...cardModels],
+  hasTags: false,
+  direction: 'left',
 };
 const GridTemplate = (args) => (
   <Container>
@@ -349,6 +390,8 @@ CardGrid.args = {
   fluid: true,
   numberOfCards: 5,
   cards: [...cardModels],
+  hasTags: false,
+  direction: 'left',
 };
 
 const ImageCard = ({
@@ -394,6 +437,8 @@ ImageGrid.args = {
   fluid: true,
   cards: [...cardModels],
   numberOfCards: 5,
+  hasTags: false,
+  direction: 'left',
 };
 
 ImageGrid.argTypes = {
@@ -443,6 +488,8 @@ FluidGrid.args = {
   eventDate: false,
   fluid: true,
   cards: [...cardModels],
+  hasTags: false,
+  direction: 'left',
 };
 const PrevArrow = (props) => {
   const { onClick } = props;
@@ -562,6 +609,8 @@ CarouselCards.args = {
   },
   numberOfCards: 5,
   cards: [...cardModels],
+  hasTags: false,
+  direction: 'left',
 };
 CarouselCards.argTypes = {
   settings: {
@@ -587,6 +636,8 @@ const TeaserCard = ({
   maxLines,
   eventDate,
   card,
+  hasTags,
+  direction,
 }) => (
   <div className="column grid-block-teaser">
     <div
@@ -625,6 +676,19 @@ const TeaserCard = ({
             </div>
             {eventDate && <EventDate {...card} />}
             <Card.Description>{card.description}</Card.Description>
+            {hasTags && (
+              <div className="card-tags">
+                <TagList className={direction}>
+                  <TagList.Content>
+                    {card.tags.map((tag, index) => [
+                      <Tag href={tag.href} key={index}>
+                        {tag.category}
+                      </Tag>,
+                    ])}
+                  </TagList.Content>
+                </TagList>
+              </div>
+            )}
           </div>
         )}
       </div>
@@ -669,4 +733,6 @@ TeaserCardGrid.args = {
   fluid: true,
   numberOfCards: 3,
   cards: [...cardModels],
+  hasTags: false,
+  direction: 'left',
 };

package/src/ui/Card/Card.stories.test.jsx

@@ -5,8 +5,8 @@ import {
   TeaserCardGrid,
   CarouselCards,
   FluidGrid,
-  CardGrid,
   ImageGrid,
+  CardGrid,
   Default,
 } from './Card.stories';
 
@@ -113,6 +113,16 @@ describe('CarouselCards component', () => {
   });
 });
 
+describe('ImageGrid component', () => {
+  it('renders the image grid with correct number of cards', () => {
+    const { container } = render(<ImageGrid {...ImageGrid.args} />);
+    const imageGridCards = container.querySelectorAll(
+      '.imageCard-items .ui.card a.image',
+    );
+    expect(imageGridCards.length).toBe(5);
+  });
+});
+
 describe('FluidGrid component', () => {
   it('renders correctly', () => {
     const { container } = render(<FluidGrid {...FluidGrid.args} />);

package/src/ui/Footer/Footer.jsx

@@ -18,7 +18,7 @@ import Description from '@eeacms/volto-eea-design-system/ui/Footer/Description';
 /**
  * Component to display the footer.
  * @function Footer
- * @param {Object} intl Intl object
+ * @param {Object} props object
  * @returns {string} Markup of the component
  */
 
@@ -28,7 +28,7 @@ const Footer = (props) => {
   const bgImgRef = React.useRef();
   const onScreen = useFirstVisited(bgImgRef);
   return (
-    <footer id={'footer'}>
+    <footer id={'footer'} aria-label={'Footer'}>
       <div
         ref={bgImgRef}
         className={onScreen ? 'footer-wrapper' : 'footer-wrapper-nobg'}