@eeacms/volto-cca-policy 0.3.65 → 0.3.66

package/CHANGELOG.md

@@ -4,17 +4,29 @@ All notable changes to this project will be documented in this file. Dates are d
 
 Generated by [`auto-changelog`](https://github.com/CookPete/auto-changelog).
 
-### [0.3.65](https://github.com/eea/volto-cca-policy/compare/1.0.0-alpha.0...0.3.65) - 16 July 2025
+### [0.3.66](https://github.com/eea/volto-cca-policy/compare/1.0.0-alpha.0...0.3.66) - 17 July 2025
 
 #### :rocket: Dependency updates
 
 - Release @eeacms/volto-searchlib@2.1.0 [EEA Jenkins - [`e5fc813`](https://github.com/eea/volto-cca-policy/commit/e5fc813f97922df335be28673d6303cb81b3c888)]
 
+#### :bug: Bug Fixes
+
+- fix: issues reported by sonarqube [kreafox - [`ccf5bcd`](https://github.com/eea/volto-cca-policy/commit/ccf5bcde698444d9bed9b138edb54841f78e27af)]
+- fix: resolve sonarqube code quality issues - refs #289841 [kreafox - [`f9e2bd0`](https://github.com/eea/volto-cca-policy/commit/f9e2bd07bc4db00cc452dd4a2837b28dae7c3d64)]
+- fix: resolve sonarqube code quality issues (WIP) - refs #289841 [kreafox - [`8253492`](https://github.com/eea/volto-cca-policy/commit/82534921494f8b0c5ba6c12cf6af834e4cc3f7e5)]
+
 #### :nail_care: Enhancements
 
 - change(header): add sitemap link - refs #288920 [kreafox - [`0b51b76`](https://github.com/eea/volto-cca-policy/commit/0b51b7649a13f250390cc78e88f6946d370c4c59)]
 
-### [1.0.0-alpha.0](https://github.com/eea/volto-cca-policy/compare/0.3.64...1.0.0-alpha.0) - 15 July 2025
+#### :hammer_and_wrench: Others
+
+- test: fix security hotspots on sonarqube - refs #289841 [kreafox - [`ed2ae6f`](https://github.com/eea/volto-cca-policy/commit/ed2ae6f3d41062740df5dd31c749b25316321776)]
+- test: fix security hotspots on sonarqube - refs #289841 [kreafox - [`2e86b28`](https://github.com/eea/volto-cca-policy/commit/2e86b285de2d43919248d53988a1f97eb44793d8)]
+- test: add tests to increase code coverage [kreafox - [`29ee566`](https://github.com/eea/volto-cca-policy/commit/29ee56661f1e349177f91237b6e548e1036d8b57)]
+- test: add tests to increase code coverage [kreafox - [`75e95bf`](https://github.com/eea/volto-cca-policy/commit/75e95bf109369b637eecfbd649cb07280c27c9fe)]
+### [1.0.0-alpha.0](https://github.com/eea/volto-cca-policy/compare/0.3.65...1.0.0-alpha.0) - 15 July 2025
 
 #### :bug: Bug Fixes
 
@@ -28,13 +40,11 @@ Generated by [`auto-changelog`](https://github.com/CookPete/auto-changelog).
 
 #### :nail_care: Enhancements
 
-- change: add archived info message on DefaultView - refs #289794 [kreafox - [`7005f0d`](https://github.com/eea/volto-cca-policy/commit/7005f0dcc653f2fd85713b12cb9fa75be97943c7)]
 - change: add volto grid teaser block customization [kreafox - [`1523323`](https://github.com/eea/volto-cca-policy/commit/15233230a01fbc7b9ef9c6df7aeb069876811530)]
 - change: update Header component [kreafox - [`8025ab9`](https://github.com/eea/volto-cca-policy/commit/8025ab9b2b5a19045dfe313cc3d4e7928a989771)]
 
 #### :house: Internal changes
 
-- chore: i18n [kreafox - [`5ffe66e`](https://github.com/eea/volto-cca-policy/commit/5ffe66e22b34f9451b01db1f4578037e03e1415f)]
 - chore: code cleanup [kreafox - [`842419b`](https://github.com/eea/volto-cca-policy/commit/842419b1bce3dc624755c81c9dea672198cab9e2)]
 - style: update teaser block styling [kreafox - [`1e0cad8`](https://github.com/eea/volto-cca-policy/commit/1e0cad8e1ed3ae827ee868dce8ad50b292a937ba)]
 - chore: update Makefile, run yarn i18n [kreafox - [`61e6962`](https://github.com/eea/volto-cca-policy/commit/61e6962901068ae6512265417a730bd9befd65fe)]
@@ -53,13 +63,30 @@ Generated by [`auto-changelog`](https://github.com/CookPete/auto-changelog).
 
 - Bump version [Tiberiu Ichim - [`f8e327e`](https://github.com/eea/volto-cca-policy/commit/f8e327e750771576e4f44fa4c27035b6e3b9c9e7)]
 - Fix eslint [Tiberiu Ichim - [`b6cfdd8`](https://github.com/eea/volto-cca-policy/commit/b6cfdd81c09e523d75ffbf2059008c77240311e2)]
-- test: improve security hotspots on sonarqube - refs #289841 [kreafox - [`2259d69`](https://github.com/eea/volto-cca-policy/commit/2259d696fe8c3ef2e1b3d49959d314556ceae501)]
 - update Jenkinsfile [kreafox - [`c8683c2`](https://github.com/eea/volto-cca-policy/commit/c8683c28ff5272c76ea055ba4e2870d9d8236082)]
 - test: update snaphots [kreafox - [`de0506a`](https://github.com/eea/volto-cca-policy/commit/de0506a81fd5e224bb1d4dd27109ae4d07fe919c)]
 - test: update snaphots [kreafox - [`1fee9fe`](https://github.com/eea/volto-cca-policy/commit/1fee9fec29b08aa06d40c88722fb2a032ce63019)]
 - test: Update to volto 17 PR30 [valentinab25 - [`ed03286`](https://github.com/eea/volto-cca-policy/commit/ed032865efa051d6353844737616019b202ea562)]
 - test: update snapshots [ana-oprea - [`94608ad`](https://github.com/eea/volto-cca-policy/commit/94608adc1b3b3655c7ecd5c39dde1f0fcd4b41e9)]
 - test: Update to volto 17 PR30 [valentinab25 - [`2e81033`](https://github.com/eea/volto-cca-policy/commit/2e810334e08366ca77ba62383c064770dde643a1)]
+### [0.3.65](https://github.com/eea/volto-cca-policy/compare/0.3.64...0.3.65) - 16 July 2025
+
+#### :rocket: Dependency updates
+
+- Release @eeacms/volto-searchlib@2.1.0 [EEA Jenkins - [`e5fc813`](https://github.com/eea/volto-cca-policy/commit/e5fc813f97922df335be28673d6303cb81b3c888)]
+
+#### :nail_care: Enhancements
+
+- change(header): add sitemap link - refs #288920 [kreafox - [`0b51b76`](https://github.com/eea/volto-cca-policy/commit/0b51b7649a13f250390cc78e88f6946d370c4c59)]
+- change: add archived info message on DefaultView - refs #289794 [kreafox - [`7005f0d`](https://github.com/eea/volto-cca-policy/commit/7005f0dcc653f2fd85713b12cb9fa75be97943c7)]
+
+#### :house: Internal changes
+
+- chore: i18n [kreafox - [`5ffe66e`](https://github.com/eea/volto-cca-policy/commit/5ffe66e22b34f9451b01db1f4578037e03e1415f)]
+
+#### :hammer_and_wrench: Others
+
+- test: improve security hotspots on sonarqube - refs #289841 [kreafox - [`2259d69`](https://github.com/eea/volto-cca-policy/commit/2259d696fe8c3ef2e1b3d49959d314556ceae501)]
 ### [0.3.64](https://github.com/eea/volto-cca-policy/compare/0.3.63...0.3.64) - 11 July 2025
 
 #### :rocket: New Features

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@eeacms/volto-cca-policy",
-  "version": "0.3.65",
+  "version": "0.3.66",
   "description": "@eeacms/volto-cca-policy: Volto add-on",
   "main": "src/index.js",
   "author": "European Environment Agency: IDM2 A-Team",

package/src/components/theme/Header/Header.jsx

@@ -26,7 +26,10 @@ import cx from 'classnames';
 import eeaFlag from '@eeacms/volto-eea-design-system/../theme/themes/eea/assets/images/Header/eea.png';
 
 function removeTrailingSlash(path) {
-  return path.replace(/\/+$/, '');
+  while (path.endsWith('/')) {
+    path = path.slice(0, -1);
+  }
+  return path;
 }
 
 /**

package/src/components/theme/Header/LanguageSwitch.jsx

@@ -20,8 +20,8 @@ export default function LanguageSwitch({ history }) {
   );
   const [, setSelectedLanguage] = useAtom(selectedLanguageAtom);
   const width = useSelector((state) => state.screen?.width);
-
   const currentLang = useSelector((state) => state.intl.locale);
+
   const [language, setLanguage] = React.useState(
     currentLang || eea.defaultLanguage,
   );
@@ -45,7 +45,43 @@ export default function LanguageSwitch({ history }) {
     });
   };
 
-  // .filter((item) => eea.non_eu_langs.indexOf(item.code) !== -1)
+  const renderLanguageItems = (languages) =>
+    languages.map((item, index) => {
+      const translated = (translations || []).some(
+        (obj) => obj.language === item.code,
+      );
+      const active = item.code === currentLang;
+      const disabled = !translated && !active;
+
+      return (
+        <Dropdown.Item
+          className={cx({
+            disabled: disabled,
+            active: active,
+          })}
+          as="li"
+          key={index}
+          text={
+            <span>
+              <span className="country-code">{item.code.toUpperCase()}</span>{' '}
+              {item.name}
+            </span>
+          }
+          onClick={(e) =>
+            disabled || active ? e.preventDefault() : handlePageRedirect(item)
+          }
+        />
+      );
+    });
+
+  const euLanguages = eea.languages.filter(
+    (item) => eea.non_eu_langs.indexOf(item.code) === -1,
+  );
+
+  const nonEuLanguages = eea.languages.filter(
+    (item) => eea.non_eu_langs.indexOf(item.code) !== -1,
+  );
+
   return (
     <Header.TopDropdownMenu
       id="language-switcher"
@@ -56,7 +92,7 @@ export default function LanguageSwitch({ history }) {
       }
       text={`${language.toUpperCase()}`}
       mobileText={`${language.toUpperCase()}`}
-      icon={<Image src={globeIcon} alt="language dropdown globe icon"></Image>}
+      icon={<Image src={globeIcon} alt="language dropdown globe icon" />}
       viewportWidth={width}
     >
       <ul
@@ -64,39 +100,8 @@ export default function LanguageSwitch({ history }) {
         role="listbox"
         aria-label="language switcher"
       >
-        {eea.languages
-          .filter((item) => eea.non_eu_langs.indexOf(item.code) === -1)
-          .map((item, index) => {
-            const translated = (translations || []).some(
-              (obj) => obj.language === item.code,
-            );
-            const active = item.code === currentLang;
-            const disabled = !translated && !active;
+        {renderLanguageItems(euLanguages)}
 
-            return (
-              <Dropdown.Item
-                className={cx({
-                  disabled: disabled,
-                  active: active,
-                })}
-                as="li"
-                key={index}
-                text={
-                  <span>
-                    <span className="country-code">
-                      {item.code.toUpperCase()}
-                    </span>{' '}
-                    {item.name}
-                  </span>
-                }
-                onClick={(e) =>
-                  disabled || active
-                    ? e.preventDefault()
-                    : handlePageRedirect(item)
-                }
-              ></Dropdown.Item>
-            );
-          })}
         <strong className="noneu-langs-label">
           <FormattedMessage
             id="Non-EU Languages"
@@ -104,39 +109,7 @@ export default function LanguageSwitch({ history }) {
           />
         </strong>
 
-        {eea.languages
-          .filter((item) => eea.non_eu_langs.indexOf(item.code) !== -1)
-          .map((item, index) => {
-            const translated = (translations || []).some(
-              (obj) => obj.language === item.code,
-            );
-            const active = item.code === currentLang;
-            const disabled = !translated && !active;
-
-            return (
-              <Dropdown.Item
-                className={cx({
-                  disabled: disabled,
-                  active: active,
-                })}
-                as="li"
-                key={index}
-                text={
-                  <span>
-                    <span className="country-code">
-                      {item.code.toUpperCase()}
-                    </span>{' '}
-                    {item.name}
-                  </span>
-                }
-                onClick={(e) =>
-                  disabled || active
-                    ? e.preventDefault()
-                    : handlePageRedirect(item)
-                }
-              ></Dropdown.Item>
-            );
-          })}
+        {renderLanguageItems(nonEuLanguages)}
       </ul>
     </Header.TopDropdownMenu>
   );

package/src/components/theme/ImageGallery/ImageGallery.jsx

@@ -89,10 +89,10 @@ const ImageGallery = (props) => {
           <Slider {...carouselSettings} ref={sliderRef}>
             {items.map((item, i) => {
               return image.rights ? (
-                <div>
+                <div key={i}>
                   <div className="image-slide">
                     <div className="image-rights">@ {image.rights}</div>
-                    <Image key={i} src={item.url} alt={item?.title} />
+                    <Image src={item.url} alt={item?.title} />
                   </div>
                 </div>
               ) : (

package/src/components/theme/ImageGallery/ImageGallery.test.jsx

@@ -0,0 +1,38 @@
+import '@testing-library/jest-dom';
+import { render, screen, fireEvent } from '@testing-library/react';
+import ImageGallery from './ImageGallery';
+
+jest.mock('react-slick', () => (props) => <div>React Slick Gallery</div>);
+
+const mockItems = [
+  {
+    url: 'https://example.com/image1.jpg',
+    title: 'Image One',
+    description: 'First image description',
+    rights: 'Author One',
+  },
+  {
+    url: 'https://example.com/image2.jpg',
+    title: 'Image Two',
+    description: 'Second image description',
+    rights: 'Author Two',
+  },
+];
+
+describe('ImageGallery', () => {
+  it('renders preview image and opens modal on click', () => {
+    render(<ImageGallery items={mockItems} />);
+
+    const previewImage = screen.getByRole('img', { name: /Image One/i });
+    expect(previewImage).toBeInTheDocument();
+
+    expect(
+      screen.queryByText('First image description'),
+    ).not.toBeInTheDocument();
+
+    fireEvent.click(previewImage);
+
+    expect(screen.getByText('Image One')).toBeInTheDocument();
+    expect(screen.getByText('First image description')).toBeInTheDocument();
+  });
+});

package/src/components/theme/PortalMessage/PortalMessage.test.jsx

@@ -0,0 +1,24 @@
+import { render } from '@testing-library/react';
+import PortalMessage from './PortalMessage';
+import { IntlProvider } from 'react-intl';
+import '@testing-library/jest-dom';
+
+const renderWithIntl = (ui) =>
+  render(<IntlProvider locale="en">{ui}</IntlProvider>);
+
+describe('PortalMessage', () => {
+  it('renders the message component when content is archived', () => {
+    const content = { review_state: 'archived' };
+    const { container } = renderWithIntl(<PortalMessage content={content} />);
+
+    const messageEl = container.querySelector('.ui.message');
+    expect(messageEl).toBeInTheDocument();
+  });
+
+  it('renders nothing when content is not archived', () => {
+    const content = { review_state: 'published' };
+    const { container } = renderWithIntl(<PortalMessage content={content} />);
+
+    expect(container).toBeEmptyDOMElement();
+  });
+});

package/src/components/theme/Widgets/PromotionalImageWidget.jsx

@@ -72,6 +72,24 @@ const messages = defineMessages({
  * ```
  *
  */
+function parseDataURL(dataUrl) {
+  if (!dataUrl.startsWith('data:')) return null;
+
+  const commaIndex = dataUrl.indexOf(',');
+  if (commaIndex === -1) return null;
+
+  const meta = dataUrl.slice(5, commaIndex);
+  const data = dataUrl.slice(commaIndex + 1);
+
+  const [contentType, encoding] = meta.split(';');
+
+  return {
+    'content-type': contentType || '',
+    encoding: encoding || '',
+    data: data || '',
+  };
+}
+
 const FileWidget = (props) => {
   const { id, value, onChange, isDisabled } = props;
   const [fileType, setFileType] = React.useState(false);
@@ -99,27 +117,31 @@ const FileWidget = (props) => {
     const file = files[0];
     if (!validateFileUploadSize(file, intl.formatMessage)) return;
     readAsDataURL(file).then((data) => {
-      const fields = data.match(/^data:(.*);(.*),(.*)$/);
-      onChange(id, {
-        data: fields[3],
-        encoding: fields[2],
-        'content-type': fields[1],
-        filename: file.name,
-      });
+      const fields = parseDataURL(data);
+      if (fields) {
+        onChange(id, {
+          data: fields.data,
+          encoding: fields.encoding,
+          'content-type': fields['content-type'],
+          filename: file.name,
+        });
+      }
     });
 
-    let reader = new FileReader();
+    const reader = new FileReader();
     reader.onload = function () {
-      const fields = reader.result.match(/^data:(.*);(.*),(.*)$/);
-      if (imageMimetypes.includes(fields[1])) {
+      const parsed = parseDataURL(reader.result);
+      if (parsed && imageMimetypes.includes(parsed['content-type'])) {
         setFileType(true);
-        let imagePreview = document.getElementById(`field-${id}-image`);
-        imagePreview.src = reader.result;
+        const imagePreview = document.getElementById(`field-${id}-image`);
+        if (imagePreview) {
+          imagePreview.src = reader.result;
+        }
       } else {
         setFileType(false);
       }
     };
-    reader.readAsDataURL(files[0]);
+    reader.readAsDataURL(file);
   };
 
   return (

package/src/index.js

@@ -522,7 +522,7 @@ const applyConfig = (config) => {
     },
     {
       match: {
-        path: /(.*)\/add$/,
+        path: /^.*\/add$/,
       },
       component: RedirectToLogin,
     },
@@ -532,13 +532,13 @@ const applyConfig = (config) => {
     ...config.settings.apiExpanders,
     {
       match: {
-        path: /(.*)\/policy-context\/country-profiles\/(.*)/,
+        path: /\/policy-context\/country-profiles\/.+/,
       },
       GET_CONTENT: ['siblings'],
     },
     {
       match: {
-        path: /(.*)\/countries-regions\/countries\/(.*)/,
+        path: /\/countries-regions\/countries\/.+/,
       },
       GET_CONTENT: ['siblings'],
     },

package/src/utils.js

@@ -101,6 +101,15 @@ export const formatTextToHTML = (text) => {
     : `<p>${formattedText}</p>`;
 };
 
+const trimTrailingChars = (str) => {
+  const charsToTrim = ['-', '–', ';', ',', ':', ' '];
+  let end = str.length;
+  while (end > 0 && charsToTrim.includes(str[end - 1])) {
+    end--;
+  }
+  return str.substring(0, end);
+};
+
 export const extractPlanNameAndURL = (text) => {
   if (!text) return { name: '', url: '' };
 
@@ -114,12 +123,8 @@ export const extractPlanNameAndURL = (text) => {
 
   if (url) {
     // Remove URL and any punctuation before it
-    name = name
-      .replace(`(${url})`, '')
-      .replace(url, '')
-      .replace(/[-–;,:\s]+$/, '')
-      .replace(/[-–;,:\s]+$/, '')
-      .trim();
+    name = name.replace(`(${url})`, '').replace(url, '');
+    name = trimTrailingChars(name).trim();
   }
 
   return {