@eeacms/volto-cca-policy 0.3.53 → 0.3.54

package/CHANGELOG.md

@@ -4,6 +4,29 @@ All notable changes to this project will be documented in this file. Dates are d
 
 Generated by [`auto-changelog`](https://github.com/CookPete/auto-changelog).
 
+### [0.3.54](https://github.com/eea/volto-cca-policy/compare/0.3.53...0.3.54) - 24 June 2025
+
+#### :bug: Bug Fixes
+
+- fix(mission): add more checks; code cleanup [kreafox - [`35bb513`](https://github.com/eea/volto-cca-policy/commit/35bb513dfb124e8001a3743680176c6b9643b0ac)]
+
+#### :nail_care: Enhancements
+
+- change(view): remove draft background on archived items; add portal message - refs #289196 [kreafox - [`a5aa7b5`](https://github.com/eea/volto-cca-policy/commit/a5aa7b53284faced93b8c1ae0751a64743347183)]
+- change(view): remove archived item info message - refs #289196 [kreafox - [`b65e876`](https://github.com/eea/volto-cca-policy/commit/b65e876efae651c30d2d0e7a91ee7839ed904d90)]
+- change(mission): small refactoring [kreafox - [`58e51ee`](https://github.com/eea/volto-cca-policy/commit/58e51ee704efd42671c9e360c74f7d930ceda604)]
+
+#### :house: Internal changes
+
+- chore: update package.json [kreafox - [`5b6449b`](https://github.com/eea/volto-cca-policy/commit/5b6449b5167a72fd49d3ff7c17ac50d95a302da2)]
+
+#### :hammer_and_wrench: Others
+
+- test: increase coverage [kreafox - [`9b97e31`](https://github.com/eea/volto-cca-policy/commit/9b97e3164c8fe8122d18d39b667144133c669ada)]
+- test: increase coverage [kreafox - [`63170f2`](https://github.com/eea/volto-cca-policy/commit/63170f29afef7176910a96dee906df74953329a0)]
+- Don't need the migration buttons anymore [Tiberiu Ichim - [`98d0812`](https://github.com/eea/volto-cca-policy/commit/98d08124818dd7dff1f4c41c3fc98fde9c84d06f)]
+- update tests [kreafox - [`e4c1992`](https://github.com/eea/volto-cca-policy/commit/e4c1992da98dd30718884c1d0b228db4ef6f4180)]
+- Redirect without ++api++ [Tiberiu Ichim - [`f268921`](https://github.com/eea/volto-cca-policy/commit/f268921307ff0f08a1f15e20db3c08bfe261260c)]
 ### [0.3.53](https://github.com/eea/volto-cca-policy/compare/0.3.52...0.3.53) - 28 May 2025
 
 ### [0.3.52](https://github.com/eea/volto-cca-policy/compare/0.3.51...0.3.52) - 27 May 2025

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@eeacms/volto-cca-policy",
-  "version": "0.3.53",
+  "version": "0.3.54",
   "description": "@eeacms/volto-cca-policy: Volto add-on",
   "main": "src/index.js",
   "author": "European Environment Agency: IDM2 A-Team",
@@ -34,7 +34,7 @@
     "@eeacms/volto-embed": "^9.1.1",
     "@eeacms/volto-globalsearch": "2.1.2",
     "@eeacms/volto-hero-block": "^7.1.0",
-    "@eeacms/volto-openlayers-map": "github:eea/volto-openlayers-map#1.0.0-alpha.1",
+    "@eeacms/volto-openlayers-map": "1.0.0",
     "@eeacms/volto-searchlib": "2.0.16",
     "@eeacms/volto-slate-label": "^0.6.0",
     "@eeacms/volto-tabs-block": "^7.5.1",

package/src/components/manage/Blocks/ReadMore/ReadMoreView.test.jsx

@@ -0,0 +1,26 @@
+import '@testing-library/jest-dom/extend-expect';
+import { render, screen, fireEvent } from '@testing-library/react';
+import ReadMoreView from './ReadMoreView';
+
+describe('ReadMoreView', () => {
+  it('renders with default labels and toggles on click', () => {
+    const data = {
+      label_closed: 'Show more',
+      label_opened: 'Show less',
+      label_position: 'left',
+      height: '200px',
+    };
+
+    const { container } = render(<ReadMoreView data={data} mode="view" />);
+
+    expect(screen.getByText('Show more')).toBeInTheDocument();
+
+    fireEvent.click(screen.getByRole('button'));
+    expect(screen.getByText('Show less')).toBeInTheDocument();
+
+    fireEvent.click(screen.getByRole('button'));
+    expect(screen.getByText('Show more')).toBeInTheDocument();
+
+    expect(container).toBeTruthy();
+  });
+});

package/src/components/manage/Blocks/TransRegionSelect/TransRegionSelectView.test.jsx

@@ -0,0 +1,90 @@
+import '@testing-library/jest-dom/extend-expect';
+import { render, screen } from '@testing-library/react';
+import { MemoryRouter } from 'react-router-dom';
+import { Provider } from 'react-intl-redux';
+import configureStore from 'redux-mock-store';
+import TransRegionSelectView from './TransRegionSelectView';
+
+const mockStore = configureStore();
+
+describe('TransRegionSelectView', () => {
+  it('renders in view mode with regions and countries', () => {
+    const store = mockStore({
+      intl: {
+        locale: 'en',
+        messages: {},
+      },
+    });
+
+    const mockProps = {
+      data: {
+        title: 'Transnational Region',
+      },
+      metadata: {
+        title: 'Sample Region',
+        '@components': {
+          transnationalregion: {
+            regions: [
+              { title: 'Region A', url: '/region-a' },
+              { title: 'Region B', url: '/region-b' },
+            ],
+            countries: [
+              [
+                ['Country X', '/country-x'],
+                ['Country Y', '/country-y'],
+              ],
+            ],
+          },
+        },
+      },
+    };
+
+    render(
+      <Provider store={store}>
+        <MemoryRouter>
+          <TransRegionSelectView {...mockProps} />
+        </MemoryRouter>
+      </Provider>,
+    );
+
+    // Dropdown should appear
+    expect(screen.getByText('Choose a region')).toBeInTheDocument();
+
+    // Title should render
+    expect(screen.getByText('Transnational Region')).toBeInTheDocument();
+
+    // Countries should be rendered as links
+    expect(screen.getByText('Country X,')).toBeInTheDocument();
+    expect(screen.getByText('Country Y')).toBeInTheDocument();
+
+    // Dropdown options should exist
+    expect(screen.getByText('Region A')).toBeInTheDocument();
+    expect(screen.getByText('Region B')).toBeInTheDocument();
+  });
+
+  it('renders edit mode correctly', () => {
+    const store = mockStore({
+      intl: {
+        locale: 'en',
+        messages: {},
+      },
+    });
+
+    const mockProps = {
+      mode: 'edit',
+      data: {
+        region: 'Region A',
+      },
+    };
+
+    const { container } = render(
+      <Provider store={store}>
+        <MemoryRouter>
+          <TransRegionSelectView {...mockProps} />
+        </MemoryRouter>
+      </Provider>,
+    );
+
+    expect(container).toHaveTextContent('TransRegionSelectView: Region A');
+  });
+});

package/src/components/theme/MissionSignatoryProfile/NoDataReported.jsx

@@ -0,0 +1,9 @@
+import { Tab } from 'semantic-ui-react';
+
+const NoDataReported = ({ label }) => (
+  <Tab.Pane>
+    <h5>{label}</h5>
+  </Tab.Pane>
+);
+
+export default NoDataReported;

package/src/components/theme/MissionSignatoryProfile/TabSections/ActionPagesTab.jsx

@@ -1,10 +1,9 @@
 import { Tab, Grid } from 'semantic-ui-react';
 import { Callout } from '@eeacms/volto-eea-design-system/ui';
 import { HTMLField } from '@eeacms/volto-cca-policy/helpers';
-import { formatTextToHTML } from '@eeacms/volto-cca-policy/utils';
+import { formatTextToHTML, isEmpty } from '@eeacms/volto-cca-policy/utils';
 import AccordionList from '../AccordionList';
-
-const isEmpty = (arr) => !Array.isArray(arr) || arr.length === 0;
+import NoDataReported from '../NoDataReported';
 
 const ActionsTabContent = ({ action }) => {
   const hasHazards = action?.Climate_Hazards?.length > 0;
@@ -77,11 +76,7 @@ const ActionPagesTab = ({ result, general_text }) => {
   const NoResults = isEmpty(action_text) && isEmpty(actions);
 
   if (NoResults) {
-    return (
-      <Tab.Pane>
-        <p>{No_Data_Reported_Label}</p>
-      </Tab.Pane>
-    );
+    return <NoDataReported label={No_Data_Reported_Label} />;
   }
 
   return (

package/src/components/theme/MissionSignatoryProfile/TabSections/ActionPagesTab.test.jsx

@@ -6,6 +6,11 @@ jest.mock('@eeacms/volto-eea-design-system/ui', () => ({
   Callout: ({ children }) => <div>{children}</div>,
 }));
 
+jest.mock('@eeacms/volto-cca-policy/utils', () => ({
+  isEmpty: (arr) => !arr || arr.length === 0,
+  formatTextToHTML: (text) => text,
+}));
+
 jest.mock('./../AccordionList', () => ({ variation, accordions }) => (
   <div>
     {accordions.map((item, index) => (

package/src/components/theme/MissionSignatoryProfile/TabSections/AssessmentTab.jsx

@@ -1,13 +1,12 @@
 import { Tab, Image, Segment, Item } from 'semantic-ui-react';
 import { Callout } from '@eeacms/volto-eea-design-system/ui';
 import { HTMLField } from '@eeacms/volto-cca-policy/helpers';
-import { formatTextToHTML } from '@eeacms/volto-cca-policy/utils';
+import { formatTextToHTML, isEmpty } from '@eeacms/volto-cca-policy/utils';
 import AccordionList from '../AccordionList';
+import NoDataReported from '../NoDataReported';
 
 import image from '@eeacms/volto-cca-policy/../theme//assets/images/image-narrow.svg';
 
-const isEmpty = (arr) => !Array.isArray(arr) || arr.length === 0;
-
 const ItemsSection = ({ items }) => {
   if (!items?.length) return null;
 
@@ -61,7 +60,6 @@ const AssessmentTab = ({ result, general_text }) => {
   const assessment_risks = result.assessment_risks || [];
   const assessment_hazards_sectors = result.assessment_hazards_sectors || [];
   const { No_Data_Reported_Label } = general_text || {};
-  // const [activeIndex, setActiveIndex] = React.useState(0);
 
   const NoResults =
     isEmpty(result.assessment_text) &&
@@ -70,11 +68,7 @@ const AssessmentTab = ({ result, general_text }) => {
     isEmpty(result.assessment_hazards_sectors);
 
   if (NoResults) {
-    return (
-      <Tab.Pane>
-        <p>{No_Data_Reported_Label}</p>
-      </Tab.Pane>
-    );
+    return <NoDataReported label={No_Data_Reported_Label} />;
   }
 
   return (
@@ -90,32 +84,39 @@ const AssessmentTab = ({ result, general_text }) => {
 
       <div className="tab-section-wrapper assessment">
         {Cra_Title && <h3>{Cra_Title}</h3>}
-        {Cra_Abstract && <h5>{Cra_Abstract}</h5>}
-
-        <ItemsSection items={result.assessment_factors} />
-
-        {Attachments && <h4>{Attachments}</h4>}
-
-        {assessment_risks.map((risk, index) => {
-          const title = risk?.Attachment_Title
-            ? `${risk.Assessment_Id}. ${risk.Attachment_Title} - ${
-                risk.Year_Of_Publication || ''
-              }`
-            : null;
-          return (
-            <div key={index}>
-              <AccordionList
-                variation="tertiary"
-                accordions={[
-                  {
-                    title: title,
-                    content: <AssessmentAccordionContent result={risk} />,
-                  },
-                ]}
-              />
-            </div>
-          );
-        })}
+
+        {result.assessment_factors.length > 0 && (
+          <>
+            {Cra_Abstract && <h5>{Cra_Abstract}</h5>}
+            <ItemsSection items={result.assessment_factors} />
+          </>
+        )}
+
+        {assessment_risks.length > 0 && (
+          <>
+            {Attachments && <h4>{Attachments}</h4>}
+            {assessment_risks.map((risk, index) => {
+              const title = risk?.Attachment_Title
+                ? `${risk.Assessment_Id}. ${risk.Attachment_Title} - ${
+                    risk.Year_Of_Publication || ''
+                  }`
+                : null;
+              return (
+                <div key={index}>
+                  <AccordionList
+                    variation="tertiary"
+                    accordions={[
+                      {
+                        title: title,
+                        content: <AssessmentAccordionContent result={risk} />,
+                      },
+                    ]}
+                  />
+                </div>
+              );
+            })}
+          </>
+        )}
       </div>
 
       {Hazards_Title && <h3>{Hazards_Title}</h3>}
@@ -140,59 +141,6 @@ const AssessmentTab = ({ result, general_text }) => {
           }))}
         />
       )}
-
-      {/* <Tab
-        menu={{
-          fluid: true,
-          className: 'secondary',
-          vertical: true,
-          pointing: true,
-        }}
-        grid={{ paneWidth: 9, tabWidth: 3, stackable: true }}
-        activeIndex={activeIndex}
-        onTabChange={(e, { activeIndex }) => setActiveIndex(activeIndex)}
-        panes={[
-          {
-            menuItem: 'Water related',
-            render: () => (
-              <AccordionList
-                accordions={[
-                  {
-                    title: 'Vestibulum ante ipsum primis',
-                    content: 'No additional details provided.',
-                  },
-                  {
-                    title: 'Etiam accumsan urna a mauris',
-                    content: 'No additional details provided.',
-                  },
-                ]}
-              />
-            ),
-          },
-          {
-            menuItem: 'Heat related',
-            render: () => (
-              <div>
-                Nam tempor finibus lorem, nec varius arcu convallis sed. Nunc id
-                orci a neque vehicula malesuada. Donec vehicula libero vel leo
-                convallis, nec tincidunt felis tincidunt. Maecenas euismod
-                tristique leo, vel malesuada ligula malesuada sed.
-              </div>
-            ),
-          },
-          {
-            menuItem: 'Other hazards',
-            render: () => (
-              <div>
-                Nam tempor finibus lorem, nec varius arcu convallis sed. Nunc id
-                orci a neque vehicula malesuada. Donec vehicula libero vel leo
-                convallis, nec tincidunt felis tincidunt. Maecenas euismod
-                tristique leo, vel malesuada ligula malesuada sed.
-              </div>
-            ),
-          },
-        ]}
-      /> */}
     </Tab.Pane>
   );
 };

package/src/components/theme/MissionSignatoryProfile/TabSections/AssessmentTab.test.jsx

@@ -6,6 +6,11 @@ jest.mock('@eeacms/volto-eea-design-system/ui', () => ({
   Callout: ({ children }) => <div>{children}</div>,
 }));
 
+jest.mock('@eeacms/volto-cca-policy/utils', () => ({
+  isEmpty: (arr) => !arr || arr.length === 0,
+  formatTextToHTML: (text) => text,
+}));
+
 const mockData = {
   assessment_text: [
     {

package/src/components/theme/MissionSignatoryProfile/TabSections/PlanningTab.jsx

@@ -5,12 +5,12 @@ import { HTMLField } from '@eeacms/volto-cca-policy/helpers';
 import {
   formatTextToHTML,
   extractPlanNameAndURL,
+  isEmpty,
 } from '@eeacms/volto-cca-policy/utils';
 import AccordionList from '../AccordionList';
+import NoDataReported from '../NoDataReported';
 import image from '@eeacms/volto-cca-policy/../theme/assets/images/image-narrow.svg';
 
-const isEmpty = (arr) => !Array.isArray(arr) || arr.length === 0;
-
 const ItemsSection = ({ items }) => {
   if (!items?.length) return null;
 
@@ -94,11 +94,7 @@ const PlanningTab = ({ result, general_text }) => {
     isEmpty(planning_climate_action);
 
   if (NoResults) {
-    return (
-      <Tab.Pane>
-        <p>{No_Data_Reported_Label}</p>
-      </Tab.Pane>
-    );
+    return <NoDataReported label={No_Data_Reported_Label} />;
   }
 
   return (

package/src/components/theme/MissionSignatoryProfile/TabSections/PlanningTab.test.jsx

@@ -9,6 +9,7 @@ jest.mock('@eeacms/volto-cca-policy/helpers', () => ({
 }));
 
 jest.mock('@eeacms/volto-cca-policy/utils', () => ({
+  isEmpty: (arr) => !arr || arr.length === 0,
   formatTextToHTML: (text) => text,
   extractPlanNameAndURL: (str) => ({
     name: 'Plan Example',

package/src/components/theme/Views/EventView.jsx

@@ -28,9 +28,8 @@ function EventView(props) {
 
   return (
     <div className="cca-event-view">
-      <PortalMessage content={content} />
-
       <Container>
+        <PortalMessage content={content} />
         <Grid columns="12">
           <Grid.Row>
             <Grid.Column mobile={12} tablet={12} computer={8}>

package/src/components/theme/Views/NewsItemView.jsx

@@ -1,8 +1,8 @@
 import React from 'react';
 import { Container } from 'semantic-ui-react';
 import { filterBlocks } from '@eeacms/volto-cca-policy/utils';
-import { PortalMessage } from '@eeacms/volto-cca-policy/components';
 import { HTMLField, SubjectTags } from '@eeacms/volto-cca-policy/helpers';
+import { PortalMessage } from '@eeacms/volto-cca-policy/components';
 import RenderBlocks from '@plone/volto/components/theme/View/RenderBlocks';
 import { UniversalLink } from '@plone/volto/components';
 

package/src/components/theme/Views/ProjectView.jsx

@@ -11,6 +11,7 @@ import {
   ShareInfoButton,
   PortalMessage,
 } from '@eeacms/volto-cca-policy/components';
+
 import { FormattedMessage } from 'react-intl';
 
 import config from '@plone/volto/registry';

package/src/index.js

@@ -22,9 +22,7 @@ import C3SIndicatorView from './components/theme/Views/C3SIndicatorView';
 import DatabaseItemView from './components/theme/Views/DatabaseItemView';
 
 import GeocharsWidget from './components/theme/Widgets/GeocharsWidget';
-// import GeolocationWidget from './components/theme/Widgets/GeolocationWidget';
 import PromotionalImageWidget from './components/theme/Widgets/PromotionalImageWidget';
-import MigrationButtons from './components/MigrationButtons';
 import HealthHorizontalCardItem from './components/Result/HealthHorizontalCardItem';
 import ClusterHorizontalCardItem from './components/Result/ClusterHorizontalCardItem';
 
@@ -45,6 +43,9 @@ import BrokenLinks from './components/theme/Views/BrokenLinks';
 
 import { eea_languages, non_eu_langs } from './constants';
 
+// import GeolocationWidget from './components/theme/Widgets/GeolocationWidget';
+// import MigrationButtons from './components/MigrationButtons';
+
 const getEnv = () => (typeof window !== 'undefined' ? window.env : process.env);
 
 const pathToNegRegex = (p) => `(?!(${p}))`;
@@ -511,10 +512,10 @@ const applyConfig = (config) => {
 
   config.settings.appExtras = [
     ...(config.settings.appExtras || []),
-    {
-      match: '',
-      component: MigrationButtons,
-    },
+    // {
+    //   match: '',
+    //   component: MigrationButtons,
+    // },
     {
       match: '',
       component: TranslationDisclaimer,

package/src/store/middleware.js

@@ -16,6 +16,13 @@ export const langRedirection = ({ dispatch, getState }) => (next) => (
       const urlParams = new URLSearchParams(queryString);
       const hasLanguageQueryParam = urlParams.has('set_language');
 
+      // sometimes there's Links where the target has moved
+      const nonApiPathname = pathname.replaceAll('++api++', '');
+      if (nonApiPathname !== pathname) {
+        action.payload.location.pathname = nonApiPathname;
+        window.history.replaceState(window.history.state, '', nonApiPathname);
+      }
+
       if (
         locale !== 'en' &&
         !isSearchPage &&

package/src/utils.js

@@ -127,3 +127,5 @@ export const extractPlanNameAndURL = (text) => {
     url,
   };
 };
+
+export const isEmpty = (arr) => !Array.isArray(arr) || arr.length === 0;

package/theme/globals/views.less

@@ -335,3 +335,8 @@ hr {
   border-radius: 4px;
   border: 1px solid #e5e5e5;
 }
+
+
+body.view-viewview.wf-state-is-draft {
+  background-image: none !important;
+}