@eeacms/volto-cca-policy 0.3.121 → 0.3.122

package/CHANGELOG.md

@@ -4,6 +4,20 @@ All notable changes to this project will be documented in this file. Dates are d
 
 Generated by [`auto-changelog`](https://github.com/CookPete/auto-changelog).
 
+### [0.3.122](https://github.com/eea/volto-cca-policy/compare/0.3.121...0.3.122) - 8 May 2026
+
+#### :bug: Bug Fixes
+
+- fix: add image fallback & improvements in RSS middleware [kreafox - [`6e6091a`](https://github.com/eea/volto-cca-policy/commit/6e6091a2e72c53fd37489fc959f5c1083e99c84e)]
+
+#### :house: Internal changes
+
+- style: Automated code fix [eea-jenkins - [`278f8b4`](https://github.com/eea/volto-cca-policy/commit/278f8b49ae0c56ce7a705a2eea8a6ff3373e6dff)]
+
+#### :house: Documentation changes
+
+- docs: update README.md [kreafox - [`5d810e1`](https://github.com/eea/volto-cca-policy/commit/5d810e1385c22d481fd14977c8c69dcecd16f70e)]
+
 ### [0.3.121](https://github.com/eea/volto-cca-policy/compare/0.3.120...0.3.121) - 7 May 2026
 
 #### :rocket: New Features

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@eeacms/volto-cca-policy",
-  "version": "0.3.121",
+  "version": "0.3.122",
   "description": "@eeacms/volto-cca-policy: Volto add-on",
   "main": "src/index.js",
   "author": "European Environment Agency: IDM2 A-Team",

package/src/customizations/@plone-collective/volto-rss-provider/README.md

@@ -1,3 +1,5 @@
-## RSS sort_order customization
+## RSS middleware customization
 
 This customization patches the `volto-rss-provider` middleware to correctly handle reversed sorting in RSS Listing block queries.
+
+It also fixes image handling so items with small lead images or missing `preview` scales do not break the entire feed; those items remain in the RSS output, but their image enclosure is skipped.

package/src/customizations/@plone-collective/volto-rss-provider/express-middleware.js

@@ -1,7 +1,7 @@
 import express from 'express';
 import superagent from 'superagent';
 import RSS from 'rss';
-import { findBlocks, toPublicURL } from '@plone/volto/helpers';
+import { findBlocks } from '@plone/volto/helpers';
 import config from '@plone/volto/registry';
 
 /**
@@ -26,75 +26,82 @@ import config from '@plone/volto/registry';
  *
  * @function getRssFeedData
  * @param {string} apiPath - The base path for the API requests.
- * @param {string} APISUFIX - The suffix added to the API path depending on the environment.
+ * @param {string} APISUFFIX - The suffix added to the API path depending on the environment.
  * @param {Object} req - The incoming Express request object.
  * @param {Object} settings - Configuration settings for the application.
  * @return {Object} An object containing the query data, language, description, and title of the rss_feed.
  * @throws Will throw an error if no query data is found in the listing block or if the request fails.
  */
-async function getRssFeedData(apiPath, APISUFIX, req, settings) {
-  try {
-    const request = superagent
-      .get(
-        `${apiPath}${__DEVELOPMENT__ ? '' : APISUFIX}${req.path.replace(
-          '/rss.xml',
-          '',
-        )}`,
-      )
-      .accept('json');
+async function getRssFeedData(apiPath, APISUFFIX, req, settings) {
+  const request = superagent
+    .get(
+      `${apiPath}${__DEVELOPMENT__ ? '' : APISUFFIX}${req.path.replace(
+        '/rss.xml',
+        '',
+      )}`,
+    )
+    .accept('json');
 
-    const authToken = req.universalCookies.get('auth_token');
-    if (authToken) {
-      request.set('Authorization', `Bearer ${authToken}`);
-    }
+  const authToken = req.universalCookies.get('auth_token');
+  if (authToken) {
+    request.set('Authorization', `Bearer ${authToken}`);
+  }
 
-    const response = await request;
-    const json = JSON.parse(JSON.stringify(response.body));
-    const listingBlock = findBlocks(json.blocks, 'listing');
-    let queryData = json.blocks[listingBlock]?.querystring;
-    let language = json.language.token ?? 'en';
-    let description = json.description ?? 'A Volto RSS Feed';
-    let title = json.title;
-    let subjects = json.subjects;
-    let date = json.effective;
-    let max_description_length = json.max_description_length;
-    let max_title_length = json.max_title_length;
-    if (!queryData) {
-      throw new Error('No query data found in listing block');
-    }
+  const response = await request;
+  const json = response.body;
+  const listingBlocks = findBlocks(json.blocks, 'listing');
+  const listingBlockId = Array.isArray(listingBlocks)
+    ? listingBlocks[0]
+    : listingBlocks;
 
-    if (queryData?.sort_order !== null) {
-      if (typeof queryData.sort_order === 'boolean') {
-        queryData.sort_order = queryData.sort_order ? 'reverse' : 'ascending';
-      }
+  const queryData = listingBlockId
+    ? json.blocks?.[listingBlockId]?.querystring
+    : null;
+  const language = json.language?.token ?? 'en';
+  const description = json.description ?? 'A Volto RSS Feed';
+  const title = json.title;
+  const subjects = json.subjects;
+  const date = json.effective;
+  const max_description_length = json.max_description_length;
+  const max_title_length = json.max_title_length;
+  if (!queryData) {
+    throw new Error('No query data found in listing block');
+  }
 
-      if (queryData.sort_order === 'descending') {
-        queryData.sort_order = 'reverse';
-      }
+  const normalizedQueryData = { ...queryData };
+
+  if (normalizedQueryData.sort_order != null) {
+    if (typeof normalizedQueryData.sort_order === 'boolean') {
+      normalizedQueryData.sort_order = normalizedQueryData.sort_order
+        ? 'reverse'
+        : 'ascending';
     }
 
-    let query = {
-      ...queryData,
-      ...(!queryData.b_size && {
-        b_size: settings.defaultPageSize,
-      }),
-      query: queryData?.query,
-      metadata_fields: '_all',
-      b_start: 0,
-    };
-    return {
-      query,
-      language,
-      description,
-      title,
-      subjects,
-      date,
-      max_description_length,
-      max_title_length,
-    };
-  } catch (err) {
-    throw err;
+    if (normalizedQueryData.sort_order === 'descending') {
+      normalizedQueryData.sort_order = 'reverse';
+    }
   }
+
+  const query = {
+    ...normalizedQueryData,
+    ...(!normalizedQueryData.b_size && {
+      b_size: settings.defaultPageSize,
+    }),
+    query: normalizedQueryData?.query,
+    metadata_fields: '_all',
+    b_start: 0,
+  };
+
+  return {
+    query,
+    language,
+    description,
+    title,
+    subjects,
+    date,
+    max_description_length,
+    max_title_length,
+  };
 }
 
 /**
@@ -107,26 +114,44 @@ async function getRssFeedData(apiPath, APISUFIX, req, settings) {
  * @function fetchListingItems
  * @param {Object} query - The query data used for fetching items.
  * @param {string} apiPath - The base path for the API requests.
- * @param {string} APISUFIX - The suffix added to the API path depending on the environment.
+ * @param {string} APISUFFIX - The suffix added to the API path depending on the environment.
  * @param {string} authToken - The authentication token for authorized requests.
  * @return {Array} An array of items that match the query criteria.
  * @throws Will throw an error if the request fails.
  */
-async function fetchListingItems(query, apiPath, APISUFIX, authToken) {
+async function fetchListingItems(query, apiPath, APISUFFIX, authToken) {
+  const request = superagent
+    .post(`${apiPath}${__DEVELOPMENT__ ? '' : APISUFFIX}/@querystring-search`)
+    .send(query)
+    .accept('json');
+
+  if (authToken) {
+    request.set('Authorization', `Bearer ${authToken}`);
+  }
+
+  const response = await request;
+  return response.body.items || [];
+}
+
+function normalizeFeedURL(url, publicURL, apiPath) {
+  if (!url) return publicURL;
+
   try {
-    const request = superagent
-      .post(`${apiPath}${__DEVELOPMENT__ ? '' : APISUFIX}/@querystring-search`)
-      .send(query)
-      .accept('json');
+    const parsedUrl = new URL(url, publicURL);
+
+    if (apiPath) {
+      const apiOrigin = new URL(apiPath).origin;
+      const publicOrigin = new URL(publicURL).origin;
 
-    if (authToken) {
-      request.set('Authorization', `Bearer ${authToken}`);
+      if (parsedUrl.origin === apiOrigin) {
+        parsedUrl.protocol = new URL(publicOrigin).protocol;
+        parsedUrl.host = new URL(publicOrigin).host;
+      }
     }
 
-    const response = await request;
-    return response.body.items;
-  } catch (err) {
-    throw err;
+    return parsedUrl.toString();
+  } catch {
+    return url;
   }
 }
 
@@ -137,8 +162,16 @@ async function fetchListingItems(query, apiPath, APISUFIX, authToken) {
  * @param {number} maxLength - The maximum length of the text.
  * @return {string} The truncated text.
  */
-function truncateText(text, maxLength) {
-  return text.length > maxLength ? text.substring(0, maxLength) + '...' : text;
+function truncateText(text = '', maxLength) {
+  if (!maxLength || typeof text !== 'string') return text || '';
+  return text.length > maxLength ? `${text.substring(0, maxLength)}...` : text;
+}
+
+function safeDate(value) {
+  if (!value) return undefined;
+  const d = new Date(value);
+  if (Number.isNaN(d.getTime()) || d.getTime() <= 0) return undefined;
+  return d;
 }
 
 /**
@@ -153,7 +186,7 @@ function truncateText(text, maxLength) {
  */
 function make_rssMiddleware() {
   const { settings } = config;
-  const APISUFIX = settings.legacyTraverse ? '' : '/++api++';
+  const APISUFFIX = settings.legacyTraverse ? '' : '/++api++';
   let apiPath = '';
   const host = process.env.HOST || 'localhost';
   const port = process.env.PORT || '3000';
@@ -180,67 +213,62 @@ function make_rssMiddleware() {
         date,
         max_description_length,
         max_title_length,
-      } = await getRssFeedData(apiPath, APISUFIX, req, settings);
+      } = await getRssFeedData(apiPath, APISUFFIX, req, settings);
       const items = await fetchListingItems(
         query,
         apiPath,
-        APISUFIX,
+        APISUFFIX,
         req.universalCookies.get('auth_token'),
       );
       const feedOptions = {
         title: truncateText(title, max_title_length),
         description: truncateText(description, max_description_length),
-        feed_url: `${settings.publicURL}${req.path}`,
+        feed_url: normalizeFeedURL(req.path, settings.publicURL, apiPath),
         site_url: settings.publicURL,
         generator: 'RSS Feed Generator',
         language: language,
-        pubDate: new Date(date),
+        pubDate: safeDate(date),
+        categories: subjects || [],
       };
-      if (subjects) {
-        for (let i = 0; i < subjects.length; i++) {
-          feedOptions.categories = subjects;
-        }
-      }
+
       const feed = new RSS(feedOptions);
 
       items.forEach((item) => {
-        let link = toPublicURL(item['getURL']);
+        const link = normalizeFeedURL(item.getURL, settings.publicURL, apiPath);
         let enclosure = undefined;
-        if (
-          item.image_field &&
-          item.image_scales &&
-          item.image_scales[item.image_field]
-        ) {
-          const imageData = item.image_scales[item.image_field][0];
-          const imageUrl = `${link
-            .concat('/')
-            .concat(
-              item.image_scales[item.image_field][0].scales.preview.download,
-            )}`;
-          const mimeType = item['content-type'];
-          const originalSize = imageData.size;
+
+        const imageData = item.image_scales?.[item.image_field]?.[0];
+        const previewDownload = imageData?.scales?.preview?.download;
+
+        if (previewDownload && imageData.size && imageData['content-type']) {
           enclosure = {
-            url: imageUrl,
-            type: mimeType,
-            size: originalSize,
+            url: normalizeFeedURL(
+              new URL(previewDownload, link).toString(),
+              settings.publicURL,
+              apiPath,
+            ),
+            type: imageData['content-type'],
+            size: imageData.size,
           };
         }
+
         feed.item({
           title: truncateText(item.title, max_title_length),
-          description: truncateText(item.description, max_description_length),
+          description: truncateText(
+            item.description || item.Description || '',
+            max_description_length,
+          ),
           url: link,
           guid: item.UID,
-          date: new Date(item.effective),
-          author: item['listCreators']
-            ? item['listCreators'].map((creator) => creator).join(', ')
-            : undefined,
+          date: safeDate(item.effective || item.created || item.modified),
+          author: item.listCreators?.join(', '),
           categories: item.Subject ? item.Subject : [],
           enclosure: enclosure || undefined,
         });
       });
 
       const xml = feed.xml({ indent: true });
-      res.setHeader('content-type', 'application/atom+xml');
+      res.setHeader('Content-Type', 'application/rss+xml; charset=utf-8');
       res.send(xml);
     } catch (err) {
       if (err.response && err.response.status === 401) {
@@ -275,7 +303,7 @@ function make_rssMiddleware() {
 export default function makeMiddlewares() {
   const middleware = express.Router();
   middleware.use(express.urlencoded({ extended: true }));
-  middleware.all('**/rss.xml', make_rssMiddleware());
+  middleware.get('**/rss.xml', make_rssMiddleware());
 
   middleware.id = 'rss-middleware';