@eduardbar/drift 1.2.0 → 1.3.0

package/src/rules/complexity.ts

@@ -1,6 +1,6 @@
 import { SourceFile, SyntaxKind } from 'ts-morph'
 import type { DriftIssue } from '../types.js'
-import { hasIgnoreComment, getSnippet, type FunctionLike } from './shared.js'
+import { hasIgnoreComment, getSnippet, collectFunctionLikes, type FunctionLike } from './shared.js'
 
 const COMPLEXITY_THRESHOLD = 10
 
@@ -31,12 +31,7 @@ function getCyclomaticComplexity(fn: FunctionLike): number {
 
 export function detectHighComplexity(file: SourceFile): DriftIssue[] {
   const issues: DriftIssue[] = []
-  const fns: FunctionLike[] = [
-    ...file.getFunctions(),
-    ...file.getDescendantsOfKind(SyntaxKind.ArrowFunction),
-    ...file.getDescendantsOfKind(SyntaxKind.FunctionExpression),
-    ...file.getClasses().flatMap((c) => c.getMethods()),
-  ]
+  const fns: FunctionLike[] = collectFunctionLikes(file)
 
   for (const fn of fns) {
     const complexity = getCyclomaticComplexity(fn)

package/src/rules/nesting.ts

@@ -1,6 +1,6 @@
 import { SourceFile, SyntaxKind, Node } from 'ts-morph'
 import type { DriftIssue } from '../types.js'
-import { hasIgnoreComment, getSnippet, type FunctionLike } from './shared.js'
+import { hasIgnoreComment, getSnippet, collectFunctionLikes, type FunctionLike } from './shared.js'
 
 const NESTING_THRESHOLD = 3
 const PARAMS_THRESHOLD = 4
@@ -35,12 +35,7 @@ function getMaxNestingDepth(fn: FunctionLike): number {
 
 export function detectDeepNesting(file: SourceFile): DriftIssue[] {
   const issues: DriftIssue[] = []
-  const fns: FunctionLike[] = [
-    ...file.getFunctions(),
-    ...file.getDescendantsOfKind(SyntaxKind.ArrowFunction),
-    ...file.getDescendantsOfKind(SyntaxKind.FunctionExpression),
-    ...file.getClasses().flatMap((c) => c.getMethods()),
-  ]
+  const fns: FunctionLike[] = collectFunctionLikes(file)
 
   for (const fn of fns) {
     const depth = getMaxNestingDepth(fn)
@@ -62,12 +57,7 @@ export function detectDeepNesting(file: SourceFile): DriftIssue[] {
 
 export function detectTooManyParams(file: SourceFile): DriftIssue[] {
   const issues: DriftIssue[] = []
-  const fns: FunctionLike[] = [
-    ...file.getFunctions(),
-    ...file.getDescendantsOfKind(SyntaxKind.ArrowFunction),
-    ...file.getDescendantsOfKind(SyntaxKind.FunctionExpression),
-    ...file.getClasses().flatMap((c) => c.getMethods()),
-  ]
+  const fns: FunctionLike[] = collectFunctionLikes(file)
 
   for (const fn of fns) {
     const paramCount = fn.getParameters().length

package/src/rules/phase0-basic.ts

@@ -1,6 +1,6 @@
 import { SourceFile, SyntaxKind } from 'ts-morph'
 import type { DriftIssue } from '../types.js'
-import { hasIgnoreComment, getSnippet, getFunctionLikeLines, type FunctionLike } from './shared.js'
+import { hasIgnoreComment, getSnippet, getFunctionLikeLines, collectFunctionLikes, getFileLines } from './shared.js'
 
 const LARGE_FILE_THRESHOLD = 300
 const LARGE_FUNCTION_THRESHOLD = 50
@@ -26,12 +26,7 @@ export function detectLargeFile(file: SourceFile): DriftIssue[] {
 
 export function detectLargeFunctions(file: SourceFile): DriftIssue[] {
   const issues: DriftIssue[] = []
-  const fns: FunctionLike[] = [
-    ...file.getFunctions(),
-    ...file.getDescendantsOfKind(SyntaxKind.ArrowFunction),
-    ...file.getDescendantsOfKind(SyntaxKind.FunctionExpression),
-    ...file.getClasses().flatMap((c) => c.getMethods()),
-  ]
+  const fns = collectFunctionLikes(file)
 
   for (const fn of fns) {
     const lines = getFunctionLikeLines(fn)
@@ -70,7 +65,7 @@ export function detectDebugLeftovers(file: SourceFile): DriftIssue[] {
     }
   }
 
-  const lines = file.getFullText().split('\n')
+  const lines = getFileLines(file)
   lines.forEach((lineContent, i) => {
     if (/\/\/\s*(TODO|FIXME|HACK|XXX|TEMP)\b/i.test(lineContent)) {
       if (hasIgnoreComment(file, i + 1)) return
@@ -90,14 +85,18 @@ export function detectDebugLeftovers(file: SourceFile): DriftIssue[] {
 
 export function detectDeadCode(file: SourceFile): DriftIssue[] {
   const issues: DriftIssue[] = []
+  const identifierCounts = new Map<string, number>()
+
+  for (const id of file.getDescendantsOfKind(SyntaxKind.Identifier)) {
+    const text = id.getText()
+    identifierCounts.set(text, (identifierCounts.get(text) ?? 0) + 1)
+  }
 
   for (const imp of file.getImportDeclarations()) {
     for (const named of imp.getNamedImports()) {
       const name = named.getName()
-      const refs = file.getDescendantsOfKind(SyntaxKind.Identifier).filter(
-        (id) => id.getText() === name && id !== named.getNameNode()
-      )
-      if (refs.length === 0) {
+      const refsCount = Math.max(0, (identifierCounts.get(name) ?? 0) - 1)
+      if (refsCount === 0) {
         issues.push({
           rule: 'dead-code',
           severity: 'warning',

package/src/rules/shared.ts

@@ -5,12 +5,40 @@ import {
   ArrowFunction,
   FunctionExpression,
   MethodDeclaration,
+  SyntaxKind,
 } from 'ts-morph'
 
 export type FunctionLike = FunctionDeclaration | ArrowFunction | FunctionExpression | MethodDeclaration
 
-export function hasIgnoreComment(file: SourceFile, line: number): boolean {
+const fileLinesCache = new WeakMap<SourceFile, string[]>()
+const functionLikesCache = new WeakMap<SourceFile, FunctionLike[]>()
+
+export function getFileLines(file: SourceFile): string[] {
+  const cached = fileLinesCache.get(file)
+  if (cached) return cached
+
   const lines = file.getFullText().split('\n')
+  fileLinesCache.set(file, lines)
+  return lines
+}
+
+export function collectFunctionLikes(file: SourceFile): FunctionLike[] {
+  const cached = functionLikesCache.get(file)
+  if (cached) return cached
+
+  const fns: FunctionLike[] = [
+    ...file.getFunctions(),
+    ...file.getDescendantsOfKind(SyntaxKind.ArrowFunction),
+    ...file.getDescendantsOfKind(SyntaxKind.FunctionExpression),
+    ...file.getClasses().flatMap((c) => c.getMethods()),
+  ]
+
+  functionLikesCache.set(file, fns)
+  return fns
+}
+
+export function hasIgnoreComment(file: SourceFile, line: number): boolean {
+  const lines = getFileLines(file)
   const currentLine = lines[line - 1] ?? ''
   const prevLine = lines[line - 2] ?? ''
 
@@ -20,13 +48,13 @@ export function hasIgnoreComment(file: SourceFile, line: number): boolean {
 }
 
 export function isFileIgnored(file: SourceFile): boolean {
-  const firstLines = file.getFullText().split('\n').slice(0, 10).join('\n') // drift-ignore
+  const firstLines = getFileLines(file).slice(0, 10).join('\n') // drift-ignore
   return /\/\/\s*drift-ignore-file\b/.test(firstLines)
 }
 
 export function getSnippet(node: Node, file: SourceFile): string {
   const startLine = node.getStartLineNumber()
-  const lines = file.getFullText().split('\n')
+  const lines = getFileLines(file)
   return lines
     .slice(Math.max(0, startLine - 1), startLine + 1)
     .join('\n')