@edspencer/paddock 0.65.0 → 0.66.0

package/packages/server/dist/subagents.js

@@ -88,7 +88,7 @@ export const SAFE_SEGMENT = /^[A-Za-z0-9._-]+$/;
  */
 export const MTIME_CACHE_MAX = 1024;
 const taskUsesCache = new Map();
-const durationCache = new Map();
+const factsCache = new Map();
 const usageCache = new Map();
 /** The file's mtime in epoch ms, or undefined if it can't be stat'd. */
 export async function statMtimeMs(file) {
@@ -137,7 +137,7 @@ export async function readTaskToolUses(projectDir, sessionId) {
  */
 async function readTaskUsesForSession(projectDir, sessionId) {
     if (!SAFE_SEGMENT.test(sessionId))
-        return { paired: [], pending: [] };
+        return emptyTaskToolUses();
     return readTaskUsesFromFile(path.join(projectChatsDir(projectDir), `${sessionId}.jsonl`));
 }
 /**
@@ -158,10 +158,32 @@ async function readTaskUsesFromFile(file) {
         mtimeCacheSet(taskUsesCache, file, mtimeMs, value);
     return value;
 }
+function emptyTaskToolUses() {
+    return { paired: [], pending: [], sidechain: { uuids: new Set(), taskIds: new Set() } };
+}
+/**
+ * True when a raw transcript LINE was written on a sub-agent's own lane.
+ *
+ * Two markers, because the writers disagree: Claude Code stamps `isSidechain:
+ * true` (plus an `agentId`) on the line, while the SDK message stream — which
+ * `isSidechainMessage` in `ws-turn.ts` reads live, and which the test harness
+ * mirrors onto disk — carries `parent_tool_use_id`. Either is conclusive.
+ *
+ * Exported because EVERY file-order join over a main transcript has to agree with
+ * {@link dropSidechainMessages} about which lines exist: a scan that keeps a
+ * sidechain line while the parsed message list has dropped it shifts the whole
+ * join by one (#727).
+ */
+export function isSidechainLine(parsed) {
+    if (parsed.isSidechain === true)
+        return true;
+    return Boolean(parsed.parent_tool_use_id ?? parsed.message?.parent_tool_use_id);
+}
 async function readTaskUsesFromFileUncached(file) {
     const byId = new Map();
     const order = [];
     const resultIds = new Set();
+    const sidechain = { uuids: new Set(), taskIds: new Set() };
     const stream = createReadStream(file, { encoding: "utf8" });
     stream.on("error", () => undefined);
     const rl = createInterface({ input: stream, crlfDelay: Infinity });
@@ -177,12 +199,20 @@ async function readTaskUsesFromFileUncached(file) {
             catch {
                 continue;
             }
+            // A sub-agent's OWN transcript is sidechain top to bottom, so this only ever
+            // marks anything on a MAIN session file — which is the only place the
+            // distinction means something (issue #727).
+            const onSidechain = isSidechainLine(parsed);
+            if (onSidechain && typeof parsed.uuid === "string")
+                sidechain.uuids.add(parsed.uuid);
             const content = parsed.message?.content;
             if (!Array.isArray(content))
                 continue;
             for (const block of content) {
                 const b = block;
                 if (b?.type === "tool_use" && b.name && SUBAGENT_TOOL_NAMES.has(b.name) && b.id) {
+                    if (onSidechain)
+                        sidechain.taskIds.add(b.id);
                     if (!byId.has(b.id)) {
                         order.push(b.id);
                         byId.set(b.id, {
@@ -200,7 +230,7 @@ async function readTaskUsesFromFileUncached(file) {
         }
     }
     catch {
-        return { paired: [], pending: [] };
+        return emptyTaskToolUses();
     }
     finally {
         rl.close();
@@ -209,8 +239,43 @@ async function readTaskUsesFromFileUncached(file) {
     return {
         paired: order.filter((id) => resultIds.has(id)).map((id) => byId.get(id)),
         pending: order.filter((id) => !resultIds.has(id)).map((id) => byId.get(id)),
+        sidechain,
     };
 }
+/**
+ * Drop a session's sub-agent sidechain steps from its parsed history (issue
+ * #727) — the history-path counterpart of the live path's `isSidechainMessage`
+ * filter, and the same invariant: a sub-agent's steps render INSIDE its Task
+ * card (via the subagents endpoint), never as top-level rows of the parent.
+ *
+ * Joins on `uuid`, the source line's own id, which `@herdctl/core` preserves on
+ * every parsed message (and, for a paired tool message, takes from the
+ * originating `tool_use` entry — so a sidechain tool call matches on the same
+ * line that made it sidechain). Rides the mtime-cached transcript scan, and
+ * short-circuits to the identity for the overwhelmingly common transcript with
+ * no sidechain lines at all, so this costs nothing on the normal path.
+ *
+ * A transcript that is sidechain top to bottom is not a parent with leaked steps
+ * — it IS a sub-agent's own session, the shape Claude Code writes as its own
+ * `agent-<hex>.jsonl`. herdctl keeps those out of session discovery, but if one
+ * is ever reached directly it should render its content, not an empty chat, so
+ * a drop that would empty the history is refused.
+ */
+export async function dropSidechainMessages(projectDir, sessionId, messages) {
+    const { sidechain } = await readTaskUsesForSession(projectDir, sessionId);
+    if (sidechain.uuids.size === 0)
+        return messages;
+    const kept = messages.filter((m) => !(m.uuid && sidechain.uuids.has(m.uuid)));
+    return kept.length === 0 ? messages : kept;
+}
+/** The same launches minus any a sub-agent made on its own sidechain lane. */
+function withoutSidechainLaunches(uses) {
+    const { taskIds } = uses.sidechain;
+    if (taskIds.size === 0)
+        return uses;
+    const keep = (u) => !taskIds.has(u.toolUseId);
+    return { ...uses, paired: uses.paired.filter(keep), pending: uses.pending.filter(keep) };
+}
 /**
  * Live sub-agent enrichment for a tool frame (issue #429). When the tool is a
  * `Task`/`Agent` launch this turn already recovered (via {@link extractSubagentLaunches}),
@@ -306,10 +371,16 @@ export async function readSubagentMessages(projectDir, sessionId, toolUseId) {
 export async function enrichWithSubagents(projectDir, sessionId, messages) {
     if (!hasSubagentTool(messages))
         return messages;
-    const [taskUses, subagents] = await Promise.all([
+    const [rawTaskUses, subagents] = await Promise.all([
         readTaskUsesForSession(projectDir, sessionId),
         listSubagents(projectDir, sessionId),
     ]);
+    // The join is by FILE ORDER, so it has to see the same launches the caller's
+    // message list does. {@link dropSidechainMessages} has already removed the
+    // sidechain rows from that list, so a nested launch a sub-agent made on its own
+    // lane must come out of the cursor too — leaving it in would shift every
+    // following top-level sub-agent's enrichment onto the wrong card (#727).
+    const taskUses = withoutSidechainLaunches(rawTaskUses);
     const [durations, costs] = await Promise.all([
         subagentDurations(subagents),
         subagentCosts(subagents),
@@ -317,42 +388,85 @@ export async function enrichWithSubagents(projectDir, sessionId, messages) {
     return attachSubagentFields(messages, taskUses, subagents, durations, costs);
 }
 /**
- * Compute each sub-agent's run time (ms) from the first→last timestamp in its
- * own transcript. Keyed by toolUseId. Runs once per session on chat open (only
- * over that session's sub-agent files), so the cost is bounded to the open chat.
+ * How long a sub-agent transcript with no terminal `end_turn` may stay quiet
+ * before we stop calling it live (issue #725).
+ *
+ * A sub-agent that was interrupted — its keeper killed, the box restarted — never
+ * writes an `end_turn`, so without this fallback its card would advertise "still
+ * running" forever and its duration would never appear. The window has to be
+ * comfortably longer than the longest gap a WORKING sub-agent can leave between
+ * transcript lines, which is one slow tool call (a full test suite, a long build),
+ * not one slow model response. Ten minutes clears that with room to spare, and the
+ * `end_turn` check below means the overwhelming majority of finished sub-agents
+ * (392 of the 483 real transcripts this was measured against) never wait for it at
+ * all — they are recognised as finished the instant their last line lands.
+ */
+const SUBAGENT_STALE_MS = 10 * 60_000;
+/**
+ * Compute each FINISHED sub-agent's run time (ms) from the first→last timestamp
+ * in its own transcript. Keyed by toolUseId. Runs once per session on chat open
+ * (only over that session's sub-agent files), so the cost is bounded to the open
+ * chat.
+ *
+ * A sub-agent that still looks live is deliberately left OUT of the map (issue
+ * #725). `subagentDurationMs` is not merely cosmetic — it is the client's
+ * finished signal (`useRunningSubagents` drops any card that carries one) — and
+ * it is derived from a transcript that is still growing, so publishing it for a
+ * running sub-agent both freezes a bogus part-way number onto the card and
+ * evicts it from the running-sub-agents bar for the rest of the run. #622 fixed
+ * that for the `pending` branch of {@link attachSubagentFields} by omitting the
+ * field; the `paired` branch below it kept stamping one, and because the SDK
+ * backgrounds sub-agents, the launching `Task` pairs within milliseconds while
+ * the sub-agent keeps working — so a live sub-agent reaches the paired branch as
+ * a matter of course. Gating at the source fixes both branches by construction.
  */
 async function subagentDurations(subagents) {
     const out = new Map();
+    const now = Date.now();
     await Promise.all([...subagents.values()].map(async (m) => {
-        const ms = await readSubagentDurationMs(m.transcriptPath);
+        const ms = await readFinishedSubagentDurationMs(m.transcriptPath, now);
         if (ms !== undefined)
             out.set(m.toolUseId, ms);
     }));
     return out;
 }
 /**
- * The elapsed wall-clock of a sub-agent transcript: the delta between its first
- * and last `timestamp`. Scans for timestamps without a full JSON parse; returns
- * undefined if the file is missing or has < 2 timestamps.
+ * The elapsed wall-clock of a FINISHED sub-agent transcript, or undefined when it
+ * is missing, has < 2 timestamps, or still looks live (see {@link SUBAGENT_STALE_MS}).
  */
-async function readSubagentDurationMs(file) {
+async function readFinishedSubagentDurationMs(file, now) {
     const mtimeMs = await statMtimeMs(file);
+    const facts = await readSubagentFacts(file, mtimeMs);
+    if (facts.durationMs === undefined)
+        return undefined;
+    // No mtime (the file vanished between the stat and the read) ⇒ nothing is
+    // writing to it, so fall back to the structural check alone.
+    const quietMs = mtimeMs === undefined ? Infinity : now - mtimeMs;
+    if (!facts.endsWithEndTurn && quietMs < SUBAGENT_STALE_MS)
+        return undefined;
+    return facts.durationMs;
+}
+async function readSubagentFacts(file, mtimeMs) {
     if (mtimeMs !== undefined) {
-        const cached = mtimeCacheGet(durationCache, file, mtimeMs);
+        const cached = mtimeCacheGet(factsCache, file, mtimeMs);
         if (cached.hit)
             return cached.value;
     }
-    const value = await readSubagentDurationMsUncached(file);
-    // Cache even undefined (missing/malformed) so a repeat open of an unchanged,
-    // duration-less transcript doesn't re-read the whole file every time.
+    const value = await readSubagentFactsUncached(file);
+    // Cache even the empty result (missing/malformed) so a repeat open of an
+    // unchanged, duration-less transcript doesn't re-read the whole file every time.
     if (mtimeMs !== undefined)
-        mtimeCacheSet(durationCache, file, mtimeMs, value);
+        mtimeCacheSet(factsCache, file, mtimeMs, value);
     return value;
 }
-async function readSubagentDurationMsUncached(file) {
+async function readSubagentFactsUncached(file) {
     const raw = await fs.readFile(file, "utf8").catch(() => null);
     if (raw === null)
-        return undefined;
+        return { endsWithEndTurn: false };
+    return { durationMs: transcriptSpanMs(raw), endsWithEndTurn: endsWithEndTurn(raw) };
+}
+/** First→last `timestamp` delta. Scans for timestamps without a full JSON parse. */
+function transcriptSpanMs(raw) {
     const matches = [...raw.matchAll(/"timestamp":"([^"]+)"/g)];
     if (matches.length < 2)
         return undefined;
@@ -362,6 +476,25 @@ async function readSubagentDurationMsUncached(file) {
         return undefined;
     return last - first;
 }
+/** True when the transcript's last non-empty line is an assistant entry that
+ *  stopped with `end_turn`. Only that line is JSON-parsed. */
+function endsWithEndTurn(raw) {
+    const lines = raw.split("\n");
+    for (let i = lines.length - 1; i >= 0; i--) {
+        const trimmed = lines[i].trim();
+        if (!trimmed)
+            continue;
+        try {
+            const parsed = JSON.parse(trimmed);
+            return parsed.type === "assistant" && parsed.message?.stop_reason === "end_turn";
+        }
+        catch {
+            // A torn final line means the writer is mid-append — definitively not settled.
+            return false;
+        }
+    }
+    return false;
+}
 /**
  * Compute each sub-agent's estimated API-rate cost (USD), keyed by toolUseId, as
  * the RECURSIVE total of the sub-agent PLUS every sub-agent it (transitively)
@@ -611,6 +744,13 @@ function attachSubagentFields(messages, taskUses, subagents, durations, costs) {
                 description: use.description,
                 prompt: use.prompt,
                 hasSubagent: subagents.has(use.toolUseId),
+                // Same hazard as the `pending` branch above, and for the same reason:
+                // a PAIRED `Task` does NOT mean the sub-agent is done — the SDK
+                // backgrounds it, so the tool_result lands in milliseconds while the
+                // sub-agent keeps working. `durations` is therefore gated on liveness at
+                // its source ({@link subagentDurations}) and holds an entry only for a
+                // sub-agent whose transcript has actually settled, so a still-running one
+                // gets `undefined` here and keeps its place in the bar (#725).
                 subagentDurationMs: durations.get(use.toolUseId),
                 subagentCostUsd: costs.get(use.toolUseId),
             },

package/packages/server/dist/tooldetails.d.ts

@@ -24,10 +24,16 @@ export declare function readToolDetails(projectDir: string, sessionId: string):
  */
 export declare function attachToolDetails(projectDir: string, sessionId: string, messages: EnrichedMessage[]): Promise<EnrichedMessage[]>;
 /**
- * The single history-enrichment orchestrator (issue #237). Composes the three
- * server-side passes so the routes call one function: sub-agent recovery (#37) →
- * generalized per-tool detail (#237, subsuming #232's edit diff) → background /
- * task-notification folding (#230) → local-command stdout recovery (#158).
+ * The single history-enrichment orchestrator (issue #237). Composes the
+ * server-side passes so the routes call one function: sidechain drop (#727) →
+ * sub-agent recovery (#37) → generalized per-tool detail (#237, subsuming #232's
+ * edit diff) → background / task-notification folding (#230) → local-command
+ * stdout recovery (#158).
+ *
+ * The sidechain drop goes FIRST and is the history-path mirror of the live path's
+ * `isSidechainMessage` filter: a sub-agent's steps belong inside its Task card,
+ * and every later pass here joins by file order, so they have to be gone before
+ * anything counts positions.
  */
 export declare function enrichWithToolDetails(projectDir: string, sessionId: string, messages: EnrichedMessage[]): Promise<EnrichedMessage[]>;
 export {};

package/packages/server/dist/tooldetails.js

@@ -33,7 +33,7 @@ import { createInterface } from "node:readline";
 import path from "node:path";
 import { projectChatsDir } from "./transcripts.js";
 import { fileKind } from "./projects.js";
-import { enrichWithSubagents } from "./subagents.js";
+import { dropSidechainMessages, enrichWithSubagents, isSidechainLine } from "./subagents.js";
 import { enrichWithBackground } from "./background.js";
 import { enrichWithLocalCommands } from "./localcommand.js";
 import { SAFE_SEGMENT, statMtimeMs, mtimeCacheGet, mtimeCacheSet, } from "./subagents.js";
@@ -355,6 +355,16 @@ async function readToolDetailsFromFileUncached(file) {
             catch {
                 continue;
             }
+            // A sub-agent's steps are not rows of THIS transcript — `dropSidechainMessages`
+            // has already removed them from the message list this list joins against, so
+            // keeping them would shift every following tool's detail by one (#727). Their
+            // detail is derived separately, off the sub-agent's own transcript. (A file
+            // that is sidechain top to bottom — a sub-agent's OWN transcript — therefore
+            // recovers nothing and its messages pass through unenriched, which is a
+            // degrade rather than a misjoin; `dropSidechainMessages` likewise refuses to
+            // empty such a history.)
+            if (isSidechainLine(parsed))
+                continue;
             const content = parsed.message?.content;
             if (!Array.isArray(content))
                 continue;
@@ -453,13 +463,20 @@ export async function attachToolDetails(projectDir, sessionId, messages) {
     });
 }
 /**
- * The single history-enrichment orchestrator (issue #237). Composes the three
- * server-side passes so the routes call one function: sub-agent recovery (#37) →
- * generalized per-tool detail (#237, subsuming #232's edit diff) → background /
- * task-notification folding (#230) → local-command stdout recovery (#158).
+ * The single history-enrichment orchestrator (issue #237). Composes the
+ * server-side passes so the routes call one function: sidechain drop (#727) →
+ * sub-agent recovery (#37) → generalized per-tool detail (#237, subsuming #232's
+ * edit diff) → background / task-notification folding (#230) → local-command
+ * stdout recovery (#158).
+ *
+ * The sidechain drop goes FIRST and is the history-path mirror of the live path's
+ * `isSidechainMessage` filter: a sub-agent's steps belong inside its Task card,
+ * and every later pass here joins by file order, so they have to be gone before
+ * anything counts positions.
  */
 export async function enrichWithToolDetails(projectDir, sessionId, messages) {
-    const withSubagents = await enrichWithSubagents(projectDir, sessionId, messages);
+    const topLevel = await dropSidechainMessages(projectDir, sessionId, messages);
+    const withSubagents = await enrichWithSubagents(projectDir, sessionId, topLevel);
     const withDetails = await attachToolDetails(projectDir, sessionId, withSubagents);
     const withBackground = enrichWithBackground(withDetails);
     return enrichWithLocalCommands(projectDir, sessionId, withBackground);

package/packages/server/dist/trusted-proxy.js

@@ -40,7 +40,7 @@
  * A request from another host to a `0.0.0.0`-published port is SNAT'd to that
  * same address, so "peer is the gateway" does not prove the traffic stayed on
  * the box. Smoke-test from INSIDE the container instead (`docker compose exec
- * paddock curl http://127.0.0.1:4000/mcp …`), where the peer really is loopback.
+ * paddock curl http://127.0.0.1:7233/mcp …`), where the peer really is loopback.
  */
 import proxyAddr from "proxy-addr";
 /**

package/packages/server/dist/turn-interlock.d.ts

@@ -0,0 +1,101 @@
+/**
+ * Turn interlock (issue #731) — stop a chat's in-flight turn BEFORE a destructive
+ * operation mutates its transcript.
+ *
+ * ## The bug this exists to make impossible
+ *
+ * A chat's transcript is not something paddock writes: `claude` writes
+ * `<sessionId>.jsonl` itself, straight through the symlink `ensureProjectAgent`
+ * plants (see `transcripts.ts`). So a destructive operation — delete, promote,
+ * revert, project delete — is a race against a live subprocess that still holds
+ * that path and will append to it whenever it next has something to say.
+ *
+ * Deleting the file mid-turn therefore did not delete the chat. The unlink
+ * landed, the chat left the list, and ~45s later the still-running process
+ * re-created the SAME file containing only its own tail: a 3-line transcript
+ * opening on an orphan `tool_result` whose `tool_use` no longer existed. The
+ * chat came back, named after its raw session id, with every prior turn
+ * permanently gone. Promote lost the chat from BOTH projects the same way.
+ *
+ * ## The guarantee
+ *
+ * Nothing here tries to out-race the writer, because that race is unwinnable.
+ * Instead {@link quiesceSession} refuses to return "go ahead" until the session
+ * is verifiably dead — and a caller that cannot get that answer within its
+ * timeout must NOT mutate (the routes return 409 instead). A destructive op
+ * therefore only ever runs against a transcript no process holds, and a dead
+ * session has nothing left to write itself back with.
+ *
+ * ## Why two liveness signals
+ *
+ * `hub.isRunning` sees the WS layer's turn, and `herdctl.isSdkSessionLive` sees
+ * herdctl's `SessionReaper` — a session held open past its turn (a killed
+ * background task's keepAlive, or the re-invocation grace, #397). Either one
+ * means a `claude` process may still write. The recovery engine already pairs
+ * them for exactly this reason (`ws-turn.ts`); so do we.
+ *
+ * ## Why cancel is not enough on its own
+ *
+ * `herdctl.cancel(jobId)` ends the model TURN. On the session runtime that is an
+ * `interrupt()`, which deliberately leaves the session — and its subprocess —
+ * alive for the next message. That is right for the Stop button and wrong for a
+ * delete, so we also reap the managed session. Cancel and reap are both
+ * best-effort; the polled liveness check is what actually decides.
+ */
+import type { SessionHub } from "./session-hub.js";
+import type { HerdctlService } from "./herdctl.js";
+/** How long to wait for a cancelled turn to actually die before giving up. */
+export declare const DEFAULT_QUIESCE_TIMEOUT_MS = 10000;
+/**
+ * The dependencies the interlock needs. Both come off the route context: `hub`
+ * via `ctx.managementOpsContext?.hub` (hence optional — a server built without
+ * the WS layer has no hub, and correctly reports nothing running).
+ */
+export interface TurnInterlockDeps {
+    hub: SessionHub | undefined;
+    herdctl: HerdctlService;
+}
+/**
+ * - `idle` — nothing was running; the caller may proceed.
+ * - `stopped` — a turn WAS running, was stopped, and is now verifiably dead;
+ *   the caller may proceed.
+ * - `stuck` — something is still alive after the timeout. The caller MUST NOT
+ *   mutate the transcript: that is precisely the resurrection case.
+ */
+export type QuiesceOutcome = "idle" | "stopped" | "stuck";
+/**
+ * Is anything alive on this session right now — a live WS turn, or a session
+ * herdctl's reaper is still holding open?
+ */
+export declare function sessionIsBusy(deps: TurnInterlockDeps, sessionId: string): boolean;
+/**
+ * Stop whatever is running against `sessionId` and WAIT for it to actually be
+ * gone. Returns `stuck` rather than throwing, so each caller can pick its own
+ * failure shape (a 409, or a `failed` bucket entry in a batch).
+ *
+ * A running turn is not always cancellable the instant we look at it: `jobId`
+ * is null early in a turn (it arrives with the first frames). That is why this
+ * polls rather than cancelling once — each pass re-reads `activeInfo` and
+ * cancels any job id it has not cancelled yet, so a turn that arms its job id a
+ * beat later is still caught inside the same call.
+ */
+export declare function quiesceSession(deps: TurnInterlockDeps, sessionId: string, opts?: {
+    timeoutMs?: number;
+}): Promise<QuiesceOutcome>;
+/**
+ * Quiesce every session with a running turn in `projectSlug`, ahead of a project
+ * delete. Returns the ids that could NOT be stopped — empty means it is safe to
+ * remove the project directory.
+ *
+ * Only the hub can enumerate running turns by project, so a server with no hub
+ * simply has nothing to stop.
+ */
+export declare function quiesceProject(deps: TurnInterlockDeps, projectSlug: string, opts?: {
+    timeoutMs?: number;
+}): Promise<string[]>;
+/** The 409 body every refusing route sends, so clients can match one code. */
+export declare function turnRunningError(sessionIds: string[]): {
+    error: string;
+    code: "turn_running";
+    sessionIds: string[];
+};

package/packages/server/dist/turn-interlock.js

@@ -0,0 +1,76 @@
+/** How long to wait for a cancelled turn to actually die before giving up. */
+export const DEFAULT_QUIESCE_TIMEOUT_MS = 10_000;
+/** How often to re-check liveness while waiting. */
+const POLL_MS = 25;
+const delay = (ms) => new Promise((r) => setTimeout(r, ms));
+/**
+ * Is anything alive on this session right now — a live WS turn, or a session
+ * herdctl's reaper is still holding open?
+ */
+export function sessionIsBusy(deps, sessionId) {
+    if (deps.hub?.isRunning(sessionId) === true)
+        return true;
+    return deps.herdctl.isSdkSessionLive(sessionId);
+}
+/**
+ * Stop whatever is running against `sessionId` and WAIT for it to actually be
+ * gone. Returns `stuck` rather than throwing, so each caller can pick its own
+ * failure shape (a 409, or a `failed` bucket entry in a batch).
+ *
+ * A running turn is not always cancellable the instant we look at it: `jobId`
+ * is null early in a turn (it arrives with the first frames). That is why this
+ * polls rather than cancelling once — each pass re-reads `activeInfo` and
+ * cancels any job id it has not cancelled yet, so a turn that arms its job id a
+ * beat later is still caught inside the same call.
+ */
+export async function quiesceSession(deps, sessionId, opts = {}) {
+    if (!sessionIsBusy(deps, sessionId))
+        return "idle";
+    const deadline = Date.now() + (opts.timeoutMs ?? DEFAULT_QUIESCE_TIMEOUT_MS);
+    const cancelled = new Set();
+    let reaped = false;
+    for (;;) {
+        const jobId = deps.hub?.activeInfo(sessionId)?.jobId ?? null;
+        if (jobId && !cancelled.has(jobId)) {
+            cancelled.add(jobId);
+            await deps.herdctl.cancel(jobId).catch(() => false);
+        }
+        // Close the managed session too — on the session runtime `cancel` only
+        // interrupts the turn and leaves the subprocess holding the transcript.
+        // Once is enough; a second reap of an already-closed session is a no-op.
+        if (!reaped) {
+            reaped = true;
+            deps.herdctl.reapSession(sessionId);
+        }
+        if (!sessionIsBusy(deps, sessionId))
+            return "stopped";
+        if (Date.now() >= deadline)
+            return "stuck";
+        await delay(POLL_MS);
+    }
+}
+/**
+ * Quiesce every session with a running turn in `projectSlug`, ahead of a project
+ * delete. Returns the ids that could NOT be stopped — empty means it is safe to
+ * remove the project directory.
+ *
+ * Only the hub can enumerate running turns by project, so a server with no hub
+ * simply has nothing to stop.
+ */
+export async function quiesceProject(deps, projectSlug, opts = {}) {
+    const running = (deps.hub?.runningSessions() ?? []).filter((i) => i.projectSlug === projectSlug);
+    // Concurrent: each turn dies independently, so the whole call is bounded by one
+    // timeout rather than N of them stacked end to end.
+    const outcomes = await Promise.all(running.map(async (info) => [info.sessionId, await quiesceSession(deps, info.sessionId, opts)]));
+    return outcomes.filter(([, outcome]) => outcome === "stuck").map(([sessionId]) => sessionId);
+}
+/** The 409 body every refusing route sends, so clients can match one code. */
+export function turnRunningError(sessionIds) {
+    return {
+        error: sessionIds.length === 1
+            ? `A turn is still running on chat ${sessionIds[0]} and could not be stopped; try again.`
+            : `Turns are still running on ${sessionIds.length} chats and could not be stopped; try again.`,
+        code: "turn_running",
+        sessionIds,
+    };
+}

package/packages/server/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@paddock/server",
-  "version": "0.65.0",
+  "version": "0.66.0",
   "private": true,
   "type": "module"
 }

package/packages/web/dist/assets/InstanceConfigPage-DBrwtZjx.js

@@ -0,0 +1,2 @@
+import{r as p,k as Q,b as C,j as t,A as B,l as U,X as W,m as Y,n as Z,p as _,M as ee,q as te}from"./index-B-QAOq9a.js";function ne(){const[e,n]=p.useState(null),[l,o]=p.useState(!0),[a,c]=p.useState(null),[i,g]=p.useState({}),[u,O]=p.useState(!1),[$,y]=p.useState(null),[R,w]=p.useState(!1),[k,V]=p.useState(""),[j,P]=p.useState(!1),[D,A]=p.useState(null),F=p.useRef(null),T=Q("(min-width: 1024px)");p.useEffect(()=>{let s=!0;return o(!0),C.getInstanceConfig().then(r=>{s&&(n(r),c(null))}).catch(r=>s&&c(r instanceof Error?r.message:String(r))).finally(()=>s&&o(!1)),()=>{s=!1}},[]);const G=(s,r)=>{w(!1),y(null),g(d=>({...d,[s]:r}))},q=s=>Object.prototype.hasOwnProperty.call(i,s.key)?i[s.key]:s.value,S=p.useMemo(()=>e?e.groups.flatMap(s=>s.fields):[],[e]),x=p.useMemo(()=>S.filter(s=>s.editable&&!s.envOverridden).filter(s=>Object.prototype.hasOwnProperty.call(i,s.key)).filter(s=>!M(i[s.key],s.value)).map(s=>s.key),[S,i]),I=p.useMemo(()=>new Set(x),[x]),m=p.useMemo(()=>{if(!e)return[];const s=k.trim().toLowerCase(),r=[];for(const d of e.groups){const f=s!==""&&d.label.toLowerCase().includes(s),b=d.fields.filter(h=>{const v=Object.prototype.hasOwnProperty.call(i,h.key)?i[h.key]:h.value;return j&&M(v,h.default)?!1:s===""||f?!0:ue(h).includes(s)});b.length>0&&r.push({...d,fields:b})}return r},[e,k,j,i]),L=m.reduce((s,r)=>s+r.fields.length,0),H=k.trim()!==""||j,K=m.some(s=>s.fields.some(r=>r.envOverridden));p.useEffect(()=>{const s=F.current;if(!s||m.length===0)return;const r=m.map(f=>f.id),d=()=>{const f=s.getBoundingClientRect().top;let b=r[0];for(const h of r){const v=document.getElementById(E(h));if(v)if(v.getBoundingClientRect().top-f<=80)b=h;else break}A(b)};return d(),s.addEventListener("scroll",d,{passive:!0}),()=>s.removeEventListener("scroll",d)},[m]);const X=s=>{var d;const r=document.getElementById(E(s));(d=r==null?void 0:r.scrollIntoView)==null||d.call(r,{behavior:"smooth",block:"start"}),A(s)},z=async()=>{if(x.length===0)return;const s={};for(const r of x)s[r]=i[r];O(!0),y(null);try{await C.updateInstanceConfig(s);const r=await C.getInstanceConfig();n(r),g({}),w(!0)}catch(r){y(r instanceof Z||r instanceof Error?r.message:String(r))}finally{O(!1)}},J=()=>{g({}),y(null),w(!1)};return t.jsxs(t.Fragment,{children:[t.jsxs("div",{className:"flex min-h-0 flex-1",children:[e&&t.jsx(se,{groups:m,active:D,onJump:X,dirtyCount:me(m,I)}),t.jsxs("div",{className:"flex min-h-0 min-w-0 flex-1 flex-col",children:[e&&t.jsx(re,{query:k,onQuery:V,modifiedOnly:j,onModifiedOnly:P,visibleCount:L,totalCount:S.length,filtering:H,autoFocus:T}),t.jsx("div",{ref:F,className:"min-h-0 flex-1 overflow-y-auto px-4 py-5 sm:px-6",children:t.jsxs("div",{className:"mx-auto max-w-4xl",children:[t.jsx(ae,{saved:R,configPath:e==null?void 0:e.configPath}),l&&t.jsx("p",{className:"text-sm text-paddock-500",children:"Loading…"}),a&&t.jsxs("p",{className:"text-sm text-red-600 dark:text-red-400",role:"alert",children:["Failed to load settings: ",a]}),e&&K&&t.jsx(le,{}),e&&L===0&&t.jsxs("p",{className:"py-8 text-center text-sm text-paddock-500",children:["No settings match"," ",k.trim()?t.jsxs(t.Fragment,{children:["“",t.jsx("span",{className:"font-medium",children:k.trim()}),"”"]}):"this filter","."]}),m.map((s,r)=>t.jsx(oe,{group:s,first:r===0,children:t.jsx("div",{className:"grid grid-cols-1 gap-x-6 gap-y-4 sm:grid-cols-2",children:s.fields.map(d=>t.jsx(ie,{field:d,value:q(d),dirty:I.has(d.key),onChange:f=>G(d.key,f)},d.key))})},s.id))]})})]})]}),e&&t.jsxs("footer",{className:"flex items-center gap-3 border-t border-paddock-200 px-4 py-3 dark:border-paddock-800 sm:px-6",children:[$&&t.jsxs("span",{className:"flex items-center gap-1.5 text-[13px] text-red-600 dark:text-red-400",role:"alert",children:[t.jsx(B,{width:14,height:14,className:"shrink-0"}),$]}),t.jsx("span",{className:"ml-auto text-[12px] text-paddock-400",children:x.length>0?`${x.length} unsaved change${x.length===1?"":"s"}`:"No changes"}),t.jsx("button",{type:"button",className:"btn-subtle",onClick:J,disabled:x.length===0||u,children:"Reset"}),t.jsx("button",{type:"button",className:"btn-primary",onClick:z,disabled:x.length===0||u,children:u?"Saving…":"Save changes"})]})]})}function se({groups:e,active:n,onJump:l,dirtyCount:o}){return t.jsx("nav",{"aria-label":"Config sections",className:"hidden w-52 shrink-0 overflow-y-auto border-r border-paddock-200 px-2 py-4 dark:border-paddock-800 lg:block",children:t.jsx("ul",{className:"space-y-0.5",children:e.map(a=>{const c=a.id===n,i=o[a.id]??0;return t.jsx("li",{children:t.jsxs("button",{type:"button",onClick:()=>l(a.id),"aria-current":c?"true":void 0,className:`flex w-full items-center gap-2 rounded-md px-2.5 py-1.5 text-left text-[13px] transition-colors ${c?"bg-paddock-100 font-medium text-paddock-900 dark:bg-paddock-800 dark:text-paddock-100":"text-paddock-500 hover:bg-paddock-100/60 hover:text-paddock-800 dark:hover:bg-paddock-800/50 dark:hover:text-paddock-200"}`,children:[t.jsx("span",{className:"min-w-0 flex-1 truncate",children:a.label}),i>0&&t.jsx("span",{className:"h-1.5 w-1.5 shrink-0 rounded-full bg-accent","aria-label":`${i} unsaved`}),t.jsx("span",{className:"shrink-0 text-[11px] tabular-nums text-paddock-400",children:a.fields.length})]})},a.id)})})})}function re({query:e,onQuery:n,modifiedOnly:l,onModifiedOnly:o,visibleCount:a,totalCount:c,filtering:i,autoFocus:g}){return t.jsxs("div",{className:"flex flex-wrap items-center gap-2 border-b border-paddock-200 px-4 py-2.5 dark:border-paddock-800 sm:px-6",children:[t.jsxs("div",{className:"relative min-w-0 flex-1 sm:max-w-sm",children:[t.jsx(U,{width:14,height:14,className:"pointer-events-none absolute left-2.5 top-1/2 -translate-y-1/2 text-paddock-400"}),t.jsx("input",{type:"search","aria-label":"Search settings",placeholder:"Search settings, keys, env vars…",className:"input h-8 w-full pl-8 pr-7 text-[13px] [&::-webkit-search-cancel-button]:appearance-none",value:e,autoFocus:g,onChange:u=>n(u.target.value),onKeyDown:u=>{u.key==="Escape"&&e!==""&&(u.preventDefault(),n(""))}}),e!==""&&t.jsx("button",{type:"button","aria-label":"Clear search",onClick:()=>n(""),className:"absolute right-2 top-1/2 -translate-y-1/2 text-paddock-400 hover:text-paddock-700 dark:hover:text-paddock-200",children:t.jsx(W,{width:13,height:13})})]}),t.jsx("button",{type:"button","aria-pressed":l,onClick:()=>o(!l),className:`shrink-0 rounded-md border px-2.5 py-1 text-[12px] transition-colors ${l?"border-accent/60 bg-accent/10 text-accent":"border-paddock-200 text-paddock-500 hover:text-paddock-800 dark:border-paddock-700 dark:hover:text-paddock-200"}`,children:"Modified only"}),t.jsx("span",{className:"shrink-0 text-[12px] tabular-nums text-paddock-400",children:i?`${a} of ${c}`:`${c} settings`})]})}function ae({saved:e,configPath:n}){return t.jsxs("div",{role:"status",className:`mb-5 flex items-start gap-2 rounded-lg border px-3 py-2.5 text-[13px] leading-snug ${e?"border-emerald-300 bg-emerald-50 text-emerald-800 dark:border-emerald-700/60 dark:bg-emerald-900/20 dark:text-emerald-300":"border-amber-300 bg-amber-50 text-amber-800 dark:border-amber-700/60 dark:bg-amber-900/20 dark:text-amber-300"}`,children:[e?t.jsx(Y,{width:15,height:15,className:"mt-0.5 shrink-0"}):t.jsx(B,{width:15,height:15,className:"mt-0.5 shrink-0"}),t.jsx("span",{children:e?t.jsxs(t.Fragment,{children:[t.jsx("strong",{children:"Saved to disk."})," These changes take effect only after the server restarts."]}):t.jsxs(t.Fragment,{children:["Changes here are written to ",t.jsx("code",{className:"font-mono text-[12px]",children:he(n)})," ","and take effect only after the server restarts — the running instance keeps its current config until then."]})})]})}function le(){return t.jsxs("p",{className:"mb-5 text-[12px] leading-snug text-paddock-500",children:["Settings marked ",t.jsx(N,{tone:"amber",children:"env"})," are overridden by an environment variable, which wins over this file — edit that variable (and restart) to change them."]})}function oe({group:e,first:n,children:l}){return t.jsxs("section",{id:E(e.id),className:`scroll-mt-4 ${n?"":"mt-9 border-t border-paddock-200 pt-7 dark:border-paddock-800"}`,children:[t.jsx("h2",{className:"text-base font-semibold tracking-tight text-paddock-900 dark:text-paddock-50",children:e.label}),e.description&&t.jsx("p",{className:"mt-1 text-[12px] leading-snug text-paddock-500",children:e.description}),t.jsx("div",{className:"mt-4",children:l})]})}function ie({field:e,value:n,dirty:l,onChange:o}){const a=!e.editable||e.envOverridden,c=`cfg-${e.key}`,i=e.type==="boolean";return t.jsxs("div",{className:`min-w-0 ${xe(e,n)?"sm:col-span-2":""} ${l?"-ml-2.5 border-l-2 border-accent pl-2":""}`,children:[t.jsxs("div",{className:"flex items-center justify-between gap-2",children:[t.jsxs("label",{htmlFor:a||i?void 0:c,className:"min-w-0 text-[13px] font-medium",children:[t.jsx("span",{className:"align-middle",children:e.label}),e.sensitive&&t.jsx(N,{tone:"amber",children:"sensitive"}),e.envOverridden&&t.jsx(N,{tone:"amber",title:`Overridden by environment variable ${e.envVar} — edit that env var (and restart) to change it.`,children:"env"}),!e.editable&&!e.envOverridden&&t.jsx(N,{tone:"plain",children:"read-only"})]}),i&&!a&&t.jsx(de,{id:c,checked:!!n,onChange:o,label:e.label})]}),e.help&&t.jsx("p",{className:"mt-0.5 text-[12px] leading-snug text-paddock-500",children:e.help}),a?t.jsx(pe,{field:e,value:n}):!i&&t.jsx(ce,{field:e,value:n,onChange:o,inputId:c}),e.envOverridden&&t.jsx("p",{className:"mt-1 truncate font-mono text-[11px] text-amber-600 dark:text-amber-500/90",children:e.envVar})]})}function N({children:e,tone:n,title:l}){return t.jsx("span",{title:l,className:`ml-1.5 rounded px-1 py-px align-middle text-[10px] font-semibold uppercase tracking-wide ${n==="amber"?"bg-amber-100 text-amber-700 dark:bg-amber-900/40 dark:text-amber-400":"bg-paddock-100 text-paddock-500 dark:bg-paddock-800 dark:text-paddock-400"}`,children:e})}function de({id:e,checked:n,onChange:l,label:o}){return t.jsxs("label",{htmlFor:e,className:"relative shrink-0 cursor-pointer",children:[t.jsx("input",{id:e,type:"checkbox","aria-label":o,className:"peer sr-only",checked:n,onChange:a=>l(a.target.checked)}),t.jsx("span",{className:"block h-[18px] w-8 rounded-full bg-paddock-300 transition-colors after:absolute after:left-[2px] after:top-[2px] after:h-[14px] after:w-[14px] after:rounded-full after:bg-white after:transition-transform after:content-[''] peer-checked:bg-accent peer-checked:after:translate-x-[14px] peer-focus-visible:ring-2 peer-focus-visible:ring-accent/50 dark:bg-paddock-700"})]})}function ce({field:e,value:n,onChange:l,inputId:o}){if(e.type==="enum")return t.jsx("select",{id:o,className:"input mt-1.5",value:String(n??""),onChange:a=>l(a.target.value),children:(e.enumValues??[]).map(a=>t.jsx("option",{value:a,children:a},a))});if(e.type==="number")return t.jsx("input",{id:o,type:"number",className:"input mt-1.5",value:n==null?"":String(n),placeholder:e.default===null?"default":String(e.default),onChange:a=>l(a.target.value===""?null:Number(a.target.value))});if(e.type==="text"){const a=n==null||n===e.default,c=n==null?String(e.default??""):String(n),i=typeof e.default=="string"&&!a;return t.jsxs("div",{className:"mt-1.5",children:[t.jsx("textarea",{id:o,className:"input min-h-[7rem] resize-y font-mono text-[12px] leading-relaxed",rows:6,spellCheck:!1,value:c,onChange:g=>l(g.target.value)}),t.jsxs("div",{className:"mt-1 flex items-center justify-between gap-3 text-[12px] text-paddock-500",children:[t.jsx("span",{children:a?"Using the built-in default.":n===""?"Empty — nothing will be appended.":`${c.length.toLocaleString()} characters.`}),i&&t.jsx("button",{type:"button",className:"shrink-0 underline underline-offset-2 hover:text-paddock-700 dark:hover:text-paddock-300",onClick:()=>l(null),children:"Restore default"})]})]})}if(e.type==="string-list"){const a=Array.isArray(n)?n.join(", "):String(n??"");return t.jsx("input",{id:o,type:"text",className:"input mt-1.5",value:a,onChange:c=>l(c.target.value.split(",").map(i=>i.trim()).filter(Boolean))})}return t.jsx("input",{id:o,type:"text",className:"input mt-1.5",value:n==null?"":String(n),placeholder:e.default===null?"":String(e.default),onChange:a=>l(a.target.value)})}function pe({field:e,value:n}){return t.jsx("div",{className:"mt-1 text-[12px] text-paddock-600 dark:text-paddock-300",children:e.type==="boolean"?t.jsx("span",{className:"font-mono",children:n?"true":"false"}):n==null||n===""?t.jsx("span",{className:"italic text-paddock-400",children:e.type==="text"&&n===""?"(empty — nothing appended)":"(not set)"}):e.type==="text"?t.jsx("span",{className:"block max-h-40 overflow-y-auto whitespace-pre-wrap rounded bg-paddock-50 px-2 py-1.5 font-mono text-[12px] leading-relaxed dark:bg-paddock-900/40",children:String(n)}):t.jsx("span",{className:"block break-all font-mono",children:Array.isArray(n)?n.join(", "):String(n)})})}function xe(e,n){return e.type==="text"||e.type==="string-list"?!0:(Array.isArray(n)?n.join(", "):n==null?"":String(n)).length>38}function ue(e){return[e.label,e.key,e.help,e.envVar,...e.enumValues??[]].filter(Boolean).join(" ").toLowerCase()}function me(e,n){const l={};for(const o of e)l[o.id]=o.fields.filter(a=>n.has(a.key)).length;return l}const E=e=>`cfg-section-${e}`;function M(e,n){return Array.isArray(e)&&Array.isArray(n)?e.length===n.length&&e.every((l,o)=>l===n[o]):e===n}function he(e){if(!e)return"paddock.config.yaml";const n=e.split("/");return n[n.length-1]||e}function fe(){const e=_(),n=(e==null?void 0:e.openNav)??(()=>{});return t.jsxs("div",{className:"flex h-full min-h-0 flex-col",children:[t.jsxs("header",{className:"pt-safe flex items-center gap-2 border-b border-paddock-200 px-3 pb-2.5 dark:border-paddock-800 sm:px-6 lg:py-4",children:[t.jsx("button",{type:"button",onClick:n,"aria-label":"Open menu",className:"btn-subtle -ml-1 shrink-0 px-2 py-1.5 lg:hidden",children:t.jsx(ee,{width:20,height:20})}),t.jsx(te,{width:18,height:18,className:"shrink-0 text-paddock-400"}),t.jsx("h1",{className:"text-[15px] font-semibold tracking-tight",children:"Config"})]}),t.jsx(ne,{})]})}export{fe as InstanceConfigPage};
+