@editframe/elements 0.9.0-beta.1 → 0.9.0-beta.3

package/dist/elements/EFMedia.d.ts

@@ -15,7 +15,7 @@ export declare class EFMedia extends EFMedia_base {
     get assetId(): string | null;
     fragmentIndexPath(): string;
     fragmentTrackPath(trackId: string): string;
-    trackFragmentIndexLoader: Task<readonly [string, typeof fetch], Record<number, TrackFragmentIndex> | undefined>;
+    trackFragmentIndexLoader: Task<readonly [string, typeof fetch], Record<number, TrackFragmentIndex>>;
     protected initSegmentsLoader: Task<readonly [Record<number, TrackFragmentIndex> | undefined, string, typeof fetch], {
         trackId: string;
         buffer: MP4Box.MP4ArrayBuffer;

package/dist/elements/EFTemporal.d.ts

@@ -16,6 +16,8 @@ export declare class TemporalMixinInterface {
     get trimAdjustedOwnCurrentTimeMs(): number;
     set duration(value: string);
     get duration(): string;
+    set trimstart(value: string);
+    set trimend(value: string);
     parentTimegroup?: EFTimegroup;
     rootTimegroup?: EFTimegroup;
     frameTask: Task<readonly unknown[], unknown>;

package/dist/elements/EFTimegroup.d.ts

@@ -17,7 +17,7 @@ export declare class EFTimegroup extends EFTimegroup_base {
     connectedCallback(): void;
     get storageKey(): string;
     get durationMs(): number;
-    waitForMediaDurations(): Promise<(Record<number, import('packages/assets/src/Probe.ts').TrackFragmentIndex> | undefined)[]>;
+    waitForMediaDurations(): Promise<Record<number, import('packages/assets/src/Probe.ts').TrackFragmentIndex>[]>;
     get childTemporals(): import('./EFTemporal.ts').TemporalMixinInterface[];
     protected updated(changedProperties: PropertyValueMap<any> | Map<PropertyKey, unknown>): void;
     shouldWrapWithWorkbench(): boolean;

package/dist/elements/src/elements/EFMedia.js

@@ -44,9 +44,6 @@ class EFMedia extends EFSourceMixin(EFTemporal(FetchMixin(LitElement)), {
     this.trackFragmentIndexLoader = new Task(this, {
       args: () => [this.fragmentIndexPath(), this.fetch],
       task: async ([fragmentIndexPath, fetch], { signal }) => {
-        if (this.src === "") {
-          return;
-        }
         const response = await fetch(fragmentIndexPath, { signal });
         return await response.json();
       },
@@ -257,7 +254,7 @@ class EFMedia extends EFSourceMixin(EFTemporal(FetchMixin(LitElement)), {
       if (EF_RENDERING()) {
         return `editframe://api/video2/isobmff_tracks/${this.assetId}/${trackId}`;
       }
-      return `https://editframe.dev/api/video2/isobmff_tracks/${this.assetId}?trackId=${trackId}`;
+      return `https://editframe.dev/api/video2/isobmff_tracks/${this.assetId}/${trackId}`;
     }
     return `/@ef-track/${this.src ?? ""}?trackId=${trackId}`;
   }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@editframe/elements",
-  "version": "0.9.0-beta.1",
+  "version": "0.9.0-beta.3",
   "description": "",
   "exports": {
     ".": {
@@ -20,7 +20,7 @@
   "author": "",
   "license": "UNLICENSED",
   "dependencies": {
-    "@editframe/assets": "0.9.0-beta.1",
+    "@editframe/assets": "0.9.0-beta.3",
     "@lit/context": "^1.1.2",
     "@lit/task": "^1.0.1",
     "d3": "^7.9.0",

package/src/elements/EFMedia.browsertest.ts

@@ -76,7 +76,7 @@ describe("EFMedia", () => {
       const element = document.createElement("test-media");
       element.setAttribute("asset-id", `${id}:example.mp4`);
       expect(element.fragmentTrackPath("1")).toBe(
-        `https://editframe.dev/api/video2/isobmff_tracks/${id}:example.mp4?trackId=1`,
+        `https://editframe.dev/api/video2/isobmff_tracks/${id}:example.mp4/1`,
       );
     });
   });

package/src/elements/EFMedia.ts

@@ -82,21 +82,19 @@ export class EFMedia extends EFSourceMixin(EFTemporal(FetchMixin(LitElement)), {
   fragmentTrackPath(trackId: string) {
     if (this.assetId) {
       if (EF_RENDERING()) {
-        // It is significant that the editframe:// protocol lists the trackId in the path rather than
-        // as a query parameter. This is a shortcut to loading track data from storage.
         return `editframe://api/video2/isobmff_tracks/${this.assetId}/${trackId}`;
       }
-      return `https://editframe.dev/api/video2/isobmff_tracks/${this.assetId}?trackId=${trackId}`;
+      return `https://editframe.dev/api/video2/isobmff_tracks/${this.assetId}/${trackId}`;
     }
+    // trackId is only specified as a query  in the @ef-track url shape
+    // this is because that system doesn't have a full url matching system.
+    // This is an annoying incosistency that should be fixed.
     return `/@ef-track/${this.src ?? ""}?trackId=${trackId}`;
   }
 
   public trackFragmentIndexLoader = new Task(this, {
     args: () => [this.fragmentIndexPath(), this.fetch] as const,
     task: async ([fragmentIndexPath, fetch], { signal }) => {
-      if (this.src === "") {
-        return;
-      }
       const response = await fetch(fragmentIndexPath, { signal });
       return (await response.json()) as Record<number, TrackFragmentIndex>;
     },

package/src/elements/EFTemporal.ts

@@ -24,6 +24,8 @@ export declare class TemporalMixinInterface {
 
   set duration(value: string);
   get duration(): string;
+  set trimstart(value: string);
+  set trimend(value: string);
 
   parentTimegroup?: EFTimegroup;
   rootTimegroup?: EFTimegroup;