@edgedev/firebase 2.0.4 → 2.0.6

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@edgedev/firebase",
-  "version": "2.0.4",
+  "version": "2.0.6",
   "description": "Vue 3 / Nuxt 3 Plugin or Nuxt 3 plugin for firebase authentication and firestore.",
   "main": "index.ts",
   "scripts": {

package/src/edgeFirebase.js

@@ -1,3 +1,7 @@
+// TODO: THE permissionCheck will call a cloud function that will check the user's permissions also...
+// This could function will right to "rules-helpers" collction a document with the user's uid and the collection path and the permission
+// This will make the rules far more efficient and will allow for more complex rules // this only needs done really for snapshots... 
+// All the other document reads and writes should be made using a cloud functions exclusively and the cloud function will check the permissions
 const { onCall, HttpsError, logger, getFirestore, functions, admin, twilio, db } = require('./config.js')
 
 const authToken = process.env.TWILIO_AUTH_TOKEN
@@ -278,9 +282,9 @@ function setUser(userRef, newData, oldData, stagedDocId) {
     let userUpdate = { meta: newData.meta, stagedDocId }
 
     if (newData.meta && newData.meta.name) {
-      const publicUserRef = db.collection('public-users').doc(newData.userId)
+      const publicUserRef = db.collection('public-users').doc(newData.uid)
       const publicMeta = { name: newData.meta.name }
-      publicUserRef.set({ uid: newData.uid, meta: publicMeta, collectionPaths: newData.collectionPaths, userId: newData.userId })
+      publicUserRef.set({ uid: newData.uid, meta: publicMeta, collectionPaths: newData.collectionPaths, userId: newData.uid })
     }
 
     if (Object.prototype.hasOwnProperty.call(newData, 'roles')) {

package/src/firestore.rules

@@ -10,13 +10,13 @@ service cloud.firestore {
   }
 
   match /databases/{database}/documents/public-users/{user} {
-    allow read: if true;
-    allow list: if true;
+    allow read: if request.auth != null;
+    allow list: if request.auth != null;
     allow create: if false;  
     allow update: if false; 
     allow delete: if false; 
   }
-
+  
   match /databases/{database}/documents/events/{event} {
     allow read: if false;
     allow create: if false;