@ecopages/core 0.2.0-alpha.53 → 0.2.0-alpha.54

package/src/services/assets/asset-processing-service/{processor.interface.d.ts → processor.interface.ts}

@@ -1,22 +1,27 @@
-import type { IHmrManager } from '../../../types/internal-types.js';
-import type { AssetDefinition, ProcessedAsset } from './assets.types.js';
+import type { IHmrManager } from '../../../types/internal-types.ts';
+import type { AssetDefinition, ProcessedAsset } from './assets.types.ts';
+
 /**
  * Base interface for asset processors.
  * Processors transform asset definitions into processed assets.
  */
 export interface AssetProcessor<T extends AssetDefinition = AssetDefinition> {
-    process(asset: T): Promise<ProcessedAsset>;
+	process(asset: T): Promise<ProcessedAsset>;
 }
+
 /**
  * Interface for processors that support HMR (Hot Module Replacement).
  * These processors can receive an HMR manager to enable hot reloading capabilities.
  */
 export interface HmrAwareProcessor extends AssetProcessor {
-    setHmrManager(hmrManager: IHmrManager): void;
+	setHmrManager(hmrManager: IHmrManager): void;
 }
+
 /**
  * Type guard to check if a processor supports HMR.
  * @param processor - The processor to check
  * @returns True if the processor implements HmrAwareProcessor
  */
-export declare function isHmrAware(processor: AssetProcessor): processor is HmrAwareProcessor;
+export function isHmrAware(processor: AssetProcessor): processor is HmrAwareProcessor {
+	return 'setHmrManager' in processor && typeof (processor as HmrAwareProcessor).setHmrManager === 'function';
+}

package/src/services/assets/asset-processing-service/processor.registry.ts

@@ -0,0 +1,18 @@
+import type { AssetKind, AssetSource } from './assets.types.ts';
+import type { BaseProcessor } from './processors/base/base-processor.ts';
+
+export class ProcessorRegistry {
+	private processors = new Map<`${AssetKind}-${AssetSource}`, BaseProcessor<any>>();
+
+	register(kind: AssetKind, variant: AssetSource, processor: BaseProcessor<any>) {
+		this.processors.set(`${kind}-${variant}`, processor);
+	}
+
+	getProcessor(kind: AssetKind, variant: AssetSource): BaseProcessor<any> | undefined {
+		return this.processors.get(`${kind}-${variant}`);
+	}
+
+	getAllProcessors(): Map<`${AssetKind}-${AssetSource}`, BaseProcessor<any>> {
+		return this.processors;
+	}
+}

package/src/services/assets/asset-processing-service/processors/base/base-processor.test.ts

@@ -0,0 +1,59 @@
+import { afterEach, beforeEach, expect, test, vi } from 'vitest';
+import { fileSystem } from '@ecopages/file-system';
+import type { BaseAsset, ProcessedAsset } from '../../assets.types.ts';
+import { BaseProcessor } from './base-processor.ts';
+
+type TestAsset = BaseAsset & {
+	name: string;
+};
+
+class TestProcessor extends BaseProcessor<TestAsset> {
+	processCalls = 0;
+
+	async process(dep: TestAsset): Promise<ProcessedAsset> {
+		return this.getOrProcess(dep.name, async () => {
+			this.processCalls += 1;
+			return {
+				filepath: `/test/dist/assets/${dep.name}.js`,
+				kind: dep.kind,
+				inline: false,
+			};
+		});
+	}
+}
+
+const originalExists = fileSystem.exists;
+
+beforeEach(() => {
+	fileSystem.exists = vi.fn(() => true);
+});
+
+afterEach(() => {
+	fileSystem.exists = originalExists;
+	vi.restoreAllMocks();
+});
+
+test('BaseProcessor - rebuilds cached outputs when emitted file was deleted', async () => {
+	const existsMock = vi
+		.fn()
+		.mockImplementationOnce(() => false)
+		.mockImplementation(() => true);
+	fileSystem.exists = existsMock;
+
+	const processor = new TestProcessor({
+		appConfig: {
+			absolutePaths: { distDir: '/test/dist' },
+		} as any,
+	});
+
+	const asset: TestAsset = {
+		kind: 'script',
+		source: 'file',
+		name: 'runtime-vendor',
+	};
+
+	await processor.process(asset);
+	await processor.process(asset);
+
+	expect(processor.processCalls).toBe(2);
+});

package/src/services/assets/asset-processing-service/processors/base/base-processor.ts

@@ -0,0 +1,83 @@
+import path from 'node:path';
+import { RESOLVED_ASSETS_DIR } from '../../../../../config/constants.ts';
+import type { EcoPagesAppConfig } from '../../../../../types/internal-types.ts';
+import { rapidhash } from '../../../../../utils/hash.ts';
+import { isDevelopmentRuntime, isProductionRuntime } from '../../../../../utils/runtime.ts';
+import type { BaseAsset, ProcessedAsset } from '../../assets.types.ts';
+import { fileSystem } from '@ecopages/file-system';
+
+export abstract class BaseProcessor<T extends BaseAsset> {
+	protected appConfig: EcoPagesAppConfig;
+	/**
+	 * Cache for processed assets to avoid reprocessing the same asset multiple times.
+	 * The cache key is a combination of the asset name and its hash.
+	 * The cache value is the processed asset.
+	 */
+	protected cache: Map<string, ProcessedAsset> = new Map();
+
+	constructor({ appConfig }: { appConfig: EcoPagesAppConfig }) {
+		this.appConfig = appConfig;
+	}
+
+	get isDevelopment(): boolean {
+		return isDevelopmentRuntime();
+	}
+
+	get isProduction(): boolean {
+		return isProductionRuntime();
+	}
+
+	abstract process(dep: T): Promise<ProcessedAsset>;
+
+	protected getAssetsDir(): string {
+		return path.join(this.appConfig.absolutePaths.distDir, RESOLVED_ASSETS_DIR);
+	}
+
+	protected writeCacheFile(key: string, path: ProcessedAsset): void {
+		this.cache.set(key, path);
+	}
+
+	protected getCacheFile(key: string): ProcessedAsset | undefined {
+		return this.cache.get(key);
+	}
+
+	protected hasCacheFile(key: string): boolean {
+		return this.cache.has(key);
+	}
+
+	protected generateHash(content: string): string {
+		return rapidhash(content).toString();
+	}
+
+	protected buildCacheKey(identifier: string, contentHash: string, dep: T): string {
+		const attrsHash = dep.attributes ? this.generateHash(JSON.stringify(dep.attributes)) : '';
+		const position = dep.position ?? '';
+		const packageRole = dep.packageRole ?? '';
+		return `${identifier}:${contentHash}:${position}:${attrsHash}:${packageRole}`;
+	}
+
+	protected getOrProcess(
+		cacheKey: string,
+		processFn: () => ProcessedAsset | Promise<ProcessedAsset>,
+	): Promise<ProcessedAsset> {
+		if (this.hasCacheFile(cacheKey)) {
+			const cached = this.getCacheFile(cacheKey) as ProcessedAsset;
+			if (!cached.filepath || fileSystem.exists(cached.filepath)) {
+				return Promise.resolve(cached);
+			}
+
+			this.cache.delete(cacheKey);
+		}
+
+		const result = processFn();
+		if (result instanceof Promise) {
+			return result.then((asset) => {
+				this.writeCacheFile(cacheKey, asset);
+				return asset;
+			});
+		}
+
+		this.writeCacheFile(cacheKey, result);
+		return Promise.resolve(result);
+	}
+}

package/src/services/assets/asset-processing-service/processors/base/base-script-processor.ts

@@ -0,0 +1,173 @@
+import { appLogger } from '../../../../../global/app-logger.ts';
+import type { EcoPagesAppConfig } from '../../../../../types/internal-types.ts';
+import { getAppBrowserBuildPlugins } from '../../../../../build/build-adapter.ts';
+import type { EcoBuildPlugin } from '../../../../../build/build-types.ts';
+import { fileSystem } from '@ecopages/file-system';
+import path from 'node:path';
+import type { ScriptAsset } from '../../assets.types.ts';
+import { BaseProcessor } from './base-processor.ts';
+import { BrowserBundleService, type BrowserBundleGroupedEntry } from '../../../browser-bundle.service.ts';
+
+export abstract class BaseScriptProcessor<T extends ScriptAsset> extends BaseProcessor<T> {
+	private readonly browserBundleService: BrowserBundleService;
+
+	constructor({ appConfig }: { appConfig: EcoPagesAppConfig }) {
+		super({ appConfig });
+		this.browserBundleService = new BrowserBundleService(appConfig);
+	}
+
+	protected shouldBundle(dep: T): boolean {
+		return dep.bundle !== false;
+	}
+
+	protected getBundlerOptions(dep: T): Record<string, any> {
+		if (dep.packageRole === 'page-script' && dep.bundleOptions?.splitting === undefined) {
+			return {
+				...dep.bundleOptions,
+				splitting: false,
+			};
+		}
+
+		return dep.bundleOptions || {};
+	}
+
+	protected collectBuildPlugins(excludePluginNames?: string[]): EcoBuildPlugin[] {
+		const buildPlugins = getAppBrowserBuildPlugins(this.appConfig);
+		if (!excludePluginNames || excludePluginNames.length === 0) {
+			return buildPlugins;
+		}
+
+		const excluded = new Set(excludePluginNames);
+		return buildPlugins.filter((plugin) => !excluded.has(plugin.name));
+	}
+
+	protected async bundleScript({
+		entrypoint,
+		outdir,
+		excludeAppBuildPlugins,
+		plugins: additionalPlugins,
+		...rest
+	}: {
+		entrypoint: string;
+		outdir: string;
+	} & ScriptAsset['bundleOptions']): Promise<string> {
+		const buildPlugins = this.collectBuildPlugins(excludeAppBuildPlugins);
+		const allPlugins = additionalPlugins ? [...additionalPlugins, ...buildPlugins] : buildPlugins;
+
+		const buildResult = await this.browserBundleService.bundle({
+			profile: 'browser-script',
+			entrypoints: [entrypoint],
+			outdir,
+			root: this.appConfig.rootDir,
+			excludeAppBuildPlugins,
+			splitting: true,
+			naming: '[name]-[hash].[ext]',
+			plugins: allPlugins,
+			...rest,
+		});
+
+		if (!buildResult.success) {
+			for (const log of buildResult.logs) {
+				appLogger.debug(log.message, log);
+			}
+		}
+
+		const entryBaseName = path.parse(entrypoint).name;
+		const entryOutput = buildResult.outputs
+			.map((output) => output.path)
+			.find((outputPath) => path.basename(outputPath) === `${entryBaseName}.js`);
+
+		if (entryOutput) {
+			return entryOutput;
+		}
+
+		const nonVendorOutput = buildResult.outputs
+			.map((output) => output.path)
+			.find((outputPath) => !path.basename(outputPath).startsWith('vendors'));
+
+		if (nonVendorOutput) {
+			return nonVendorOutput;
+		}
+
+		const primaryOutput = buildResult.outputs[0]?.path;
+		if (primaryOutput) {
+			return primaryOutput;
+		}
+
+		const namedFallbackOutput = path.join(outdir, `${entryBaseName}.js`);
+		if (fileSystem.exists(namedFallbackOutput)) {
+			return namedFallbackOutput;
+		}
+
+		const fallbackOutput = path.join(outdir, 'entry_0.js');
+		if (fileSystem.exists(fallbackOutput)) {
+			return fallbackOutput;
+		}
+
+		const logMessage = buildResult.logs.map((log) => log.message).join(' | ');
+		throw new Error(`No build output generated for ${entrypoint}${logMessage ? `: ${logMessage}` : ''}`);
+	}
+
+	protected async bundleScripts({
+		entries,
+		outdir,
+		excludeAppBuildPlugins,
+		plugins: additionalPlugins,
+		...rest
+	}: {
+		entries: BrowserBundleGroupedEntry[];
+		outdir: string;
+	} & ScriptAsset['bundleOptions']): Promise<Map<string, string>> {
+		const buildPlugins = this.collectBuildPlugins(excludeAppBuildPlugins);
+		const allPlugins = additionalPlugins ? [...additionalPlugins, ...buildPlugins] : buildPlugins;
+
+		const buildResult = await this.browserBundleService.bundleGroupedEntries(entries, {
+			profile: 'browser-script',
+			outdir,
+			root: this.appConfig.rootDir,
+			excludeAppBuildPlugins,
+			...rest,
+			splitting: true,
+			naming: '[name]-[hash].[ext]',
+			plugins: allPlugins,
+		});
+
+		if (!buildResult.success) {
+			for (const log of buildResult.logs) {
+				appLogger.debug(log.message, log);
+			}
+		}
+
+		const outputs = buildResult.outputs.map((output) => output.path);
+		const entryOutputs = new Map<string, string>();
+
+		for (const entry of entries) {
+			const exactOutput = outputs.find((outputPath) => path.basename(outputPath) === `${entry.entryName}.js`);
+			if (exactOutput) {
+				entryOutputs.set(entry.entryName, exactOutput);
+				continue;
+			}
+
+			const hashedOutput = outputs.find((outputPath) =>
+				path.basename(outputPath).startsWith(`${entry.entryName}-`),
+			);
+			if (hashedOutput) {
+				entryOutputs.set(entry.entryName, hashedOutput);
+				continue;
+			}
+
+			const fallbackOutput = path.join(outdir, `${entry.entryName}.js`);
+			if (fileSystem.exists(fallbackOutput)) {
+				entryOutputs.set(entry.entryName, fallbackOutput);
+				continue;
+			}
+
+			const logMessage = buildResult.logs.map((log) => log.message).join(' | ');
+			throw new Error(
+				`No build output generated for grouped entry ${entry.entryName}${logMessage ? `: ${logMessage}` : ''}`,
+			);
+		}
+
+		return entryOutputs;
+	}
+}

package/src/services/assets/asset-processing-service/processors/index.ts

@@ -0,0 +1,5 @@
+export * from './script/content-script.processor.ts';
+export * from './script/file-script.processor.ts';
+export * from './script/node-module-script.processor.ts';
+export * from './stylesheet/content-stylesheet.processor.ts';
+export * from './stylesheet/file-stylesheet.processor.ts';

package/src/services/assets/asset-processing-service/processors/script/content-script.processor.test.ts

@@ -0,0 +1,188 @@
+import { afterEach, beforeEach, describe, expect, test, vi } from 'vitest';
+import { fileSystem } from '@ecopages/file-system';
+import { ContentScriptProcessor } from './content-script.processor';
+import type { EcoPagesAppConfig } from '../../../../../types/internal-types.ts';
+import type { ContentScriptAsset } from '../../assets.types.ts';
+import type { BrowserBundleGroupedEntry } from '../../../browser-bundle.service.ts';
+
+function createMockConfig(): EcoPagesAppConfig {
+	return {
+		baseUrl: 'http://localhost:3000',
+		rootDir: '/test/project',
+		srcDir: 'src',
+		publicDir: 'public',
+		pagesDir: 'pages',
+		includesDir: 'includes',
+		layoutsDir: 'layouts',
+		distDir: '.eco/public',
+		workDir: '.eco',
+		templatesExt: [],
+		componentsDir: 'components',
+		robotsTxt: { preferences: { '*': [] } },
+		additionalWatchPaths: [],
+		defaultMetadata: { title: 'Test', description: 'Test' },
+		integrations: [],
+		integrationsDependencies: [],
+		absolutePaths: {
+			config: '/test/project/eco.config.ts',
+			componentsDir: '/test/project/src/components',
+			distDir: '/test/project/.eco/public',
+			workDir: '/test/project/.eco',
+			includesDir: '/test/project/src/includes',
+			layoutsDir: '/test/project/src/layouts',
+			pagesDir: '/test/project/src/pages',
+			projectDir: '/test/project',
+			publicDir: '/test/project/public',
+			srcDir: '/test/project/src',
+			htmlTemplatePath: '/test/project/src/html.tsx',
+			error404TemplatePath: '/test/project/src/404.tsx',
+		},
+		processors: new Map(),
+		loaders: new Map(),
+		sourceTransforms: new Map(),
+	};
+}
+
+class TestContentScriptProcessor extends ContentScriptProcessor {
+	readonly bundleScriptsCalls: Array<{
+		entries: BrowserBundleGroupedEntry[];
+		outdir: string;
+		naming?: string;
+	}> = [];
+	bundleScriptsResult = new Map<string, string>();
+	bundleScriptsError?: Error;
+
+	protected override async bundleScripts({
+		entries,
+		outdir,
+		naming,
+	}: {
+		entries: BrowserBundleGroupedEntry[];
+		outdir: string;
+		naming?: string;
+	}): Promise<Map<string, string>> {
+		this.bundleScriptsCalls.push({ entries, outdir, naming });
+
+		if (this.bundleScriptsError) {
+			throw this.bundleScriptsError;
+		}
+
+		return this.bundleScriptsResult;
+	}
+}
+
+describe('ContentScriptProcessor', () => {
+	beforeEach(() => {
+		vi.spyOn(fileSystem, 'ensureDir').mockImplementation(() => {});
+		vi.spyOn(fileSystem, 'write').mockImplementation(() => {});
+		vi.spyOn(fileSystem, 'remove').mockImplementation(() => {});
+		vi.spyOn(fileSystem, 'readFileSync').mockImplementation(() => '');
+	});
+
+	afterEach(() => {
+		vi.restoreAllMocks();
+	});
+
+	test('processGrouped should bundle grouped entries together and preserve logical entry mapping', async () => {
+		const processor = new TestContentScriptProcessor({ appConfig: createMockConfig() });
+		processor.bundleScriptsResult = new Map([
+			['page-entry', '/test/project/.eco/public/assets/page-entry-abc123.js'],
+			['lazy-entry', '/test/project/.eco/public/assets/lazy-entry-def456.js'],
+		]);
+
+		const deps: ContentScriptAsset[] = [
+			{
+				kind: 'script',
+				source: 'content',
+				content: 'import "/test/project/src/page.ts";',
+				position: 'head',
+				attributes: { type: 'module', defer: '' },
+				packageRole: 'page-script',
+				groupedBundle: { id: 'bundle-1', entryName: 'page-entry' },
+			},
+			{
+				kind: 'script',
+				source: 'content',
+				content: 'import "/test/project/src/lazy.ts";',
+				position: 'head',
+				attributes: { type: 'module', defer: '', 'data-eco-lazy-key': 'lazy-key' },
+				excludeFromHtml: true,
+				groupedBundle: { id: 'bundle-1', entryName: 'lazy-entry' },
+			},
+		];
+
+		const results = await processor.processGrouped(deps);
+
+		expect(processor.bundleScriptsCalls).toHaveLength(1);
+		expect(processor.bundleScriptsCalls[0]).toEqual(
+			expect.objectContaining({
+				entries: expect.arrayContaining([
+					expect.objectContaining({ entryName: 'page-entry' }),
+					expect.objectContaining({ entryName: 'lazy-entry' }),
+				]),
+				naming: '[name]-[hash].[ext]',
+			}),
+		);
+
+		expect(results).toEqual([
+			expect.objectContaining({
+				filepath: '/test/project/.eco/public/assets/page-entry-abc123.js',
+				packageRole: 'page-script',
+				groupedBundle: { id: 'bundle-1', entryName: 'page-entry' },
+			}),
+			expect.objectContaining({
+				filepath: '/test/project/.eco/public/assets/lazy-entry-def456.js',
+				excludeFromHtml: true,
+				groupedBundle: { id: 'bundle-1', entryName: 'lazy-entry' },
+			}),
+		]);
+
+		expect(fileSystem.write).toHaveBeenCalledTimes(2);
+		expect(fileSystem.remove).toHaveBeenCalledTimes(1);
+	});
+
+	test('processGrouped should fall back to per-entry processing when bundling is disabled', async () => {
+		const processor = new ContentScriptProcessor({ appConfig: createMockConfig() });
+		vi.spyOn(fileSystem, 'write').mockImplementation(() => {});
+
+		const results = await processor.processGrouped([
+			{
+				kind: 'script',
+				source: 'content',
+				content: 'console.log("first")',
+				bundle: false,
+				groupedBundle: { id: 'bundle-1', entryName: 'first-entry' },
+			},
+			{
+				kind: 'script',
+				source: 'content',
+				content: 'console.log("second")',
+				bundle: false,
+				groupedBundle: { id: 'bundle-1', entryName: 'second-entry' },
+			},
+		]);
+
+		expect(results).toEqual([
+			expect.objectContaining({ groupedBundle: { id: 'bundle-1', entryName: 'first-entry' } }),
+			expect.objectContaining({ groupedBundle: { id: 'bundle-1', entryName: 'second-entry' } }),
+		]);
+	});
+
+	test('processGrouped should remove temporary entries when bundling fails', async () => {
+		const processor = new TestContentScriptProcessor({ appConfig: createMockConfig() });
+		processor.bundleScriptsError = new Error('bundle failed');
+
+		await expect(
+			processor.processGrouped([
+				{
+					kind: 'script',
+					source: 'content',
+					content: 'console.log("grouped")',
+					groupedBundle: { id: 'bundle-1', entryName: 'page-entry' },
+				},
+			]),
+		).rejects.toThrow('bundle failed');
+
+		expect(fileSystem.remove).toHaveBeenCalledTimes(1);
+	});
+});