@ecomplus/storefront-renderer 2.10.5 → 2.10.7

package/CHANGELOG.md

@@ -3,6 +3,18 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [2.10.7](https://github.com/ecomplus/storefront/compare/@ecomplus/storefront-renderer@2.10.6...@ecomplus/storefront-renderer@2.10.7) (2023-05-20)
+
+### Bug Fixes
+
+- **renderer/proxy:** fix handling url on reverse proxy ([#904](https://github.com/ecomplus/storefront/issues/904)) ([15c4116](https://github.com/ecomplus/storefront/commit/15c411617b427fecaa618532d53cff3c245c4ae2))
+
+## [2.10.6](https://github.com/ecomplus/storefront/compare/@ecomplus/storefront-renderer@2.10.5...@ecomplus/storefront-renderer@2.10.6) (2023-05-12)
+
+### Bug Fixes
+
+- **renderer/image-size:** properly handling fallback dimensions ([e5953a1](https://github.com/ecomplus/storefront/commit/e5953a123087237b8407bd9aa4c3a87e46bf63f8))
+
 ## [2.10.5](https://github.com/ecomplus/storefront/compare/@ecomplus/storefront-renderer@2.10.4...@ecomplus/storefront-renderer@2.10.5) (2023-05-11)
 
 ### Bug Fixes

package/functions/index.js

@@ -28,16 +28,14 @@ exports.ssr = (req, res, getCacheControl) => {
       )
   }
 
-  const proxy = url => {
-    const urlInstance = new URL(url)
-    const requestUrl = urlInstance.searchParam.get('url')
+  const proxy = requestUrl => {
     if (requestUrl) {
-      return axios.get(requestUrl, { 
+      return axios.get(requestUrl, {
         headers,
         timeout: 3000,
         validateStatus: (status) => {
           return Boolean(status)
-        } 
+        }
       })
     }
     return null
@@ -65,7 +63,7 @@ exports.ssr = (req, res, getCacheControl) => {
 
   const fallback = () => {
     if (url.startsWith('/reverse-proxy/')) {
-      proxy(url).then((response) => {
+      proxy(req.query.url).then((response) => {
         if (response) {
           const { status, headers, data } = response
           return res.writeHead(status, headers).send(data)

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ecomplus/storefront-renderer",
-  "version": "2.10.5",
+  "version": "2.10.7",
   "description": "SSR for Storefront EJS views with E-Com Plus APIs",
   "main": "src/index.js",
   "repository": {

package/src/renderer.js

@@ -110,14 +110,17 @@ cmsCollections.forEach(collection => {
 
 // abstracting comming image size handler for local images
 const tryImageSize = (src, fallbackDimensions = {}) => {
-  let dimensions = fallbackDimensions
+  let dimensions = {}
   if (typeof src === 'string' && src.startsWith('/')) {
     try {
       dimensions = imageSize(`template/public${src}`)
     } catch (e) {
-      dimensions = fallbackDimensions
+      dimensions = {}
     }
   }
+  if (fallbackDimensions && !dimensions.width && fallbackDimensions.width) {
+    return fallbackDimensions
+  }
   return dimensions
 }