@ecology91/skills 0.1.5 → 0.1.7

package/.claude-plugin/marketplace.json

@@ -0,0 +1,45 @@
+{
+  "metadata": {
+    "pluginRoot": "./skills"
+  },
+  "plugins": [
+    {
+      "name": "engineering",
+      "source": "./engineering",
+      "skills": [
+        "./diagnose",
+        "./grill-with-docs",
+        "./improve-codebase-architecture",
+        "./prototype",
+        "./setup-agent-skills",
+        "./setup-coding-quality-checks",
+        "./tdd",
+        "./to-issues",
+        "./to-prd",
+        "./to-qa",
+        "./triage",
+        "./zoom-out"
+      ]
+    },
+    {
+      "name": "productivity",
+      "source": "./productivity",
+      "skills": [
+        "./caveman",
+        "./grill-me",
+        "./handoff",
+        "./write-a-skill"
+      ]
+    },
+    {
+      "name": "misc",
+      "source": "./misc",
+      "skills": [
+        "./git-guardrails-opencode",
+        "./migrate-to-shoehorn",
+        "./scaffold-exercises",
+        "./setup-pre-commit"
+      ]
+    }
+  ]
+}

package/README.md

@@ -17,6 +17,8 @@ These skills are designed to be small, easy to adapt, and composable. They work
 npx skills@latest add ecology9191/skills -g
 ```
 
+The install menu is grouped by bucket (`engineering`, `productivity`, `misc`). Toggle a whole category or pick individual skills in one screen.
+
 1. Or install from a git checkout or the published npm package:
 
 ```bash

package/bin/install-summary.mjs

@@ -0,0 +1,74 @@
+import os from "node:os";
+import path from "node:path";
+
+const home = os.homedir();
+
+/** @param {string} targetPath */
+export function shortenPath(targetPath) {
+  const normalized = path.resolve(targetPath);
+  if (normalized.startsWith(`${home}${path.sep}`)) {
+    return `~${path.sep}${path.relative(home, normalized)}`;
+  }
+  return normalized;
+}
+
+/** @param {string} bucketId */
+export function bucketTitle(bucketId) {
+  return bucketId
+    .split("-")
+    .map((part) => part.charAt(0).toUpperCase() + part.slice(1))
+    .join(" ");
+}
+
+/** @param {string[]} paths */
+export function dedupePaths(paths) {
+  return [...new Set(paths)];
+}
+
+/**
+ * @param {Map<string, { name: string, dest: string, src?: string }[]>} grouped
+ * @param {{ mode: "copy" | "link", dryRun: boolean }} options
+ */
+export function formatInstallSummary(grouped, { mode, dryRun }) {
+  const lines = [];
+  const actionLabel = dryRun ? (mode === "link" ? "would link" : "would install") : mode;
+
+  for (const [bucket, bucketSkills] of grouped) {
+    lines.push("");
+    lines.push(bucketTitle(bucket));
+
+    for (const skill of bucketSkills) {
+      const shortDest = shortenPath(skill.dest);
+
+      if (mode === "copy") {
+        const marker = dryRun ? actionLabel : "copied";
+        lines.push(`✓ ${skill.name} (${marker})`);
+        lines.push(`  → ${shortDest}`);
+        continue;
+      }
+
+      if (dryRun) {
+        lines.push(`✓ ${skill.name} (${actionLabel})`);
+        lines.push(`  → ${shortDest}`);
+        if (skill.src) {
+          lines.push(`  → ${shortenPath(skill.src)}`);
+        }
+        continue;
+      }
+
+      lines.push(`✓ ${skill.name}`);
+      lines.push(`  → ${shortDest}`);
+      if (skill.src) {
+        lines.push(`  → ${shortenPath(skill.src)}`);
+      }
+    }
+  }
+
+  const skillCount = [...grouped.values()].reduce((total, skills) => total + skills.length, 0);
+  const verb = dryRun ? "Checked" : mode === "link" ? "Linked" : "Installed";
+
+  return {
+    title: `${verb} ${skillCount} skill${skillCount === 1 ? "" : "s"}`,
+    lines: lines.join("\n").trimStart(),
+  };
+}

package/bin/install-summary.test.mjs

@@ -0,0 +1,31 @@
+import assert from "node:assert/strict";
+import os from "node:os";
+import path from "node:path";
+import { test } from "node:test";
+import { dedupePaths, formatInstallSummary, shortenPath } from "./install-summary.mjs";
+
+test("dedupePaths removes duplicate install destinations", () => {
+  assert.deepEqual(
+    dedupePaths(["~/.agents/skills/tdd", "~/.agents/skills/tdd", "~/.cursor/skills/tdd"]),
+    ["~/.agents/skills/tdd", "~/.cursor/skills/tdd"],
+  );
+});
+
+test("formatInstallSummary shows one destination line per skill", () => {
+  const dest = path.join(os.homedir(), ".agents", "skills", "diagnose");
+  const grouped = new Map([
+    [
+      "engineering",
+      [{ name: "diagnose", dest }],
+    ],
+  ]);
+
+  const summary = formatInstallSummary(grouped, { mode: "copy", dryRun: false });
+  assert.equal(summary.title, "Installed 1 skill");
+  assert.equal(summary.lines.split("\n").filter((line) => line.startsWith("  →")).length, 1);
+});
+
+test("shortenPath replaces home prefix with tilde", () => {
+  const dest = path.join(os.homedir(), ".agents", "skills", "tdd");
+  assert.equal(shortenPath(dest), "~/.agents/skills/tdd");
+});

package/bin/install.mjs

@@ -3,12 +3,14 @@ import fs from "node:fs";
 import os from "node:os";
 import path from "node:path";
 import { fileURLToPath } from "node:url";
+import { note, outro, spinner } from "@clack/prompts";
 import {
   collectSkillsByBucket,
   countByBucket,
   flattenCatalog,
   formatBucketCounts,
 } from "./collect-skills.mjs";
+import { formatInstallSummary } from "./install-summary.mjs";
 import { promptSkillSelection } from "./prompt-skills.mjs";
 import { parseArgs, resolveSelection, skillsFromNames } from "./resolve-selection.mjs";
 
@@ -54,6 +56,7 @@ const isGitCheckout = fs.existsSync(path.join(root, ".git"));
 const link = flags.has("--link") || (isGitCheckout && !flags.has("--copy"));
 const isInteractive =
   Boolean(process.stdin.isTTY && process.stdout.isTTY) && !flags.has("--all");
+const useClackSummary = isInteractive;
 
 const catalog = collectSkillsByBucket(root, destRoot);
 const allSkills = flattenCatalog(catalog);
@@ -97,39 +100,54 @@ function installCopy(skills) {
 
   const grouped = groupSkillsByBucket(skills);
   for (const [bucket, bucketSkills] of grouped) {
-    console.log(`${bucket} (${bucketSkills.length})`);
+    if (!useClackSummary) {
+      console.log(`${bucket} (${bucketSkills.length})`);
+    }
+
     for (const skill of bucketSkills) {
       if (dryRun) {
-        console.log(`  would install ${skill.name} -> ${skill.dest}`);
+        if (!useClackSummary) {
+          console.log(`  would install ${skill.name} -> ${skill.dest}`);
+        }
         continue;
       }
 
       fs.rmSync(skill.dest, { recursive: true, force: true });
       fs.cpSync(skill.src, skill.dest, { recursive: true, force: true });
-      console.log(`  installed ${skill.name} -> ${skill.dest}`);
+      if (!useClackSummary) {
+        console.log(`  installed ${skill.name} -> ${skill.dest}`);
+      }
     }
   }
+
+  return grouped;
 }
 
 /** @param {{ bucket: string, name: string, src: string, dest: string }[]} skills */
 function installLink(skills) {
+  const grouped = groupSkillsByBucket(skills);
+
   if (dryRun) {
-    const grouped = groupSkillsByBucket(skills);
     for (const [bucket, bucketSkills] of grouped) {
-      console.log(`${bucket} (${bucketSkills.length})`);
+      if (!useClackSummary) {
+        console.log(`${bucket} (${bucketSkills.length})`);
+      }
       for (const skill of bucketSkills) {
-        console.log(`  would link ${skill.name} -> ${skill.dest} (${skill.src})`);
+        if (!useClackSummary) {
+          console.log(`  would link ${skill.name} -> ${skill.dest} (${skill.src})`);
+        }
       }
     }
-    return;
+    return grouped;
   }
 
   assertSafeDest();
   fs.mkdirSync(destRoot, { recursive: true });
 
-  const grouped = groupSkillsByBucket(skills);
   for (const [bucket, bucketSkills] of grouped) {
-    console.log(`${bucket} (${bucketSkills.length})`);
+    if (!useClackSummary) {
+      console.log(`${bucket} (${bucketSkills.length})`);
+    }
     for (const skill of bucketSkills) {
       const stat = fs.lstatSync(skill.dest, { throwIfNoEntry: false });
       if (stat) {
@@ -137,9 +155,43 @@ function installLink(skills) {
       }
 
       fs.symlinkSync(skill.src, skill.dest);
-      console.log(`  linked ${skill.name} -> ${skill.src}`);
+      if (!useClackSummary) {
+        console.log(`  linked ${skill.name} -> ${skill.src}`);
+      }
     }
   }
+
+  return grouped;
+}
+
+function printPlainSummary(selectedSkills, mode) {
+  const verb = dryRun ? "Checked" : mode === "link" ? "Linked" : "Installed";
+  console.log(
+    `${verb} ${selectedSkills.length} skills to ~/.agents/skills (${formatBucketCounts(countByBucket(selectedSkills))}).`,
+  );
+  console.log("Restart your agent (opencode, Cursor, etc.) to reload the skill list.");
+}
+
+function printClackSummary(grouped, mode) {
+  const summarySkills = new Map();
+  for (const [bucket, bucketSkills] of grouped) {
+    summarySkills.set(
+      bucket,
+      bucketSkills.map((skill) => ({
+        name: skill.name,
+        dest: skill.dest,
+        src: mode === "link" ? skill.src : undefined,
+      })),
+    );
+  }
+
+  const { title, lines } = formatInstallSummary(summarySkills, {
+    mode: mode === "link" ? "link" : "copy",
+    dryRun,
+  });
+
+  note(lines, title);
+  outro("Restart your agent (opencode, Cursor, etc.) to reload the skill list.");
 }
 
 let selectedSkills;
@@ -163,18 +215,23 @@ if (selectedSkills.length === 0) {
   process.exit(0);
 }
 
-if (link) {
-  installLink(selectedSkills);
-  const verb = dryRun ? "Checked" : "Linked";
-  console.log(
-    `${verb} ${selectedSkills.length} skills to ~/.agents/skills (${formatBucketCounts(countByBucket(selectedSkills))}).`,
-  );
+const installMode = link ? "link" : "copy";
+const s = spinner();
+
+if (useClackSummary) {
+  s.start("Installing skills...");
+}
+
+let grouped;
+if (installMode === "link") {
+  grouped = installLink(selectedSkills);
 } else {
-  installCopy(selectedSkills);
-  const verb = dryRun ? "Checked" : "Installed";
-  console.log(
-    `${verb} ${selectedSkills.length} skills to ~/.agents/skills (${formatBucketCounts(countByBucket(selectedSkills))}).`,
-  );
+  grouped = installCopy(selectedSkills);
 }
 
-console.log("Restart your agent (opencode, Cursor, etc.) to reload the skill list.");
+if (useClackSummary) {
+  s.stop("Installation complete");
+  printClackSummary(grouped, installMode);
+} else {
+  printPlainSummary(selectedSkills, installMode);
+}

package/bin/prompt-skills.mjs

@@ -1,4 +1,4 @@
-import { cancel, groupMultiselect, intro, isCancel, outro } from "@clack/prompts";
+import { cancel, groupMultiselect, intro, isCancel } from "@clack/prompts";
 
 /**
  * @param {{ id: string, label: string, skills: { name: string, description: string }[] }[]} catalog
@@ -34,6 +34,5 @@ export async function promptSkillSelection(catalog) {
     return null;
   }
 
-  outro(`Selected ${selected.length} skill${selected.length === 1 ? "" : "s"}.`);
   return selected;
 }

package/bin/resolve-selection.mjs

@@ -103,5 +103,16 @@ function filterByFlags(allSkills, values, allNames) {
 export function skillsFromNames(selectedNames, allSkills) {
   if (!selectedNames || selectedNames.length === 0) return [];
   const byName = new Map(allSkills.map((skill) => [skill.name, skill]));
-  return selectedNames.map((name) => byName.get(name)).filter(Boolean);
+  const seen = new Set();
+  /** @type {typeof allSkills} */
+  const selected = [];
+
+  for (const name of selectedNames) {
+    if (seen.has(name)) continue;
+    seen.add(name);
+    const skill = byName.get(name);
+    if (skill) selected.push(skill);
+  }
+
+  return selected;
 }

package/bin/resolve-selection.test.mjs

@@ -58,3 +58,9 @@ test("skillsFromNames preserves prompt order", () => {
   const selected = skillsFromNames(["caveman", "tdd"], allSkills);
   assert.deepEqual(selected.map((skill) => skill.name), ["caveman", "tdd"]);
 });
+
+test("skillsFromNames deduplicates repeated selections", () => {
+  const allSkills = catalog.flatMap((bucket) => bucket.skills);
+  const selected = skillsFromNames(["tdd", "tdd", "tdd"], allSkills);
+  assert.deepEqual(selected.map((skill) => skill.name), ["tdd"]);
+});

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ecology91/skills",
-  "version": "0.1.5",
+  "version": "0.1.7",
   "description": "opencode agent skills for real engineering workflows.",
   "license": "MIT",
   "type": "module",
@@ -13,6 +13,7 @@
   "files": [
     "bin/",
     "scripts/",
+    ".claude-plugin/",
     "skills/engineering/",
     "skills/productivity/",
     "skills/misc/",
@@ -40,11 +41,12 @@
     "access": "public"
   },
   "scripts": {
-    "typecheck": "node --check bin/install.mjs && node --check bin/collect-skills.mjs && node --check bin/prompt-skills.mjs && node --check bin/resolve-selection.mjs && node --check bin/resolve-selection.test.mjs && node --check scripts/verify-package-files.mjs",
-    "test": "node --test bin/resolve-selection.test.mjs && node bin/install.mjs --dry-run --copy --all",
-    "test:unit": "node --test bin/resolve-selection.test.mjs",
+    "typecheck": "node --check bin/install.mjs && node --check bin/collect-skills.mjs && node --check bin/install-summary.mjs && node --check bin/prompt-skills.mjs && node --check bin/resolve-selection.mjs && node --check bin/resolve-selection.test.mjs && node --check bin/install-summary.test.mjs && node --check scripts/generate-marketplace.mjs && node --check scripts/verify-marketplace.mjs && node --check scripts/verify-package-files.mjs",
+    "test": "node --test bin/resolve-selection.test.mjs && node --test bin/install-summary.test.mjs && node bin/install.mjs --dry-run --copy --all",
+    "test:unit": "node --test bin/resolve-selection.test.mjs && node --test bin/install-summary.test.mjs",
     "link-skills": "./scripts/link-skills.sh",
-    "build": "node scripts/verify-package-files.mjs",
+    "build": "node scripts/verify-package-files.mjs && node scripts/verify-marketplace.mjs",
+    "generate:marketplace": "node scripts/generate-marketplace.mjs",
     "validate:fast": "npm run typecheck && npm run test",
     "validate": "npm run validate:fast && npm run build"
   }

package/scripts/generate-marketplace.mjs

@@ -0,0 +1,24 @@
+#!/usr/bin/env node
+import fs from "node:fs";
+import path from "node:path";
+import { fileURLToPath } from "node:url";
+import { collectSkillsByBucket } from "../bin/collect-skills.mjs";
+
+const root = path.resolve(path.dirname(fileURLToPath(import.meta.url)), "..");
+const outPath = path.join(root, ".claude-plugin", "marketplace.json");
+
+const catalog = collectSkillsByBucket(root, "/tmp/unused");
+
+const manifest = {
+  metadata: { pluginRoot: "./skills" },
+  plugins: catalog.map((bucket) => ({
+    name: bucket.id,
+    source: `./${bucket.id}`,
+    skills: bucket.skills.map((skill) => `./${skill.name}`),
+  })),
+};
+
+fs.mkdirSync(path.dirname(outPath), { recursive: true });
+fs.writeFileSync(outPath, `${JSON.stringify(manifest, null, 2)}\n`);
+
+console.log(`Wrote ${path.relative(root, outPath)} (${catalog.flatMap((b) => b.skills).length} skills).`);

package/scripts/verify-marketplace.mjs

@@ -0,0 +1,33 @@
+#!/usr/bin/env node
+import fs from "node:fs";
+import path from "node:path";
+import { fileURLToPath } from "node:url";
+import { collectSkillsByBucket } from "../bin/collect-skills.mjs";
+
+const root = path.resolve(path.dirname(fileURLToPath(import.meta.url)), "..");
+const marketplacePath = path.join(root, ".claude-plugin", "marketplace.json");
+
+const catalog = collectSkillsByBucket(root, "/tmp/unused");
+const expected = {
+  metadata: { pluginRoot: "./skills" },
+  plugins: catalog.map((bucket) => ({
+    name: bucket.id,
+    source: `./${bucket.id}`,
+    skills: bucket.skills.map((skill) => `./${skill.name}`),
+  })),
+};
+
+if (!fs.existsSync(marketplacePath)) {
+  console.error("Missing .claude-plugin/marketplace.json — run: npm run generate:marketplace");
+  process.exit(1);
+}
+
+const actual = JSON.parse(fs.readFileSync(marketplacePath, "utf8"));
+if (JSON.stringify(actual) !== JSON.stringify(expected)) {
+  console.error(
+    ".claude-plugin/marketplace.json is out of date — run: npm run generate:marketplace",
+  );
+  process.exit(1);
+}
+
+console.log("Verified .claude-plugin/marketplace.json matches promoted skills.");