@eclipse-scout/core 22.0.33 → 22.0.37

package/dist/file-list

@@ -1,9 +1,9 @@
-eclipse-scout-core-b11dde8e4ac1367f5a06.min.js
-eclipse-scout-core-b11dde8e4ac1367f5a06.min.js.map
-eclipse-scout-core-theme-dark-0d9d468e5722f73f5075.min.css
+eclipse-scout-core-990e036967fa14669bd8.min.js
+eclipse-scout-core-990e036967fa14669bd8.min.js.map
+eclipse-scout-core-theme-dark-17a1d77d53510e113a3c.min.css
 eclipse-scout-core-theme-dark.css
 eclipse-scout-core-theme-dark.css.map
-eclipse-scout-core-theme-db0af3fa95956b820bfc.min.css
+eclipse-scout-core-theme-dfed415a6b7fb17f3f4c.min.css
 eclipse-scout-core-theme.css
 eclipse-scout-core-theme.css.map
 eclipse-scout-core.js

package/dist/texts.json

@@ -6,6 +6,7 @@
     "Column": "Column",
     "ColumnSorting": "Sorting",
     "ConfirmApplyChanges": "Would you like to apply the changes?",
+    "DateIsNotAllowed": "Date is not allowed",
     "ErrorWhileLoadingData": "Failed to load the data.",
     "FormEmptyMandatoryFieldsMessage": "The following fields must be filled in:",
     "FormInvalidFieldsMessage": "The following fields are invalid:",
@@ -186,6 +187,7 @@
     "Column": "Colonne",
     "ColumnSorting": "Tri",
     "ConfirmApplyChanges": "Voulez-vous appliquer les modifications?",
+    "DateIsNotAllowed": "Date interdite",
     "ErrorWhileLoadingData": "Erreur lors du chargement des données",
     "FormEmptyMandatoryFieldsMessage": "Les champs suivants doivent être remplis:",
     "FormInvalidFieldsMessage": "Les champs suivants ont une valeur invalide:",
@@ -366,6 +368,7 @@
     "Column": "Colonna",
     "ColumnSorting": "Ordinamento",
     "ConfirmApplyChanges": "Applicare le modifiche?",
+    "DateIsNotAllowed": "Data non valida",
     "ErrorWhileLoadingData": "Caricamento dati fallito",
     "FormEmptyMandatoryFieldsMessage": "I seguenti campi devono essere compilati:",
     "FormInvalidFieldsMessage": "I campi seguenti hanno un valore invalido:",
@@ -546,6 +549,7 @@
     "Column": "Spalte",
     "ColumnSorting": "Sortierung",
     "ConfirmApplyChanges": "Möchten Sie die Änderungen übernehmen?",
+    "DateIsNotAllowed": "Unzulässiges Datum",
     "ErrorWhileLoadingData": "Fehler beim Laden der Daten",
     "FormEmptyMandatoryFieldsMessage": "Folgende Felder müssen ausgefüllt werden:",
     "FormInvalidFieldsMessage": "Folgende Felder haben einen ungültigen Wert:",
@@ -814,6 +818,7 @@
     "CloseButton": "Cerrar",
     "Column": "Columna",
     "ColumnSorting": "Clasificación",
+    "DateIsNotAllowed": "No se permite la fecha",
     "ErrorWhileLoadingData": "Error al cargar los datos.",
     "FormEmptyMandatoryFieldsMessage": "Se requieren los siguientes campos:",
     "FormInvalidFieldsMessage": "Los siguientes campos no son válidos:",
@@ -1005,6 +1010,7 @@
     "CloseButton": "閉じる",
     "Column": "間隙",
     "ColumnSorting": "並び替え",
+    "DateIsNotAllowed": "日付は許可されていません",
     "ErrorWhileLoadingData": "データの読み込みに失敗しました。",
     "FormEmptyMandatoryFieldsMessage": "以下のフィールドが必要です:",
     "FormInvalidFieldsMessage": "以下のフィールドは無効です:",
@@ -1043,6 +1049,7 @@
     "CancelButton": "Annuleer",
     "CloseButton": "Sluit",
     "Column": "Kolom",
+    "DateIsNotAllowed": "Datum is niet toegestaan",
     "ErrorWhileLoadingData": "Laden van gegevens mislukt.",
     "FormEmptyMandatoryFieldsMessage": "Volgende velden zijn verplicht:",
     "FormInvalidFieldsMessage": "Volgende velden zijn ongeldig:",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@eclipse-scout/core",
-  "version": "22.0.33",
+  "version": "22.0.37",
   "description": "Eclipse Scout runtime",
   "author": "BSI Business Systems Integration AG",
   "homepage": "https://www.eclipse.org/scout",
@@ -26,7 +26,7 @@
     "src"
   ],
   "devDependencies": {
-    "@eclipse-scout/cli": "22.0.33",
+    "@eclipse-scout/cli": "22.0.37",
     "@eclipse-scout/releng": "^22.0.0",
     "jasmine-core": "3.10.1",
     "jasmine-ajax": "4.0.0",

package/src/App.js

@@ -3,7 +3,7 @@
  * All rights reserved. This program and the accompanying materials
  * are made available under the terms of the Eclipse Public License v1.0
  * which accompanies this distribution, and is available at
- * http://www.eclipse.org/legal/epl-v10.html
+ * https://www.eclipse.org/legal/epl-v10.html
  *
  * Contributors:
  *     BSI Business Systems Integration AG - initial API and implementation
@@ -341,8 +341,9 @@ export default class App {
     // Bluebird has a polyfill -> can it be ported to jQuery?
   }
 
-  _createErrorHandler() {
-    return scout.create('ErrorHandler');
+  _createErrorHandler(opts) {
+    opts = $.extend({}, opts);
+    return scout.create('ErrorHandler', opts);
   }
 
   /**
@@ -459,16 +460,33 @@ export default class App {
     $.log.error('App initialization failed.');
     this.setLoading(false);
 
-    return this.errorHandler.handle(error, ...args)
-      .then(errorInfo => {
-        let $error = $('body').appendDiv('startup-error');
-        $error.appendDiv('startup-error-title').text('The application could not be started');
-        if (errorInfo.message) {
-          $error.appendDiv('startup-error-message').text(errorInfo.message);
-        }
-        // Reject with original rejection arguments
-        return $.rejectedPromise(error, ...args);
-      });
+    let promises = [];
+    if (this.sessions.length === 0) {
+      promises.push(this.errorHandler.handle(error, ...args)
+        .then(errorInfo => {
+          this._appendStartupError($('body'), errorInfo.message);
+        }));
+    } else {
+      // Session.js may already display a fatal message box
+      // -> don't handle the error again and display multiple error messages
+      this.sessions
+        .filter(session => !session.ready && !session.isFatalMessageShown())
+        .forEach(session => {
+          session.$entryPoint.empty();
+          promises.push(this._createErrorHandler({session: session}).handle(error));
+        });
+    }
+
+    // Reject with original rejection arguments
+    return $.promiseAll(promises).then(errorInfo => $.rejectedPromise(error, ...args));
+  }
+
+  _appendStartupError($parent, message) {
+    let $error = $parent.appendDiv('startup-error');
+    $error.appendDiv('startup-error-title').text('The application could not be started');
+    if (message) {
+      $error.appendDiv('startup-error-message').text(message);
+    }
   }
 
   /**
@@ -517,13 +535,3 @@ export default class App {
     return this.events.when(type);
   }
 }
-/*
- * Copyright (c) 2010-2019 BSI Business Systems Integration AG.
- * All rights reserved. This program and the accompanying materials
- * are made available under the terms of the Eclipse Public License v1.0
- * which accompanies this distribution, and is available at
- * http://www.eclipse.org/legal/epl-v10.html
- *
- * Contributors:
- *     BSI Business Systems Integration AG - initial API and implementation
- */

package/src/ErrorHandler.js

@@ -19,6 +19,7 @@ export default class ErrorHandler {
     this.displayError = true;
     this.sendError = false;
     this.windowErrorHandler = this._onWindowError.bind(this);
+    this.session = null;
   }
 
   /**
@@ -264,8 +265,8 @@ export default class ErrorHandler {
     // Note: The error handler is installed globally and we cannot tell in which scout session the error happened.
     // We simply use the first scout session to display the message box and log the error. This is not ideal in the
     // multi-session-case (portlet), but currently there is no other way. Besides, this feature is not in use yet.
-    if (App.get().sessions.length > 0) {
-      let session = App.get().sessions[0];
+    let session = this.session || App.get().sessions[0];
+    if (session) {
       if (this.displayError && errorInfo.level === logging.Level.ERROR) {
         this._showMessageBox(session, errorInfo.message, errorInfo.code, errorInfo.log);
       }

package/src/RemoteApp.js

@@ -1,9 +1,9 @@
 /*
- * Copyright (c) 2014-2018 BSI Business Systems Integration AG.
+ * Copyright (c) 2010-2022 BSI Business Systems Integration AG.
  * All rights reserved. This program and the accompanying materials
  * are made available under the terms of the Eclipse Public License v1.0
  * which accompanies this distribution, and is available at
- * http://www.eclipse.org/legal/epl-v10.html
+ * https://www.eclipse.org/legal/epl-v10.html
  *
  * Contributors:
  *     BSI Business Systems Integration AG - initial API and implementation
@@ -31,10 +31,11 @@ export default class RemoteApp extends App {
     defaultValues.bootstrap();
   }
 
-  _createErrorHandler() {
-    return scout.create('ErrorHandler', {
+  _createErrorHandler(opts) {
+    opts = $.extend({
       sendError: true
-    });
+    }, opts);
+    return super._createErrorHandler(opts);
   }
 
   /**
@@ -47,12 +48,4 @@ export default class RemoteApp extends App {
     App.get().sessions.push(session);
     return session.start();
   }
-
-  _fail(options, error, ...args) {
-    $.log.error('App initialization failed', error);
-    this.setLoading(false);
-    // Session.js already handled the error -> don't show a message here
-    // Reject with original rejection arguments
-    return $.rejectedPromise(error, ...args);
-  }
 }

package/src/datepicker/DatePicker.js

@@ -23,7 +23,7 @@ export default class DatePicker extends Widget {
     this.selectedDate = null;
     this.dateFormat = null;
     this.viewDate = null;
-    this.allowedDates = null;
+    this.allowedDates = [];
     this.currentMonth = null;
     this.$scrollable = null;
     // Contains the months to be rendered.
@@ -342,7 +342,7 @@ export default class DatePicker extends Widget {
     let date = this.preselectedDate;
 
     if (this.selectedDate) {
-      if (this.allowedDates) {
+      if (this.allowedDates.length > 0) {
         date = this._findNextAllowedDate(years, months, days);
       } else {
         date = dates.shift(this.selectedDate, years, months, days);
@@ -391,16 +391,12 @@ export default class DatePicker extends Widget {
 
   _isDateAllowed(date) {
     // when allowedDates is empty or not set, any date is allowed
-    if (!this.allowedDates || this.allowedDates.length === 0) {
+    if (this.allowedDates.length === 0) {
       return true;
     }
     // when allowedDates is set, only dates contained in this array are allowed
-    let allowedDateAsTimestamp,
-      dateAsTimestamp = date.getTime();
-    return this.allowedDates.some(allowedDate => {
-      allowedDateAsTimestamp = allowedDate.getTime();
-      return allowedDateAsTimestamp === dateAsTimestamp;
-    });
+    let dateAsTimestamp = dates.trunc(date).getTime();
+    return this.allowedDates.some(allowedDate => allowedDate.getTime() === dateAsTimestamp);
   }
 
   _build$DateBox(viewDate) {

package/src/desktop/outline/Outline.js

@@ -1,9 +1,9 @@
 /*
- * Copyright (c) 2010-2021 BSI Business Systems Integration AG.
+ * Copyright (c) 2010-2022 BSI Business Systems Integration AG.
  * All rights reserved. This program and the accompanying materials
  * are made available under the terms of the Eclipse Public License v1.0
  * which accompanies this distribution, and is available at
- * http://www.eclipse.org/legal/epl-v10.html
+ * https://www.eclipse.org/legal/epl-v10.html
  *
  * Contributors:
  *     BSI Business Systems Integration AG - initial API and implementation
@@ -482,6 +482,7 @@ export default class Outline extends Tree {
     }
     this._setProperty('defaultDetailForm', defaultDetailForm);
     if (this.defaultDetailForm) {
+      this.defaultDetailForm.setClosable(false);
       this.defaultDetailForm.detailForm = true;
     }
     if (this.initialized) {

package/src/form/fields/datefield/DateField.js

@@ -16,6 +16,7 @@ export default class DateField extends ValueField {
   constructor() {
     super();
 
+    this.allowedDates = [];
     this.popup = null;
     this.autoDate = null;
     this.dateDisplayText = null;
@@ -438,6 +439,11 @@ export default class DateField extends ValueField {
     if (!(value instanceof Date)) {
       throw this.session.text(this.invalidValueMessageKey);
     }
+
+    if (!this.isDateAllowed(value)) {
+      throw this.session.text('DateIsNotAllowed');
+    }
+
     if (!this.hasDate && !this.value) {
       // truncate to 01.01.1970 if no date was entered before. Otherwise preserve date part (important for toggling hasDate on the fly)
       value = dates.combineDateTime(null, value);
@@ -445,6 +451,14 @@ export default class DateField extends ValueField {
     return value;
   }
 
+  isDateAllowed(date) {
+    if (!date || this.allowedDates.length === 0 || this.embedded) { // in embedded mode, main date field must take care of validation, otherwise error status won't be shown
+      return true;
+    }
+    let dateAsTimestamp = dates.trunc(date).getTime();
+    return this.allowedDates.some(allowedDate => allowedDate.getTime() === dateAsTimestamp);
+  }
+
   _valueEquals(valueA, valueB) {
     return dates.equals(valueA, valueB);
   }
@@ -458,15 +472,19 @@ export default class DateField extends ValueField {
     this._setProperty('autoDate', autoDate);
   }
 
+  setAllowedDates(allowedDates) {
+    this.setProperty('allowedDates', allowedDates);
+  }
+
   _setAllowedDates(allowedDates) {
-    if (Array.isArray(allowedDates)) {
-      allowedDates = allowedDates.map(date => {
-        return dates.ensure(date);
-      });
-      this._setProperty('allowedDates', allowedDates);
-    } else {
-      this._setProperty('allowedDates', null);
-    }
+    let truncDates = [];
+    arrays.ensure(allowedDates).forEach(date => {
+      if (date) {
+        truncDates.push(dates.trunc(dates.ensure(date)));
+      }
+    });
+    truncDates = truncDates.sort(dates.compare);
+    this._setProperty('allowedDates', truncDates);
   }
 
   /**

package/src/form/fields/datefield/DateFieldAdapter.js

@@ -8,7 +8,7 @@
  * Contributors:
  *     BSI Business Systems Integration AG - initial API and implementation
  */
-import {arrays, dates, ParsingFailedStatus, ValueFieldAdapter} from '../../../index';
+import {App, arrays, DateField, dates, objects, ParsingFailedStatus, ValueFieldAdapter} from '../../../index';
 
 export default class DateFieldAdapter extends ValueFieldAdapter {
 
@@ -18,13 +18,6 @@ export default class DateFieldAdapter extends ValueFieldAdapter {
 
   static PROPERTIES_ORDER = ['hasTime', 'hasDate'];
 
-  /**
-   * @override
-   */
-  _initProperties(model) {
-    super._initProperties(model);
-  }
-
   /**
    * @override
    */
@@ -64,4 +57,21 @@ export default class DateFieldAdapter extends ValueFieldAdapter {
     return Object.keys(newProperties).sort(this._createPropertySortFunc(DateFieldAdapter.PROPERTIES_ORDER));
   }
 
+  static isDateAllowedRemote(date) {
+    if (!this.modelAdapter) {
+      return this.isDateAllowedOrig(date);
+    }
+    // Server will take care of it
+    return true;
+  }
+
+  static modifyPrototype() {
+    if (!App.get().remote) {
+      return;
+    }
+
+    objects.replacePrototypeFunction(DateField, 'isDateAllowed', DateFieldAdapter.isDateAllowedRemote, true);
+  }
 }
+
+App.addListener('bootstrap', DateFieldAdapter.modifyPrototype);

package/src/form/js/JsFormAdapter.js

@@ -15,6 +15,7 @@ import {FormAdapter} from '../../index';
  * @property {object} parent
  * @property {object} owner
  * @property {object} displayParent
+ * @property {string} displayHint
  * @property {object} inputData
  * @property {string} jsFormObjectType
  * @property {object} jsFormModel
@@ -41,6 +42,7 @@ export default class JsFormAdapter extends FormAdapter {
       owner: model.owner,
       objectType: model.jsFormObjectType,
       displayParent: model.displayParent,
+      displayHint: model.displayHint,
       data: model.inputData
     };
 

package/src/keystroke/KeyStroke.js

@@ -8,7 +8,7 @@
  * Contributors:
  *     BSI Business Systems Integration AG - initial API and implementation
  */
-import {Action, HAlign, Key, keys, scout} from '../index';
+import {Action, HAlign, Key, keys, scout, Widget} from '../index';
 import $ from 'jquery';
 
 export default class KeyStroke {
@@ -134,24 +134,29 @@ export default class KeyStroke {
   _isEnabled() {
     // Hint: do not check for which.length because there are keystrokes without a which, e.g. RangeKeyStroke.js
 
-    if (this.field) {
-      // Check visibility
-      if (this.field.visible !== undefined && !this.field.visible) {
-        return false;
-      }
-      // Check enabled state (if inheritAccessibility is true)
-      if (!this.inheritAccessibility) {
-        return true;
-      }
-      if (this.field.enabledComputed !== undefined) {
-        return this.field.enabledComputed;
-      }
-      if (this.field.enabled !== undefined) {
-        // This should actually not happen because this.field should always be a hypothetical case if this.field is not a widget
-        return this.field.enabled;
-      }
+    if (!this.field) {
+      return true;
+    }
+    if (this.field instanceof Widget && this.field.isRemovalPending()) {
+      // Prevent possible exceptions or unexpected behavior if a keystroke is executed while a widget is being removed.
+      return false;
+    }
+    // Check visibility
+    if (this.field.visible !== undefined && !this.field.visible) {
+      return false;
+    }
+    // Check enabled state (if inheritAccessibility is true)
+    if (!this.inheritAccessibility) {
+      return true;
+    }
+    if (this.field.enabledComputed !== undefined) {
+      return this.field.enabledComputed;
+    }
+    if (this.field.enabled !== undefined) {
+      // This should actually not happen because this.field should always be a widget
+      return this.field.enabled;
     }
-    return true;
+    return false;
   }
 
   /**

package/src/lookup/StaticLookupCall.js

@@ -120,14 +120,39 @@ export default class StaticLookupCall extends LookupCall {
   }
 
   _lookupRowsByText(text) {
-    let datas = this.data.filter(data => {
-      return strings.startsWith(data[1].toLowerCase(), text.toLowerCase());
-    });
+    let regex = this._createSearchPattern(text);
+    let datas = this.data.filter(data => regex.test(data[1].toLowerCase()));
     return datas
       .map(this._dataToLookupRow, this)
       .filter(this._filterActiveLookupRow, this);
   }
 
+  _createSearchPattern(text) {
+    // Implementation copied from LocalLookupRow.java
+
+    const WILDCARD = '*';
+    const WILDCARD_PLACEHOLDER = '@wildcard@';
+
+    text = strings.nvl(text);
+    text = text.toLowerCase();
+    text = text.replace(new RegExp(strings.quote(WILDCARD), 'g'), WILDCARD_PLACEHOLDER);
+    text = strings.quote(text);
+
+    // replace repeating wildcards to prevent regex DoS
+    let duplicateWildcards = WILDCARD_PLACEHOLDER + WILDCARD_PLACEHOLDER;
+    while (strings.contains(text, duplicateWildcards)) {
+      text = text.replace(duplicateWildcards, WILDCARD_PLACEHOLDER);
+    }
+
+    if (!strings.endsWith(WILDCARD_PLACEHOLDER)) {
+      text += WILDCARD_PLACEHOLDER;
+    }
+
+    text = text.replace(new RegExp(strings.quote(WILDCARD_PLACEHOLDER), 'g'), '.*');
+
+    return new RegExp('^' + text + '$', 's'); // s = DOT_ALL
+  }
+
   _getByKey(key) {
     let deferred = $.Deferred();
     setTimeout(this._queryByKey.bind(this, deferred, key), this.delay);

package/src/main.less

@@ -501,6 +501,7 @@ a,
   padding: 20px;
   border: 1px solid @error-border-color;
   background-color: @error-background-color;
+  border-radius: @border-radius-large;
 }
 
 .startup-error-title {