@eclipse-scout/core 22.0.1 → 22.0.2

package/src/table/columns/Column.js

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2010-2021 BSI Business Systems Integration AG.
+ * Copyright (c) 2010-2022 BSI Business Systems Integration AG.
  * All rights reserved. This program and the accompanying materials
  * are made available under the terms of the Eclipse Public License v1.0
  * which accompanies this distribution, and is available at
@@ -43,7 +43,6 @@ export default class Column {
     this.type = 'text';
     this.width = 60;
     this.initialWidth = undefined; // the width the column initially has
-    this.prefMinWidth = null;
     this.minWidth = Column.DEFAULT_MIN_WIDTH; // the minimal width the column can have
     this.showSeparator = true;
     this.table = null;
@@ -71,7 +70,8 @@ export default class Column {
   }
 
   static DEFAULT_MIN_WIDTH = 60;
-  static NARROW_MIN_WIDTH = 32; // for columns without text (icon, check box)
+  static SMALL_MIN_WIDTH = 38;
+  static NARROW_MIN_WIDTH = 32;
 
   init(model) {
     this.session = model.session;

package/src/table/editor/CellEditorPopup.js

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2014-2018 BSI Business Systems Integration AG.
+ * Copyright (c) 2010-2022 BSI Business Systems Integration AG.
  * All rights reserved. This program and the accompanying materials
  * are made available under the terms of the Eclipse Public License v1.0
  * which accompanies this distribution, and is available at
@@ -63,6 +63,13 @@ export default class CellEditorPopup extends Popup {
     this.pack();
   }
 
+  /**
+   * @override
+   */
+  _getDefaultOpen$Parent() {
+    return this.table.$data;
+  }
+
   _render() {
     super._render();
 

package/src/tile/TileGrid.js

@@ -396,7 +396,7 @@ export default class TileGrid extends Widget {
   }
 
   _onAnimatedTileRemove(tile) {
-    if (!tile.rendered || !tile.animateRemoval) {
+    if (!tile.removalPending) {
       return;
     }
     this.tileRemovalPendingCount++;

package/src/tile/TileGridLayout.js

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2010-2021 BSI Business Systems Integration AG.
+ * Copyright (c) 2010-2022 BSI Business Systems Integration AG.
  * All rights reserved. This program and the accompanying materials
  * are made available under the terms of the Eclipse Public License v1.0
  * which accompanies this distribution, and is available at
@@ -151,7 +151,7 @@ export default class TileGridLayout extends LogicalGridLayout {
    */
   _layoutCellBounds(containerSize, containerInsets) {
     // Since the tiles are positioned absolutely it is necessary to add the height of the filler to the top insets
-    if (this.widget.virtual) {
+    if (this.widget.virtual && this.widget.$fillBefore) {
       containerInsets.top += this.widget.$fillBefore.outerHeight(true);
     }
     return super._layoutCellBounds(containerSize, containerInsets);

package/src/tile/accordion/TileAccordion.js

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2010-2021 BSI Business Systems Integration AG.
+ * Copyright (c) 2010-2022 BSI Business Systems Integration AG.
  * All rights reserved. This program and the accompanying materials
  * are made available under the terms of the Eclipse Public License v1.0
  * which accompanies this distribution, and is available at
@@ -352,6 +352,21 @@ export default class TileAccordion extends Accordion {
   _filter() {
     this.groups.forEach(group => {
       group.body.filter();
+
+      // If the layout has not been invalidated as part of the filtering above, it even though must be validated here.
+      // This is because groups above might have fewer visible Tiles now which makes room for this group.
+      // The revalidateLayout() with scrolling=true here ensures TileGrid._renderViewPort() is called to ensure these Tiles become visible as there is space available now.
+      // It is executed as postValidateFunction because the groups above must have completed their layouting so that
+      // TileGrid._renderViewPort() knows that there is more space available now.
+      if (group.body.htmlComp && group.body.htmlComp.valid && !group.body._accordionLayoutHandler /* skip if already registered */) {
+        group.body._accordionLayoutHandler = () => {
+          group.body.scrolling = true;
+          group.body.revalidateLayout();
+          group.body.scrolling = false;
+          group.body._accordionLayoutHandler = null;
+        };
+        this.session.layoutValidator.schedulePostValidateFunction(group.body._accordionLayoutHandler);
+      }
     });
   }
 

package/src/tile/fields/FormFieldTile.less

@@ -222,8 +222,16 @@
         }
       }
 
-      &.has-error > .status::before {
-        color: @palette-red-3;
+      &.has-error > .status {
+        &::before {
+          color: @tile-default-inverted-error-status-color;
+        }
+
+        &:hover::before,
+        &:active::before,
+        &.selected::before {
+          color: @tile-default-inverted-error-status-hover-color;
+        }
       }
 
       .scrollbar-thumb-handle {
@@ -315,11 +323,11 @@
   }
 
   &.selected {
-    #scout.double-drop-shadow(@spread1: 2px, @color1: @dashboard-tile-selected-border-color, @y2: 0px, @blur2: 0px);
+    #scout.double-drop-shadow(@spread1: 2px, @color1: @dashboard-tile-default-selected-border-color, @y2: 0px, @blur2: 0px);
 
     &.inverted {
-      --tile-background-color: mix(@tile-default-inverted-background-color, @tile-default-inverted-selection-background-color, 65%);
-      #scout.double-drop-shadow(@spread1: 2px, @color1: @dashboard-tile-default-selected-border-color, @y2: 0px, @blur2: 0px);
+      --tile-background-color: @dashboard-tile-default-inverted-background-color;
+      #scout.double-drop-shadow(@spread1: 2px, @color1: @dashboard-tile-default-inverted-selected-border-color, @y2: 0px, @blur2: 0px);
     }
 
     &.color-alternative {
@@ -327,16 +335,15 @@
     }
 
     &.inverted.color-alternative {
-      --tile-background-color: mix(@tile-alternative-inverted-background-color, @tile-alternative-inverted-selection-background-color, 65%);
-      #scout.double-drop-shadow(@spread1: 2px, @color1: @dashboard-tile-alternative-selected-border-color, @y2: 0px, @blur2: 0px);
+      --tile-background-color: @dashboard-tile-alternative-inverted-background-color;
+      #scout.double-drop-shadow(@spread1: 2px, @color1: @dashboard-tile-alternative-inverted-selected-border-color, @y2: 0px, @blur2: 0px);
     }
 
-
     .dimmed-background & {
-      #scout.double-drop-shadow(@spread1: 2px, @color1: @dashboard-tile-selected-border-color, @alpha2: @dashboard-tile-drop-shadow-light-alpha);
+      #scout.double-drop-shadow(@spread1: 2px, @color1: @dashboard-tile-default-selected-border-color, @alpha2: @dashboard-tile-drop-shadow-light-alpha);
 
       &.inverted {
-        #scout.double-drop-shadow(@spread1: 2px, @color1: @dashboard-tile-default-selected-border-color, @alpha2: @dashboard-tile-drop-shadow-dark-alpha);
+        #scout.double-drop-shadow(@spread1: 2px, @color1: @dashboard-tile-default-inverted-selected-border-color, @alpha2: @dashboard-tile-drop-shadow-dark-alpha);
       }
 
       &.color-alternative {
@@ -344,7 +351,7 @@
       }
 
       &.inverted.color-alternative {
-        #scout.double-drop-shadow(@spread1: 2px, @color1: @dashboard-tile-alternative-selected-border-color, @alpha2: @dashboard-tile-drop-shadow-dark-alpha);
+        #scout.double-drop-shadow(@spread1: 2px, @color1: @dashboard-tile-alternative-inverted-selected-border-color, @alpha2: @dashboard-tile-drop-shadow-dark-alpha);
       }
     }
   }

package/src/tree/CompactTree.less

@@ -19,7 +19,7 @@
 
     & > .tree-data > .nodes > .section > .section-node.selected {
       text-decoration: underline;
-      color: @active-color;
+      color: @focus-color;
     }
   }
 

package/src/tree/Tree.less

@@ -216,18 +216,16 @@
 
     .tree-node.lazy > & {
       font-family: @font-default-family;
-      font-size: @font-size-normal;
       content: '+';
       /* Move to left because '+' sign is not as wide as 'arrow-down' */
       margin-left: -2px;
     }
 
     .tree-node.expanded > & {
-      /* This "imprecise" angle is a workround for firefox to prevent shifting the div a little when the animation finishes. */
+      /* This "imprecise" angle is a workaround for firefox to prevent shifting the div a little when the animation finishes. */
       /* See https://bugzilla.mozilla.org/show_bug.cgi?id=739176 */
       #scout.transform(rotate(89.99deg));
     }
-
   }
 
   &:hover {

package/src/util/arrays.js

@@ -206,6 +206,11 @@ export function containsAll(haystack, needles) {
   });
 }
 
+/**
+ * @template T
+ * @param {T[]} arr
+ * @return {T}
+ */
 export function first(arr) {
   if (Array.isArray(arr)) {
     return arr[0];
@@ -213,6 +218,11 @@ export function first(arr) {
   return arr;
 }
 
+/**
+ * @template T
+ * @param {T[]} arr
+ * @return {T}
+ */
 export function last(arr) {
   if (Array.isArray(arr)) {
     return arr[arr.length - 1];
@@ -285,8 +295,8 @@ export function union(array1, array2) {
   return result;
 }
 
-// noinspection DuplicatedCode
 export function equalsIgnoreOrder(arr, arr2) {
+  // noinspection DuplicatedCode
   if (arr === arr2) {
     return true;
   }
@@ -302,8 +312,8 @@ export function equalsIgnoreOrder(arr, arr2) {
   return containsAll(arr, arr2);
 }
 
-// noinspection DuplicatedCode
 export function equals(arr, arr2) {
+  // noinspection DuplicatedCode
   if (arr === arr2) {
     return true;
   }
@@ -600,6 +610,17 @@ export function toMap(array, keyMapper = (el => el), valueMapper = (el => el)) {
   }, {}));
 }
 
+/**
+ * If the argument is an empty array, null is returned. Otherwise, the argument is returned unchanged.
+ *
+ * @template T
+ * @param {T[]} array
+ * @return {T[]|null}
+ */
+export function nullIfEmpty(array) {
+  return empty(array) ? null : array;
+}
+
 export default {
   $indexOf,
   $remove,
@@ -638,6 +659,7 @@ export default {
   max,
   min,
   move,
+  nullIfEmpty,
   pushAll,
   pushIfDefined,
   pushSet,

package/src/util/objects.js

@@ -693,11 +693,14 @@ export function resolveConstProperty(object, config) {
 /**
  * @param {object} obj
  * @returns {Boolean|undefined}
- *  - true if the obj is empty
+ *  - true if the obj is empty, null or undefined
  *  - false if the obj is not empty
  *  - nothing if the obj is not an object
  */
 export function isEmpty(obj) {
+  if (isNullOrUndefined(obj)) {
+    return true;
+  }
   if (!isPlainObject(obj)) {
     return;
   }

package/src/widget/Widget.js

@@ -524,7 +524,8 @@ export default class Widget {
    * After the animation is executed, the element gets removed using this._removeInternal.
    */
   _removeAnimated() {
-    if (!Device.get().supportsCssAnimation() || !this.$container || this.$container.isDisplayNone()) {
+    let animateRemovalWhileRemovingParent = this._animateRemovalWhileRemovingParent();
+    if ((this.parent.removing && !animateRemovalWhileRemovingParent) || !Device.get().supportsCssAnimation() || !this.$container || this.$container.isDisplayNone()) {
       // Cannot remove animated, remove regularly
       this._removeInternal();
       return;
@@ -544,7 +545,7 @@ export default class Widget {
       if (!this.animateRemovalClass) {
         throw new Error('Missing animate removal class. Cannot remove animated.');
       }
-      if (!this.$container.isVisible() || !this.$container.isEveryParentVisible()) {
+      if (!this.$container.isVisible() || !this.$container.isEveryParentVisible() || !this.$container.isAttached()) {
         // If element is not visible, animationEnd would never fire -> remove it immediately
         this._removeInternal();
         return;
@@ -557,7 +558,14 @@ export default class Widget {
 
     // If the parent is being removed while the animation is running, the animationEnd event will never fire
     // -> Make sure remove is called nevertheless. Important: remove it before the parent is removed to maintain the regular remove order
-    this.parent.one('removing', this._parentRemovingWhileAnimatingHandler);
+    if (!animateRemovalWhileRemovingParent) {
+      this.parent.one('removing', this._parentRemovingWhileAnimatingHandler);
+    }
+  }
+
+  _animateRemovalWhileRemovingParent() {
+    // By default, remove animation is prevented when parent is being removed
+    return false;
   }
 
   _onParentRemovingWhileAnimating() {