@eclipse-scout/core 22.0.0 → 22.0.10

package/src/testing/lookup/AbortableMicrotaskStaticLookupCall.js

@@ -0,0 +1,50 @@
+/*
+ * Copyright (c) 2010-2020 BSI Business Systems Integration AG.
+ * All rights reserved. This program and the accompanying materials
+ * are made available under the terms of the Eclipse Public License v1.0
+ * which accompanies this distribution, and is available at
+ * http://www.eclipse.org/legal/epl-v10.html
+ *
+ * Contributors:
+ *     BSI Business Systems Integration AG - initial API and implementation
+ */
+import {StaticLookupCall} from '../../index';
+import $ from 'jquery';
+
+export default class AbortableMicrotaskStaticLookupCall extends StaticLookupCall {
+  constructor() {
+    super();
+    this._deferred = null;
+  }
+
+  abort() {
+    this._deferred.reject({
+      canceled: true
+    });
+    super.abort();
+  }
+
+  _getByKey(key) {
+    this._deferred = $.Deferred();
+    queueMicrotask(this._queryByKey.bind(this, this._deferred, key));
+    return this._deferred.promise();
+  }
+
+  _getAll() {
+    this._deferred = $.Deferred();
+    queueMicrotask(this._queryByAll.bind(this, this._deferred));
+    return this._deferred.promise();
+  }
+
+  _getByText(text) {
+    this._deferred = $.Deferred();
+    queueMicrotask(this._queryByText.bind(this, this._deferred, text));
+    return this._deferred.promise();
+  }
+
+  _getByRec(rec) {
+    this._deferred = $.Deferred();
+    queueMicrotask(this._queryByRec.bind(this, this._deferred, rec));
+    return this._deferred.promise();
+  }
+}

package/src/tile/TileGrid.js

@@ -198,7 +198,11 @@ export default class TileGrid extends Widget {
   }
 
   _updateTabbable() {
-    this.$container.setTabbable(this.enabled && (this.textFilterEnabled || this.selectable));
+    if (!this.textFilterEnabled && !this.selectable) {
+      this.$container.setTabbable(false);
+    } else {
+      this.$container.setTabbableOrFocusable(this.enabledComputed);
+    }
   }
 
   insertTile(tile) {
@@ -396,7 +400,7 @@ export default class TileGrid extends Widget {
   }
 
   _onAnimatedTileRemove(tile) {
-    if (!tile.rendered || !tile.animateRemoval) {
+    if (!tile.removalPending) {
       return;
     }
     this.tileRemovalPendingCount++;
@@ -760,16 +764,10 @@ export default class TileGrid extends Widget {
     if ($scrollables.length === 0) {
       return;
     }
-    let oldScrollTopArr = $scrollables.map((i, $elem) => {
-      return $elem.scrollTop();
-    }).toArray();
     // Make sure the tile grid has the focus when focusing a tile
-    if (this.focus()) {
-      // Restore old scroll to prevent scrolling by the browser due to the focus() call
-      oldScrollTopArr.forEach((val, idx) => {
-        $scrollables[idx].scrollTop(val);
-      }, this);
-    }
+    this.focus({
+      preventScroll: true
+    });
   }
 
   setSelectable(selectable) {
@@ -1382,7 +1380,7 @@ export default class TileGrid extends Widget {
   }
 
   _removeTileByFilter(tile) {
-    // In virtual mode, filtered tiles are not rendered. In normal mode, the filter animation is triggerd by _renderVisible of the tile.
+    // In virtual mode, filtered tiles are not rendered. In normal mode, the filter animation is triggered by _renderVisible of the tile.
     // Since the tile is removed immediately, the invisible animation would not start, so we use the remove animation instead.
     // But because the delete animation is a different one to the filter animation, the removeClass needs to be swapped
     // Remove class first to make sure animation won't be finished before the animationend listener is attached in Widget._removeAnimated (which may happen because a setTimeout is used there)

package/src/tile/TileGridLayout.js

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2010-2021 BSI Business Systems Integration AG.
+ * Copyright (c) 2010-2022 BSI Business Systems Integration AG.
  * All rights reserved. This program and the accompanying materials
  * are made available under the terms of the Eclipse Public License v1.0
  * which accompanies this distribution, and is available at
@@ -151,7 +151,7 @@ export default class TileGridLayout extends LogicalGridLayout {
    */
   _layoutCellBounds(containerSize, containerInsets) {
     // Since the tiles are positioned absolutely it is necessary to add the height of the filler to the top insets
-    if (this.widget.virtual) {
+    if (this.widget.virtual && this.widget.$fillBefore) {
       containerInsets.top += this.widget.$fillBefore.outerHeight(true);
     }
     return super._layoutCellBounds(containerSize, containerInsets);

package/src/tile/accordion/TileAccordion.js

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2010-2021 BSI Business Systems Integration AG.
+ * Copyright (c) 2010-2022 BSI Business Systems Integration AG.
  * All rights reserved. This program and the accompanying materials
  * are made available under the terms of the Eclipse Public License v1.0
  * which accompanies this distribution, and is available at
@@ -352,6 +352,21 @@ export default class TileAccordion extends Accordion {
   _filter() {
     this.groups.forEach(group => {
       group.body.filter();
+
+      // If the layout has not been invalidated as part of the filtering above, it even though must be validated here.
+      // This is because groups above might have fewer visible Tiles now which makes room for this group.
+      // The revalidateLayout() with scrolling=true here ensures TileGrid._renderViewPort() is called to ensure these Tiles become visible as there is space available now.
+      // It is executed as postValidateFunction because the groups above must have completed their layouting so that
+      // TileGrid._renderViewPort() knows that there is more space available now.
+      if (group.body.htmlComp && group.body.htmlComp.valid && !group.body._accordionLayoutHandler /* skip if already registered */) {
+        group.body._accordionLayoutHandler = () => {
+          group.body.scrolling = true;
+          group.body.revalidateLayout();
+          group.body.scrolling = false;
+          group.body._accordionLayoutHandler = null;
+        };
+        this.session.layoutValidator.schedulePostValidateFunction(group.body._accordionLayoutHandler);
+      }
     });
   }
 

package/src/tile/fields/FormFieldTile.less

@@ -222,8 +222,16 @@
         }
       }
 
-      &.has-error > .status::before {
-        color: @palette-red-3;
+      &.has-error > .status {
+        &::before {
+          color: @tile-default-inverted-error-status-color;
+        }
+
+        &:hover::before,
+        &:active::before,
+        &.selected::before {
+          color: @tile-default-inverted-error-status-hover-color;
+        }
       }
 
       .scrollbar-thumb-handle {
@@ -315,11 +323,11 @@
   }
 
   &.selected {
-    #scout.double-drop-shadow(@spread1: 2px, @color1: @dashboard-tile-selected-border-color, @y2: 0px, @blur2: 0px);
+    #scout.double-drop-shadow(@spread1: 2px, @color1: @dashboard-tile-default-selected-border-color, @y2: 0px, @blur2: 0px);
 
     &.inverted {
-      --tile-background-color: mix(@tile-default-inverted-background-color, @tile-default-inverted-selection-background-color, 65%);
-      #scout.double-drop-shadow(@spread1: 2px, @color1: @dashboard-tile-default-selected-border-color, @y2: 0px, @blur2: 0px);
+      --tile-background-color: @dashboard-tile-default-inverted-background-color;
+      #scout.double-drop-shadow(@spread1: 2px, @color1: @dashboard-tile-default-inverted-selected-border-color, @y2: 0px, @blur2: 0px);
     }
 
     &.color-alternative {
@@ -327,16 +335,15 @@
     }
 
     &.inverted.color-alternative {
-      --tile-background-color: mix(@tile-alternative-inverted-background-color, @tile-alternative-inverted-selection-background-color, 65%);
-      #scout.double-drop-shadow(@spread1: 2px, @color1: @dashboard-tile-alternative-selected-border-color, @y2: 0px, @blur2: 0px);
+      --tile-background-color: @dashboard-tile-alternative-inverted-background-color;
+      #scout.double-drop-shadow(@spread1: 2px, @color1: @dashboard-tile-alternative-inverted-selected-border-color, @y2: 0px, @blur2: 0px);
     }
 
-
     .dimmed-background & {
-      #scout.double-drop-shadow(@spread1: 2px, @color1: @dashboard-tile-selected-border-color, @alpha2: @dashboard-tile-drop-shadow-light-alpha);
+      #scout.double-drop-shadow(@spread1: 2px, @color1: @dashboard-tile-default-selected-border-color, @alpha2: @dashboard-tile-drop-shadow-light-alpha);
 
       &.inverted {
-        #scout.double-drop-shadow(@spread1: 2px, @color1: @dashboard-tile-default-selected-border-color, @alpha2: @dashboard-tile-drop-shadow-dark-alpha);
+        #scout.double-drop-shadow(@spread1: 2px, @color1: @dashboard-tile-default-inverted-selected-border-color, @alpha2: @dashboard-tile-drop-shadow-dark-alpha);
       }
 
       &.color-alternative {
@@ -344,7 +351,7 @@
       }
 
       &.inverted.color-alternative {
-        #scout.double-drop-shadow(@spread1: 2px, @color1: @dashboard-tile-alternative-selected-border-color, @alpha2: @dashboard-tile-drop-shadow-dark-alpha);
+        #scout.double-drop-shadow(@spread1: 2px, @color1: @dashboard-tile-alternative-inverted-selected-border-color, @alpha2: @dashboard-tile-drop-shadow-dark-alpha);
       }
     }
   }

package/src/tile/fields/button/ButtonTile.js

@@ -15,4 +15,4 @@ export default class ButtonTile extends FormFieldTile {
     super._render();
     this.$container.addClass('button-tile');
   }
-}
+}

package/src/tile/fields/tablefield/TileTableField.less

@@ -1,9 +1,9 @@
 /*
- * Copyright (c) 2010-2021 BSI Business Systems Integration AG.
+ * Copyright (c) 2010-2022 BSI Business Systems Integration AG.
  * All rights reserved. This program and the accompanying materials
  * are made available under the terms of the Eclipse Public License v1.0
  * which accompanies this distribution, and is available at
- * http://www.eclipse.org/legal/epl-v10.html
+ * https://www.eclipse.org/legal/epl-v10.html
  *
  * Contributors:
  *     BSI Business Systems Integration AG - initial API and implementation
@@ -53,6 +53,23 @@
       & > .table-header-item {
         color: @tile-table-default-color;
 
+        &.sorted,
+        &.grouped,
+        &.filtered {
+          padding-right: @table-header-item-padding-right;
+
+          &.halign-right,
+          &.halign-center {
+            padding-right: @table-header-item-padding-left;
+          }
+
+          &.last.halign-left,
+          &.last.halign-center,
+          &.last.halign-right {
+            padding-right: @table-header-item-padding-right-last;
+          }
+        }
+
         & > .table-header-item-state {
           display: none;
         }

package/src/tile/keystrokes/TileGridSelectKeyStroke.js

@@ -16,12 +16,13 @@ export default class TileGridSelectKeyStroke extends KeyStroke {
     super();
     this.field = tileGrid;
     this.shift = !tileGrid.multiSelect ? false : undefined;
-    this.renderingHints.$drawingArea = function($drawingArea, event) {
+    this.renderingHints.$drawingArea = ($drawingArea, event) => {
       let result = this._computeNewSelection();
       if (result && result.focusedTile) {
         return result.focusedTile.$container;
       }
-    }.bind(this);
+    };
+    this.inheritAccessibility = false;
   }
 
   /**

package/src/timepicker/TimePickerTouchPopup.js

@@ -51,4 +51,12 @@ export default class TimePickerTouchPopup extends TouchPopup {
     }
     this._touchField._triggerAcceptInput();
   }
+
+  /**
+   * @override
+   */
+  _acceptInput() {
+    this._field.acceptTime();
+    this.close();
+  }
 }

package/src/tree/CompactTree.less

@@ -19,7 +19,7 @@
 
     & > .tree-data > .nodes > .section > .section-node.selected {
       text-decoration: underline;
-      color: @active-color;
+      color: @focus-color;
     }
   }
 

package/src/tree/LazyNodeFilter.js

@@ -20,7 +20,9 @@ export default class LazyNodeFilter {
       return true;
     }
     // not expanded: remove lazy expand marker (forget lazy expanded children)
-    node.childNodes.forEach(child => child._lazyNodeFilterAccepted = false);
+    node.childNodes.forEach(child => {
+      child._lazyNodeFilterAccepted = false;
+    });
 
     if (!node.parentNode || !node.parentNode.expandedLazy || !node.parentNode.lazyExpandingEnabled || !this.tree.lazyExpandingEnabled) {
       // no lazy expanding supported
@@ -33,7 +35,7 @@ export default class LazyNodeFilter {
       if (typeof selectedNode === 'string') {
         break;
       }
-      if (selectedNode == node) {
+      if (selectedNode === node) {
         node._lazyNodeFilterAccepted = true;
         return true;
       }

package/src/tree/Tree.js

@@ -3,7 +3,7 @@
  * All rights reserved. This program and the accompanying materials
  * are made available under the terms of the Eclipse Public License v1.0
  * which accompanies this distribution, and is available at
- * http://www.eclipse.org/legal/epl-v10.html
+ * https://www.eclipse.org/legal/epl-v10.html
  *
  * Contributors:
  *     BSI Business Systems Integration AG - initial API and implementation
@@ -250,7 +250,9 @@ export default class Tree extends Widget {
     }
     this._inSelectionPathList[selectedNode.id] = true;
 
-    selectedNode.childNodes.forEach(child => this._inSelectionPathList[child.id] = true);
+    selectedNode.childNodes.forEach(child => {
+      this._inSelectionPathList[child.id] = true;
+    });
 
     let parentNode = selectedNode.parentNode;
     while (parentNode) {
@@ -909,7 +911,7 @@ export default class Tree extends Widget {
     this._installOrUninstallDragAndDropHandler();
     let enabled = this.enabledComputed;
     this.$data.setEnabled(enabled);
-    this.$container.setTabbable(enabled);
+    this.$container.setTabbableOrFocusable(enabled);
   }
 
   /**
@@ -2450,7 +2452,7 @@ export default class Tree extends Widget {
     }
     nodes = arrays.ensure(nodes);
     nodes.forEach(function(node) {
-      if (!node.enabled && opts.checkOnlyEnabled || node.checked === opts.checked) {
+      if (!node.enabled && opts.checkOnlyEnabled || node.checked === opts.checked || !node.filterAccepted) {
         if (opts.checkChildren) {
           this.checkNodes(node.childNodes, opts);
         }
@@ -3168,7 +3170,7 @@ export default class Tree extends Widget {
   // same as on Table.prototype._onDesktopPopupOpen
   _onDesktopPopupOpen(event) {
     let popup = event.popup;
-    if (!this.enabledComputed) {
+    if (!this.isFocusable(false)) {
       return;
     }
     // Set tree style to focused if a context menu or a menu bar popup opens, so that it looks as it still has the focus

package/src/tree/Tree.less

@@ -3,7 +3,7 @@
  * All rights reserved. This program and the accompanying materials
  * are made available under the terms of the Eclipse Public License v1.0
  * which accompanies this distribution, and is available at
- * http://www.eclipse.org/legal/epl-v10.html
+ * https://www.eclipse.org/legal/epl-v10.html
  *
  * Contributors:
  *     BSI Business Systems Integration AG - initial API and implementation
@@ -64,6 +64,13 @@
     & > .animation-wrapper > .tree-node {
       cursor: pointer;
     }
+
+    &.disabled > .tree-node,
+    &.disabled > .animation-wrapper > .tree-node,
+    & > .tree-node.disabled,
+    & > .animation-wrapper > .tree-node.disabled {
+      cursor: default;
+    }
   }
 }
 
@@ -95,12 +102,14 @@
     color: @disabled-color;
   }
 
+  .disabled > .animation-wrapper > &,
   .disabled > & {
     /* Whole tree is disabled -> use darker disabled color */
     color: @text-disabled-color;
   }
 
-  .disabled.read-only > .tree-data > & {
+  .disabled.read-only > .animation-wrapper > &,
+  .disabled.read-only > & {
     color: @read-only-color;
   }
 
@@ -132,6 +141,7 @@
     &.font-icon {
       /* Necessary to align with the text, depends on the used font size */
       line-height: @tree-node-font-icon-line-height;
+      font-size: @tree-node-font-icon-size;
     }
   }
 }
@@ -216,18 +226,16 @@
 
     .tree-node.lazy > & {
       font-family: @font-default-family;
-      font-size: @font-size-normal;
       content: '+';
       /* Move to left because '+' sign is not as wide as 'arrow-down' */
       margin-left: -2px;
     }
 
     .tree-node.expanded > & {
-      /* This "imprecise" angle is a workround for firefox to prevent shifting the div a little when the animation finishes. */
+      /* This "imprecise" angle is a workaround for firefox to prevent shifting the div a little when the animation finishes. */
       /* See https://bugzilla.mozilla.org/show_bug.cgi?id=739176 */
       #scout.transform(rotate(89.99deg));
     }
-
   }
 
   &:hover {

package/src/tree/keystrokes/AbstractTreeNavigationKeyStroke.js

@@ -24,6 +24,7 @@ export default class AbstractTreeNavigationKeyStroke extends KeyStroke {
     this.alt = keyStrokeModifier.isAlt(modifierBitMask);
 
     this.keyStrokeMode = KeyStroke.Mode.DOWN;
+    this.inheritAccessibility = false;
   }
 
   _accept(event) {

package/src/tree/keystrokes/TreeCollapseAllKeyStroke.js

@@ -16,11 +16,11 @@ export default class TreeCollapseAllKeyStroke extends AbstractTreeNavigationKeyS
     super(tree, keyStrokeModifier);
     this.which = [keys.HOME];
     this.renderingHints.hAlign = HAlign.RIGHT;
-    this.renderingHints.$drawingArea = function($drawingArea, event) {
+    this.renderingHints.$drawingArea = ($drawingArea, event) => {
       if (this.field.visibleNodesFlat.length > 0) {
         return this.field.visibleNodesFlat[0].$node;
       }
-    }.bind(this);
+    };
   }
 
   handle(event) {

package/src/tree/keystrokes/TreeExpandOrDrillDownKeyStroke.js

@@ -16,14 +16,14 @@ export default class TreeExpandOrDrillDownKeyStroke extends AbstractTreeNavigati
     super(tree, modifierBitMask);
     this.which = [keys.ADD];
     this.renderingHints.text = '+';
-    this.renderingHints.$drawingArea = function($drawingArea, event) {
+    this.renderingHints.$drawingArea = ($drawingArea, event) => {
       let currentNode = event._treeCurrentNode;
       if (this.isNodeExpandable(currentNode)) {
         return currentNode.$node;
       } else if (currentNode.childNodes.length > 0) {
         return currentNode.childNodes[0].$node;
       }
-    }.bind(this);
+    };
   }
 
   _accept(event) {

package/src/tree/keystrokes/TreeNavigationDownKeyStroke.js

@@ -16,12 +16,12 @@ export default class TreeNavigationDownKeyStroke extends AbstractTreeNavigationK
     super(tree, modifierBitMask);
     this.which = [keys.DOWN];
     this.renderingHints.text = '↓';
-    this.renderingHints.$drawingArea = function($drawingArea, event) {
+    this.renderingHints.$drawingArea = ($drawingArea, event) => {
       let newSelectedNode = this._computeNewSelection(event._treeCurrentNode);
       if (newSelectedNode) {
         return newSelectedNode.$node;
       }
-    }.bind(this);
+    };
   }
 
   _computeNewSelection(currentNode) {

package/src/tree/keystrokes/TreeNavigationEndKeyStroke.js

@@ -15,12 +15,12 @@ export default class TreeNavigationEndKeyStroke extends AbstractTreeNavigationKe
   constructor(tree, modifierBitMask) {
     super(tree, modifierBitMask);
     this.which = [keys.END];
-    this.renderingHints.$drawingArea = function($drawingArea, event) {
+    this.renderingHints.$drawingArea = ($drawingArea, event) => {
       let newSelectedNode = this._computeNewSelection(event._treeCurrentNode);
       if (newSelectedNode) {
         return newSelectedNode.$node;
       }
-    }.bind(this);
+    };
   }
 
   handle(event) {

package/src/tree/keystrokes/TreeNavigationUpKeyStroke.js

@@ -16,12 +16,12 @@ export default class TreeNavigationUpKeyStroke extends AbstractTreeNavigationKey
     super(tree, modifierBitMask);
     this.which = [keys.UP];
     this.renderingHints.text = '↑';
-    this.renderingHints.$drawingArea = function($drawingArea, event) {
+    this.renderingHints.$drawingArea = ($drawingArea, event) => {
       let newSelectedNode = this._computeNewSelection(event._treeCurrentNode);
       if (newSelectedNode) {
         return newSelectedNode.$node;
       }
-    }.bind(this);
+    };
   }
 
   _computeNewSelection(currentNode) {

package/src/util/Device.js

@@ -259,15 +259,15 @@ export default class Device {
 
   /**
    * This method returns false for all browsers that are known to be unsupported, all others (e.g. unknown engines) are allowed by default.
-   * The supported browser versions are mainly determined by the features needed by Scout (e.g. class syntax, Array.flatMap, IntersectionObserver, Custom CSS Properties, CSS flex-box).
+   * The supported browser versions are mainly determined by the features needed by Scout (e.g. class syntax, Array.flatMap, IntersectionObserver, Custom CSS Properties, CSS flex-box, queueMicrotask).
    */
   isSupportedBrowser(browser, version) {
     browser = scout.nvl(browser, this.browser);
     version = scout.nvl(version, this.browserVersion);
     let browsers = Device.Browser;
-    return (browser === browsers.CHROME && version >= 69)
-      || (browser === browsers.FIREFOX && version >= 62)
-      || (browser === browsers.SAFARI && version >= 12);
+    return (browser === browsers.CHROME && version >= 71)
+      || (browser === browsers.FIREFOX && version >= 69)
+      || (browser === browsers.SAFARI && version >= 12.1);
   }
 
   /**

package/src/util/arrays.js

@@ -206,6 +206,11 @@ export function containsAll(haystack, needles) {
   });
 }
 
+/**
+ * @template T
+ * @param {T[]} arr
+ * @return {T}
+ */
 export function first(arr) {
   if (Array.isArray(arr)) {
     return arr[0];
@@ -213,6 +218,11 @@ export function first(arr) {
   return arr;
 }
 
+/**
+ * @template T
+ * @param {T[]} arr
+ * @return {T}
+ */
 export function last(arr) {
   if (Array.isArray(arr)) {
     return arr[arr.length - 1];
@@ -285,8 +295,8 @@ export function union(array1, array2) {
   return result;
 }
 
-// noinspection DuplicatedCode
 export function equalsIgnoreOrder(arr, arr2) {
+  // noinspection DuplicatedCode
   if (arr === arr2) {
     return true;
   }
@@ -302,8 +312,8 @@ export function equalsIgnoreOrder(arr, arr2) {
   return containsAll(arr, arr2);
 }
 
-// noinspection DuplicatedCode
 export function equals(arr, arr2) {
+  // noinspection DuplicatedCode
   if (arr === arr2) {
     return true;
   }
@@ -600,9 +610,40 @@ export function toMap(array, keyMapper = (el => el), valueMapper = (el => el)) {
   }, {}));
 }
 
+/**
+ * If the argument is an empty array, null is returned. Otherwise, the argument is returned unchanged.
+ *
+ * @template T
+ * @param {T[]} array
+ * @return {T[]|null}
+ */
+export function nullIfEmpty(array) {
+  return empty(array) ? null : array;
+}
+
+/**
+ * Clears the content of an array <i>in-place</i>. All elements are removed from the array and the
+ * length will be set to 0. If the given argument is not an array, nothing happens.
+ *
+ * This is a more readable version of `array.splice(0, a.length)`.
+ *
+ * The return value is an array of all deleted elements (never null).
+ *
+ * @template T
+ * @param {T[]} array
+ * @return {T[]}
+ */
+export function clear(array) {
+  if (Array.isArray(array)) {
+    return array.splice(0, array.length);
+  }
+  return [];
+}
+
 export default {
   $indexOf,
   $remove,
+  clear,
   contains,
   containsAll,
   containsAny,
@@ -638,6 +679,7 @@ export default {
   max,
   min,
   move,
+  nullIfEmpty,
   pushAll,
   pushIfDefined,
   pushSet,

package/src/util/dragAndDrop.js

@@ -175,13 +175,13 @@ export function _createDragAndDropHandlerOptions(target) {
     target: target,
     supportedScoutTypes: dragAndDrop.SCOUT_TYPES.FILE_TRANSFER,
     validateFiles: (files, defaultValidator) => defaultValidator(files),
-    onDrop: (files) => {
+    onDrop: files => {
     },
     dropType: () => dragAndDrop.SCOUT_TYPES.FILE_TRANSFER,
     dropMaximumSize: () => target.dropMaximumSize,
     doInstall: () => target.enabledComputed,
     container: () => target.$container,
-    additionalDropProperties: (event) => {
+    additionalDropProperties: event => {
     }
   };
 }
@@ -269,6 +269,7 @@ export default {
  * @property {String} [selector] CSS selector which will be added to the event source.
  * @property {dropType} [dropType] Returns the allowed drop type during a drop event. Default is {@link dragAndDrop.SCOUT_TYPES.FILE_TRANSFER}
  * @property {dropMaximumSize} [dropMaximumSize] Returns the maximum allowed size of a dropped object. Default is {@link DragAndDropTarget.dropMaximumSize}
- * @property {validateFiles} [validateFiles] An optional function to add a custom file validation logic. Throw a {@link dropValidationErrorMessage} to indicate a failed validation. if no custom validator is installed, the default maximum file size validator is invoked.
+ * @property {validateFiles} [validateFiles] An optional function to add a custom file validation logic. Throw a {@link dropValidationErrorMessage} to indicate a failed validation.
+ *           If no custom validator is installed, the default maximum file size validator is invoked.
  * @property {additionalDropProperties} [additionalDropProperties] Returns additional drop properties to be used in {@link DragAndDropHandler.uploadFiles} as uploadProperties
- */
+ */

package/src/util/events.js

@@ -220,7 +220,7 @@ export function onSwipe($element, id, onDown, onMove, onUp) {
       let pageX = events.pageX(event);
       let deltaX = pageX - origPageX;
       let newLeft = origPosLeft + deltaX;
-      if (newLeft != curPosLeft) {
+      if (newLeft !== curPosLeft) {
         // only update swipe direction if it actually changed
         direction = Math.sign(newLeft - curPosLeft);
       }