@eclipse-scout/core 22.0.0-beta.10 → 22.0.1

package/dist/eclipse-scout-core.js

@@ -312,7 +312,7 @@ class App {
 
     $loadingRoot.oneAnimationEnd(() => $loadingRoot.remove());
 
-    if ($loadingRoot.css('opacity') == 1) {
+    if ($loadingRoot.css('opacity') === '1') {
       $loadingRoot.addClass('fadeout and-more');
     } else {
       $loadingRoot.addClass('fadeout');
@@ -3189,8 +3189,6 @@ __webpack_require__.r(__webpack_exports__);
 /* harmony export */   "default": () => (/* binding */ BreadcrumbBarLayout)
 /* harmony export */ });
 /* harmony import */ var _index__WEBPACK_IMPORTED_MODULE_0__ = __webpack_require__(/*! ../index */ "./src/index.js");
-function _defineProperty(obj, key, value) { if (key in obj) { Object.defineProperty(obj, key, { value: value, enumerable: true, configurable: true, writable: true }); } else { obj[key] = value; } return obj; }
-
 /*
  * Copyright (c) 2010-2020 BSI Business Systems Integration AG.
  * All rights reserved. This program and the accompanying materials
@@ -3205,40 +3203,6 @@ function _defineProperty(obj, key, value) { if (key in obj) { Object.definePrope
 class BreadcrumbBarLayout extends _index__WEBPACK_IMPORTED_MODULE_0__.AbstractLayout {
   constructor(breadcrumbBar) {
     super();
-
-    _defineProperty(this, "_collapse", function ($container, containerSize) {
-      let currentIndex = 1;
-
-      const visibleBreadcrumbItems = this._visibleBreadcrumbItems();
-
-      let prefSize = this._actualPrefSize(visibleBreadcrumbItems, true);
-
-      while (prefSize.width > containerSize.width && currentIndex < visibleBreadcrumbItems.length - 1) {
-        // remove breadcrumbItems until size fits or only 2 breadcrumbItems are visible
-        const crumb = visibleBreadcrumbItems[currentIndex];
-        crumb.$container.hide();
-        crumb._layHidden = true;
-        visibleBreadcrumbItems.splice(currentIndex, 1);
-        prefSize = this._actualPrefSize(visibleBreadcrumbItems, true);
-      }
-    });
-
-    _defineProperty(this, "_breadcrumbItemsWidth", function (breadcrumbItems, considerEllipsis) {
-      let breadcrumbsWidth = 0;
-      breadcrumbItems = breadcrumbItems || this._visibleBreadcrumbItems();
-      breadcrumbItems.forEach(breadcrumbItem => {
-        if (breadcrumbItem.rendered) {
-          breadcrumbsWidth += breadcrumbItem.$container.outerWidth(true);
-        }
-      }, this);
-
-      if (considerEllipsis && this._breadcrumbBar._ellipsisBreadcrumbItem && this._breadcrumbBar._ellipsisBreadcrumbItem.rendered) {
-        breadcrumbsWidth += this._breadcrumbBar._ellipsisBreadcrumbItem.$container.outerWidth(true);
-      }
-
-      return breadcrumbsWidth;
-    });
-
     this._breadcrumbBar = breadcrumbBar;
   }
 
@@ -3271,6 +3235,23 @@ class BreadcrumbBarLayout extends _index__WEBPACK_IMPORTED_MODULE_0__.AbstractLa
     this._collapse(breadcrumbItems, containerSize);
   }
 
+  _collapse($container, containerSize) {
+    let currentIndex = 1;
+
+    const visibleBreadcrumbItems = this._visibleBreadcrumbItems();
+
+    let prefSize = this._actualPrefSize(visibleBreadcrumbItems, true);
+
+    while (prefSize.width > containerSize.width && currentIndex < visibleBreadcrumbItems.length - 1) {
+      // remove breadcrumbItems until size fits or only 2 breadcrumbItems are visible
+      const crumb = visibleBreadcrumbItems[currentIndex];
+      crumb.$container.hide();
+      crumb._layHidden = true;
+      visibleBreadcrumbItems.splice(currentIndex, 1);
+      prefSize = this._actualPrefSize(visibleBreadcrumbItems, true);
+    }
+  }
+
   _applyToEllipsis(fun) {
     if (this._breadcrumbBar._ellipsisBreadcrumbItem) {
       fun(this._breadcrumbBar._ellipsisBreadcrumbItem);
@@ -3327,6 +3308,22 @@ class BreadcrumbBarLayout extends _index__WEBPACK_IMPORTED_MODULE_0__.AbstractLa
    */
 
 
+  _breadcrumbItemsWidth(breadcrumbItems, considerEllipsis) {
+    let breadcrumbsWidth = 0;
+    breadcrumbItems = breadcrumbItems || this._visibleBreadcrumbItems();
+    breadcrumbItems.forEach(breadcrumbItem => {
+      if (breadcrumbItem.rendered) {
+        breadcrumbsWidth += breadcrumbItem.$container.outerWidth(true);
+      }
+    }, this);
+
+    if (considerEllipsis && this._breadcrumbBar._ellipsisBreadcrumbItem && this._breadcrumbBar._ellipsisBreadcrumbItem.rendered) {
+      breadcrumbsWidth += this._breadcrumbBar._ellipsisBreadcrumbItem.$container.outerWidth(true);
+    }
+
+    return breadcrumbsWidth;
+  }
+
 }
 
 /***/ }),
@@ -88546,9 +88543,8 @@ class Table extends _index__WEBPACK_IMPORTED_MODULE_0__.Widget {
     let $row = $cell.parent();
     return $row.data('aggregateRow')
     /* row in the table */
-    || $row.hasClass('table-aggregate')
+    || $row.hasClass('table-aggregate');
     /* aggregate table control */
-    ;
   }
 
   reload(reloadReason) {
@@ -102891,7 +102887,7 @@ class ColumnOptimalWidthMeasurer {
 
     let $neighbour = cellRange[cellRange.length - 1];
 
-    if ($neighbour.hasClass('empty') || $cell.hasClass('halign-right') == $neighbour.hasClass('halign-right')) {
+    if ($neighbour.hasClass('empty') || $cell.hasClass('halign-right') === $neighbour.hasClass('halign-right')) {
       return 0;
     }
 
@@ -118087,10 +118083,12 @@ class LazyNodeFilter {
   accept(node) {
     if (node.expanded) {
       return true;
-    } else {
-      // not expanded: remove lazy expand marker (forget lazy expanded children)
-      node.childNodes.forEach(child => delete child._lazyNodeFilterAccepted);
-    }
+    } // not expanded: remove lazy expand marker (forget lazy expanded children)
+
+
+    node.childNodes.forEach(child => {
+      child._lazyNodeFilterAccepted = false;
+    });
 
     if (!node.parentNode || !node.parentNode.expandedLazy || !node.parentNode.lazyExpandingEnabled || !this.tree.lazyExpandingEnabled) {
       // no lazy expanding supported
@@ -118105,7 +118103,7 @@ class LazyNodeFilter {
         break;
       }
 
-      if (selectedNode == node) {
+      if (selectedNode === node) {
         node._lazyNodeFilterAccepted = true;
         return true;
       }
@@ -118262,10 +118260,9 @@ class Tree extends _index__WEBPACK_IMPORTED_MODULE_0__.Widget {
 
     this._ensureTreeNodes(this.nodes);
 
-    this.visitNodes(this._initTreeNode.bind(this));
-    this.visitNodes(this._updateFlatListAndSelectionPath.bind(this));
+    this._initNodes(this.nodes);
+
     this.initialTraversing = false;
-    this.selectedNodes = this._nodesByIds(this.selectedNodes);
     this.menuBar = _index__WEBPACK_IMPORTED_MODULE_0__.scout.create('MenuBar', {
       parent: this,
       position: _index__WEBPACK_IMPORTED_MODULE_0__.MenuBar.Position.BOTTOM,
@@ -118282,6 +118279,27 @@ class Tree extends _index__WEBPACK_IMPORTED_MODULE_0__.Widget {
 
     this._setMenus(this.menus);
   }
+  /**
+   * Initialize nodes, applies filters and updates flat list
+   */
+
+
+  _initNodes(nodes, parentNode) {
+    if (!nodes) {
+      nodes = this.nodes;
+    }
+
+    Tree.visitNodes(this._initTreeNode.bind(this), nodes, parentNode);
+
+    if (typeof this.selectedNodes[0] === 'string') {
+      this.selectedNodes = this._nodesByIds(this.selectedNodes);
+    }
+
+    this._updateSelectionPath();
+
+    nodes.forEach(node => this.applyFiltersForNode(node));
+    Tree.visitNodes((node, parentNode) => this._addToVisibleFlatList(node, false), nodes, parentNode);
+  }
   /**
    * Iterates through the given array and converts node-models to instances of TreeNode (or a subclass).
    * If the array element is already a TreeNode the function leaves the element untouched. This function also
@@ -118367,45 +118385,26 @@ class Tree extends _index__WEBPACK_IMPORTED_MODULE_0__.Widget {
   }
 
   isSelectedNode(node) {
-    if (this.initialTraversing) {
-      return this.selectedNodes.indexOf(node.id) > -1;
-    }
-
     return this.selectedNodes.indexOf(node) > -1;
   }
 
-  _updateFlatListAndSelectionPath(node, parentNode) {
-    // if this node is selected all parent nodes have to be added to selectionPath
-    if (this.isSelectedNode(node) && (node.parentNode && !this.visibleNodesMap[node.parentNode.id] || node.level === 0)) {
-      let p = node;
-
-      while (p) {
-        this._inSelectionPathList[p.id] = true;
-        p.filterDirty = true;
-
-        if (p !== node) {
-          // ensure node is expanded
-          node.expanded = true; // if parent was filtered before, try refilter after adding to selection path.
-
-          if (p.level === 0) {
-            this.applyFiltersForNode(p); // add visible nodes to visible nodes array when they are initialized
-
-            this._addToVisibleFlatList(p, false); // process children
+  _updateSelectionPath() {
+    let selectedNode = this.selectedNodes[0];
 
-
-            this._addChildrenToFlatList(p, this.visibleNodesFlat.length - 1, false, null, true);
-          }
-        }
-
-        p = p.parentNode;
-      }
-    } else if (node.parentNode && this.isSelectedNode(node.parentNode)) {
-      this._inSelectionPathList[node.id] = true;
+    if (!selectedNode) {
+      return;
     }
 
-    this.applyFiltersForNode(node); // add visible nodes to visible nodes array when they are initialized
+    this._inSelectionPathList[selectedNode.id] = true;
+    selectedNode.childNodes.forEach(child => {
+      this._inSelectionPathList[child.id] = true;
+    });
+    let parentNode = selectedNode.parentNode;
 
-    this._addToVisibleFlatList(node, false);
+    while (parentNode) {
+      this._inSelectionPathList[parentNode.id] = true;
+      parentNode = parentNode.parentNode;
+    }
   }
 
   _initTreeNode(node, parentNode) {
@@ -119705,9 +119704,7 @@ class Tree extends _index__WEBPACK_IMPORTED_MODULE_0__.Widget {
           this._removeFromFlatList(node, false);
         }
       } else if (renderExpansionOpts.expandLazyChanged) {
-        node.childNodes.forEach(child => {
-          this.applyFiltersForNode(child, true, renderAnimated);
-        });
+        this.applyFiltersForNode(node, false, renderAnimated);
       }
 
       if (this.groupedNodes[node.id]) {
@@ -119952,8 +119949,9 @@ class Tree extends _index__WEBPACK_IMPORTED_MODULE_0__.Widget {
           isAlreadyAdded = this.visibleNodesMap[node.id];
 
       if (isAlreadyAdded) {
-        this.insertBatchInVisibleNodes(insertBatch, this._showNodes(insertBatch), animatedRendering);
-        this.checkAndHandleBatchAnimationWrapper(parentNode, animatedRendering, insertBatch);
+        this.insertBatchInVisibleNodes(insertBatch, this._showNodes(insertBatch), animatedRendering); // Animate rendering is always false because it would generate a bunch of animation wrappers which stay forever without really starting an animation...
+
+        this.checkAndHandleBatchAnimationWrapper(parentNode, false, insertBatch);
         insertBatch = this.newInsertBatch(insertBatch.nextBatchInsertIndex());
         insertBatch = this._addChildrenToFlatListIfExpanded(1, node, insertIndex, animatedRendering, insertBatch, forceFilter);
       } else {
@@ -120559,11 +120557,9 @@ class Tree extends _index__WEBPACK_IMPORTED_MODULE_0__.Widget {
         nodes.forEach(entry => {
           parentNode.childNodes.push(entry);
         });
-      } // initialize node and add to visible list if node is visible
-
+      }
 
-      Tree.visitNodes(this._initTreeNode.bind(this), nodes, parentNode);
-      Tree.visitNodes(this._updateFlatListAndSelectionPath.bind(this), nodes, parentNode);
+      this._initNodes(nodes, parentNode);
 
       if (this.groupedNodes[parentNode.id]) {
         this._updateItemPath(false, parentNode);
@@ -120590,11 +120586,9 @@ class Tree extends _index__WEBPACK_IMPORTED_MODULE_0__.Widget {
         this._updateChildNodeIndex(this.nodes, nodes[0].childNodeIndex);
       } else {
         _index__WEBPACK_IMPORTED_MODULE_0__.arrays.pushAll(this.nodes, nodes);
-      } // initialize node and add to visible list if node is visible
-
+      }
 
-      Tree.visitNodes(this._initTreeNode.bind(this), nodes, parentNode);
-      Tree.visitNodes(this._updateFlatListAndSelectionPath.bind(this), nodes, parentNode);
+      this._initNodes(nodes, parentNode);
     }
 
     if (this.rendered) {
@@ -120735,9 +120729,7 @@ class Tree extends _index__WEBPACK_IMPORTED_MODULE_0__.Widget {
       Tree.visitNodes(this._destroyTreeNode.bind(this), node.childNodes);
     }, this); // update child node indices
 
-    parentNodesToReindex.forEach(function (p) {
-      this._updateChildNodeIndex(p.childNodes);
-    }, this);
+    parentNodesToReindex.forEach(p => this._updateChildNodeIndex(p.childNodes));
 
     this._updateChildNodeIndex(topLevelNodesToReindex);
 
@@ -121210,9 +121202,6 @@ class Tree extends _index__WEBPACK_IMPORTED_MODULE_0__.Widget {
 
     result.newlyShown.forEach(node => this._addToVisibleFlatList(node, this.filterAnimated));
     result.newlyHidden.forEach(node => this._removeFromFlatList(node, this.filterAnimated));
-
-    this._nodesFiltered(result.newlyHidden);
-
     this.filteredElementsDirty = false;
   }
 
@@ -121223,7 +121212,7 @@ class Tree extends _index__WEBPACK_IMPORTED_MODULE_0__.Widget {
     for (let i = this.visibleNodesFlat.length - 1; i >= 0; i--) {
       let node = this.visibleNodesFlat[i];
 
-      let result = this._applyFiltersForNodeRec(node, false, animated);
+      let result = this._applyFiltersForNodeRec(node, true, animated);
 
       if (result.newlyHidden.length) {
         if (!node.isFilterAccepted()) {
@@ -121262,11 +121251,11 @@ class Tree extends _index__WEBPACK_IMPORTED_MODULE_0__.Widget {
       parent = parent.parentNode;
     }
 
+    this._nodesFiltered(result.newlyHidden);
+
     if (applyNewHiddenShownNodes) {
       result.newlyShown.forEach(node => this._addToVisibleFlatList(node, animated));
       result.newlyHidden.forEach(node => this._removeFromFlatList(node, animated));
-
-      this._nodesFiltered(result.newlyHidden);
     }
 
     return result;
@@ -121285,16 +121274,19 @@ class Tree extends _index__WEBPACK_IMPORTED_MODULE_0__.Widget {
     if (node.level < 32
     /* see org.eclipse.scout.rt.client.ui.basic.tree.AbstractTree.expandAllRec */
     ) {
-      node.childNodes.forEach(childNode => {
-        if (recursive) {
+      if (recursive) {
+        node.childNodes.forEach(childNode => {
           let result = this._applyFiltersForNodeRec(childNode, true, animated);
 
           newlyHidden.push(...result.newlyHidden);
           newlyShown.push(...result.newlyShown);
-        }
-
-        hasChildrenWithFilterAccepted = hasChildrenWithFilterAccepted || childNode.filterAccepted;
-      });
+          hasChildrenWithFilterAccepted = hasChildrenWithFilterAccepted || childNode.filterAccepted;
+        });
+      } else if (!node.filterAccepted) {
+        // Check children only if filterAccepted is false because only then hasChildrenWithFilterAccepted is used (see below).
+        // This has great impact on performance when there are many nodes
+        hasChildrenWithFilterAccepted = node.childNodes.some(childNode => childNode.filterAccepted);
+      }
     } // set filter accepted on this node if it has children with filter accepted (so that the children are visible)
 
 
@@ -121561,6 +121553,10 @@ class Tree extends _index__WEBPACK_IMPORTED_MODULE_0__.Widget {
           $node.removeClass('hiding');
 
           if (!$node.hasClass('showing')) {
+            // JQuery sets display to none which we don't need because node will be detached.
+            // If node is added using another method than slideDown (used by show node), it would be invisible.
+            // Example: parent is collapsed while nodes are hiding -> remove filter, expand parent -> invisible nodes
+            $node.css('display', '');
             $node.detach();
             node.attached = false;
           }
@@ -121574,15 +121570,11 @@ class Tree extends _index__WEBPACK_IMPORTED_MODULE_0__.Widget {
   }
 
   _nodesToIds(nodes) {
-    return nodes.map(node => {
-      return node.id;
-    });
+    return nodes.map(node => node.id);
   }
 
   _nodesByIds(ids) {
-    return ids.map(id => {
-      return this.nodesMap[id];
-    });
+    return ids.map(id => this.nodesMap[id]);
   }
 
   _nodeById(id) {
@@ -128394,7 +128386,8 @@ function uninstallDragAndDropHandler(target) {
  * @property {String} [selector] CSS selector which will be added to the event source.
  * @property {dropType} [dropType] Returns the allowed drop type during a drop event. Default is {@link dragAndDrop.SCOUT_TYPES.FILE_TRANSFER}
  * @property {dropMaximumSize} [dropMaximumSize] Returns the maximum allowed size of a dropped object. Default is {@link DragAndDropTarget.dropMaximumSize}
- * @property {validateFiles} [validateFiles] An optional function to add a custom file validation logic. Throw a {@link dropValidationErrorMessage} to indicate a failed validation. if no custom validator is installed, the default maximum file size validator is invoked.
+ * @property {validateFiles} [validateFiles] An optional function to add a custom file validation logic. Throw a {@link dropValidationErrorMessage} to indicate a failed validation.
+ *           If no custom validator is installed, the default maximum file size validator is invoked.
  * @property {additionalDropProperties} [additionalDropProperties] Returns additional drop properties to be used in {@link DragAndDropHandler.uploadFiles} as uploadProperties
  */
 
@@ -128658,7 +128651,7 @@ function onSwipe($element, id, onDown, onMove, onUp) {
       let deltaX = pageX - origPageX;
       let newLeft = origPosLeft + deltaX;
 
-      if (newLeft != curPosLeft) {
+      if (newLeft !== curPosLeft) {
         // only update swipe direction if it actually changed
         direction = Math.sign(newLeft - curPosLeft);
       }