@eclipse-glsp/server 1.1.0-next.5fd686c.61 → 1.1.0-next.abdebbd.65

package/src/common/di/diagram-module.ts

@@ -13,44 +13,11 @@
  *
  * SPDX-License-Identifier: EPL-2.0 OR GPL-2.0 WITH Classpath-exception-2.0
  ********************************************************************************/
-import {
-    CenterAction,
-    DeleteMarkersAction,
-    EndProgressAction,
-    ExportSvgAction,
-    FitToScreenAction,
-    NavigateToExternalTargetAction,
-    NavigateToTargetAction,
-    RequestBoundsAction,
-    SelectAction,
-    SelectAllAction,
-    ServerMessageAction,
-    ServerStatusAction,
-    SetBoundsAction,
-    SetClipboardDataAction,
-    SetContextActions,
-    SetDirtyStateAction,
-    SetEditModeAction,
-    SetEditValidationResultAction,
-    SetMarkersAction,
-    SetModelAction,
-    SetNavigationTargetsAction,
-    SetPopupModelAction,
-    SetResolvedNavigationTargetAction,
-    SetTypeHintsAction,
-    SetViewportAction,
-    SourceModelChangedAction,
-    StartProgressAction,
-    TriggerEdgeCreationAction,
-    TriggerNodeCreationAction,
-    UpdateModelAction,
-    UpdateProgressAction
-} from '@eclipse-glsp/protocol';
 import { interfaces } from 'inversify';
 import { ActionDispatcher, DefaultActionDispatcher } from '../actions/action-dispatcher';
 import { ActionHandlerConstructor, ActionHandlerFactory } from '../actions/action-handler';
 import { ActionHandlerRegistry, ActionHandlerRegistryInitializer } from '../actions/action-handler-registry';
-import { ClientActionHandler } from '../actions/client-action-handler';
+import { ClientActionForwarder } from '../actions/client-action-handler';
 import { CommandStack, DefaultCommandStack } from '../command/command-stack';
 import { UndoRedoActionHandler } from '../command/undo-redo-action-handler';
 import { DiagramConfiguration } from '../diagram/diagram-configuration';
@@ -101,7 +68,6 @@ import { BindingTarget, applyBindingTarget, applyOptionalBindingTarget } from '.
 import { GLSPModule } from './glsp-module';
 import { InstanceMultiBinding, MultiBinding } from './multi-binding';
 import {
-    ClientActionKinds,
     ClientId,
     ContextActionsProviders,
     ContextEditValidators,
@@ -167,6 +133,7 @@ export abstract class DiagramModule extends GLSPModule {
         applyBindingTarget(context, DiagramType, this.bindDiagramType());
         applyBindingTarget(context, ClientId, this.bindClientId());
         applyBindingTarget(context, DiagramConfiguration, this.bindDiagramConfiguration()).inSingletonScope();
+        applyBindingTarget(context, ClientActionForwarder, this.bindClientActionForwarder()).inSingletonScope();
 
         // Model-related bindings
         applyBindingTarget(context, GModelSerializer, this.bindGModelSerializer()).inSingletonScope();
@@ -191,7 +158,6 @@ export abstract class DiagramModule extends GLSPModule {
 
         // Action & operation related bindings
         applyBindingTarget(context, ActionDispatcher, this.bindActionDispatcher()).inSingletonScope();
-        this.configureMultiBinding(new InstanceMultiBinding<string>(ClientActionKinds), binding => this.configureClientActions(binding));
         this.configureMultiBinding(new InstanceMultiBinding<ActionHandlerConstructor>(ActionHandlerConstructor), binding =>
             this.configureActionHandlers(binding)
         );
@@ -233,7 +199,6 @@ export abstract class DiagramModule extends GLSPModule {
     }
 
     protected configureActionHandlers(binding: InstanceMultiBinding<ActionHandlerConstructor>): void {
-        binding.add(ClientActionHandler);
         binding.add(RequestModelActionHandler);
         binding.add(RequestContextActionsHandler);
         binding.add(RequestTypeHintsActionHandler);
@@ -260,6 +225,10 @@ export abstract class DiagramModule extends GLSPModule {
         return DefaultGModelSerializer;
     }
 
+    protected bindClientActionForwarder(): BindingTarget<ClientActionForwarder> {
+        return ClientActionForwarder;
+    }
+
     protected bindGModelIndex(): BindingTarget<GModelIndex> {
         return GModelIndex;
     }
@@ -330,40 +299,6 @@ export abstract class DiagramModule extends GLSPModule {
         // empty as default
     }
 
-    protected configureClientActions(binding: InstanceMultiBinding<string>): void {
-        binding.add(CenterAction.KIND);
-        binding.add(DeleteMarkersAction.KIND);
-        binding.add(EndProgressAction.KIND);
-        binding.add(ExportSvgAction.KIND);
-        binding.add(FitToScreenAction.KIND);
-        binding.add(NavigateToExternalTargetAction.KIND);
-        binding.add(NavigateToTargetAction.KIND);
-        binding.add(RequestBoundsAction.KIND);
-        binding.add(SelectAction.KIND);
-        binding.add(SelectAllAction.KIND);
-        binding.add(ServerMessageAction.KIND);
-        binding.add(ServerStatusAction.KIND);
-        binding.add(SetBoundsAction.KIND);
-        binding.add(SetClipboardDataAction.KIND);
-        binding.add(SetContextActions.KIND);
-        binding.add(SetDirtyStateAction.KIND);
-        binding.add(SetEditModeAction.KIND);
-        binding.add(SetEditValidationResultAction.KIND);
-        binding.add(SetMarkersAction.KIND);
-        binding.add(SetModelAction.KIND);
-        binding.add(SetNavigationTargetsAction.KIND);
-        binding.add(SetPopupModelAction.KIND);
-        binding.add(SetResolvedNavigationTargetAction.KIND);
-        binding.add(SetTypeHintsAction.KIND);
-        binding.add(SetViewportAction.KIND);
-        binding.add(SourceModelChangedAction.KIND);
-        binding.add(StartProgressAction.KIND);
-        binding.add(TriggerEdgeCreationAction.KIND);
-        binding.add(TriggerNodeCreationAction.KIND);
-        binding.add(UpdateModelAction.KIND);
-        binding.add(UpdateProgressAction.KIND);
-    }
-
     protected bindContextActionsProviderRegistry(): BindingTarget<ContextActionsProviderRegistry> {
         return ContextActionsProviderRegistry;
     }

package/src/common/di/server-module.ts

@@ -41,7 +41,6 @@ import { DiagramModules, InjectionContainer } from './service-identifiers';
  * * {@link ClientSessionFactory}
  * * {@link ClientSessionManager}
  * * {@link GlobalActionProvider}
- * * {@link GLSPClientProxy}
  *
  */
 export class ServerModule extends GLSPModule {

package/src/common/features/model/model-submission-handler.ts

@@ -20,6 +20,7 @@ import {
     MarkersReason,
     MaybePromise,
     RequestBoundsAction,
+    RequestModelAction,
     SetDirtyStateAction,
     SetMarkersAction,
     SetModelAction,
@@ -35,6 +36,15 @@ import { GModelFactory } from './gmodel-factory';
 import { GModelSerializer } from './gmodel-serializer';
 import { ModelState } from './model-state';
 
+/**
+ * Helper class that provides utility methods to handle model updates i.e.
+ * submit a new model to the client. In addition, to the core model update action this class
+ * also takes care of related behavior like dirty state handling, validation and client/server side layouting.
+ * Note that the submissions handler is only responsible for deriving the set of actions that comprise a model update
+ * but does not actually dispatch them. The returned actions should be either manually dispatched
+ * to the `ActionDispatcher`, or simply returned as the result of an
+ * `ActionHandler.execute` method.
+ */
 @injectable()
 export class ModelSubmissionHandler {
     @inject(DiagramConfiguration)
@@ -60,8 +70,34 @@ export class ModelSubmissionHandler {
     @optional()
     protected validator?: ModelValidator;
 
+    protected requestModelAction?: RequestModelAction;
+
     /**
-     * Returns a list of actions to update the client-side model, based on the specified <code>modelState</code>.
+     * Returns a list of actions to submit the initial revision of the client-side model, based on the injected
+     * {@link GModelState}. Typically this method is invoked by the {@link RequestModelActionHandler} when the diagram
+     * is (re)loaded.
+     * <p>
+     * These actions are not processed by this {@link ModelSubmissionHandler}, but should be either manually dispatched
+     * to the {@link ActionDispatcher}, or simply returned as the result of an
+     * {@link ActionHandler#execute(Action)} method.
+     * </p>
+     *
+     * @param requestAction The {@link RequestModelAction} that triggere the initial model update
+     * @return A list of actions to be processed in order to submit the intial model.
+     *
+     */
+    submitInitialModel(requestAction: RequestModelAction): MaybePromise<Action[]> {
+        /*
+         * In the default update action flow a `RequestModelAction` does not directly trigger a `SetModelAction` response
+         * (RequestModelAction (C) -> RequestBoundsAction (S) -> ComputedBoundsAction (C) -> SetModelACtion (S)
+         * Therefore we temporarily store the action later retrival
+         */
+        this.requestModelAction = requestAction;
+        return this.submitModel();
+    }
+
+    /**
+     * Returns a list of actions to update the client-side model, based on the injected {@link ModelState}
      *
      * These actions are not processed by this {@link ModelSubmissionHandler}, but should be either manually dispatched
      * to the `ActionDispatcher`, or simply returned as the result of an `ActionHandler.execute()` method.
@@ -71,13 +107,15 @@ export class ModelSubmissionHandler {
      */
     submitModel(reason?: DirtyStateChangeReason): MaybePromise<Action[]> {
         this.modelFactory.createModel();
-        this.modelState.root.revision = (this.modelState.root.revision ?? 0) + 1;
+
+        const revision = this.requestModelAction ? 0 : this.modelState.root.revision! + 1;
+        this.modelState.root.revision = revision;
         const root = this.serializeGModel();
 
         if (this.diagramConfiguration.needsClientLayout) {
             return [RequestBoundsAction.create(root), SetDirtyStateAction.create(this.commandStack.isDirty, { reason })];
         }
-        return [SetModelAction.create(root)];
+        return this.submitModelDirectly(reason);
     }
 
     /**
@@ -102,8 +140,8 @@ export class ModelSubmissionHandler {
         }
         const result: Action[] = [];
         result.push(
-            root.revision === 0
-                ? SetModelAction.create(root)
+            this.requestModelAction
+                ? this.createSetModeAction(root)
                 : UpdateModelAction.create(root, { animate: this.diagramConfiguration.animatedUpdate })
         );
         if (!this.diagramConfiguration.needsClientLayout) {
@@ -116,6 +154,13 @@ export class ModelSubmissionHandler {
         return result;
     }
 
+    protected createSetModeAction(newRoot: GModelRootSchema): SetModelAction {
+        const responseId = this.requestModelAction?.requestId ?? '';
+        const response = SetModelAction.create(newRoot, { responseId });
+        this.requestModelAction = undefined;
+        return response;
+    }
+
     protected serializeGModel(): GModelRootSchema {
         return this.serializer.createSchema(this.modelState.root);
     }

package/src/common/features/model/request-model-action-handler.ts

@@ -13,7 +13,7 @@
  *
  * SPDX-License-Identifier: EPL-2.0 OR GPL-2.0 WITH Classpath-exception-2.0
  ********************************************************************************/
-import { Action, RequestModelAction, ServerStatusAction } from '@eclipse-glsp/protocol';
+import { Action, RequestModelAction, StatusAction } from '@eclipse-glsp/protocol';
 import { inject, injectable } from 'inversify';
 import { ActionDispatcher } from '../../actions/action-dispatcher';
 import { ActionHandler } from '../../actions/action-handler';
@@ -61,7 +61,7 @@ export class RequestModelActionHandler implements ActionHandler {
         }
         this.reportModelLoadingFinished(progress);
 
-        return this.submissionHandler.submitModel();
+        return this.submissionHandler.submitInitialModel(action);
     }
 
     protected async handleReconnect(action: RequestModelAction): Promise<void> {
@@ -76,12 +76,12 @@ export class RequestModelActionHandler implements ActionHandler {
     }
 
     protected reportModelLoading(message: string): ProgressMonitor {
-        this.actionDispatcher.dispatch(ServerStatusAction.create(message, { severity: 'INFO' }));
+        this.actionDispatcher.dispatch(StatusAction.create(message, { severity: 'INFO' }));
         return this.progressService.start(message);
     }
 
     protected reportModelLoadingFinished(monitor: ProgressMonitor): void {
-        this.actionDispatcher.dispatch(ServerStatusAction.create('', { severity: 'NONE' }));
+        this.actionDispatcher.dispatch(StatusAction.create('', { severity: 'NONE' }));
         monitor.end();
     }
 }

package/src/common/operations/operation-action-handler.ts

@@ -13,7 +13,7 @@
  *
  * SPDX-License-Identifier: EPL-2.0 OR GPL-2.0 WITH Classpath-exception-2.0
  ********************************************************************************/
-import { Action, MaybePromise, Operation, ServerMessageAction } from '@eclipse-glsp/protocol';
+import { Action, MaybePromise, MessageAction, Operation } from '@eclipse-glsp/protocol';
 import { inject, injectable } from 'inversify';
 import { ActionHandler } from '../actions/action-handler';
 import { Command } from '../command/command';
@@ -47,7 +47,7 @@ export class OperationActionHandler implements ActionHandler {
         }
         if (this.modelState.isReadonly) {
             return [
-                ServerMessageAction.create(`Server is in readonly-mode! Could not execute operation: ${action.kind}`, {
+                MessageAction.create(`Server is in readonly-mode! Could not execute operation: ${action.kind}`, {
                     severity: 'WARNING'
                 })
             ];

package/src/common/protocol/client-action.ts

@@ -0,0 +1,38 @@
+/********************************************************************************
+ * Copyright (c) 2023 EclipseSource and others.
+ *
+ * This program and the accompanying materials are made available under the
+ * terms of the Eclipse Public License v. 2.0 which is available at
+ * http://www.eclipse.org/legal/epl-2.0.
+ *
+ * This Source Code may also be made available under the following Secondary
+ * Licenses when the conditions for such availability set forth in the Eclipse
+ * Public License v. 2.0 are satisfied: GNU General Public License, version 2
+ * with the GNU Classpath Exception which is available at
+ * https://www.gnu.org/software/classpath/license.html.
+ *
+ * SPDX-License-Identifier: EPL-2.0 OR GPL-2.0 WITH Classpath-exception-2.0
+ ********************************************************************************/
+
+import { Action } from '@eclipse-glsp/protocol';
+
+/**
+ * A helper interface that allows the server to mark actions that have been received from the client.
+ */
+export interface ClientAction extends Action {
+    __receivedFromClient: true;
+}
+
+export namespace ClientAction {
+    export function is(object: unknown): object is ClientAction {
+        return Action.is(object) && '__receivedFromClient' in object && object.__receivedFromClient === true;
+    }
+
+    /**
+     * Mark the given action as {@link ClientAction} by attaching the "__receivedFromClient" property
+     * @param action The action that should be marked as client action
+     */
+    export function mark(action: Action): void {
+        (action as ClientAction).__receivedFromClient = true;
+    }
+}

package/src/common/protocol/glsp-server.spec.ts

@@ -20,6 +20,7 @@ import {
     InitializeClientSessionParameters,
     InitializeParameters
 } from '@eclipse-glsp/protocol';
+import * as assert from 'assert';
 import { expect } from 'chai';
 import { Container, ContainerModule } from 'inversify';
 import * as sinon from 'sinon';
@@ -28,7 +29,6 @@ import { ClientSessionManager } from '../session/client-session-manager';
 import * as mock from '../test/mock-util';
 import { Logger } from '../utils/logger';
 import { DefaultGLSPServer } from './glsp-server';
-import assert = require('assert');
 
 describe('test DefaultGLSPServer', () => {
     const container = new Container();
@@ -36,8 +36,8 @@ describe('test DefaultGLSPServer', () => {
     const diagramType = 'myDiagram';
     const applicationId = 'Test';
     const protocolVersion = '1.0.0';
-    const serverActionKinds = new Map<string, string[]>();
-    serverActionKinds.set(diagramType, ['A1', 'A2']);
+    const actionKinds = new Map<string, string[]>();
+    actionKinds.set(diagramType, ['A1', 'A2']);
     const sessionManager = new mock.StubClientSessionManager();
     const spy_sessionManager_getOrCreate = sinon.spy(sessionManager, 'getOrCreateClientSession');
     const spy_sessionManager_dispose = sinon.spy(sessionManager, 'disposeClientSession');
@@ -53,7 +53,7 @@ describe('test DefaultGLSPServer', () => {
             bind(Logger).toConstantValue(new mock.StubLogger());
             bind(GLSPClientProxy).toConstantValue(new mock.StubGLSPClientProxy());
             bind(ClientSessionManager).toConstantValue(sessionManager);
-            bind(GlobalActionProvider).toConstantValue({ clientActionKinds: new Map<string, string[]>(), serverActionKinds });
+            bind(GlobalActionProvider).toConstantValue(<GlobalActionProvider>{ actionKinds });
             bind(GLSPServerListener).toConstantValue(listener1);
         })
     );
@@ -70,7 +70,7 @@ describe('test DefaultGLSPServer', () => {
     });
 
     it('Test calls before server initialization (should throw errors)', async () => {
-        assert.rejects(() => glspServer.initializeClientSession({ clientSessionId: 'id', diagramType: 'type' }));
+        assert.rejects(() => glspServer.initializeClientSession({ clientSessionId: 'id', diagramType: 'type', clientActionKinds: [] }));
         assert.rejects(() => glspServer.disposeClientSession({ clientSessionId: 'id' }));
         assert.throws(() => glspServer.process({ clientId: 'id', action: { kind: 'action' } }));
     });
@@ -109,8 +109,8 @@ describe('test DefaultGLSPServer', () => {
         const initializeParameters: InitializeParameters = { applicationId, protocolVersion };
         const result = await glspServer.initialize(initializeParameters);
         expect(result.protocolVersion).to.be.equal(protocolVersion);
-        expect(result.serverActions[diagramType]).to.be.equal(serverActionKinds.get(diagramType));
-        expect(result.serverActions[diagramType]).to.be.equal(serverActionKinds.get(diagramType));
+        expect(result.serverActions[diagramType]).to.be.equal(actionKinds.get(diagramType));
+        expect(result.serverActions[diagramType]).to.be.equal(actionKinds.get(diagramType));
         expect(spy_listener1_initialize.calledWith(glspServer));
         expect(spy_listener2_initialize.notCalled);
     });
@@ -119,8 +119,8 @@ describe('test DefaultGLSPServer', () => {
         const initializeParameters: InitializeParameters = { applicationId, protocolVersion };
         const result = await glspServer.initialize(initializeParameters);
         expect(result.protocolVersion).to.be.equal(protocolVersion);
-        expect(result.serverActions[diagramType]).to.be.equal(serverActionKinds.get(diagramType));
-        expect(result.serverActions[diagramType]).to.be.equal(serverActionKinds.get(diagramType));
+        expect(result.serverActions[diagramType]).to.be.equal(actionKinds.get(diagramType));
+        expect(result.serverActions[diagramType]).to.be.equal(actionKinds.get(diagramType));
     });
 
     it('initialize -  subsequent call with other parameters', async () => {
@@ -131,7 +131,8 @@ describe('test DefaultGLSPServer', () => {
     it('initialize client session', async () => {
         const initializeClientSessionParameters: InitializeClientSessionParameters = {
             clientSessionId,
-            diagramType
+            diagramType,
+            clientActionKinds: []
         };
         await glspServer.initializeClientSession(initializeClientSessionParameters);
         expect(spy_sessionManager_getOrCreate.calledWith(initializeClientSessionParameters));

package/src/common/protocol/glsp-server.ts

@@ -17,7 +17,6 @@ import {
     ActionMessage,
     Args,
     DisposeClientSessionParameters,
-    distinctAdd,
     GLSPClientProxy,
     GLSPServer,
     GLSPServerListener,
@@ -25,9 +24,10 @@ import {
     InitializeParameters,
     InitializeResult,
     MaybePromise,
-    remove,
+    MessageAction,
     ServerActions,
-    ServerMessageAction
+    distinctAdd,
+    remove
 } from '@eclipse-glsp/protocol';
 import { inject, injectable, multiInject, optional } from 'inversify';
 import { GlobalActionProvider } from '../actions/global-action-provider';
@@ -35,6 +35,7 @@ import { ClientSession } from '../session/client-session';
 import { ClientSessionManager } from '../session/client-session-manager';
 import { GLSPServerError } from '../utils/glsp-server-error';
 import { Logger } from '../utils/logger';
+import { ClientAction } from './client-action';
 
 @injectable()
 export class DefaultGLSPServer implements GLSPServer {
@@ -50,8 +51,7 @@ export class DefaultGLSPServer implements GLSPServer {
     protected actionProvider: GlobalActionProvider;
 
     @inject(GLSPClientProxy)
-    @optional()
-    protected glspClientProxy?: GLSPClientProxy;
+    protected glspClientProxy: GLSPClientProxy;
 
     protected initializeResult?: InitializeResult;
 
@@ -97,7 +97,7 @@ export class DefaultGLSPServer implements GLSPServer {
         this.applicationId = params.applicationId;
         const serverActions: ServerActions = {};
 
-        this.actionProvider.serverActionKinds.forEach((kinds, diagramType) => (serverActions[diagramType] = kinds));
+        this.actionProvider.actionKinds.forEach((kinds, diagramType) => (serverActions[diagramType] = kinds));
 
         let result = { protocolVersion: DefaultGLSPServer.PROTOCOL_VERSION, serverActions };
 
@@ -149,8 +149,9 @@ export class DefaultGLSPServer implements GLSPServer {
         if (!clientSession) {
             throw new Error(`No client session has been initialized for client id: ${clientSessionId}`);
         }
-
-        clientSession.actionDispatcher.dispatch(message.action).catch(error => this.handleProcessError(message, error));
+        const action = message.action;
+        ClientAction.mark(action);
+        clientSession.actionDispatcher.dispatch(action).catch(error => this.handleProcessError(message, error));
     }
 
     protected handleProcessError(message: ActionMessage, reason: any): void | PromiseLike<void> {
@@ -162,16 +163,12 @@ export class DefaultGLSPServer implements GLSPServer {
             details = reason.cause?.toString?.();
             errorMsg = reason.message;
         }
-        const errorAction = ServerMessageAction.create(errorMsg, { severity: 'ERROR', details });
+        const errorAction = MessageAction.create(errorMsg, { severity: 'ERROR', details });
         this.sendToClient({ clientId: message.clientId, action: errorAction });
     }
 
     protected sendToClient(message: ActionMessage): void {
-        if (this.glspClientProxy) {
-            this.glspClientProxy.process(message);
-            return;
-        }
-        throw new Error("Could not send message to client. No 'GLSPClientProxy' is connected");
+        this.glspClientProxy.process(message);
     }
 
     getClientSession(sessionId: string): ClientSession | undefined {

package/src/common/session/client-session-factory.spec.ts

@@ -47,7 +47,7 @@ describe('test DefaultClientSessionFactory', () => {
     const factory = container.resolve(DefaultClientSessionFactory);
 
     it('create - new client session', () => {
-        const session = factory.create({ clientSessionId, diagramType });
+        const session = factory.create({ clientSessionId, diagramType, clientActionKinds: [] });
         expect(session.id).to.be.equal(clientSessionId);
         expect(session.diagramType).to.be.equal(diagramType);
         expect(session.container.parent).to.be.equal(container);
@@ -55,6 +55,6 @@ describe('test DefaultClientSessionFactory', () => {
     });
 
     it('create - unknown diagram type', () => {
-        expect(() => factory.create({ clientSessionId, diagramType: 'unknown-type' })).to.throw(GLSPServerError);
+        expect(() => factory.create({ clientSessionId, diagramType: 'unknown-type', clientActionKinds: [] })).to.throw(GLSPServerError);
     });
 });

package/src/common/session/client-session-factory.ts

@@ -52,18 +52,18 @@ export class DefaultClientSessionFactory implements ClientSessionFactory {
     protected glspClient: GLSPClientProxy;
 
     create(params: InitializeClientSessionParameters): ClientSession {
-        const { clientSessionId: id, diagramType, args } = params;
+        const { clientSessionId: clientId, diagramType, clientActionKinds, args } = params;
         const diagramModules = this.diagramModules.get(diagramType);
         if (!diagramModules || diagramModules.length === 0) {
             throw new GLSPServerError(`Could not retrieve diagram module configuration for diagram type: '${diagramType}''`);
         }
 
-        const sessionModule = createClientSessionModule(id, this.glspClient);
+        const sessionModule = createClientSessionModule({ clientId, glspClient: this.glspClient, clientActionKinds });
         const sessionContainer = this.serverContainer.createChild();
         sessionContainer.load(...diagramModules, sessionModule);
         const initializers = sessionContainer.getAll<ClientSessionInitializer>(ClientSessionInitializer);
         initializers.forEach(service => service.initialize(args));
         const actionDispatcher = sessionContainer.get<ActionDispatcher>(ActionDispatcher);
-        return new DefaultClientSession(id, diagramType, actionDispatcher, sessionContainer);
+        return new DefaultClientSession(clientId, diagramType, actionDispatcher, sessionContainer);
     }
 }

package/src/common/session/client-session-manager.spec.ts

@@ -13,13 +13,13 @@
  *
  * SPDX-License-Identifier: EPL-2.0 OR GPL-2.0 WITH Classpath-exception-2.0
  ********************************************************************************/
+import { expect } from 'chai';
 import { Container, ContainerModule } from 'inversify';
+import * as sinon from 'sinon';
 import * as mock from '../test/mock-util';
 import { Logger } from '../utils/logger';
 import { ClientSessionFactory } from './client-session-factory';
 import { DefaultClientSessionManager } from './client-session-manager';
-import { expect } from 'chai';
-import * as sinon from 'sinon';
 
 describe('test DefaultClientSessionManager', () => {
     const testSession = mock.createClientSession('myId', 'myDiagram');
@@ -47,7 +47,8 @@ describe('test DefaultClientSessionManager', () => {
         // Test execution
         const createdSession = sessionManager.getOrCreateClientSession({
             clientSessionId: testSession.id,
-            diagramType: testSession.diagramType
+            diagramType: testSession.diagramType,
+            clientActionKinds: []
         });
         expect(createdSession).to.not.be.undefined;
         expect(createdSession.id).to.be.equal(testSession.id);

package/src/common/utils/promise-queue.ts

@@ -62,14 +62,13 @@ export class PromiseQueue<T = void> {
             return false;
         }
 
-        try {
-            this.busy = true;
-            this.resolveQueuedPromise(element);
-        } catch (error) {
+        this.busy = true;
+        this.resolveQueuedPromise(element).catch(error => {
             element.reject(error);
             this.busy = false;
             this.dequeue();
-        }
+        });
+
         return true;
     }
 

package/src/node/abstract-json-model-storage.ts

@@ -14,8 +14,9 @@
  * SPDX-License-Identifier: EPL-2.0 OR GPL-2.0 WITH Classpath-exception-2.0
  ********************************************************************************/
 import { MaybePromise, RequestModelAction, SaveModelAction, TypeGuard } from '@eclipse-glsp/protocol';
-import * as fs from 'fs-extra';
+import * as fs from 'fs';
 import { inject, injectable } from 'inversify';
+import * as os from 'os';
 import { fileURLToPath } from 'url';
 import { ModelState, SOURCE_URI_ARG } from '../common/features/model/model-state';
 import { SourceModelStorage } from '../common/features/model/source-model-storage';
@@ -91,7 +92,12 @@ export abstract class AbstractJsonModelStorage implements SourceModelStorage {
     }
 
     protected toPath(sourceUri: string): string {
-        return sourceUri.startsWith('file://') ? fileURLToPath(sourceUri) : sourceUri;
+        let path = sourceUri.startsWith('file://') ? fileURLToPath(sourceUri) : sourceUri;
+        if (os.platform() === 'win32') {
+            // Remove the leading slash if it exists (Windows paths don't have it)
+            path = path.replace(/^\//, '');
+        }
+        return path;
     }
 
     protected getFileUri(action: SaveModelAction): string {

package/src/node/launch/cli-parser.ts

@@ -14,7 +14,7 @@
  * SPDX-License-Identifier: EPL-2.0 OR GPL-2.0 WITH Classpath-exception-2.0
  ********************************************************************************/
 import * as cmd from 'commander';
-import * as fs from 'fs-extra';
+import * as fs from 'fs';
 import * as path from 'path';
 import { LogLevel, LoggerConfigOptions, asLogLevel } from '../../common/utils/logger';