@eclipse-glsp/eslint-config 0.9.0-next.18041f6a → 0.9.0-next.34c10fc7

package/README.md

@@ -15,30 +15,11 @@ $ yarn add --dev @eclipse-glsp/eslint-config
 ```javascript
 /** @type {import('eslint').Linter.Config} */
 module.exports = {
-    extends: "@eclipse-glsp",
+    extends: '@eclipse-glsp',
     parserOptions: {
         tsconfigRootDir: __dirname,
-        project: "tsconfig.json",
-    },
-};
-```
-
-## Usage without prettier
-
-The default shared ESLint configuration is expected to be used in combination with [Prettier](https://prettier.io/).
-As a consequence all stylistic rules that might conflict with Prettier haven been disabled.
-We provide an additional `no-prettier` configuration that can be used for projects that don't use Prettier.
-
-**Create a `.eslintrc.js`**:
-
-```javascript
-/** @type {import('eslint').Linter.Config} */
-module.exports = {
-    extends: "@eclipse-glsp/eslint-config/no-prettier",
-    parserOptions: {
-        tsconfigRootDir: __dirname,
-        project: "tsconfig.json",
-    },
+        project: 'tsconfig.json'
+    }
 };
 ```
 

package/configs/errors.eslintrc.js

@@ -5,14 +5,11 @@ module.exports = {
         // Possible Errors
         'no-inner-declarations': 'off',
         // Best Practices
-        curly: 'error',
-        'eol-last': 'error',
         eqeqeq: ['error', 'smart'],
         'guard-for-in': 'error',
         'no-caller': 'error',
         'no-eval': 'error',
-        'no-redeclare': 'off',
-        'no-restricted-imports': ['error', '..', '../index', '../..', '../../index'],
+        'no-restricted-imports': ['error', '..', '../index', '../..', '../../index', 'src'],
         'no-sequences': 'error',
         'no-throw-literal': 'error',
         'no-unused-expressions': [
@@ -25,13 +22,6 @@ module.exports = {
         // Variables
         'no-unused-vars': 'off', // typescript-eslint rule activated instead
         'no-use-before-define': 'off', // typescript-eslint rule activated instead
-        // Stylistic Issues
-        'max-len': [
-            'error',
-            {
-                code: 180
-            }
-        ],
         'no-multiple-empty-lines': [
             'error',
             {
@@ -40,18 +30,9 @@ module.exports = {
         ],
         'no-underscore-dangle': 'off',
         quotes: 'off', // typescript-eslint rule activated instead
-        'space-before-function-paren': [
-            'error',
-            {
-                anonymous: 'always',
-                named: 'never',
-                asyncArrow: 'always'
-            }
-        ],
         'one-var': ['error', 'never'],
         // ECMAScript6
         'arrow-body-style': ['error', 'as-needed'],
-        'arrow-parens': ['error', 'as-needed'],
         'no-var': 'error',
         'prefer-const': [
             'error',
@@ -62,7 +43,6 @@ module.exports = {
         // @typescript-eslint/eslint-plugin
         '@typescript-eslint/naming-convention': 'off',
         '@typescript-eslint/consistent-type-definitions': 'error',
-        '@typescript-eslint/no-explicit-any': 'off',
         '@typescript-eslint/no-misused-new': 'error',
         '@typescript-eslint/no-empty-interface': 'off',
         '@typescript-eslint/no-namespace': 'off',
@@ -73,14 +53,6 @@ module.exports = {
                 args: 'none'
             }
         ],
-        '@typescript-eslint/quotes': [
-            'error',
-            'single',
-            {
-                avoidEscape: true
-            }
-        ],
-        '@typescript-eslint/semi': ['error', 'always'],
         // eslint-plugin-header
         'header/header': [
             2,

package/configs/warnings.eslintrc.js

@@ -3,6 +3,8 @@ module.exports = {
         // https://eslint.org/docs/rules/
         'brace-style': ['warn', '1tbs'],
         'comma-dangle': 'warn',
+        curly: 'warn',
+        'eol-last': 'warn',
         indent: [
             'warn',
             4,
@@ -13,6 +15,7 @@ module.exports = {
         'no-invalid-this': 'warn',
         'no-new-wrappers': 'warn',
         'no-return-await': 'warn',
+        'no-redeclare': 'off',
         'no-shadow': [
             'warn',
             {
@@ -36,8 +39,33 @@ module.exports = {
                 exceptions: ['*', '+', '-', '/', '!']
             }
         ],
+        'space-before-function-paren': [
+            'warn',
+            {
+                anonymous: 'always',
+                named: 'never',
+                asyncArrow: 'always'
+            }
+        ],
+        // Stylistic Issues
+        'max-len': [
+            'warn',
+            {
+                code: 140
+            }
+        ],
         'use-isnan': 'warn',
+        'arrow-parens': ['warn', 'as-needed'],
+
         // @typescript-eslint/eslint-plugin
+        '@typescript-eslint/semi': ['warn', 'always'],
+        '@typescript-eslint/quotes': [
+            'warn',
+            'single',
+            {
+                avoidEscape: true
+            }
+        ],
         '@typescript-eslint/explicit-function-return-type': [
             'warn',
             {

package/index.js

@@ -1,4 +1,9 @@
+module.exports = require('./configs/base.eslintrc');
+module.exports = require('./configs/errors.eslintrc');
+module.exports = require('./configs/warnings.eslintrc');
+/** @type {import('eslint').Linter.Config} */
 module.exports = {
-    extends: ['./no-prettier', 'prettier'],
-    root: 'true'
+    extends: ['prettier', './configs/base.eslintrc', './configs/warnings.eslintrc', './configs/errors.eslintrc'],
+    ignorePatterns: ['**/{css,node_modules,lib}'],
+    root: true
 };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@eclipse-glsp/eslint-config",
-  "version": "0.9.0-next.18041f6a",
+  "version": "0.9.0-next.34c10fc7",
   "description": "Shared ESLint configuration for GLSP projects",
   "license": "(EPL-2.0 OR GPL-2.0 WITH Classpath-exception-2.0)",
   "keywords": [

package/no-prettier.js

@@ -1,12 +0,0 @@
-module.exports = require("./configs/base.eslintrc");
-module.exports = require("./configs/errors.eslintrc");
-module.exports = require("./configs/warnings.eslintrc");
-/** @type {import('eslint').Linter.Config} */
-module.exports = {
-    extends: [
-        "./configs/base.eslintrc",
-        "./configs/warnings.eslintrc",
-        "./configs/errors.eslintrc",
-    ],
-    ignorePatterns: ["**/{css,node_modules,lib}"],
-};