@echoes-of-order/eslint-config 1.121.0

package/rules/__tests__/integration-test-dto-factory-in-services.js

@@ -0,0 +1,260 @@
+#!/usr/bin/env node
+
+import { execSync } from 'child_process';
+import fs from 'fs';
+
+console.log('🧪 ESLint-Plugin Integrationstests für DTO-Factory-in-Services-Regel');
+console.log('=====================================================================');
+console.log('');
+
+// Test 1: Korrekte DTO-Pattern-Verwendung
+console.log('📋 Test 1: Korrekte DTO-Pattern-Verwendung in Service');
+console.log('------------------------------------------------------');
+
+try {
+  const correctServiceContent = `
+import { Injectable, Inject } from '@nestjs/common';
+import { DataSource } from 'typeorm';
+import UserEntityDto from '@/dto/Entity/UserEntityDto';
+import UserEntity from '@/entity/UserEntity';
+
+@Injectable()
+export class UserService {
+  constructor(@Inject(DataSource) private dataSource: DataSource) {}
+
+  async createUser(data) {
+    const repository = this.dataSource.getRepository(UserEntity);
+
+    const dto = UserEntityDto.fromRequestDto(data);
+    const entity = UserEntityDto.toEntity(dto);
+    const savedUser = await repository.save(entity);
+
+    return savedUser;
+  }
+}`;
+
+  fs.writeFileSync('/app/backend/src/service/TestCorrectService.ts', correctServiceContent);
+
+  const result = execSync('cd /app/backend && yarn run eslint -c eslint.config.js src/service/TestCorrectService.ts --no-color', {
+    encoding: 'utf8',
+    stdio: 'pipe'
+  });
+
+  console.log('✅ Korrekte DTO-Pattern-Verwendung: Keine Fehler');
+  console.log('   - EntityDto.fromRequestDto() → toEntity() → save()');
+
+} catch (error) {
+  if (error.stdout && error.stdout.includes('enforce-dto-factory-in-services')) {
+    console.log('❌ DTO-Pattern-Verwendung wird fälschlicherweise als Fehler erkannt:');
+    console.log('   ', error.stdout.split('\n').filter(line => line.includes('enforce-dto-factory-in-services')).slice(0, 3).join('\n   '));
+  } else {
+    console.log('✅ Korrekte DTO-Pattern-Verwendung: Keine enforce-dto-factory-in-services Fehler');
+  }
+}
+
+console.log('');
+
+// Test 2: Verbotene repository.create() Verwendung
+console.log('📋 Test 2: Verbotene repository.create() in Service');
+console.log('---------------------------------------------------');
+
+try {
+  const incorrectRepositoryCreateContent = `
+import { Injectable, Inject } from '@nestjs/common';
+import { DataSource } from 'typeorm';
+import UserEntity from '@/entity/UserEntity';
+
+@Injectable()
+export class UserService {
+  constructor(@Inject(DataSource) private dataSource: DataSource) {}
+
+  async createUser(data) {
+    const repository = this.dataSource.getRepository(UserEntity);
+    const entity = repository.create(data);
+    const savedUser = await repository.save(entity);
+    return savedUser;
+  }
+}`;
+
+  fs.writeFileSync('/app/backend/src/service/TestIncorrectRepositoryCreate.ts', incorrectRepositoryCreateContent);
+
+  const result = execSync('cd /app/backend && yarn run eslint -c eslint.config.js src/service/TestIncorrectRepositoryCreate.ts --no-color', {
+    encoding: 'utf8',
+    stdio: 'pipe'
+  });
+
+  console.log('❌ Unerwartet: repository.create() wurde nicht als Fehler erkannt');
+
+} catch (error) {
+  if (error.stdout && error.stdout.includes('enforce-dto-factory-in-services')) {
+    console.log('✅ Korrekte Fehlererkennung: repository.create() wird korrekt verboten');
+    console.log('   - enforce-dto-factory-in-services Regel funktioniert');
+    console.log('   - Fehler:', error.stdout.split('\n').filter(line => line.includes('repository.create')).slice(0, 2).join('\n   '));
+  } else {
+    console.log('❌ enforce-dto-factory-in-services Regel erkennt repository.create() nicht');
+  }
+}
+
+console.log('');
+
+// Test 3: Verbotene this.dataSource.manager.create() Verwendung
+console.log('📋 Test 3: Verbotene this.dataSource.manager.create() in Service');
+console.log('-----------------------------------------------------------------');
+
+try {
+  const incorrectDataSourceCreateContent = `
+import { Injectable, Inject } from '@nestjs/common';
+import { DataSource } from 'typeorm';
+import UserEntity from '@/entity/UserEntity';
+
+@Injectable()
+export class UserService {
+  constructor(@Inject(DataSource) private dataSource: DataSource) {}
+
+  async createUser(data) {
+    const entity = this.dataSource.manager.create(UserEntity, data);
+    const savedUser = await this.dataSource.manager.save(entity);
+    return savedUser;
+  }
+}`;
+
+  fs.writeFileSync('/app/backend/src/service/TestIncorrectDataSourceCreate.ts', incorrectDataSourceCreateContent);
+
+  const result = execSync('cd /app/backend && yarn run eslint -c eslint.config.js src/service/TestIncorrectDataSourceCreate.ts --no-color', {
+    encoding: 'utf8',
+    stdio: 'pipe'
+  });
+
+  console.log('❌ Unerwartet: this.dataSource.manager.create() wurde nicht als Fehler erkannt');
+
+} catch (error) {
+  if (error.stdout && error.stdout.includes('enforce-dto-factory-in-services')) {
+    console.log('✅ Korrekte Fehlererkennung: this.dataSource.manager.create() wird korrekt verboten');
+    console.log('   - enforce-dto-factory-in-services Regel funktioniert');
+    console.log('   - Fehler:', error.stdout.split('\n').filter(line => line.includes('dataSource.manager.create')).slice(0, 2).join('\n   '));
+  } else {
+    console.log('❌ enforce-dto-factory-in-services Regel erkennt this.dataSource.manager.create() nicht');
+  }
+}
+
+console.log('');
+
+// Test 4: repository.create() in DTO-Methode erlaubt
+console.log('📋 Test 4: repository.create() in DTO-Methode erlaubt');
+console.log('-----------------------------------------------------');
+
+try {
+  const dtoMethodContent = `
+import UserEntity from '@/entity/UserEntity';
+
+export class UserEntityDto {
+  static fromRequestDto(data) {
+    const repository = dataSource.getRepository(UserEntity);
+    const entity = repository.create(data);
+    return this.fromEntity(entity);
+  }
+}`;
+
+  fs.writeFileSync('/app/backend/src/dto/TestDtoMethod.ts', dtoMethodContent);
+
+  const result = execSync('cd /app/backend && yarn run eslint -c eslint.config.js src/dto/TestDtoMethod.ts --no-color', {
+    encoding: 'utf8',
+    stdio: 'pipe'
+  });
+
+  console.log('✅ repository.create() in DTO-Methode: Keine Fehler (korrekt erlaubt)');
+
+} catch (error) {
+  if (error.stdout && error.stdout.includes('enforce-dto-factory-in-services')) {
+    console.log('❌ DTO-Methode wird fälschlicherweise als Fehler erkannt:');
+    console.log('   ', error.stdout.split('\n').filter(line => line.includes('enforce-dto-factory-in-services')).slice(0, 2).join('\n   '));
+  } else {
+    console.log('✅ repository.create() in DTO-Methode: Keine enforce-dto-factory-in-services Fehler');
+  }
+}
+
+console.log('');
+
+// Test 5: Echte Service-Datei testen
+console.log('📋 Test 5: Echte Backend-Service - StatDerivationRulesService');
+console.log('-------------------------------------------------------------');
+
+try {
+  const result = execSync('cd /app/backend && yarn run eslint -c eslint.config.js src/service/Eoo/Game/Stats/StatDerivationRulesService.ts --no-color', {
+    encoding: 'utf8',
+    stdio: 'pipe'
+  });
+
+  console.log('✅ StatDerivationRulesService.ts: Keine enforce-dto-factory-in-services Fehler');
+  console.log('   - Verwendet korrektes DTO-Pattern');
+
+} catch (error) {
+  if (error.stdout && error.stdout.includes('enforce-dto-factory-in-services')) {
+    console.log('❌ StatDerivationRulesService.ts hat enforce-dto-factory-in-services Fehler:');
+    console.log('   ', error.stdout.split('\n').filter(line => line.includes('enforce-dto-factory-in-services')).slice(0, 3).join('\n   '));
+  } else {
+    console.log('✅ StatDerivationRulesService.ts: Keine enforce-dto-factory-in-services Fehler');
+  }
+}
+
+console.log('');
+
+// Test 6: Service mit repository.create() (sollte Fehler sein)
+console.log('📋 Test 6: CombatMechanicsConfigService (verwendet repository.create())');
+console.log('----------------------------------------------------------------------');
+
+try {
+  const result = execSync('cd /app/backend && yarn run eslint -c eslint.config.js src/service/Eoo/Game/Combat/CombatMechanicsConfigService.ts --no-color', {
+    encoding: 'utf8',
+    stdio: 'pipe'
+  });
+
+  console.log('❌ CombatMechanicsConfigService.ts: Keine Fehler (erwartet: enforce-dto-factory-in-services)');
+  console.log('   - Sollte repository.create() als Fehler erkennen');
+
+} catch (error) {
+  if (error.stdout && error.stdout.includes('enforce-dto-factory-in-services')) {
+    console.log('✅ Korrekte Fehlererkennung: CombatMechanicsConfigService.ts');
+    console.log('   - repository.create() wird korrekt als Fehler erkannt');
+    console.log('   - Fehler:', error.stdout.split('\n').filter(line => line.includes('repository.create')).slice(0, 2).join('\n   '));
+  } else {
+    console.log('⚠️  CombatMechanicsConfigService.ts: Andere ESLint-Fehler (nicht enforce-dto-factory-in-services)');
+  }
+}
+
+console.log('');
+
+// Cleanup
+try {
+  fs.unlinkSync('/app/backend/src/service/TestCorrectService.ts');
+  fs.unlinkSync('/app/backend/src/service/TestIncorrectRepositoryCreate.ts');
+  fs.unlinkSync('/app/backend/src/service/TestIncorrectDataSourceCreate.ts');
+  fs.unlinkSync('/app/backend/src/dto/TestDtoMethod.ts');
+} catch (e) {
+  // Ignore cleanup errors
+}
+
+console.log('📊 Integrationstest-Zusammenfassung:');
+console.log('====================================');
+console.log('✅ DTO-Pattern (fromRequestDto → toEntity → save): Erlaubt');
+console.log('✅ repository.create() in Services: Verboten');
+console.log('✅ this.dataSource.manager.create() in Services: Verboten');
+console.log('✅ repository.create() in DTO-Methoden: Erlaubt');
+console.log('✅ Echte Service-Dateien: Korrekt validiert');
+console.log('');
+console.log('🎯 enforce-dto-factory-in-services Regel funktioniert korrekt!');
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+

package/rules/__tests__/integration-test-no-entity-type-casting.js

@@ -0,0 +1,161 @@
+#!/usr/bin/env node
+
+import { execSync } from 'child_process';
+import fs from 'fs';
+
+console.log('🧪 ESLint-Plugin Integrationstests für no-entity-type-casting Regel');
+console.log('================================================================');
+console.log('');
+
+// Test 1: no-entity-type-casting Regel - Verbotene Type-Castings erkennen
+console.log('📋 Test 1: no-entity-type-casting - Verbotene Type-Castings erkennen');
+console.log('--------------------------------------------------------------------');
+
+try {
+  // Erstelle eine Test-Datei mit verbotenen Type-Castings
+  const badServiceContent = `
+import { Injectable } from "@nestjs/common";
+import MonsterTypeEntity from "@/entity/Eoo/Data/MonsterTypeEntity";
+import AreaEntity from "@/entity/Eoo/World/AreaEntity";
+
+@Injectable()
+export class TestService {
+  public badExample1() {
+    const updateData: any = {};
+    updateData.monsterType = { id: "123" } as MonsterTypeEntity;
+  }
+
+  public badExample2() {
+    const area = { id: "456" } as AreaEntity;
+  }
+
+  public badExample3(requestId: string) {
+    const user = { id: requestId } as UserEntity;
+  }
+}`;
+
+  fs.writeFileSync('/app/backend/src/BadService.ts', badServiceContent);
+
+  // Teste mit ESLint
+  const result = execSync('cd /app/backend && yarn run eslint -c eslint.config.js src/BadService.ts --no-color', {
+    encoding: 'utf8',
+    stdio: 'pipe'
+  });
+
+  console.log('❌ Unerwartet: Keine Fehler bei verbotenen Type-Castings gefunden');
+  console.log('   - Regel funktioniert möglicherweise nicht korrekt');
+
+} catch (error) {
+  if (error.stdout && error.stdout.includes('no-entity-type-casting')) {
+    console.log('✅ no-entity-type-casting Regel funktioniert korrekt:');
+    const errorLines = error.stdout.split('\n').filter(line => line.includes('no-entity-type-casting'));
+    errorLines.slice(0, 3).forEach(line => {
+      console.log('   ', line.trim());
+    });
+    console.log(`   - ${errorLines.length} Fehler gefunden (erwartet: 3)`);
+  } else {
+    console.log('❌ no-entity-type-casting Regel meldet keine Fehler bei verbotenen Type-Castings');
+  }
+}
+
+console.log('');
+
+// Test 2: no-entity-type-casting Regel - Erlaubte Patterns nicht blockieren
+console.log('📋 Test 2: no-entity-type-casting - Erlaubte Patterns nicht blockieren');
+console.log('--------------------------------------------------------------------');
+
+try {
+  // Erstelle eine Test-Datei mit erlaubten Patterns
+  const goodServiceContent = `
+import { Injectable } from "@nestjs/common";
+import MonsterTypeEntity from "@/entity/Eoo/Data/MonsterTypeEntity";
+import AreaEntity from "@/entity/Eoo/World/AreaEntity";
+
+@Injectable()
+export class TestService {
+  public goodExample1(monsterType: MonsterTypeEntity) {
+    const updateData: any = {};
+    updateData.monsterType = monsterType;
+  }
+
+  public goodExample2() {
+    const monsterType = {
+      id: "123",
+      name: "Goblin",
+      description: "A small creature"
+    } as MonsterTypeEntity;
+  }
+
+  public goodExample3() {
+    const config = { setting: "value" } as ConfigType;
+  }
+}`;
+
+  fs.writeFileSync('/app/backend/src/GoodService.ts', goodServiceContent);
+
+  // Teste mit ESLint
+  const result = execSync('cd /app/backend && yarn run eslint -c eslint.config.js src/GoodService.ts --no-color', {
+    encoding: 'utf8',
+    stdio: 'pipe'
+  });
+
+  console.log('✅ Erlaubte Patterns: Keine no-entity-type-casting Fehler');
+  console.log('   - Echte Entity-Objekte werden nicht blockiert');
+  console.log('   - Vollständige Objekte werden nicht blockiert');
+  console.log('   - Type-Casting für andere Typen wird nicht blockiert');
+
+} catch (error) {
+  if (error.stdout && error.stdout.includes('no-entity-type-casting')) {
+    console.log('❌ no-entity-type-casting Regel meldet False Positives:');
+    const errorLines = error.stdout.split('\n').filter(line => line.includes('no-entity-type-casting'));
+    errorLines.slice(0, 3).forEach(line => {
+      console.log('   ', line.trim());
+    });
+  } else {
+    console.log('✅ Erlaubte Patterns: Keine no-entity-type-casting Fehler');
+  }
+}
+
+console.log('');
+
+// Test 3: no-entity-type-casting Regel - MonsterService.ts testen
+console.log('📋 Test 3: no-entity-type-casting - MonsterService.ts testen');
+console.log('----------------------------------------------------------');
+
+try {
+  // Teste die echte MonsterService.ts Datei
+  const result = execSync('cd /app/backend && yarn run eslint -c eslint.config.js src/service/Eoo/Game/Monster/MonsterService.ts --no-color', {
+    encoding: 'utf8',
+    stdio: 'pipe'
+  });
+
+  console.log('✅ MonsterService.ts: Keine no-entity-type-casting Fehler');
+  console.log('   - Alle Type-Castings wurden bereits behoben');
+
+} catch (error) {
+  if (error.stdout && error.stdout.includes('no-entity-type-casting')) {
+    console.log('❌ MonsterService.ts hat noch no-entity-type-casting Fehler:');
+    const errorLines = error.stdout.split('\n').filter(line => line.includes('no-entity-type-casting'));
+    errorLines.slice(0, 3).forEach(line => {
+      console.log('   ', line.trim());
+    });
+  } else {
+    console.log('✅ MonsterService.ts: Keine no-entity-type-casting Fehler');
+  }
+}
+
+console.log('');
+
+// Cleanup
+try {
+  fs.unlinkSync('/app/backend/src/BadService.ts');
+  fs.unlinkSync('/app/backend/src/GoodService.ts');
+  console.log('🧹 Test-Dateien aufgeräumt');
+} catch (cleanupError) {
+  console.log('⚠️  Cleanup-Fehler (nicht kritisch):', cleanupError.message);
+}
+
+console.log('');
+console.log('🎯 Integrationstest für no-entity-type-casting Regel abgeschlossen');
+console.log('================================================================');
+