@ebowwa/mcp-terminal 1.0.8

package/test-fix.sh

@@ -0,0 +1,273 @@
+#!/usr/bin/env bash
+#
+# Terminal MCP Fix Test Suite
+# ===========================
+# Tests the recursive loop bug fix for exec_ssh tool
+#
+# BUG DESCRIPTION:
+# The execSSHTool function was calling execSSH with wrong parameter order:
+# - WRONG: execSSH(host, command, options)
+# - RIGHT: execSSH(command, options)
+# - The options parameter must include the 'host' field
+#
+# Author: Test Engineer (team-lead request)
+# Date: 2026-02-05
+#
+
+set -euo pipefail
+
+# Colors for output
+RED='\033[0;31m'
+GREEN='\033[0;32m'
+YELLOW='\033[1;33m'
+BLUE='\033[0;34m'
+NC='\033[0m' # No Color
+
+# Test configuration
+TEST_TIMEOUT=10  # seconds
+MEMORY_LIMIT_MB=500
+TEST_PORT=8913
+
+# Test results
+TESTS_PASSED=0
+TESTS_FAILED=0
+
+# Safe test commands (read-only, non-destructive)
+SAFE_COMMANDS=(
+    "echo 'test'"
+    "whoami"
+    "pwd"
+    "uname -m"
+    "date +%s"
+)
+
+log_info() {
+    echo -e "${BLUE}[INFO]${NC} $*"
+}
+
+log_success() {
+    echo -e "${GREEN}[PASS]${NC} $*"
+    ((TESTS_PASSED++))
+}
+
+log_error() {
+    echo -e "${RED}[FAIL]${NC} $*"
+    ((TESTS_FAILED++))
+}
+
+log_warning() {
+    echo -e "${YELLOW}[WARN]${NC} $*"
+}
+
+# Test 1: Verify MCP server starts correctly
+test_server_startup() {
+    log_info "Test 1: Starting MCP server on port $TEST_PORT..."
+
+    # Start server in background
+    cd /Users/ebowwa/Desktop/codespaces/packages/src/terminal/mcp
+    MCP_PORT=$TEST_PORT bun stdio.ts &
+    SERVER_PID=$!
+
+    # Wait for server to start
+    sleep 2
+
+    # Check if process is still running
+    if ps -p $SERVER_PID > /dev/null 2>&1; then
+        log_success "MCP server started successfully (PID: $SERVER_PID)"
+        echo $SERVER_PID > /tmp/terminal-mcp-test.pid
+        return 0
+    else
+        log_error "MCP server failed to start"
+        return 1
+    fi
+}
+
+# Test 2: Verify no infinite recursion on exec_ssh calls
+test_no_recursion() {
+    log_info "Test 2: Testing for recursive loop bug..."
+
+    # Test each safe command
+    for cmd in "${SAFE_COMMANDS[@]}"; do
+        log_info "  Testing command: $cmd"
+
+        # Create test request
+        cat > /tmp/test_request.json <<EOF
+{
+  "jsonrpc": "2.0",
+  "id": 1,
+  "method": "tools/call",
+  "params": {
+    "name": "exec_ssh",
+    "arguments": {
+      "host": "localhost",
+      "command": "$cmd"
+    }
+  }
+}
+EOF
+
+        # Execute with timeout to catch infinite loops
+        timeout $TEST_TIMEOUT cat /tmp/test_request.json | \
+            MCP_PORT=$TEST_PORT bun stdio.ts > /tmp/test_response.json 2>&1 || {
+            log_error "Command timed out or failed: $cmd"
+            cat /tmp/test_response.json
+            return 1
+        }
+
+        # Check response
+        if grep -q '"result"' /tmp/test_response.json; then
+            log_success "Command executed without recursion: $cmd"
+        else
+            log_error "Invalid response for command: $cmd"
+            cat /tmp/test_response.json
+            return 1
+        fi
+    done
+
+    return 0
+}
+
+# Test 3: Memory leak detection
+test_memory_leak() {
+    log_info "Test 3: Testing for memory leaks..."
+
+    # Get initial memory
+    local initial_mem=$(ps -o rss= -p $SERVER_PID 2>/dev/null || echo "0")
+
+    # Execute multiple commands
+    for i in {1..50}; do
+        echo "echo 'iteration-$i'" | \
+            MCP_PORT=$TEST_PORT bun stdio.ts > /dev/null 2>&1
+    done
+
+    # Get final memory
+    local final_mem=$(ps -o rss= -p $SERVER_PID 2>/dev/null || echo "0")
+
+    # Calculate memory growth (in MB)
+    local mem_growth=$(( ($final_mem - $initial_mem) / 1024 ))
+
+    log_info "  Memory growth: ${mem_growth}MB"
+
+    if [ $mem_growth -lt $MEMORY_LIMIT_MB ]; then
+        log_success "Memory usage within acceptable limits"
+        return 0
+    else
+        log_error "Excessive memory growth detected: ${mem_growth}MB"
+        return 1
+    fi
+}
+
+# Test 4: Parameter validation
+test_parameter_validation() {
+    log_info "Test 4: Testing parameter validation..."
+
+    # Test with missing host parameter
+    cat > /tmp/test_invalid.json <<EOF
+{
+  "jsonrpc": "2.0",
+  "id": 2,
+  "method": "tools/call",
+  "params": {
+    "name": "exec_ssh",
+    "arguments": {
+      "command": "echo test"
+    }
+  }
+}
+EOF
+
+    timeout 5 cat /tmp/test_invalid.json | \
+        MCP_PORT=$TEST_PORT bun stdio.ts > /tmp/test_invalid_response.json 2>&1
+
+    if grep -q '"error"' /tmp/test_invalid_response.json || \
+       grep -q 'required' /tmp/test_invalid_response.json; then
+        log_success "Parameter validation working correctly"
+        return 0
+    else
+        log_warning "Parameter validation may not be working"
+        return 1
+    fi
+}
+
+# Test 5: List available tools
+test_list_tools() {
+    log_info "Test 5: Listing available tools..."
+
+    cat > /tmp/test_list.json <<EOF
+{
+  "jsonrpc": "2.0",
+  "id": 3,
+  "method": "tools/list"
+}
+EOF
+
+    timeout 5 cat /tmp/test_list.json | \
+        MCP_PORT=$TEST_PORT bun stdio.ts > /tmp/test_list_response.json 2>&1
+
+    if grep -q '"tools"' /tmp/test_list_response.json && \
+       grep -q '"exec_ssh"' /tmp/test_list_response.json; then
+        log_success "Tools list includes exec_ssh"
+        return 0
+    else
+        log_error "Tools list incomplete"
+        cat /tmp/test_list_response.json
+        return 1
+    fi
+}
+
+# Cleanup function
+cleanup() {
+    log_info "Cleaning up..."
+
+    # Kill server if running
+    if [ -f /tmp/terminal-mcp-test.pid ]; then
+        SERVER_PID=$(cat /tmp/terminal-mcp-test.pid)
+        if ps -p $SERVER_PID > /dev/null 2>&1; then
+            kill $SERVER_PID 2>/dev/null || true
+            log_info "Killed MCP server (PID: $SERVER_PID)"
+        fi
+        rm -f /tmp/terminal-mcp-test.pid
+    fi
+
+    # Clean up test files
+    rm -f /tmp/test_*.json
+
+    # Display results
+    echo ""
+    echo "==================================="
+    echo "Test Results Summary"
+    echo "==================================="
+    echo -e "Passed: ${GREEN}${TESTS_PASSED}${NC}"
+    echo -e "Failed: ${RED}${TESTS_FAILED}${NC}"
+    echo "==================================="
+
+    if [ $TESTS_FAILED -eq 0 ]; then
+        echo -e "${GREEN}All tests passed!${NC}"
+        exit 0
+    else
+        echo -e "${RED}Some tests failed!${NC}"
+        exit 1
+    fi
+}
+
+# Trap cleanup on exit
+trap cleanup EXIT
+
+# Main test execution
+main() {
+    log_info "Terminal MCP Fix Test Suite"
+    log_info "=============================="
+    echo ""
+
+    # Run tests
+    test_server_startup || exit 1
+    test_list_tools || true
+    test_no_recursion || true
+    test_memory_leak || true
+    test_parameter_validation || true
+
+    # Cleanup will be called by trap
+}
+
+# Run main function
+main "$@"

package/wrapper.mjs

@@ -0,0 +1,10 @@
+#!/usr/bin/env node
+/**
+ * Terminal MCP Server - Node.js wrapper
+ *
+ * This wrapper ensures proper module resolution for the stdio.ts
+ */
+
+// Use dynamic import to ensure @ebowwa/terminal is resolved correctly
+const { default: run } = await import('./stdio.ts');
+run();