@easypayment/medusa-paypal 0.4.6 → 0.4.8

package/src/api/store/paypal/config/route.ts

@@ -1,103 +1,103 @@
-import type { MedusaRequest, MedusaResponse } from "@medusajs/framework/http"
-import type PayPalModuleService from "../../../../modules/paypal/service"
-import {
-  getPayPalCurrencyCompatibility,
-  getPayPalSupportedCurrencies,
-  normalizeCurrencyCode,
-} from "../../../../modules/paypal/utils/currencies"
-
-export async function GET(req: MedusaRequest, res: MedusaResponse) {
-  const paypal = req.scope.resolve<PayPalModuleService>("paypal_onboarding")
-  try {
-    const creds = await paypal.getActiveCredentials()
-    const apiDetails = await paypal.getApiDetails().catch(() => null)
-    const client_token = await paypal.generateClientToken({ locale: "en_US" }).catch(() => "")
-    const cartId = (req.query?.cart_id as string) || ""
-    const query = req.scope.resolve("query")
-    let currency = normalizeCurrencyCode(
-      apiDetails?.apiDetails?.currency_code || process.env.PAYPAL_CURRENCY || "EUR"
-    )
-    if (cartId) {
-      const { data: carts } = await query.graph({
-        entity: "cart",
-        fields: ["id", "currency_code", "region.currency_code"],
-        filters: { id: cartId },
-      })
-      const cart = carts?.[0]
-      if (cart) {
-        currency = normalizeCurrencyCode(
-          cart.region?.currency_code || cart.currency_code || currency
-        )
-      }
-    }
-    const compatibility = getPayPalCurrencyCompatibility({
-      currencyCode: currency,
-      paypalCurrencyOverride:
-        apiDetails?.apiDetails?.currency_code || process.env.PAYPAL_CURRENCY,
-    })
-
-    // Read settings so frontend SDK mirrors admin controls.
-    const settings = await paypal.getSettings().catch(() => ({}))
-    const data =
-      settings && typeof settings === "object" && "data" in settings
-        ? ((settings as any).data || {})
-        : {}
-
-    const additionalSettings =
-      data && typeof data === "object"
-        ? ((data as Record<string, any>).additional_settings || {})
-        : {}
-
-    const paypalSettings =
-      data && typeof data === "object"
-        ? ((data as Record<string, any>).paypal_settings || {})
-        : {}
-
-    const paymentAction =
-      typeof additionalSettings.paymentAction === "string"
-        ? additionalSettings.paymentAction
-        : "capture"
-
-    // P1 — enforce disable at API level: return 403 when admin disables PayPal wallet
-    if (paypalSettings.enabled === false) {
-      return res.status(403).json({ message: "PayPal is currently disabled." })
-    }
-
-
-    // P2 — read advanced card payments settings
-    const advancedCardSettings =
-      data && typeof data === "object"
-        ? ((data as Record<string, any>).advanced_card_payments || {})
-        : {}
-
-    const cardEnabled: boolean = advancedCardSettings.enabled !== false
-
-    const cardThreeDS =
-      typeof advancedCardSettings.threeDS === "string"
-        ? advancedCardSettings.threeDS
-        : "when_required"
-
-    return res.json({
-      environment: creds.environment,
-      client_id: creds.client_id,
-      currency: compatibility.currency,
-      currency_supported: compatibility.supported,
-      currency_errors: compatibility.errors,
-      supported_currencies: getPayPalSupportedCurrencies(),
-      client_token,
-      intent: paymentAction,
-      paypal_enabled: paypalSettings.enabled ?? true,
-      paypal_title: paypalSettings.title || "PayPal",
-      card_enabled: cardEnabled,
-      card_title: advancedCardSettings.title || "Credit or Debit Card",
-      card_three_ds: cardThreeDS,                                          // ← added
-      button_color: paypalSettings.buttonColor || "gold",
-      button_shape: paypalSettings.buttonShape || "rect",
-      button_width: paypalSettings.buttonWidth || "responsive",
-      button_height: paypalSettings.buttonHeight ?? 45,
-      button_label: paypalSettings.buttonLabel || "paypal",
-    })
-  } catch (e: any) {
-    return res.status(500).json({ message: e?.message || "Failed to load PayPal config" })
-  }
+import type { MedusaRequest, MedusaResponse } from "@medusajs/framework/http"
+import type PayPalModuleService from "../../../../modules/paypal/service"
+import {
+  getPayPalCurrencyCompatibility,
+  getPayPalSupportedCurrencies,
+  normalizeCurrencyCode,
+} from "../../../../modules/paypal/utils/currencies"
+
+export async function GET(req: MedusaRequest, res: MedusaResponse) {
+  const paypal = req.scope.resolve<PayPalModuleService>("paypal_onboarding")
+  try {
+    const creds = await paypal.getActiveCredentials()
+    const apiDetails = await paypal.getApiDetails().catch(() => null)
+    const client_token = await paypal.generateClientToken({ locale: "en_US" }).catch(() => "")
+    const cartId = (req.query?.cart_id as string) || ""
+    const query = req.scope.resolve("query")
+    let currency = normalizeCurrencyCode(
+      apiDetails?.apiDetails?.currency_code || process.env.PAYPAL_CURRENCY || "EUR"
+    )
+    if (cartId) {
+      const { data: carts } = await query.graph({
+        entity: "cart",
+        fields: ["id", "currency_code", "region.currency_code"],
+        filters: { id: cartId },
+      })
+      const cart = carts?.[0]
+      if (cart) {
+        currency = normalizeCurrencyCode(
+          cart.region?.currency_code || cart.currency_code || currency
+        )
+      }
+    }
+    const compatibility = getPayPalCurrencyCompatibility({
+      currencyCode: currency,
+      paypalCurrencyOverride:
+        apiDetails?.apiDetails?.currency_code || process.env.PAYPAL_CURRENCY,
+    })
+
+    // Read settings so frontend SDK mirrors admin controls.
+    const settings = await paypal.getSettings().catch(() => ({}))
+    const data =
+      settings && typeof settings === "object" && "data" in settings
+        ? ((settings as any).data || {})
+        : {}
+
+    const additionalSettings =
+      data && typeof data === "object"
+        ? ((data as Record<string, any>).additional_settings || {})
+        : {}
+
+    const paypalSettings =
+      data && typeof data === "object"
+        ? ((data as Record<string, any>).paypal_settings || {})
+        : {}
+
+    const paymentAction =
+      typeof additionalSettings.paymentAction === "string"
+        ? additionalSettings.paymentAction
+        : "capture"
+
+    // P1 — enforce disable at API level: return 403 when admin disables PayPal wallet
+    if (paypalSettings.enabled === false) {
+      return res.status(403).json({ message: "PayPal is currently disabled." })
+    }
+
+
+    // P2 — read advanced card payments settings
+    const advancedCardSettings =
+      data && typeof data === "object"
+        ? ((data as Record<string, any>).advanced_card_payments || {})
+        : {}
+
+    const cardEnabled: boolean = advancedCardSettings.enabled !== false
+
+    const cardThreeDS =
+      typeof advancedCardSettings.threeDS === "string"
+        ? advancedCardSettings.threeDS
+        : "when_required"
+
+    return res.json({
+      environment: creds.environment,
+      client_id: creds.client_id,
+      currency: compatibility.currency,
+      currency_supported: compatibility.supported,
+      currency_errors: compatibility.errors,
+      supported_currencies: getPayPalSupportedCurrencies(),
+      client_token,
+      intent: paymentAction,
+      paypal_enabled: paypalSettings.enabled ?? true,
+      paypal_title: paypalSettings.title || "PayPal",
+      card_enabled: cardEnabled,
+      card_title: advancedCardSettings.title || "Credit or Debit Card",
+      card_three_ds: cardThreeDS,                                          // ← added
+      button_color: paypalSettings.buttonColor || "gold",
+      button_shape: paypalSettings.buttonShape || "rect",
+      button_width: paypalSettings.buttonWidth || "responsive",
+      button_height: paypalSettings.buttonHeight ?? 45,
+      button_label: paypalSettings.buttonLabel || "paypal",
+    })
+  } catch (e: any) {
+    return res.status(500).json({ message: e?.message || "Failed to load PayPal config" })
+  }
 }

package/src/api/store/paypal/create-order/route.ts

@@ -254,13 +254,21 @@ export async function POST(req: MedusaRequest, res: MedusaResponse) {
     const discountMajor = Number(cart.discount_total || 0)
     const giftCardMajor = Number(cart.gift_card_total || 0)
     const lineItems = Array.isArray((cart as any).items) ? (cart as any).items : []
+    // factor converts MINOR units (cents) → MAJOR units (euros)
+    // e.g. item.subtotal=1000, factor=100 → €10.00
+    const factor = Math.pow(10, exponent)
+
     const purchaseItemsRaw = sendItemDetails
       ? lineItems
           .map((item: any) => {
             const quantity = Number(item?.quantity || 0)
-            const lineSubtotal = Number(item?.subtotal ?? (Number(item?.unit_price || 0) * quantity))
+            // item.subtotal is in MINOR units (cents) — divide by factor to get euros
+            const lineSubtotalMinor = Number(
+              item?.subtotal ?? (Number(item?.unit_price || 0) * quantity)
+            )
+            const lineSubtotalMajor = lineSubtotalMinor / factor
             const unitAmount =
-              quantity > 0 ? parseFloat((lineSubtotal / quantity).toFixed(exponent)) : 0
+              quantity > 0 ? parseFloat((lineSubtotalMajor / quantity).toFixed(exponent)) : 0
 
             if (!quantity || Number.isNaN(quantity) || Number.isNaN(unitAmount)) {
               return null
@@ -290,7 +298,9 @@ export async function POST(req: MedusaRequest, res: MedusaResponse) {
     const diff = parseFloat((subtotalMajor - roundedItemSumFixed).toFixed(exponent))
 
     const finalPurchaseItems = purchaseItemsRaw.map((item: any) => item.paypalItem)
-    let adjustedItemTotal = subtotalMajor
+    // adjustedItemTotal stays as subtotalMajor — the offset item absorbs the rounding gap
+    // so that sum(unit_amount × quantity) === subtotalMajor exactly
+    const adjustedItemTotal = subtotalMajor
 
     if (Math.abs(diff) > 0.000001 && sendItemDetails && finalPurchaseItems.length > 0) {
       finalPurchaseItems.push({

package/src/api/store/paypal/settings/route.ts

@@ -1,19 +1,19 @@
-import type { MedusaRequest, MedusaResponse } from "@medusajs/framework/http"
-import type PayPalModuleService from "../../../../modules/paypal/service"
-
-export async function GET(req: MedusaRequest, res: MedusaResponse) {
-  const paypal = req.scope.resolve<PayPalModuleService>("paypal_onboarding")
-  try {
-    const settings = await paypal.getSettings()
-    const data = (settings?.data || {}) as Record<string, any>
-    const additionalSettings = (data.additional_settings || {}) as Record<string, any>
-    const advancedCard = (data.advanced_card_payments || {}) as Record<string, any>
-
-    return res.json({
-      paymentAction: additionalSettings.paymentAction === "authorize" ? "authorize" : "capture",
-      advancedCardEnabled: advancedCard.enabled === true,
-    })
-  } catch (e: any) {
-    return res.status(500).json({ message: e?.message || "Failed to load PayPal settings" })
-  }
-}
+import type { MedusaRequest, MedusaResponse } from "@medusajs/framework/http"
+import type PayPalModuleService from "../../../../modules/paypal/service"
+
+export async function GET(req: MedusaRequest, res: MedusaResponse) {
+  const paypal = req.scope.resolve<PayPalModuleService>("paypal_onboarding")
+  try {
+    const settings = await paypal.getSettings()
+    const data = (settings?.data || {}) as Record<string, any>
+    const additionalSettings = (data.additional_settings || {}) as Record<string, any>
+    const advancedCard = (data.advanced_card_payments || {}) as Record<string, any>
+
+    return res.json({
+      paymentAction: additionalSettings.paymentAction === "authorize" ? "authorize" : "capture",
+      advancedCardEnabled: advancedCard.enabled === true,
+    })
+  } catch (e: any) {
+    return res.status(500).json({ message: e?.message || "Failed to load PayPal settings" })
+  }
+}