@dzhechkov/skills-idea2prd 0.1.6 → 0.1.7

package/.dz-manifest.json

@@ -21,7 +21,7 @@
       },
       {
         "path": "package.json",
-        "sha256": "ee0b0a6cd08b2d962cd3b734369870b434f33eeafe874a7f0f0dd1c10b68f85c"
+        "sha256": "4bfe6564c3745ab76783640b91973036f6687155111052f3e3e34a3eb4dcd874"
       },
       {
         "path": "sources.json",
@@ -109,7 +109,7 @@
       },
       {
         "path": "templates/.claude/skills/goap-research-ed25519/scripts/learning_bridge.py",
-        "sha256": "6980dd654d77e296f1ab20a9b7a7c43741fd4125ee44727183c63587421d5503"
+        "sha256": "f6ec73a2ef239b8195a321b5f20b6ab390d9a7004b42226b2a861181cf9e2d2f"
       },
       {
         "path": "templates/.claude/skills/goap-research-ed25519/scripts/source_tiers.py",
@@ -121,7 +121,7 @@
       },
       {
         "path": "templates/.claude/skills/goap-research-ed25519/scripts/test_evidence_provenance.py",
-        "sha256": "6825da92d859a299b86bd9bf9910088a95665e0716346e55f0f117d991d25c9b"
+        "sha256": "86216fb6a40fcf270eada41c4a534600d2bcb2799052cbacfd64b459229b5bfe"
       },
       {
         "path": "templates/.claude/skills/idea2prd-manual/SKILL.md",
@@ -173,5 +173,5 @@
       }
     ]
   },
-  "signature": "UhTuxP7abRlbM11LsOmZlKlUfHTEjXUHLQ3d6OmAeJDWvn+AQiJ4k1pj5p2LIKshE3rsGQrckDPa/OQXH92sCw=="
+  "signature": "Rc5O0UZz+GsMlKiMvr/E8f4SUUtkaHJnL30dpGPXNIxY7Wo5SEYaTnB+P0GRSi1AYJjihTlsAo7d34RrSfQpAQ=="
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@dzhechkov/skills-idea2prd",
-  "version": "0.1.6",
+  "version": "0.1.7",
   "description": "Idea2PRD Manual — composite skill for Claude Code: from problem/idea to Vibe-Coding-ready docs (PRD + ADR + DDD + C4 + Pseudocode + Test Scenarios + Completion) with 9 checkpoints",
   "main": "src/cli.js",
   "bin": {

package/sbom.json

@@ -55,7 +55,7 @@
       "hashes": [
         {
           "alg": "SHA-256",
-          "content": "ee0b0a6cd08b2d962cd3b734369870b434f33eeafe874a7f0f0dd1c10b68f85c"
+          "content": "4bfe6564c3745ab76783640b91973036f6687155111052f3e3e34a3eb4dcd874"
         }
       ]
     },
@@ -275,7 +275,7 @@
       "hashes": [
         {
           "alg": "SHA-256",
-          "content": "6980dd654d77e296f1ab20a9b7a7c43741fd4125ee44727183c63587421d5503"
+          "content": "f6ec73a2ef239b8195a321b5f20b6ab390d9a7004b42226b2a861181cf9e2d2f"
         }
       ]
     },
@@ -305,7 +305,7 @@
       "hashes": [
         {
           "alg": "SHA-256",
-          "content": "6825da92d859a299b86bd9bf9910088a95665e0716346e55f0f117d991d25c9b"
+          "content": "86216fb6a40fcf270eada41c4a534600d2bcb2799052cbacfd64b459229b5bfe"
         }
       ]
     },

package/templates/.claude/skills/goap-research-ed25519/scripts/learning_bridge.py

@@ -127,7 +127,12 @@ DZ_MISSING_NOTE = (
 
 # Any digit. Yes, any: a threshold, a dose, a year and a lab value are the same
 # character class, and no amount of context-sniffing reliably tells them apart.
-_DIGIT_RE = r"\d"
+# NOT the regex `\d`. Round 5: the text scan used `\d` while the token scan used
+# str.isdigit(), and `²` satisfies the second but not the first — so it was skipped as
+# "a number" by one half and never refused by the other. Two different definitions of
+# "digit" in one guard is a gap by construction. One predicate, used everywhere.
+def _has_digit(text: str) -> bool:
+    return any(ch.isdigit() or ch.isnumeric() for ch in text)
 
 # A value SPELLED OUT is still a value. Round 2 walked `John's TSH was eight point
 # zero four` through the digit rule untouched. Requiring two number-words in a row
@@ -162,7 +167,11 @@ _IDENTIFIER_PATTERNS: Sequence[Tuple[str, str, bool]] = (
     # and a permitted number — laundered by punctuation. This reads the RAW text, where
     # the joiner is still visible. A SPACE is deliberately not a joiner here, or every
     # "the 2019 guideline" would be refused.
-    (r"\b[A-Za-zА-Яа-я]{2,}[—–/._-]?\d{4,}\b",
+    # Any letter in ANY script, any single non-space separator, a long digit run. Round 5
+    # walked `ab:1234567` (colon was not in the joiner list) and `αβ—1234567` (Greek was
+    # not in the letter class) straight through. Enumerating joiners and alphabets is the
+    # same losing game as enumerating names; "not a space" and "any letter" are not.
+    (r"[^\W\d_]{2,}[^\w\s]?\d{4,}",
      "letters sitting against a long run of digits — that is an identifier, however it is punctuated", False),
 )
 
@@ -264,11 +273,11 @@ _IDENTIFIER_MIN_DIGITS = 4
 # runs when --allow-numbers was passed (digits are refused outright otherwise). It is
 # the narrowest of the three clauses and the only one that is still an enumeration.
 _PERSON_RE = (
-    r"\b(patient|subject|participant|client|donor|volunteer|"
+    r"\b(patient|subject|participant|client|donor|volunteer|person|"
     r"woman|man|individual|child|infant|adult|"
     r"he|she|him|his|her|hers|"
     r"пациент(?!ы|ов|ам|ами|ах)\w*|больн(ой|ого|ому|ым|ом)|испытуем(ый|ого|ому|ым|ом)|"
-    r"мужчина|мужчины\b|женщина|женщины\b|ребёнок|ребенок|доброволец|"
+    r"мужчина|мужчины\b|женщина|женщины\b|ребёнок|ребенок|доброволец|человек|"
     r"у него|у неё)\b"
 )
 
@@ -276,6 +285,7 @@ _PERSON_RE = (
 class LessonVerdict:
     ok: bool
     reasons: List[str]
+    numbers_allowed: bool = False
 
     @property
     def note(self) -> str:
@@ -283,6 +293,17 @@ class LessonVerdict:
             # NOT "safe": a shape detector cannot certify safety, and saying so would
             # transfer responsibility it does not have (Codex QE #2). It reports the
             # absence of a detected shape — the author still owns the content.
+            # The note must describe what was actually checked. Round 5: it said "no
+            # digits, no figures" even on the --allow-numbers path, where digits were
+            # present and consciously allowed — a message that contradicts the flag the
+            # caller just passed teaches the reader to stop reading messages.
+            if self.numbers_allowed:
+                return (
+                    "no personal-data SHAPE detected (identifiers, capitalisation, person-plus-value). "
+                    "Digits were ALLOWED by --allow-numbers and are present — you asserted the number "
+                    "is knowledge, not a reading, and you own that call. This is not a safety "
+                    "certificate: the guard checks shapes, not meaning."
+                )
             return (
                 "no personal-data SHAPE detected (no digits, no identifiers, lower case). This is "
                 "not a safety certificate: the guard checks shapes, not meaning — a lower-case "
@@ -331,11 +352,14 @@ def check_lesson(text: str, allow_numbers: bool = False) -> LessonVerdict:
                 "flag accepts it"
             )
             break
-        if has_digit or not has_alpha:
-            continue  # numbers are judged below; punctuation-only tokens carry nothing
+        if not has_alpha:
+            continue  # a pure number is judged by the digit rule; punctuation carries nothing
         if index == 0:
             continue  # an ordinary sentence start
-        if token.islower() or _is_acronym(token):
+        # Capitalisation is checked for EVERY token carrying letters, digits or not.
+        # Round 5: digit-bearing tokens returned before this check, so `method Test2
+        # applies` passed — a Title Case name only had to carry a digit to become exempt.
+        if all(ch.islower() for ch in token if ch.isalpha()) or _is_acronym(token):
             continue
         reasons.append(
             f"a capitalised word ({token!r}) after the first one — a method lesson is written "
@@ -346,7 +370,7 @@ def check_lesson(text: str, allow_numbers: bool = False) -> LessonVerdict:
         break
 
     spelled = re.search(_SPELLED_NUMBER_RE, raw, flags=re.IGNORECASE | re.UNICODE)
-    has_digits = re.search(_DIGIT_RE, raw) is not None or spelled is not None
+    has_digits = _has_digit(raw) or spelled is not None
     if has_digits and not allow_numbers:
         reasons.append(
             "the lesson contains digits — a method lesson rarely needs them, and a number is where "
@@ -367,7 +391,7 @@ def check_lesson(text: str, allow_numbers: bool = False) -> LessonVerdict:
             "a person is referred to alongside a number — that is a record about someone, "
             "and no flag makes it a method"
         )
-    return LessonVerdict(not reasons, reasons)
+    return LessonVerdict(not reasons, reasons, numbers_allowed=allow_numbers)
 
 
 # ---------------------------------------------------------------- dz detection

package/templates/.claude/skills/goap-research-ed25519/scripts/test_evidence_provenance.py

@@ -812,6 +812,45 @@ class LearningBridgeTests(unittest.TestCase):
         self.assertTrue(self.lb._boost_note_present("  [0.90] (general) x\n  " + tail))
 
 
+    # ---------------------------------------------------------------- round 5
+
+    def test_round5_ONE_definition_of_digit_everywhere(self):
+        """The text scan used the regex `\\d` and the token scan used str.isdigit().
+        `²` satisfies the second but not the first, so one half skipped it as a number
+        and the other never refused it. Two definitions of the same word inside one
+        guard is a gap by construction."""
+        self.assertFalse(self.lb.check_lesson("threshold is ²").ok)
+
+    def test_round5_capitalisation_is_checked_even_when_a_token_carries_a_digit(self):
+        """Digit-bearing tokens returned before the capitalisation check, so a Title
+        Case name only had to carry a digit to become exempt."""
+        self.assertFalse(self.lb.check_lesson("method Test2 applies", allow_numbers=True).ok)
+
+    def test_round5_joiners_and_alphabets_are_not_enumerated(self):
+        """`ab:1234567` passed because a colon was not in the joiner list, and
+        `αβ—1234567` because Greek was not in the letter class. Enumerating joiners and
+        alphabets is the same losing game as enumerating names."""
+        for leak in ("passport ab:1234567 identifies the holder",
+                     "passport αβ—1234567 identifies the holder"):
+            with self.subTest(leak=leak):
+                self.assertFalse(self.lb.check_lesson(leak, allow_numbers=True).ok, leak)
+
+    def test_round5_the_word_person_is_a_person(self):
+        """The singular list enumerated patient/subject/participant and omitted the
+        plainest word of all."""
+        self.assertFalse(self.lb.check_lesson("this person has tsh 8.04", allow_numbers=True).ok)
+
+    def test_round5_the_acceptance_note_does_not_contradict_the_flag(self):
+        """It said "no digits, no figures" on the --allow-numbers path, where digits
+        were present and consciously allowed. A message that contradicts the flag the
+        caller just passed teaches the reader to stop reading messages."""
+        verdict = self.lb.check_lesson("a 56h fast lowers total testosterone by a third",
+                                       allow_numbers=True)
+        self.assertTrue(verdict.ok)
+        self.assertNotIn("no digits", verdict.note)
+        self.assertIn("ALLOWED by --allow-numbers", verdict.note)
+
+
     def test_a_real_failure_is_not_disguised_as_an_old_cli(self):
         """A crash, timeout or corrupt store must read as a failure, not as 'upgrade'."""
         original = self.lb._run_dz