@dzhechkov/skills-feature-adr 1.3.58 → 1.3.59

package/README.md

@@ -471,6 +471,38 @@ Step 3 and Step 8 share an ADR best-practices contract distilled from the
 The pipeline **dog-foods** this: a harness test runs the gate against feature-adr's own generated ADR, so a
 Step-3↔Step-8 drift fails CI rather than shipping.
 
+### Amendments are mini-ADRs + the 🚦 Gates line (v1.3.58)
+
+Three additions derived from a real post-release incident analysis (a pipeline shipped slices whose defects
+only a *full* post-push review caught), organized by one principle — the **cost-of-detection ladder**: every
+check lives on the cheapest layer that reliably holds it (deterministic test > always-loaded file > pipeline
+gate > reviewer judgment > memory). A miss usually means a check lived one layer too weak.
+
+- **Amendment Confirmation discipline.** Corrections folded into a run (a Step-3.5 CONDITIONAL condition, a
+  challenge-panel confirmed finding, a user checkpoint steer) were historically the least-tested part of the
+  pipeline — prose deltas with no proving test. Now every amendment is a **mini-ADR** in a `## Amendments`
+  section with a fixed, lintable shape:
+  ```
+  AM-N (qcsd|challenge-panel|user-steer): <change>. Confirmation: <property> → test `test_name` (fails if reverted).
+  ```
+  Step 8 verifies each named test **exists** and is **non-vacuous** — amendment tests join the ADR property
+  test in the same `dz discrimination-check` run (a test that stays green at pre-feature base proves
+  nothing). A *safeguard* amendment needs a test proving it actually **fires** on a real input, not just
+  that its code path exists. No `## Amendments` section ⇒ the gate skips silently (zero cost).
+- **The `🚦 Gates:` line.** Every checkpoint banner (and the workflow's return objects) carries a gate map
+  **derived from machine state** — artifact existence, JSON verdicts, test results — never from what the
+  orchestrator remembers. `✓` passed · `✗` failed · `not-run` pending · `—` N/A. The line doesn't make a
+  gate run; it makes NOT running one loud.
+- **I/O-on-pure-path rule.** A change that adds I/O (DB/network/file) to a previously-pure path — above all
+  startup/lifespan/health — must carry a **negative resource-down test** (broken resource → the declared
+  degradation contract: fail-open for advisory, fail-fast for load-bearing), and Step 8 hunts the
+  **fixture-swap smell**: replacing a broken fixture with a healthy one silently deletes the negative
+  control that proved the path was I/O-free. The bundled role-default skills gained the matching entries
+  (`code-impl` P25, `code-critic` AP14).
+
+Both forms carry all of it: the interactive skill (step modules + banner template) and the deterministic
+workflow (stage prompts + derived `gates` in its returns) — same shapes, same vocabulary.
+
 ### The `Model` / `Fable?` columns — read this before swapping models
 
 The `Model` column is the **default recommendation, fully overridable** — the routing rule is

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@dzhechkov/skills-feature-adr",
-  "version": "1.3.58",
+  "version": "1.3.59",
   "description": "Adaptive Feature Development skill pack for Claude Code — 11-step pipeline with Complexity Router (S/M/L/XL), ADR-driven architecture, 15 agentic-qe skills, multi-agent fleet QE. Supports --full-qe, --full-qe-extended, --with-learning, and --knowledge-extractor modes.",
   "bin": {
     "skills-feature-adr": "./bin/cli.js"
@@ -13,6 +13,10 @@
     "CHANGELOG.md",
     "docs/"
   ],
+  "scripts": {
+    "test": "node --test \"test/**/*.test.js\"",
+    "prepack": "node -e \"const fs=require('fs');const bad=['.claude','.skills-feature-adr.json'].filter(p=>fs.existsSync(p));if(bad.length){console.error('prepack guard: stray init artifacts in package dir: '+bad.join(', ')+' — remove before packing');process.exit(1)}\""
+  },
   "keywords": [
     "claude",
     "claude-code",
@@ -57,8 +61,5 @@
   },
   "publishConfig": {
     "access": "public"
-  },
-  "scripts": {
-    "test": "node --test \"test/**/*.test.js\""
   }
-}
+}