@dzhechkov/skills-feature-adr 1.3.32 → 1.3.34

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@dzhechkov/skills-feature-adr",
-  "version": "1.3.32",
+  "version": "1.3.34",
   "description": "Adaptive Feature Development skill pack for Claude Code — 11-step pipeline with Complexity Router (S/M/L/XL), ADR-driven architecture, 15 agentic-qe skills, multi-agent fleet QE. Supports --full-qe, --full-qe-extended, --with-learning, and --knowledge-extractor modes.",
   "bin": {
     "skills-feature-adr": "./bin/cli.js"

package/src/commands/update.js

@@ -36,11 +36,20 @@ async function run(options) {
   const templatesDir = getTemplatesDir();
 
   // ── b) Get installed components ───────────────────────────────────────
-  const installedKeys = manifest.components || [];
-  if (installedKeys.length === 0) {
+  const manifestKeys = manifest.components || [];
+  if (manifestKeys.length === 0) {
     warn('Manifest lists no installed components. Consider running init instead.');
     process.exit(1);
   }
+  // UNION the manifest's components with the CORE components the NEW template provides. A component
+  // ADDED upstream AFTER this install (e.g. `workflows`, bundled in a later release) would otherwise be
+  // invisible to `update` — never installed, and worse, a file it ships (`.claude/workflows/feature-adr.js`)
+  // could be mis-flagged as an orphan "dropped from template" and DELETED. Installing the union fixes
+  // both: new core components get added, and every file the current template provides stays in the
+  // rebuilt file-set, so it is updated (never orphaned). Optional components are only touched if they
+  // were already installed (they stay driven by the manifest).
+  const newCoreKeys = Object.keys(COMPONENTS).filter((k) => fileExists(path.join(templatesDir, COMPONENTS[k].src)));
+  const installedKeys = [...new Set([...manifestKeys, ...newCoreKeys])];
 
   info(`Current version: ${dim(manifest.version)}`);
   const pkgPath = path.resolve(__dirname, '../../package.json');
@@ -274,24 +283,25 @@ async function run(options) {
   }
 
   if (totalAdded === 0 && totalModified === 0 && orphans.length === 0) {
-    if (keptModified.length > 0) {
-      // Nothing to copy, but files were kept. Refresh the per-file baseline so a
-      // legacy (no-hashes) install self-heals into the 3-way regime and a kept
-      // conflict records the current template as its baseline (D3/D4). We do NOT
-      // bump the version \u2014 no template bytes were actually applied. Never write
-      // under --dry-run.
-      if (!dryRun) {
-        const { newHashes } = rebuildManifestData();
-        if (Object.keys(newHashes).length > 0) {
-          manifest.hashes = newHashes;
-          manifest.updatedAt = new Date().toISOString();
-          writeManifest(targetDir, manifest);
-        }
+    // Nothing to copy, but the MANIFEST may still be stale: a component newly covered by the union
+    // (or a file the template ships that the old manifest never tracked) must be re-tracked so the
+    // manifest matches reality \u2014 otherwise a later `remove`/`update` mis-reasons about ownership. Also
+    // refreshes the per-file baseline so a legacy (no-hashes) install self-heals into the 3-way regime.
+    // Never bump the version (no template bytes applied) and never write under --dry-run.
+    if (!dryRun) {
+      const { allFiles, newHashes } = rebuildManifestData();
+      const prevFiles = JSON.stringify((manifest.files || []).map(toManifestPath).sort());
+      const nextFiles = JSON.stringify(allFiles.slice().sort());
+      const compsChanged = JSON.stringify((manifest.components || []).slice().sort()) !== JSON.stringify(installedKeys.slice().sort());
+      if (prevFiles !== nextFiles || compsChanged || Object.keys(newHashes).length > 0) {
+        manifest.files = allFiles.sort();
+        manifest.components = installedKeys;
+        if (Object.keys(newHashes).length > 0) manifest.hashes = newHashes;
+        manifest.updatedAt = new Date().toISOString();
+        writeManifest(targetDir, manifest);
       }
-      success('No files to update \u2014 locally modified file(s) kept.');
-    } else {
-      success('Everything is up to date!');
     }
+    success(keptModified.length > 0 ? 'No files to update \u2014 locally modified file(s) kept.' : 'Everything is up to date!');
     process.exit(0);
   }