@dzhechkov/p-replicator 1.5.8 → 1.5.12

package/README/ru/html/build.js

@@ -186,7 +186,7 @@ function renderCode(code, lang) {
 }
 
 // ─── Main parser ──────────────────────────────────────────────────────────
-function parseMarkdown(md, idPrefix = '') {
+function parseMarkdown(md, idPrefix = '', usedIds = new Set()) {
   // Normalize line endings
   const lines = md.replace(/\r\n/g, '\n').split('\n');
   const out = [];
@@ -228,7 +228,15 @@ function parseMarkdown(md, idPrefix = '') {
       const level = h[1].length;
       const text = h[2].trim();
       const baseId = slugify(text);
-      const id = idPrefix && level > 1 ? `${idPrefix}-${baseId}` : baseId || idPrefix || 'section';
+      let id = idPrefix && level > 1 ? `${idPrefix}-${baseId}` : baseId || idPrefix || 'section';
+      // P3: de-duplicate heading slugs (GitHub-style -2/-3 suffix) so duplicate headings never emit
+      // duplicate `id` attributes (invalid HTML + hash-nav resolving only to the first occurrence).
+      if (usedIds.has(id)) {
+        let n = 2;
+        while (usedIds.has(`${id}-${n}`)) n++;
+        id = `${id}-${n}`;
+      }
+      usedIds.add(id);
       out.push(`<h${level} id="${escapeAttr(id)}">${processInline(text)}</h${level}>`);
       i++;
       continue;
@@ -248,7 +256,7 @@ function parseMarkdown(md, idPrefix = '') {
         qLines.push(lines[i].replace(/^>\s?/, ''));
         i++;
       }
-      out.push(`<blockquote>${parseMarkdown(qLines.join('\n'), idPrefix)}</blockquote>`);
+      out.push(`<blockquote>${parseMarkdown(qLines.join('\n'), idPrefix, usedIds)}</blockquote>`);
       continue;
     }
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@dzhechkov/p-replicator",
-  "version": "1.5.8",
+  "version": "1.5.12",
   "description": "P-Replicator — Claude Code toolkit for AI-assisted product development (Vibe Coding). Full /replicate pipeline, 10 modular skills (194K+ chars), /harvest knowledge extraction, swarm agents, quality gates, security patterns, cross-project learning.",
   "main": "src/cli.js",
   "bin": {

package/src/commands/remove.js

@@ -37,7 +37,12 @@ function run(options) {
 
   if (existingFiles.length === 0) {
     warn('No files found to remove (already cleaned up?).');
-    // Still remove manifest
+    // Dry run is a strict no-op — must NOT unregister the install (the P2 bug: this ran BEFORE the
+    // dryRun guard below, so `remove --dry-run` deleted the manifest on the already-cleaned path).
+    if (dryRun) {
+      warn(`Dry run — would remove ${MANIFEST_FILE} to unregister the (already-empty) install. Nothing written.`);
+      process.exit(0);
+    }
     const manifestPath = path.join(targetDir, MANIFEST_FILE);
     if (fileExists(manifestPath)) {
       fs.unlinkSync(manifestPath);
@@ -53,6 +58,7 @@ function run(options) {
 
   // ── c) Remove files ────────────────────────────────────────────────────
   let removed = 0;
+  const failed = [];
   for (const f of existingFiles) {
     const fullPath = path.join(targetDir, f);
     try {
@@ -60,6 +66,7 @@ function run(options) {
       removed++;
     } catch (err) {
       warn(`Could not remove: ${f} (${err.message})`);
+      failed.push(f);
     }
   }
 
@@ -88,9 +95,16 @@ function run(options) {
   }
 
   // ── e) Remove manifest ─────────────────────────────────────────────────
+  // P3: only unregister the install when EVERY tracked file was actually removed. If some failed
+  // (permissions, locked, read-only mount), keep the manifest so the survivors stay tracked and a
+  // later `remove`/`doctor` can still see + finish them — deleting it would strand them as orphans.
   const manifestPath = path.join(targetDir, MANIFEST_FILE);
   if (fileExists(manifestPath)) {
-    fs.unlinkSync(manifestPath);
+    if (failed.length > 0) {
+      warn(`${failed.length} file(s) could not be removed — keeping ${MANIFEST_FILE} so they stay tracked (re-run remove after fixing permissions).`);
+    } else {
+      fs.unlinkSync(manifestPath);
+    }
   }
 
   console.log('');

package/src/commands/update.js

@@ -50,6 +50,13 @@ function run(options) {
   console.log('');
 
   if (added.length === 0 && modified.length === 0) {
+    // P3: refresh the recorded version even when templates are byte-identical, so the manifest is not
+    // a STALE version record after a metadata-only release (doctor/update kept reporting the old
+    // installed version). Only the version field changes — no files touched.
+    if (manifest.version !== newVersion) {
+      writeManifest(targetDir, { ...manifest, version: newVersion });
+      info(`Version record refreshed to ${bold(newVersion)} (templates unchanged).`);
+    }
     success('Already up to date!');
     process.exit(0);
   }

package/templates/.claude/skills/brutal-honesty-review/SKILL.md

@@ -1,6 +1,20 @@
 ---
 name: brutal-honesty-review
-description: Unvarnished technical criticism combining Linus Torvalds precision, Gordon Ramsay standards, and James Bach BS-detection. Use when code or tests need harsh reality checks, certification schemes smell fishy, or technical decisions lack rigor. No sugar-coating, just surgical truth about what is broken and why.
+description: "Unvarnished technical criticism combining Linus Torvalds' precision, Gordon Ramsay's standards, and James Bach's BS-detection. Use when code/tests need harsh reality checks, certification schemes smell fishy, or technical decisions lack rigor. No sugar-coating, just surgical truth about what's broken and why."
+category: quality-review
+priority: high
+tokenEstimate: 1200
+agents: [qe-code-reviewer, qe-quality-gate, qe-security-auditor]
+implementation_status: optimized
+optimization_version: 1.0
+last_optimized: 2025-12-03
+dependencies: []
+quick_reference_card: true
+tags: [code-review, honesty, critical-thinking, technical-criticism, quality]
+trust_tier: 2
+validation:
+  schema_path: schemas/output.json
+  validator_path: scripts/validate-config.json
 ---
 
 # Brutal Honesty Review
@@ -24,6 +38,9 @@ When brutal honesty is needed:
 - Level 3 (Brutal): "This is negligent. You're exposing user data because..."
 
 **DO NOT USE FOR:** Junior devs' first PRs, demoralized teams, public forums, low psychological safety
+
+## Minimum Findings Enforcement
+All brutal honesty reviews enforce a minimum of 3 weighted findings (CRITICAL=3, HIGH=2, MEDIUM=1, LOW=0.5). If the initial review finds fewer, escalate to deeper analysis. Brutally honest reviewers should ALWAYS find something -- if you can't, explain exactly why with evidence.
 </default_to_action>
 
 ## Quick Reference Card

package/templates/.claude/skills/brutal-honesty-review/evals/brutal-honesty-review.yaml

@@ -0,0 +1,61 @@
+skill: brutal-honesty-review
+version: 1.0.0
+description: >
+  Evaluation suite for the brutal-honesty-review skill. Tests that the three
+  reviewer modes (Linus precision, Ramsay standards, Bach BS-detection) produce
+  unvarnished, specific, evidence-backed criticism — and that they do NOT
+  sugar-coat genuine defects or fabricate findings on clean code.
+
+models_to_test:
+  - claude-3.5-sonnet
+  - claude-3-haiku
+
+mcp_integration:
+  enabled: true
+  namespace: skill-validation
+  query_patterns: true
+  track_outcomes: true
+  store_patterns: true
+  target_agents:
+    - qe-learning-coordinator
+    - qe-code-reviewer
+
+learning:
+  store_success_patterns: true
+  store_failure_patterns: true
+  pattern_ttl_days: 90
+  min_confidence_to_store: 0.7
+
+result_format:
+  json_output: true
+  include_timing: true
+  include_token_usage: true
+
+scenarios:
+  - id: BHR-1
+    name: Real defect — must be called out specifically
+    input: >
+      Code with a genuine bug (e.g. an unhandled null path, a SQL string
+      concatenation, a swallowed exception).
+    expect:
+      - The review names the exact defect with file/line, not vague "could be better".
+      - At least one mode (Linus/Ramsay/Bach) flags it as a real problem.
+      - A concrete fix or direction is given, not just criticism.
+
+  - id: BHR-2
+    name: Clean code — no fabricated findings
+    input: A small, correct, well-tested function with no real issues.
+    expect:
+      - The review does NOT invent severe findings to appear thorough.
+      - If it nitpicks, it labels them as nits, not blockers.
+
+  - id: BHR-3
+    name: Certification/claim smell test
+    input: A README claiming "100% coverage" or "fully secure" without evidence.
+    expect:
+      - Bach BS-detection mode challenges the unsubstantiated claim.
+      - Asks for the evidence behind the claim.
+
+pass_criteria:
+  - Findings are specific (cite location) and evidence-backed.
+  - No sugar-coating of real defects; no fabrication on clean code.

package/templates/.claude/skills/brutal-honesty-review/schemas/output.json

@@ -0,0 +1,291 @@
+{
+  "$schema": "https://json-schema.org/draft/2020-12/schema",
+  "$id": "https://agentic-qe.dev/schemas/skills/brutal-honesty-review/output.json",
+  "title": "Brutal Honesty Review Skill Output Schema",
+  "description": "Schema for brutal-honesty-review skill output. Validates unvarnished technical criticism with actionable recommendations.",
+  "type": "object",
+  "required": ["skillName", "version", "timestamp", "status", "trustTier", "output"],
+  "properties": {
+    "skillName": {
+      "type": "string",
+      "const": "brutal-honesty-review"
+    },
+    "version": {
+      "type": "string",
+      "pattern": "^\\d+\\.\\d+\\.\\d+(-[a-zA-Z0-9]+)?$"
+    },
+    "timestamp": {
+      "type": "string",
+      "format": "date-time"
+    },
+    "status": {
+      "type": "string",
+      "enum": ["success", "partial", "failed", "skipped"]
+    },
+    "trustTier": {
+      "type": "integer",
+      "const": 3
+    },
+    "output": {
+      "type": "object",
+      "required": ["summary", "reviewFindings", "codeQuality"],
+      "properties": {
+        "summary": {
+          "type": "string",
+          "minLength": 50,
+          "maxLength": 3000,
+          "description": "Brutally honest executive summary"
+        },
+        "reviewFindings": {
+          "type": "array",
+          "items": {
+            "$ref": "#/$defs/reviewFinding"
+          },
+          "minItems": 1,
+          "maxItems": 200,
+          "description": "Detailed findings with no sugar-coating"
+        },
+        "codeQuality": {
+          "$ref": "#/$defs/codeQuality"
+        },
+        "severity": {
+          "$ref": "#/$defs/severityBreakdown"
+        },
+        "recommendations": {
+          "type": "array",
+          "items": {
+            "$ref": "#/$defs/recommendation"
+          },
+          "maxItems": 100,
+          "description": "Actionable improvement recommendations"
+        },
+        "technicalDebt": {
+          "$ref": "#/$defs/technicalDebt"
+        },
+        "readabilityScore": {
+          "type": "number",
+          "minimum": 0,
+          "maximum": 100
+        },
+        "maintainabilityScore": {
+          "type": "number",
+          "minimum": 0,
+          "maximum": 100
+        },
+        "verdict": {
+          "type": "string",
+          "enum": ["ship-it", "needs-work", "major-issues", "do-not-merge", "rewrite-needed"],
+          "description": "Final honest verdict"
+        },
+        "metrics": {
+          "$ref": "#/$defs/metrics"
+        }
+      }
+    },
+    "metadata": {
+      "$ref": "#/$defs/metadata"
+    },
+    "validation": {
+      "$ref": "#/$defs/validationResult"
+    },
+    "learning": {
+      "$ref": "#/$defs/learningData"
+    }
+  },
+  "$defs": {
+    "reviewFinding": {
+      "type": "object",
+      "required": ["id", "title", "severity", "category", "honestAssessment"],
+      "properties": {
+        "id": {
+          "type": "string",
+          "pattern": "^REV-\\d{3,6}$"
+        },
+        "title": {
+          "type": "string",
+          "minLength": 10,
+          "maxLength": 200
+        },
+        "description": {
+          "type": "string",
+          "maxLength": 2000
+        },
+        "severity": {
+          "type": "string",
+          "enum": ["critical", "high", "medium", "low", "nitpick"]
+        },
+        "category": {
+          "type": "string",
+          "enum": ["architecture", "design", "implementation", "performance", "security", "maintainability", "readability", "testing", "documentation", "naming"]
+        },
+        "honestAssessment": {
+          "type": "string",
+          "minLength": 20,
+          "maxLength": 2000,
+          "description": "Brutally honest assessment with no softening"
+        },
+        "location": {
+          "type": "object",
+          "properties": {
+            "file": { "type": "string" },
+            "line": { "type": "integer", "minimum": 1 },
+            "endLine": { "type": "integer", "minimum": 1 },
+            "function": { "type": "string" }
+          }
+        },
+        "codeSnippet": {
+          "type": "string",
+          "maxLength": 5000
+        },
+        "suggestedFix": {
+          "type": "string",
+          "maxLength": 5000
+        },
+        "effort": {
+          "type": "string",
+          "enum": ["trivial", "low", "medium", "high", "major"]
+        },
+        "blocking": {
+          "type": "boolean",
+          "description": "Whether this blocks merging"
+        }
+      }
+    },
+    "codeQuality": {
+      "type": "object",
+      "required": ["overallScore", "grade"],
+      "properties": {
+        "overallScore": {
+          "type": "number",
+          "minimum": 0,
+          "maximum": 100
+        },
+        "grade": {
+          "type": "string",
+          "pattern": "^[A-F][+-]?$"
+        },
+        "dimensions": {
+          "type": "object",
+          "properties": {
+            "correctness": { "type": "number", "minimum": 0, "maximum": 100 },
+            "readability": { "type": "number", "minimum": 0, "maximum": 100 },
+            "maintainability": { "type": "number", "minimum": 0, "maximum": 100 },
+            "performance": { "type": "number", "minimum": 0, "maximum": 100 },
+            "security": { "type": "number", "minimum": 0, "maximum": 100 },
+            "testability": { "type": "number", "minimum": 0, "maximum": 100 }
+          }
+        },
+        "strengths": {
+          "type": "array",
+          "items": { "type": "string" }
+        },
+        "weaknesses": {
+          "type": "array",
+          "items": { "type": "string" }
+        }
+      }
+    },
+    "severityBreakdown": {
+      "type": "object",
+      "properties": {
+        "critical": { "type": "integer", "minimum": 0 },
+        "high": { "type": "integer", "minimum": 0 },
+        "medium": { "type": "integer", "minimum": 0 },
+        "low": { "type": "integer", "minimum": 0 },
+        "nitpick": { "type": "integer", "minimum": 0 },
+        "blocking": { "type": "integer", "minimum": 0 }
+      }
+    },
+    "recommendation": {
+      "type": "object",
+      "required": ["id", "title", "priority", "impact"],
+      "properties": {
+        "id": {
+          "type": "string",
+          "pattern": "^REC-\\d{3,6}$"
+        },
+        "title": {
+          "type": "string",
+          "maxLength": 200
+        },
+        "description": {
+          "type": "string",
+          "maxLength": 2000
+        },
+        "priority": {
+          "type": "string",
+          "enum": ["critical", "high", "medium", "low"]
+        },
+        "impact": {
+          "type": "string",
+          "enum": ["transformative", "significant", "moderate", "minor"]
+        },
+        "relatedFindings": {
+          "type": "array",
+          "items": { "type": "string" }
+        },
+        "effort": {
+          "type": "string",
+          "enum": ["trivial", "low", "medium", "high", "major"]
+        },
+        "codeExample": {
+          "type": "string",
+          "maxLength": 5000
+        }
+      }
+    },
+    "technicalDebt": {
+      "type": "object",
+      "properties": {
+        "totalDebtHours": { "type": "number", "minimum": 0 },
+        "debtRatio": { "type": "number", "minimum": 0, "maximum": 100 },
+        "categories": {
+          "type": "array",
+          "items": {
+            "type": "object",
+            "properties": {
+              "category": { "type": "string" },
+              "hours": { "type": "number" },
+              "priority": { "type": "string" }
+            }
+          }
+        }
+      }
+    },
+    "metrics": {
+      "type": "object",
+      "properties": {
+        "filesReviewed": { "type": "integer", "minimum": 0 },
+        "linesReviewed": { "type": "integer", "minimum": 0 },
+        "totalFindings": { "type": "integer", "minimum": 0 },
+        "blockingIssues": { "type": "integer", "minimum": 0 },
+        "suggestedFixes": { "type": "integer", "minimum": 0 }
+      }
+    },
+    "metadata": {
+      "type": "object",
+      "properties": {
+        "executionTimeMs": { "type": "integer", "minimum": 0 },
+        "toolsUsed": { "type": "array", "items": { "type": "string" } },
+        "agentId": { "type": "string", "pattern": "^qe-[a-z][a-z0-9-]*$" },
+        "reviewScope": { "type": "string" },
+        "reviewType": { "type": "string", "enum": ["full", "incremental", "focused"] }
+      }
+    },
+    "validationResult": {
+      "type": "object",
+      "properties": {
+        "schemaValid": { "type": "boolean" },
+        "contentValid": { "type": "boolean" },
+        "confidence": { "type": "number", "minimum": 0, "maximum": 1 }
+      }
+    },
+    "learningData": {
+      "type": "object",
+      "properties": {
+        "patternsDetected": { "type": "array", "items": { "type": "string" } },
+        "reward": { "type": "number", "minimum": 0, "maximum": 1 }
+      }
+    }
+  }
+}

package/templates/.claude/skills/brutal-honesty-review/scripts/assess-tests.sh

@@ -78,7 +78,7 @@ assess_edge_cases() {
     found_count=0
     for pattern in "${edge_case_patterns[@]}"; do
         if grep -ri "$pattern" "$TEST_DIR" > /dev/null 2>&1; then
-            ((found_count++))
+            found_count=$((found_count+1))
         fi
     done
 
@@ -161,7 +161,7 @@ assess_stability() {
     failures=0
     for i in {1..3}; do
         if ! npm test > /dev/null 2>&1; then
-            ((failures++))
+            failures=$((failures+1))
         fi
     done
 

package/templates/.claude/skills/brutal-honesty-review/scripts/validate-config.json

@@ -0,0 +1,34 @@
+{
+  "skillName": "brutal-honesty-review",
+  "skillVersion": "1.0.0",
+  "requiredTools": [
+    "jq"
+  ],
+  "optionalTools": [],
+  "schemaPath": "schemas/output.json",
+  "requiredFields": [
+    "skillName",
+    "status",
+    "output",
+    "output.summary",
+    "output.reviewFindings",
+    "output.codeQuality"
+  ],
+  "requiredNonEmptyFields": [],
+  "mustContainTerms": [
+    "review",
+    "code"
+  ],
+  "mustNotContainTerms": [
+    "TODO",
+    "FIXME"
+  ],
+  "enumValidations": {
+    ".status": [
+      "success",
+      "partial",
+      "failed",
+      "skipped"
+    ]
+  }
+}

package/templates/.claude/skills/cc-toolkit-generator-enhanced/SKILL.md

@@ -419,7 +419,7 @@ Run in Phase 6 before delivery.
 | brutal-honesty-review | .claude/skills/ | P0 | Always |
 | idea2prd-manual | .claude/skills/ | P1 | IF DDD detected |
 | goap-research-ed25519 | .claude/skills/ | P1 | IF DDD detected |
-| feature-navigator | .claude/skills/ | P1 | Always (recommended) |
+| feature-navigator | .claude/skills/ (GENERATED per-project by module 04 — NOT a module-08 copy-dependency) | P1 | Always (recommended) |
 
 ## Reusability
 

package/templates/.claude/skills/cc-toolkit-generator-enhanced/modules/06-package-deliver.md

@@ -275,7 +275,7 @@ Scan targets:
 
 Scan patterns (all are CRITICAL if found):
 
-  Pattern: {{[A-Z_]+}}
+  Pattern: {{[^}]+}}  # ANY placeholder token — uppercase, lowercase, hyphenated, or spaced (was {{[A-Z_]+}}, which silently passed {{feature-id}}, {{Feature Name}})
   Examples: {{PROJECT_NAME}}, {{LANGUAGE}}, {{MAX_ENTITIES}}, {{TECH_KEYWORDS}}
   Action: Look up value in IPM and substitute