@dzhechkov/harness-core 0.3.128 → 0.3.130

package/src/vector-tier.ts

@@ -50,6 +50,7 @@ import {
   loadStoreRecords,
   readMemoryLearningConfig,
   readReinforcementState,
+  readQuarantineState,
   removePatternsByIds,
   snapshotStore,
   updateReinforcementState,
@@ -155,6 +156,8 @@ export interface HybridHit {
   readonly backend: RecallHit['backend'];
   /** Reciprocal-rank-fusion score (ranking only — NOT the pattern's reward). */
   readonly score: number;
+  /** lesson-quarantine: set only for a quarantined hit — display marks ⚠q, ranking was damped. */
+  readonly quarantined?: boolean;
 }
 
 /** Outcome of {@link recallHybrid}. With no engine this is content-identical to `recallPatterns`. */
@@ -336,7 +339,7 @@ export function isVectorNoise(text: string): boolean {
  * ACL: taught {@link PatternRecord} → {@link VectorEntry}. Returns `undefined` for noise (the
  * ingest gate — I-6). Score is the record's REAL reward, never a fabricated 1.0.
  */
-export function patternVectorEntry(p: PatternRecord, source = 'dz-teach'): VectorEntry | undefined {
+export function patternVectorEntry(p: PatternRecord, source = 'dz-teach', opts: { quarantined?: boolean } = {}): VectorEntry | undefined {
   if (isVectorNoise(p.pattern)) return undefined;
   const dzId = patternRecordId(p);
   return {
@@ -345,7 +348,9 @@ export function patternVectorEntry(p: PatternRecord, source = 'dz-teach'): Vecto
     score: p.reward,
     taskType: 'dz-teach',
     tags: ['dz-teach', p.type],
-    metadata: { dzId, source, ts: p.ts, domain: p.domain },
+    // FR-8: quarantine rides into the mirror so the HOOK DAEMON (which reads only the mirror's
+    // sqlite metadata) can exclude unproven lessons from auto-injection.
+    metadata: { dzId, source, ts: p.ts, domain: p.domain, ...(opts.quarantined === true ? { qStatus: 'quarantined' } : {}) },
   };
 }
 
@@ -790,7 +795,20 @@ export async function recallHybrid(
   const learning = resolveLearningBackend(projectRoot);
   // Phase 3: opt-in SAFLA-delta re-rank. The map is built ONCE per recall (off ⇒ undefined ⇒ the
   // reinforce-only path, byte-identical to today).
-  const deltaMap = readMemoryLearningConfig(projectRoot).deltaRerank ? lessonDeltaMap(projectRoot) : undefined;
+  const memCfg = readMemoryLearningConfig(projectRoot);
+  const deltaMap = memCfg.deltaRerank ? lessonDeltaMap(projectRoot) : undefined;
+  // lesson-quarantine: damp read from the AUTHORITATIVE store records (idToRecord), never from
+  // mirror metadata — the mirror may lag a promotion; the store cannot.
+  const dampQuarantined = (hits: readonly HybridHit[]): HybridHit[] => {
+    if (!memCfg.quarantine) return [...hits];
+    return hits
+      .map((h) => {
+        const rec = idToRecord.get(idOf(h.pattern));
+        const q = rec !== undefined && readQuarantineState(rec).quarantined;
+        return q ? { ...h, score: h.score * memCfg.quarantineDamp, quarantined: true as const } : h;
+      })
+      .sort((a, b) => b.score - a.score);
+  };
   const enhance = (hits: readonly HybridHit[]): HybridHit[] => {
     const candidates = hits.map((h) => {
       const dzId = idOf(h.pattern);
@@ -799,9 +817,9 @@ export async function recallHybrid(
     });
     if (deltaMap !== undefined) {
       const deltaByIndex = candidates.map((c) => deltaMap.get(c.dzId) ?? 0);
-      return applyLearningSignalsWithDelta(hits, learning, candidates, REINFORCE_RRF_CAP, deltaByIndex, REINFORCE_RRF_CAP);
+      return dampQuarantined(applyLearningSignalsWithDelta(hits, learning, candidates, REINFORCE_RRF_CAP, deltaByIndex, REINFORCE_RRF_CAP));
     }
-    return applyLearningSignals(hits, learning, candidates, REINFORCE_RRF_CAP);
+    return dampQuarantined(applyLearningSignals(hits, learning, candidates, REINFORCE_RRF_CAP));
   };
   const lexicalOnly = (extra: Partial<Pick<HybridRecall, 'vectorEngine' | 'vectorReason' | 'vectorError'>>): HybridRecall => ({
     hits: enhance(lexical.map((h, rank) => ({ pattern: h.pattern, backend: h.backend, score: 1 / (RRF_K + rank + 1) }))),