@dzhechkov/harness-core 0.3.125 → 0.3.127

package/src/sign.ts

@@ -113,23 +113,32 @@ export function checkManifestEntries(files: unknown): string | null {
   return null;
 }
 
+/**
+ * Directory names that are NOT pack content and are excluded from BOTH walks. node_modules/.git:
+ * installed deps / VCS metadata. `.agentic-qe`/`.dz`: LOCAL RUNTIME STATE (learning DBs, RVF
+ * stores, witness keys) that background workers create inside pack cwds — gitignored, machine-
+ * specific, never shipped. Signing them made 19 packs verify green LOCALLY (files present, hashes
+ * match) and TAMPERED in CI (clean checkout lacks the gitignored state) — found live on GH run
+ * #103, 2026-07-19. State is not content; the walks must never see it.
+ */
+const EXCLUDED_DIRS = new Set(['node_modules', '.git', '.agentic-qe', '.dz']);
+
 /** Every file under `root`, POSIX-relative, excluding the manifest and the SBOM themselves. */
 export function listPackFiles(root: string): string[] {
   const out: string[] = [];
   const walk = (dir: string, rel: string): void => {
     for (const e of readdirSync(dir, { withFileTypes: true })) {
-      // node_modules/.git are unsigned territory BY DESIGN (installed deps / VCS metadata — not pack
-      // content; npm tarballs ship neither). The SIGN and VERIFY walks MUST share these exclusions:
-      // an asymmetry here false-TAMPERs every pnpm workspace pack whose node_modules holds symlinks
-      // (found live arming task #36 — 10 of 23 skill packs flagged right after signing).
-      if (e.name === 'node_modules' || e.name === '.git') continue;
+      // Excluded dirs are unsigned territory BY DESIGN (see EXCLUDED_DIRS). The SIGN and VERIFY
+      // walks MUST share these exclusions: an asymmetry here false-TAMPERs every pnpm workspace
+      // pack whose node_modules holds symlinks (found live arming task #36 — 10 of 23 packs).
+      if (EXCLUDED_DIRS.has(e.name)) continue;
       if (e.name === MANIFEST_NAME || e.name === SBOM_NAME) continue;
       const abs = join(dir, e.name);
       const r = rel ? rel + '/' + e.name : e.name;
       if (e.isDirectory()) walk(abs, r);
       // NOT else-isFile: a symlink (or other non-file) OUTSIDE the excluded dirs must stay VISIBLE to the
       // verify sweep — it fails as "present but not signed" / "is a symlink" (R3-4: a smuggled symlink is a
-      // finding, not something to silently ignore). Only node_modules/.git are exempt territory.
+      // finding, not something to silently ignore). Only EXCLUDED_DIRS are exempt territory.
       else out.push(r);
     }
   };
@@ -146,7 +155,7 @@ export function listSignablePackFiles(root: string): string[] {
   const out: string[] = [];
   const walk = (dir: string, rel: string): void => {
     for (const e of readdirSync(dir, { withFileTypes: true })) {
-      if (e.name === 'node_modules' || e.name === '.git') continue;
+      if (EXCLUDED_DIRS.has(e.name)) continue;
       if (e.name === MANIFEST_NAME || e.name === SBOM_NAME) continue;
       const abs = join(dir, e.name);
       const r = rel ? rel + '/' + e.name : e.name;