@dzhechkov/harness-core 0.3.124 → 0.3.125

package/src/sign.ts

@@ -118,10 +118,18 @@ export function listPackFiles(root: string): string[] {
   const out: string[] = [];
   const walk = (dir: string, rel: string): void => {
     for (const e of readdirSync(dir, { withFileTypes: true })) {
+      // node_modules/.git are unsigned territory BY DESIGN (installed deps / VCS metadata — not pack
+      // content; npm tarballs ship neither). The SIGN and VERIFY walks MUST share these exclusions:
+      // an asymmetry here false-TAMPERs every pnpm workspace pack whose node_modules holds symlinks
+      // (found live arming task #36 — 10 of 23 skill packs flagged right after signing).
+      if (e.name === 'node_modules' || e.name === '.git') continue;
       if (e.name === MANIFEST_NAME || e.name === SBOM_NAME) continue;
       const abs = join(dir, e.name);
       const r = rel ? rel + '/' + e.name : e.name;
       if (e.isDirectory()) walk(abs, r);
+      // NOT else-isFile: a symlink (or other non-file) OUTSIDE the excluded dirs must stay VISIBLE to the
+      // verify sweep — it fails as "present but not signed" / "is a symlink" (R3-4: a smuggled symlink is a
+      // finding, not something to silently ignore). Only node_modules/.git are exempt territory.
       else out.push(r);
     }
   };
@@ -129,6 +137,27 @@ export function listPackFiles(root: string): string[] {
   return out.sort();
 }
 
+/**
+ * The SIGN-side file list: same exclusions as {@link listPackFiles}, but REGULAR FILES ONLY — `dz sign`
+ * never signs a symlink (hashing one would follow it outside the pack). The verify sweep intentionally
+ * sees MORE than this (symlinks/specials outside node_modules), so a smuggled entry fails verification.
+ */
+export function listSignablePackFiles(root: string): string[] {
+  const out: string[] = [];
+  const walk = (dir: string, rel: string): void => {
+    for (const e of readdirSync(dir, { withFileTypes: true })) {
+      if (e.name === 'node_modules' || e.name === '.git') continue;
+      if (e.name === MANIFEST_NAME || e.name === SBOM_NAME) continue;
+      const abs = join(dir, e.name);
+      const r = rel ? rel + '/' + e.name : e.name;
+      if (e.isDirectory()) walk(abs, r);
+      else if (e.isFile()) out.push(r);
+    }
+  };
+  walk(root, '');
+  return out.sort();
+}
+
 /**
  * The bytes that get signed (FR-7). Sorted by path, LF endings, no trailing whitespace, and no
  * dependence on JSON key order — a signature must not depend on how a serialiser felt that day.