@dynamicu/chromedebug-mcp 2.5.14 → 2.6.1

package/src/index-modular.js

@@ -141,7 +141,7 @@ class ChromePilotApp {
    * Shows help information
    */
   showHelp() {
-    console.log(`
+    console.error(`
 Chrome Debug MCP Server - Modular Architecture
 
 Usage: node src/index.js [options]

package/src/index.js

@@ -17,6 +17,11 @@ import {
   findActiveSessions
 } from './services/unified-session-manager.js';
 import logger from './utils/logger.js';
+import { interceptStdout } from './logger.js';
+
+// CRITICAL: Intercept stdout FIRST to prevent MCP JSON-RPC pollution
+// This must happen before any other code runs
+interceptStdout();
 
 /**
  * Main application class that orchestrates all components
@@ -201,7 +206,7 @@ class ChromePilotApp {
    * Shows help information
    */
   showHelp() {
-    console.log(`
+    console.error(`
 Chrome Debug MCP Server - Modular Architecture with Session Isolation
 
 Usage: node src/index.js [options]

package/src/logger.js

@@ -1,11 +1,102 @@
-// Simple conditional logger for Chrome Debug
-// All logs go to stderr to avoid interfering with MCP stdio communication
-const isDev = process.env.NODE_ENV === 'development';
-
-module.exports = {
-  log: (...args) => { if (isDev) console.error(...args); },
-  error: (...args) => console.error(...args),
-  warn: (...args) => { if (isDev) console.error(...args); },
-  info: (...args) => { if (isDev) console.error(...args); },
-  debug: (...args) => { if (isDev) console.error(...args); }
-};
+/**
+ * Structured logging for ChromeDebug MCP
+ * Uses pino for performance and structured output
+ * All logs go to stderr to preserve MCP stdout for JSON-RPC
+ */
+
+import pino from 'pino';
+
+// Determine log level based on environment
+const getLogLevel = () => {
+  if (process.env.LOG_LEVEL) {
+    return process.env.LOG_LEVEL;
+  }
+  if (process.env.DEBUG === 'true' || process.env.DEBUG === '1') {
+    return 'debug';
+  }
+  if (process.env.NODE_ENV === 'production') {
+    return 'warn';
+  }
+  return 'info'; // Default for development
+};
+
+// Create base pino instance
+const baseLogger = pino({
+  level: getLogLevel(),
+  transport: {
+    target: 'pino-pretty',
+    options: {
+      destination: 2, // stderr
+      colorize: true,
+      ignore: 'pid,hostname',
+      translateTime: 'HH:MM:ss',
+      singleLine: false
+    }
+  }
+});
+
+/**
+ * Create a child logger with component context
+ * @param {string} component - Component name for log context
+ * @returns {pino.Logger} Configured pino logger
+ */
+export function createLogger(component) {
+  return baseLogger.child({ component });
+}
+
+/**
+ * HTTP request logger helper
+ * Only logs if DEBUG_HTTP is enabled or in debug level
+ * @param {pino.Logger} logger - Pino logger instance
+ * @param {object} req - Express request object
+ * @param {object} options - Logging options
+ */
+export function logHttpRequest(logger, req, options = {}) {
+  const shouldLog = process.env.DEBUG_HTTP === 'true' ||
+                    process.env.DEBUG === 'true' ||
+                    logger.level === 'debug';
+
+  if (!shouldLog) return;
+
+  const requestData = {
+    method: req.method,
+    url: req.originalUrl || req.url,
+    ip: req.ip,
+    userAgent: req.get('user-agent')
+  };
+
+  if (options.verbose) {
+    requestData.headers = req.headers;
+    requestData.contentType = req.get('content-type');
+    requestData.contentLength = req.get('content-length');
+  }
+
+  logger.debug(requestData, 'HTTP Request');
+}
+
+/**
+ * Intercept stdout to prevent MCP JSON-RPC pollution
+ * Call this at application startup for MCP servers
+ */
+export function interceptStdout() {
+  const originalWrite = process.stdout.write;
+
+  process.stdout.write = function(chunk, encoding, callback) {
+    // Redirect all stdout to stderr with a warning prefix
+    const message = chunk.toString();
+    const redirectedMessage = `[STDOUT-REDIRECT] ${message}`;
+
+    return process.stderr.write(redirectedMessage, encoding, callback);
+  };
+
+  baseLogger.info('Stdout interception enabled - all output redirected to stderr for MCP safety');
+}
+
+// Default export for backward compatibility
+export default {
+  error: (...args) => baseLogger.error(...args),
+  warn: (...args) => baseLogger.warn(...args),
+  info: (...args) => baseLogger.info(...args),
+  debug: (...args) => baseLogger.debug(...args),
+  log: (...args) => baseLogger.info(...args)
+};

package/src/mcp/handlers/chrome-tool-handler.js

@@ -229,7 +229,7 @@ export class ChromeToolHandler {
 
     for (let attempt = 1; attempt <= maxRetries; attempt++) {
       try {
-        console.log(`[ChromeToolHandler] Attempt ${attempt}/${maxRetries} for ${name} (Session: ${this.chromeController.sessionId})`);
+        console.error(`[ChromeToolHandler] Attempt ${attempt}/${maxRetries} for ${name} (Session: ${this.chromeController.sessionId})`);
         
         // Execute the operation based on name
         switch (name) {
@@ -254,7 +254,7 @@ export class ChromeToolHandler {
         const isSessionConflict = this.isSessionConflictError(error);
         
         if (isSessionConflict && attempt < maxRetries) {
-          console.log(`[ChromeToolHandler] Detected session conflict, attempting recovery...`);
+          console.error(`[ChromeToolHandler] Detected session conflict, attempting recovery...`);
           
           try {
             // Force cleanup current session and create new one
@@ -263,7 +263,7 @@ export class ChromeToolHandler {
             // Wait a bit before retrying to let system stabilize
             await new Promise(resolve => setTimeout(resolve, 1000 + (attempt * 500)));
             
-            console.log(`[ChromeToolHandler] Session recovery completed, retrying...`);
+            console.error(`[ChromeToolHandler] Session recovery completed, retrying...`);
           } catch (recoveryError) {
             console.error(`[ChromeToolHandler] Session recovery failed:`, recoveryError.message);
           }

package/src/mcp/handlers/frame-tool-handler.js

@@ -96,7 +96,7 @@ export class FrameToolHandler {
       }
     } catch (error) {
       // Fall back to direct database access if HTTP client fails
-      console.warn('[FrameToolHandler] HTTP client failed, falling back to direct access:', error.message);
+      console.error('[FrameToolHandler] HTTP client failed, falling back to direct access:', error.message);
       sessionInfo = await this.chromeController.getFrameSessionInfo(args.sessionId);
       if (!sessionInfo) {
         availableSessions = await this.chromeController.listFrameSessions();
@@ -167,7 +167,7 @@ export class FrameToolHandler {
           result.note = 'No frame data or interactions found. This may indicate the recording was started but stopped immediately.';
         }
       } catch (error) {
-        console.warn('[FrameToolHandler] Failed to check interactions:', error.message);
+        console.error('[FrameToolHandler] Failed to check interactions:', error.message);
         result.note = 'No frame data found. Unable to check for interactions.';
       }
       
@@ -285,7 +285,7 @@ export class FrameToolHandler {
             frameData.interactionMetadata = { totalFound: 0, displayed: 0, timeWindow: 500 };
           }
         } catch (error) {
-          console.warn('[FrameToolHandler] Failed to get frame interactions:', error.message);
+          console.error('[FrameToolHandler] Failed to get frame interactions:', error.message);
           frameData.interactions = [];
           frameData.associatedInteractions = [];
           frameData.interactionMetadata = { totalFound: 0, displayed: 0, timeWindow: 500 };
@@ -329,7 +329,7 @@ export class FrameToolHandler {
         }
       }
     } catch (error) {
-      console.warn('[FrameToolHandler] HTTP client failed, falling back to direct access:', error.message);
+      console.error('[FrameToolHandler] HTTP client failed, falling back to direct access:', error.message);
       info = await this.chromeController.getFrameSessionInfo(args.sessionId);
       if (!info) {
         availableSessions = await this.chromeController.listFrameSessions();
@@ -386,7 +386,7 @@ export class FrameToolHandler {
         interactionSummary.interactionTypes = Object.entries(typeCount).map(([type, count]) => `${type}: ${count}`);
       }
     } catch (error) {
-      console.warn('[FrameToolHandler] Failed to get interaction summary:', error.message);
+      console.error('[FrameToolHandler] Failed to get interaction summary:', error.message);
       // Keep default empty summary
     }
 
@@ -424,7 +424,7 @@ export class FrameToolHandler {
         frame = await this.chromeController.getFrame(args.sessionId, args.frameIndex);
       }
     } catch (error) {
-      console.warn('[FrameToolHandler] HTTP client failed, falling back to direct access:', error.message);
+      console.error('[FrameToolHandler] HTTP client failed, falling back to direct access:', error.message);
       frame = await this.chromeController.getFrame(args.sessionId, args.frameIndex);
     }
     
@@ -534,7 +534,7 @@ export class FrameToolHandler {
         results = await this.chromeController.searchFrameLogs(args.sessionId, args.searchText, logLevel, maxResults);
       }
     } catch (error) {
-      console.warn('[FrameToolHandler] HTTP client failed, falling back to direct access:', error.message);
+      console.error('[FrameToolHandler] HTTP client failed, falling back to direct access:', error.message);
       results = await this.chromeController.searchFrameLogs(args.sessionId, args.searchText, logLevel, maxResults);
     }
     
@@ -577,7 +577,7 @@ export class FrameToolHandler {
         results = await this.chromeController.getFrameLogsPaginated(args.sessionId, args.frameIndex, offset, limit, logLevel, searchText);
       }
     } catch (error) {
-      console.warn('[FrameToolHandler] HTTP client failed, falling back to direct access:', error.message);
+      console.error('[FrameToolHandler] HTTP client failed, falling back to direct access:', error.message);
       results = await this.chromeController.getFrameLogsPaginated(args.sessionId, args.frameIndex, offset, limit, logLevel, searchText);
     }
     
@@ -698,7 +698,7 @@ export class FrameToolHandler {
         }
       }
     } catch (error) {
-      console.warn('[FrameToolHandler] HTTP client failed, falling back to direct access:', error.message);
+      console.error('[FrameToolHandler] HTTP client failed, falling back to direct access:', error.message);
       if (args.frameIndex !== undefined) {
         interactions = await this.chromeController.getFrameInteractions(args.sessionId, args.frameIndex);
       } else {
@@ -936,7 +936,7 @@ export class FrameToolHandler {
             }
           }
         } catch (error) {
-          console.warn(`Error processing snapshot ${snapshot.id}:`, error.message);
+          console.error(`Error processing snapshot ${snapshot.id}:`, error.message);
         }
       }
 

package/src/mcp/handlers/workflow-tool-handler.js

@@ -77,7 +77,7 @@ export class WorkflowToolHandler {
         recording = await this.chromeController.getWorkflowRecording(args.sessionId);
       }
     } catch (error) {
-      console.warn('[WorkflowToolHandler] HTTP client failed, falling back to direct access:', error.message);
+      console.error('[WorkflowToolHandler] HTTP client failed, falling back to direct access:', error.message);
       recording = await this.chromeController.getWorkflowRecording(args.sessionId);
     }
     
@@ -112,7 +112,7 @@ export class WorkflowToolHandler {
         result = await this.chromeController.listWorkflowRecordings();
       }
     } catch (error) {
-      console.warn('[WorkflowToolHandler] HTTP client failed, falling back to direct access:', error.message);
+      console.error('[WorkflowToolHandler] HTTP client failed, falling back to direct access:', error.message);
       result = await this.chromeController.listWorkflowRecordings();
     }
     

package/src/middleware/security.js

@@ -38,7 +38,7 @@ export const corsOptions = {
     if (isAllowed) {
       callback(null, true);
     } else {
-      console.warn(`CORS: Blocked origin ${origin}`);
+      console.error(`CORS: Blocked origin ${origin}`);
       callback(new Error('Not allowed by CORS policy'));
     }
   },
@@ -165,14 +165,14 @@ export function securityLogger(req, res, next) {
   );
   
   if (isSensitive) {
-    console.log(`[Security] ${req.method} ${req.path} - User: ${req.user?.name || 'unauthenticated'} - IP: ${req.ip}`);
+    console.error(`[Security] ${req.method} ${req.path} - User: ${req.user?.name || 'unauthenticated'} - IP: ${req.ip}`);
   }
   
   // Track response time for monitoring
   res.on('finish', () => {
     const duration = Date.now() - start;
     if (duration > 5000) { // Log slow requests
-      console.warn(`[Performance] Slow request: ${req.method} ${req.path} - ${duration}ms`);
+      console.error(`[Performance] Slow request: ${req.method} ${req.path} - ${duration}ms`);
     }
   });
   
@@ -245,7 +245,7 @@ export function createIPWhitelist(allowedIPs = []) {
     const clientIP = req.ip || req.connection.remoteAddress;
     
     if (!allowedIPs.includes(clientIP)) {
-      console.warn(`[Security] Blocked IP: ${clientIP}`);
+      console.error(`[Security] Blocked IP: ${clientIP}`);
       return res.status(403).json({
         error: 'IP not whitelisted'
       });

package/src/services/browser-daemon.js

@@ -67,7 +67,7 @@ export class BrowserDaemon {
     const signals = ['SIGINT', 'SIGTERM', 'SIGQUIT'];
     signals.forEach(signal => {
       process.on(signal, async () => {
-        console.log(`[BrowserDaemon] Received ${signal}, initiating graceful shutdown...`);
+        console.error(`[BrowserDaemon] Received ${signal}, initiating graceful shutdown...`);
         await this.gracefulShutdown();
         process.exit(0);
       });
@@ -96,7 +96,7 @@ export class BrowserDaemon {
     }
 
     try {
-      console.log(`[BrowserDaemon] Starting daemon ${this.daemonId}...`);
+      console.error(`[BrowserDaemon] Starting daemon ${this.daemonId}...`);
 
       // Initialize core managers
       await this.profileManager.initialize();
@@ -116,7 +116,7 @@ export class BrowserDaemon {
       // Start health monitoring
       this.startHealthCheck();
 
-      console.log(`[BrowserDaemon] Daemon started successfully on port ${this.config.daemonPort}`);
+      console.error(`[BrowserDaemon] Daemon started successfully on port ${this.config.daemonPort}`);
 
       return {
         success: true,
@@ -167,9 +167,9 @@ export class BrowserDaemon {
         `--disable-extensions-except=${extensionPath}`,
         `--load-extension=${extensionPath}`
       );
-      console.log(`[BrowserDaemon] Loading ChromeDebug extension from: ${extensionPath}`);
+      console.error(`[BrowserDaemon] Loading ChromeDebug extension from: ${extensionPath}`);
     } else {
-      console.warn('[BrowserDaemon] ChromeDebug extension not found. Visual selection features will be unavailable.');
+      console.error('[BrowserDaemon] ChromeDebug extension not found. Visual selection features will be unavailable.');
     }
 
     const launchOptions = {
@@ -182,7 +182,7 @@ export class BrowserDaemon {
       userDataDir: await this.createSharedUserDataDir()
     };
 
-    console.log(`[BrowserDaemon] Launching Chrome with debugging port ${this.config.daemonPort}`);
+    console.error(`[BrowserDaemon] Launching Chrome with debugging port ${this.config.daemonPort}`);
     return await puppeteer.launch(launchOptions);
   }
 
@@ -196,7 +196,7 @@ export class BrowserDaemon {
     const sharedUserDataDir = path.join(tmpDir, sharedDirName);
 
     await fs.mkdir(sharedUserDataDir, { recursive: true });
-    console.log(`[BrowserDaemon] Created shared user data directory: ${sharedUserDataDir}`);
+    console.error(`[BrowserDaemon] Created shared user data directory: ${sharedUserDataDir}`);
 
     return sharedUserDataDir;
   }
@@ -262,7 +262,7 @@ export class BrowserDaemon {
         lastActivity: sessionData.lastActivity
       });
 
-      console.log(`[BrowserDaemon] Allocated session ${sessionId} for Claude instance ${claudeInstanceId}`);
+      console.error(`[BrowserDaemon] Allocated session ${sessionId} for Claude instance ${claudeInstanceId}`);
 
       return {
         success: true,
@@ -290,7 +290,7 @@ export class BrowserDaemon {
    */
   async deallocateSession(sessionId) {
     if (!sessionId || !this.activeSessions.has(sessionId)) {
-      console.warn(`[BrowserDaemon] Attempted to deallocate non-existent session: ${sessionId}`);
+      console.error(`[BrowserDaemon] Attempted to deallocate non-existent session: ${sessionId}`);
       return false;
     }
 
@@ -311,7 +311,7 @@ export class BrowserDaemon {
       // Remove from persistent registry
       await this.sessionRegistry.removeSession(sessionId);
 
-      console.log(`[BrowserDaemon] Deallocated session ${sessionId}`);
+      console.error(`[BrowserDaemon] Deallocated session ${sessionId}`);
       return true;
     } catch (error) {
       console.error(`[BrowserDaemon] Error deallocating session ${sessionId}:`, error);
@@ -369,7 +369,7 @@ export class BrowserDaemon {
     }
 
     this.healthCheckTimer = setInterval(this.performHealthCheck, this.config.healthCheckInterval);
-    console.log(`[BrowserDaemon] Started health check with ${this.config.healthCheckInterval}ms interval`);
+    console.error(`[BrowserDaemon] Started health check with ${this.config.healthCheckInterval}ms interval`);
   }
 
   /**
@@ -381,7 +381,7 @@ export class BrowserDaemon {
     try {
       // Check browser health - log status but don't restart
       if (!this.browser || this.browser.process()?.killed) {
-        console.warn('[BrowserDaemon] Browser process is down. Claude can launch a new browser when needed.');
+        console.error('[BrowserDaemon] Browser process is down. Claude can launch a new browser when needed.');
         // Don't restart - let Claude handle recovery via MCP tools
         return;
       }
@@ -399,12 +399,12 @@ export class BrowserDaemon {
 
       // Clean up expired sessions
       for (const sessionId of expiredSessions) {
-        console.log(`[BrowserDaemon] Cleaning up expired session: ${sessionId}`);
+        console.error(`[BrowserDaemon] Cleaning up expired session: ${sessionId}`);
         await this.deallocateSession(sessionId);
       }
 
       if (expiredSessions.length > 0) {
-        console.log(`[BrowserDaemon] Cleaned up ${expiredSessions.length} expired sessions`);
+        console.error(`[BrowserDaemon] Cleaned up ${expiredSessions.length} expired sessions`);
       }
 
     } catch (error) {
@@ -437,7 +437,7 @@ export class BrowserDaemon {
     if (this.isShuttingDown) return;
 
     this.isShuttingDown = true;
-    console.log('[BrowserDaemon] Initiating graceful shutdown...');
+    console.error('[BrowserDaemon] Initiating graceful shutdown...');
 
     try {
       // Stop health checks
@@ -447,7 +447,7 @@ export class BrowserDaemon {
       }
 
       // Clean up all active sessions
-      console.log(`[BrowserDaemon] Cleaning up ${this.activeSessions.size} active sessions...`);
+      console.error(`[BrowserDaemon] Cleaning up ${this.activeSessions.size} active sessions...`);
       for (const sessionId of this.activeSessions.keys()) {
         await this.deallocateSession(sessionId);
       }
@@ -462,7 +462,7 @@ export class BrowserDaemon {
       await this.cleanup();
 
       this.isRunning = false;
-      console.log('[BrowserDaemon] Graceful shutdown completed');
+      console.error('[BrowserDaemon] Graceful shutdown completed');
     } catch (error) {
       console.error('[BrowserDaemon] Error during graceful shutdown:', error);
     }

package/src/services/git-safety-service.js

@@ -157,7 +157,7 @@ export class GitSafetyService {
           backupInfo.created = true;
         } else {
           // Fallback to file copy if git stash fails
-          console.warn('Git stash failed, falling back to file copy:', gitBackup.error);
+          console.error('Git stash failed, falling back to file copy:', gitBackup.error);
           const fileBackup = await this._createFileCopyBackup(projectPath, operationId);
           backupInfo.strategy = 'file-copy';
           backupInfo.backupPath = fileBackup.backupPath;
@@ -502,7 +502,7 @@ export class GitSafetyService {
           mkdirSync(destDir, { recursive: true });
           copyFileSync(file, destPath);
         } catch (copyError) {
-          console.warn(`Failed to copy file ${file}:`, copyError.message);
+          console.error(`Failed to copy file ${file}:`, copyError.message);
         }
       }
 
@@ -670,6 +670,6 @@ export class GitSafetyService {
     // Clean up any temporary resources
     this.activeBackups.clear();
     this.operationHistory = [];
-    console.log('GitSafetyService cleanup completed');
+    console.error('GitSafetyService cleanup completed');
   }
 }

package/src/services/heartbeat-manager.js

@@ -41,7 +41,7 @@ export class HeartbeatManager {
     };
 
     this.heartbeats.set(sessionId, heartbeatData);
-    console.log(`[HeartbeatManager] Started heartbeat for session ${sessionId}`);
+    console.error(`[HeartbeatManager] Started heartbeat for session ${sessionId}`);
   }
 
   /**
@@ -53,7 +53,7 @@ export class HeartbeatManager {
     if (heartbeatData) {
       clearInterval(heartbeatData.interval);
       this.heartbeats.delete(sessionId);
-      console.log(`[HeartbeatManager] Stopped heartbeat for session ${sessionId}`);
+      console.error(`[HeartbeatManager] Stopped heartbeat for session ${sessionId}`);
     }
   }
 
@@ -75,9 +75,9 @@ export class HeartbeatManager {
     const heartbeatData = this.heartbeats.get(sessionId);
     if (heartbeatData) {
       heartbeatData.lastUpdate = new Date();
-      console.log(`[HeartbeatManager] Manual heartbeat update for session ${sessionId}`);
+      console.error(`[HeartbeatManager] Manual heartbeat update for session ${sessionId}`);
     } else {
-      console.warn(`[HeartbeatManager] Cannot update heartbeat for unknown session ${sessionId}`);
+      console.error(`[HeartbeatManager] Cannot update heartbeat for unknown session ${sessionId}`);
     }
   }
 
@@ -108,7 +108,7 @@ export class HeartbeatManager {
     }
 
     if (staleSessionIds.length > 0) {
-      console.log(`[HeartbeatManager] Found ${staleSessionIds.length} stale heartbeats:`, staleSessionIds);
+      console.error(`[HeartbeatManager] Found ${staleSessionIds.length} stale heartbeats:`, staleSessionIds);
     }
 
     return staleSessionIds;
@@ -152,7 +152,7 @@ export class HeartbeatManager {
    * Stops all heartbeats (cleanup method)
    */
   stopAllHeartbeats() {
-    console.log(`[HeartbeatManager] Stopping all heartbeats (${this.heartbeats.size} sessions)`);
+    console.error(`[HeartbeatManager] Stopping all heartbeats (${this.heartbeats.size} sessions)`);
     
     for (const [sessionId, heartbeatData] of this.heartbeats.entries()) {
       clearInterval(heartbeatData.interval);
@@ -173,7 +173,7 @@ export class HeartbeatManager {
     }
 
     if (staleSessionIds.length > 0) {
-      console.log(`[HeartbeatManager] Auto-cleaned ${staleSessionIds.length} stale heartbeats`);
+      console.error(`[HeartbeatManager] Auto-cleaned ${staleSessionIds.length} stale heartbeats`);
     }
 
     return staleSessionIds;

package/src/services/process-manager.js

@@ -67,7 +67,7 @@ async function findChromePilotProcesses() {
   // This allows the server to start on Windows without crashing
   // TODO: Implement proper Windows process management using tasklist or Node.js process handles
   if (process.platform === 'win32') {
-    console.log('[ChromeDebug] Process cleanup skipped on Windows (not yet implemented)');
+    console.error('[ChromeDebug] Process cleanup skipped on Windows (not yet implemented)');
     return { pidsToKill: [], processDescriptions: [] };
   }