@dynamic-labs/sdk-react-core 4.84.1 → 4.86.0

package/src/lib/widgets/DynamicWidget/components/ActiveWalletBalance/optimisticShield.cjs

@@ -19,28 +19,44 @@ const matches = (entry, token) => {
  * `balance` and `marketValue` scale by the same ratio so the fiat
  * column doesn't disagree with the optimistic raw balance.
  *
- * Tokens with no pending optimistic shield pass through by reference
- * (no copy) so downstream memos / identity comparisons don't churn on
- * every render.
+ * Rows that are zeroed by the deduction are dropped from the returned
+ * array so they disappear immediately from the unshielded list instead
+ * of lingering as a `<$0.01` ghost (the per-row fiat formatter renders
+ * any non-positive-but-non-undefined `marketValue` as `<$0.01`, which
+ * looks broken when the optimistic deduction has already taken the row
+ * to exactly 0). Rows untouched by the optimistic shield pass through
+ * by reference (no copy) so downstream memos / identity comparisons
+ * don't churn on every render.
  */
 const applyOptimisticUnshieldedDeductions = (balances, optimisticShields) => {
+    var _a, _b;
     if (optimisticShields.length === 0)
         return balances;
-    return balances.map((token) => {
-        var _a, _b;
+    const result = [];
+    for (const token of balances) {
         const adjustments = optimisticShields.filter((o) => matches(o, token));
-        if (adjustments.length === 0)
-            return token;
+        if (adjustments.length === 0) {
+            result.push(token);
+            continue;
+        }
         const currentRaw = BigInt(Math.round((_a = token.rawBalance) !== null && _a !== void 0 ? _a : 0));
         const totalAdjustment = adjustments.reduce((sum, o) => sum + o.amount, BigInt(0));
         const newRaw = currentRaw > totalAdjustment ? currentRaw - totalAdjustment : BigInt(0);
+        // Zero-out drop: the optimistic deduction took this row to (or
+        //  below) zero, so there is nothing useful to display. Filter it
+        //  out rather than emit a synthetic 0-balance row — otherwise the
+        //  `<$0.01` formatter renders it as a misleading dust value until
+        //  the server catches up and reconciliation drops the entry.
+        if (newRaw <= BigInt(0))
+            continue;
         // Ratio-scale display-units balance + fiat so they stay consistent
-        //  with the optimistic raw value. `currentRaw === 0n` happens when
-        //  the server feed has already caught up to zero but reconciliation
-        //  hasn't fired yet; treat ratio as 0 to keep display at 0.
+        //  with the optimistic raw value. `currentRaw === 0n` is
+        //  unreachable here (already handled by the zero-out drop above
+        //  via `newRaw <= 0`), but the guard remains as defence-in-depth.
         const ratio = currentRaw > BigInt(0) ? Number(newRaw) / Number(currentRaw) : 0;
-        return Object.assign(Object.assign({}, token), { balance: ((_b = token.balance) !== null && _b !== void 0 ? _b : 0) * ratio, marketValue: token.marketValue !== undefined ? token.marketValue * ratio : undefined, rawBalance: Number(newRaw), rawBalanceString: newRaw.toString() });
-    });
+        result.push(Object.assign(Object.assign({}, token), { balance: ((_b = token.balance) !== null && _b !== void 0 ? _b : 0) * ratio, marketValue: token.marketValue !== undefined ? token.marketValue * ratio : undefined, rawBalance: Number(newRaw), rawBalanceString: newRaw.toString() }));
+    }
+    return result;
 };
 /**
  * Apply optimistic shield additions to the shielded balance list. For

package/src/lib/widgets/DynamicWidget/components/ActiveWalletBalance/optimisticShield.d.ts

@@ -30,9 +30,14 @@ export declare const OPTIMISTIC_SHIELD_STALE_MS = 180000;
  * `balance` and `marketValue` scale by the same ratio so the fiat
  * column doesn't disagree with the optimistic raw balance.
  *
- * Tokens with no pending optimistic shield pass through by reference
- * (no copy) so downstream memos / identity comparisons don't churn on
- * every render.
+ * Rows that are zeroed by the deduction are dropped from the returned
+ * array so they disappear immediately from the unshielded list instead
+ * of lingering as a `<$0.01` ghost (the per-row fiat formatter renders
+ * any non-positive-but-non-undefined `marketValue` as `<$0.01`, which
+ * looks broken when the optimistic deduction has already taken the row
+ * to exactly 0). Rows untouched by the optimistic shield pass through
+ * by reference (no copy) so downstream memos / identity comparisons
+ * don't churn on every render.
  */
 export declare const applyOptimisticUnshieldedDeductions: (balances: TokenBalance[], optimisticShields: ReadonlyArray<OptimisticShieldEntry>) => TokenBalance[];
 /**

package/src/lib/widgets/DynamicWidget/components/ActiveWalletBalance/optimisticShield.js

@@ -15,28 +15,44 @@ const matches = (entry, token) => {
  * `balance` and `marketValue` scale by the same ratio so the fiat
  * column doesn't disagree with the optimistic raw balance.
  *
- * Tokens with no pending optimistic shield pass through by reference
- * (no copy) so downstream memos / identity comparisons don't churn on
- * every render.
+ * Rows that are zeroed by the deduction are dropped from the returned
+ * array so they disappear immediately from the unshielded list instead
+ * of lingering as a `<$0.01` ghost (the per-row fiat formatter renders
+ * any non-positive-but-non-undefined `marketValue` as `<$0.01`, which
+ * looks broken when the optimistic deduction has already taken the row
+ * to exactly 0). Rows untouched by the optimistic shield pass through
+ * by reference (no copy) so downstream memos / identity comparisons
+ * don't churn on every render.
  */
 const applyOptimisticUnshieldedDeductions = (balances, optimisticShields) => {
+    var _a, _b;
     if (optimisticShields.length === 0)
         return balances;
-    return balances.map((token) => {
-        var _a, _b;
+    const result = [];
+    for (const token of balances) {
         const adjustments = optimisticShields.filter((o) => matches(o, token));
-        if (adjustments.length === 0)
-            return token;
+        if (adjustments.length === 0) {
+            result.push(token);
+            continue;
+        }
         const currentRaw = BigInt(Math.round((_a = token.rawBalance) !== null && _a !== void 0 ? _a : 0));
         const totalAdjustment = adjustments.reduce((sum, o) => sum + o.amount, BigInt(0));
         const newRaw = currentRaw > totalAdjustment ? currentRaw - totalAdjustment : BigInt(0);
+        // Zero-out drop: the optimistic deduction took this row to (or
+        //  below) zero, so there is nothing useful to display. Filter it
+        //  out rather than emit a synthetic 0-balance row — otherwise the
+        //  `<$0.01` formatter renders it as a misleading dust value until
+        //  the server catches up and reconciliation drops the entry.
+        if (newRaw <= BigInt(0))
+            continue;
         // Ratio-scale display-units balance + fiat so they stay consistent
-        //  with the optimistic raw value. `currentRaw === 0n` happens when
-        //  the server feed has already caught up to zero but reconciliation
-        //  hasn't fired yet; treat ratio as 0 to keep display at 0.
+        //  with the optimistic raw value. `currentRaw === 0n` is
+        //  unreachable here (already handled by the zero-out drop above
+        //  via `newRaw <= 0`), but the guard remains as defence-in-depth.
         const ratio = currentRaw > BigInt(0) ? Number(newRaw) / Number(currentRaw) : 0;
-        return Object.assign(Object.assign({}, token), { balance: ((_b = token.balance) !== null && _b !== void 0 ? _b : 0) * ratio, marketValue: token.marketValue !== undefined ? token.marketValue * ratio : undefined, rawBalance: Number(newRaw), rawBalanceString: newRaw.toString() });
-    });
+        result.push(Object.assign(Object.assign({}, token), { balance: ((_b = token.balance) !== null && _b !== void 0 ? _b : 0) * ratio, marketValue: token.marketValue !== undefined ? token.marketValue * ratio : undefined, rawBalance: Number(newRaw), rawBalanceString: newRaw.toString() }));
+    }
+    return result;
 };
 /**
  * Apply optimistic shield additions to the shielded balance list. For