npm - @dynamic-labs/ethereum - Versions diffs - 2.0.0-alpha.20 → 2.0.0-alpha.21 - Mend

@dynamic-labs/ethereum 2.0.0-alpha.20 → 2.0.0-alpha.21

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (4) hide show

package/CHANGELOG.md +13 -0
package/package.json +8 -8
package/src/walletConnect/walletConnect.cjs +12 -3
package/src/walletConnect/walletConnect.js +12 -3

package/CHANGELOG.md CHANGED Viewed

@@ -1,4 +1,17 @@
+## [2.0.0-alpha.21](https://github.com/dynamic-labs/DynamicAuth/compare/v2.0.0-alpha.20...v2.0.0-alpha.21) (2024-03-20)
+### Features
+* implement barebones signer in PhantomRedirect connector ([#5043](https://github.com/dynamic-labs/DynamicAuth/issues/5043)) ([4d7ff79](https://github.com/dynamic-labs/DynamicAuth/commit/4d7ff79acfe554d651791139b5e1d23ebafe712c))
+### Bug Fixes
+* find embedded wallets when no chain is specified ([#5036](https://github.com/dynamic-labs/DynamicAuth/issues/5036)) ([ac50742](https://github.com/dynamic-labs/DynamicAuth/commit/ac50742c6002f48aae7b60c9ec094eb12df8dcca))
+* ignore walletconnect chainChange event when it's the same chain ([#5029](https://github.com/dynamic-labs/DynamicAuth/issues/5029)) ([115311a](https://github.com/dynamic-labs/DynamicAuth/commit/115311a4a64ae35317b8864f93c38203566714fc))
 ## [2.0.0-alpha.20](https://github.com/dynamic-labs/DynamicAuth/compare/v2.0.0-alpha.19...v2.0.0-alpha.20) (2024-03-19)

package/package.json CHANGED Viewed

@@ -1,6 +1,6 @@
 {
   "name": "@dynamic-labs/ethereum",
-  "version": "2.0.0-alpha.20",
+  "version": "2.0.0-alpha.21",
   "repository": {
     "type": "git",
     "url": "https://github.com/dynamic-labs/DynamicAuth.git",
@@ -30,13 +30,13 @@
     "@walletconnect/universal-provider": "2.10.6",
     "eventemitter3": "5.0.1",
     "buffer": "6.0.3",
-    "@dynamic-labs/rpc-provider-ethereum": "2.0.0-alpha.20",
-    "@dynamic-labs/turnkey": "2.0.0-alpha.20",
-    "@dynamic-labs/types": "2.0.0-alpha.20",
-    "@dynamic-labs/utils": "2.0.0-alpha.20",
-    "@dynamic-labs/viem-utils": "2.0.0-alpha.20",
-    "@dynamic-labs/wallet-book": "2.0.0-alpha.20",
-    "@dynamic-labs/wallet-connector-core": "2.0.0-alpha.20",
+    "@dynamic-labs/rpc-provider-ethereum": "2.0.0-alpha.21",
+    "@dynamic-labs/turnkey": "2.0.0-alpha.21",
+    "@dynamic-labs/types": "2.0.0-alpha.21",
+    "@dynamic-labs/utils": "2.0.0-alpha.21",
+    "@dynamic-labs/viem-utils": "2.0.0-alpha.21",
+    "@dynamic-labs/wallet-book": "2.0.0-alpha.21",
+    "@dynamic-labs/wallet-connector-core": "2.0.0-alpha.21",
     "stream": "0.0.2"
   },
   "peerDependencies": {

package/src/walletConnect/walletConnect.cjs CHANGED Viewed

@@ -191,6 +191,10 @@ class WalletConnect extends EthWalletConnector.EthWalletConnector {
             const { name, data } = params.event;
             if (name === 'chainChanged') {
                 const chainId = parseIntSafe.parseIntSafe(data);
+                if (chainId === this.currentChainId) {
+                    walletConnectorCore.logger.debug(`ignoring chainChanged event with same chain id as current chain id: ${chainId}`);
+                    return;
+                }
                 if (chainId === undefined) {
                     walletConnectorCore.logger.debug(`received unexpected data for chainChanged: ${data} with type ${typeof data}}`);
                     return;
@@ -286,7 +290,10 @@ class WalletConnect extends EthWalletConnector.EthWalletConnector {
                     }
                     this.setSession(session);
                     this.setActiveAccount(session.namespaces.eip155.accounts[0].split(':')[2]);
-                    resolve(this.activeAccount);
+                    this.getNetwork().then((chainId) => {
+                        this.currentChainId = chainId;
+                        resolve(this.activeAccount);
+                    });
                     // We must clean up the onConnect and onFail listeners
                     // whenever the connection attempt either succeeds or fails
                     cleanupListeners();
@@ -314,10 +321,12 @@ class WalletConnect extends EthWalletConnector.EthWalletConnector {
      */
     waitForSignMessage(signMessageFn, messageToSign) {
         return _tslib.__awaiter(this, void 0, void 0, function* () {
-            const raceConditionPromise = new Promise((resolve) => {
+            const raceConditionPromise = new Promise((resolve, reject) => {
                 // Create listener for chain change event
                 this.on('chainChange', () => resolve({ success: false }));
-                signMessageFn(messageToSign).then((result) => resolve({ signedMessage: result, success: true }));
+                signMessageFn(messageToSign)
+                    .then((result) => resolve({ signedMessage: result, success: true }))
+                    .catch(reject);
             });
             const signedMessageResult = yield raceConditionPromise;
             if (signedMessageResult.success === false) {

package/src/walletConnect/walletConnect.js CHANGED Viewed

@@ -182,6 +182,10 @@ class WalletConnect extends EthWalletConnector {
             const { name, data } = params.event;
             if (name === 'chainChanged') {
                 const chainId = parseIntSafe(data);
+                if (chainId === this.currentChainId) {
+                    logger.debug(`ignoring chainChanged event with same chain id as current chain id: ${chainId}`);
+                    return;
+                }
                 if (chainId === undefined) {
                     logger.debug(`received unexpected data for chainChanged: ${data} with type ${typeof data}}`);
                     return;
@@ -277,7 +281,10 @@ class WalletConnect extends EthWalletConnector {
                     }
                     this.setSession(session);
                     this.setActiveAccount(session.namespaces.eip155.accounts[0].split(':')[2]);
-                    resolve(this.activeAccount);
+                    this.getNetwork().then((chainId) => {
+                        this.currentChainId = chainId;
+                        resolve(this.activeAccount);
+                    });
                     // We must clean up the onConnect and onFail listeners
                     // whenever the connection attempt either succeeds or fails
                     cleanupListeners();
@@ -305,10 +312,12 @@ class WalletConnect extends EthWalletConnector {
      */
     waitForSignMessage(signMessageFn, messageToSign) {
         return __awaiter(this, void 0, void 0, function* () {
-            const raceConditionPromise = new Promise((resolve) => {
+            const raceConditionPromise = new Promise((resolve, reject) => {
                 // Create listener for chain change event
                 this.on('chainChange', () => resolve({ success: false }));
-                signMessageFn(messageToSign).then((result) => resolve({ signedMessage: result, success: true }));
+                signMessageFn(messageToSign)
+                    .then((result) => resolve({ signedMessage: result, success: true }))
+                    .catch(reject);
             });
             const signedMessageResult = yield raceConditionPromise;
             if (signedMessageResult.success === false) {