@dynamic-labs-wallet/browser 1.1.22 → 1.1.23

package/index.cjs

@@ -574,14 +574,14 @@ function meetsMinVersion(sdkVersion, { minVersionByNamespace, fallbackMinVersion
 
 /**
  * Datadog event name emitted on every signed-session nonce rejection (a 400 or
- * 401 from the backup/recovery endpoints). Log-only: lets us split the failure
+ * 403 from the backup/recovery endpoints). Log-only: lets us split the failure
  * bucket by `reason` and measure the true per-wallet unrecoverable rate
  * without changing any retry behavior. See DYNT-1599.
  */ const NONCE_FAILURE_EVENT = 'waas.signed_session.nonce_failure';
 /**
- * Reasons that represent a genuine session-key signature mismatch (the 401 the
- * server returns per DYNT-1282). Used to gate 401 instrumentation so callers
- * that reuse 401 for unrelated rejections don't pollute the failure metric.
+ * Reasons that represent a genuine session-key signature mismatch (the 403 the
+ * server returns per DYNT-1282). Used to gate 403 instrumentation so callers
+ * that reuse 403 for unrelated rejections don't pollute the failure metric.
  */ const SESSION_SIGNATURE_FAILURE_REASONS = new Set([
     'invalid_nonce_signature',
     'invalid_session_signature'
@@ -675,12 +675,12 @@ function meetsMinVersion(sdkVersion, { minVersionByNamespace, fallbackMinVersion
         let hasRefreshed = false;
         return async (error, attempt)=>{
             const status = getHttpStatus(error);
-            // A 400 is a refreshable replay nonce; a 401 is a session-key mismatch the
-            // server returns to break the refresh loop (DYNT-1282) — logged only when the
-            // body classifies as a genuine session-signature failure so unrelated 401s
+            // A 400 is a refreshable replay nonce; a 403 is a session-key
+            // mismatch the server returns to break the refresh loop (DYNT-1282) — logged only
+            // when the body classifies as a genuine session-signature failure so unrelated 403s
             // (e.g. an exhausted add-signer grant) don't pollute the DYNT-1599 metric.
             // Only the 400 can actually refresh.
-            const isSessionSignatureFailure = status === 401 && SESSION_SIGNATURE_FAILURE_REASONS.has(classifyNonceFailure(readErrorBody(error)));
+            const isSessionSignatureFailure = status === 403 && SESSION_SIGNATURE_FAILURE_REASONS.has(classifyNonceFailure(readErrorBody(error)));
             const shouldInstrument = status === 400 || isSessionSignatureFailure;
             if (shouldInstrument) {
                 const willRefresh = status === 400 && !hasRefreshed && this.canRefresh && this.supportsReverseChannel();
@@ -878,6 +878,13 @@ const SIGNED_SESSION_FAILURE_STATUSES = new Set([
     400,
     401
 ]);
+// CKS returns a session-key mismatch as 403. Other 403s (e.g. a rejected grant)
+// are unrelated, so a 403 only counts when the backend code names a signature failure.
+const SESSION_KEY_MISMATCH_STATUS = 403;
+const SESSION_KEY_MISMATCH_REASONS = new Set([
+    'invalid_nonce_signature',
+    'invalid_session_signature'
+]);
 const NONCE_REASON_TO_BACKUP_REASON = {
     nonce_already_used: 'nonce_already_used',
     invalid_nonce_signature: 'invalid_nonce_signature',
@@ -890,13 +897,17 @@ const classifyWalletApiError = (error)=>{
     if (error.status === core.NETWORK_ERROR_STATUS) {
         return 'network';
     }
-    if (!SIGNED_SESSION_FAILURE_STATUSES.has(error.status)) {
+    const isSignedSessionStatus = SIGNED_SESSION_FAILURE_STATUSES.has(error.status);
+    if (!isSignedSessionStatus && error.status !== SESSION_KEY_MISMATCH_STATUS) {
         return 'upload_failure';
     }
     const nonceReason = classifyNonceFailure({
         code: error.code,
         message: error.message
     });
+    if (!isSignedSessionStatus && !SESSION_KEY_MISMATCH_REASONS.has(nonceReason)) {
+        return 'upload_failure';
+    }
     return NONCE_REASON_TO_BACKUP_REASON[nonceReason];
 };
 const isNetworkLikeError = (error)=>{

package/index.esm.js

@@ -575,14 +575,14 @@ function meetsMinVersion(sdkVersion, { minVersionByNamespace, fallbackMinVersion
 
 /**
  * Datadog event name emitted on every signed-session nonce rejection (a 400 or
- * 401 from the backup/recovery endpoints). Log-only: lets us split the failure
+ * 403 from the backup/recovery endpoints). Log-only: lets us split the failure
  * bucket by `reason` and measure the true per-wallet unrecoverable rate
  * without changing any retry behavior. See DYNT-1599.
  */ const NONCE_FAILURE_EVENT = 'waas.signed_session.nonce_failure';
 /**
- * Reasons that represent a genuine session-key signature mismatch (the 401 the
- * server returns per DYNT-1282). Used to gate 401 instrumentation so callers
- * that reuse 401 for unrelated rejections don't pollute the failure metric.
+ * Reasons that represent a genuine session-key signature mismatch (the 403 the
+ * server returns per DYNT-1282). Used to gate 403 instrumentation so callers
+ * that reuse 403 for unrelated rejections don't pollute the failure metric.
  */ const SESSION_SIGNATURE_FAILURE_REASONS = new Set([
     'invalid_nonce_signature',
     'invalid_session_signature'
@@ -676,12 +676,12 @@ function meetsMinVersion(sdkVersion, { minVersionByNamespace, fallbackMinVersion
         let hasRefreshed = false;
         return async (error, attempt)=>{
             const status = getHttpStatus(error);
-            // A 400 is a refreshable replay nonce; a 401 is a session-key mismatch the
-            // server returns to break the refresh loop (DYNT-1282) — logged only when the
-            // body classifies as a genuine session-signature failure so unrelated 401s
+            // A 400 is a refreshable replay nonce; a 403 is a session-key
+            // mismatch the server returns to break the refresh loop (DYNT-1282) — logged only
+            // when the body classifies as a genuine session-signature failure so unrelated 403s
             // (e.g. an exhausted add-signer grant) don't pollute the DYNT-1599 metric.
             // Only the 400 can actually refresh.
-            const isSessionSignatureFailure = status === 401 && SESSION_SIGNATURE_FAILURE_REASONS.has(classifyNonceFailure(readErrorBody(error)));
+            const isSessionSignatureFailure = status === 403 && SESSION_SIGNATURE_FAILURE_REASONS.has(classifyNonceFailure(readErrorBody(error)));
             const shouldInstrument = status === 400 || isSessionSignatureFailure;
             if (shouldInstrument) {
                 const willRefresh = status === 400 && !hasRefreshed && this.canRefresh && this.supportsReverseChannel();
@@ -879,6 +879,13 @@ const SIGNED_SESSION_FAILURE_STATUSES = new Set([
     400,
     401
 ]);
+// CKS returns a session-key mismatch as 403. Other 403s (e.g. a rejected grant)
+// are unrelated, so a 403 only counts when the backend code names a signature failure.
+const SESSION_KEY_MISMATCH_STATUS = 403;
+const SESSION_KEY_MISMATCH_REASONS = new Set([
+    'invalid_nonce_signature',
+    'invalid_session_signature'
+]);
 const NONCE_REASON_TO_BACKUP_REASON = {
     nonce_already_used: 'nonce_already_used',
     invalid_nonce_signature: 'invalid_nonce_signature',
@@ -891,13 +898,17 @@ const classifyWalletApiError = (error)=>{
     if (error.status === NETWORK_ERROR_STATUS) {
         return 'network';
     }
-    if (!SIGNED_SESSION_FAILURE_STATUSES.has(error.status)) {
+    const isSignedSessionStatus = SIGNED_SESSION_FAILURE_STATUSES.has(error.status);
+    if (!isSignedSessionStatus && error.status !== SESSION_KEY_MISMATCH_STATUS) {
         return 'upload_failure';
     }
     const nonceReason = classifyNonceFailure({
         code: error.code,
         message: error.message
     });
+    if (!isSignedSessionStatus && !SESSION_KEY_MISMATCH_REASONS.has(nonceReason)) {
+        return 'upload_failure';
+    }
     return NONCE_REASON_TO_BACKUP_REASON[nonceReason];
 };
 const isNetworkLikeError = (error)=>{

package/package.json

@@ -1,12 +1,12 @@
 {
   "name": "@dynamic-labs-wallet/browser",
-  "version": "1.1.22",
+  "version": "1.1.23",
   "license": "Licensed under the Dynamic Labs, Inc. Terms Of Service (https://www.dynamic.xyz/terms-conditions)",
   "type": "module",
   "dependencies": {
-    "@dynamic-labs-wallet/core": "1.1.22",
+    "@dynamic-labs-wallet/core": "1.1.23",
     "@dynamic-labs-wallet/forward-mpc-client": "2.0.2",
-    "@dynamic-labs-wallet/primitives": "1.1.22",
+    "@dynamic-labs-wallet/primitives": "1.1.23",
     "@dynamic-labs/sdk-api-core": "0.50.0",
     "@noble/curves": "1.8.0",
     "argon2id": "1.0.1",

package/src/backup/password/errors.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"errors.d.ts","sourceRoot":"","sources":["../../../src/backup/password/errors.ts"],"names":[],"mappings":"AAaA;;;GAGG;AACH,MAAM,MAAM,iBAAiB,GAAG,aAAa,GAAG,gBAAgB,GAAG,cAAc,CAAC;AAElF;;;;;;;GAOG;AACH,MAAM,MAAM,yBAAyB,GACjC,gBAAgB,GAChB,oBAAoB,GACpB,oBAAoB,GACpB,yBAAyB,GACzB,2BAA2B,GAC3B,gBAAgB,GAChB,oBAAoB,GACpB,oBAAoB,GACpB,gBAAgB,GAChB,oBAAoB,GACpB,mBAAmB,GACnB,2BAA2B,GAC3B,kBAAkB,GAClB,oBAAoB,GACpB,SAAS,GACT,SAAS,CAAC;AAEd;;;;;;;;;;GAUG;AACH,eAAO,MAAM,6CAA6C;;;;;;;;;;;;;;;;;CAiBK,CAAC;AAEhE,eAAO,MAAM,yCAAyC,WAAY,yBAAyB,KAAG,OACvC,CAAC;AA4JxD;;;;;;;;;GASG;AACH,eAAO,MAAM,2BAA2B,UAAW,OAAO,KAAG,yBAM5D,CAAC"}
+{"version":3,"file":"errors.d.ts","sourceRoot":"","sources":["../../../src/backup/password/errors.ts"],"names":[],"mappings":"AAaA;;;GAGG;AACH,MAAM,MAAM,iBAAiB,GAAG,aAAa,GAAG,gBAAgB,GAAG,cAAc,CAAC;AAElF;;;;;;;GAOG;AACH,MAAM,MAAM,yBAAyB,GACjC,gBAAgB,GAChB,oBAAoB,GACpB,oBAAoB,GACpB,yBAAyB,GACzB,2BAA2B,GAC3B,gBAAgB,GAChB,oBAAoB,GACpB,oBAAoB,GACpB,gBAAgB,GAChB,oBAAoB,GACpB,mBAAmB,GACnB,2BAA2B,GAC3B,kBAAkB,GAClB,oBAAoB,GACpB,SAAS,GACT,SAAS,CAAC;AAEd;;;;;;;;;;GAUG;AACH,eAAO,MAAM,6CAA6C;;;;;;;;;;;;;;;;;CAiBK,CAAC;AAEhE,eAAO,MAAM,yCAAyC,WAAY,yBAAyB,KAAG,OACvC,CAAC;AAwKxD;;;;;;;;;GASG;AACH,eAAO,MAAM,2BAA2B,UAAW,OAAO,KAAG,yBAM5D,CAAC"}

package/src/services/signedSession.d.ts

@@ -3,7 +3,7 @@ import type { ILogger } from '@dynamic-labs-wallet/core';
 type ShouldRetry = (error: unknown, attempt: number) => boolean | Promise<boolean>;
 /**
  * Datadog event name emitted on every signed-session nonce rejection (a 400 or
- * 401 from the backup/recovery endpoints). Log-only: lets us split the failure
+ * 403 from the backup/recovery endpoints). Log-only: lets us split the failure
  * bucket by `reason` and measure the true per-wallet unrecoverable rate
  * without changing any retry behavior. See DYNT-1599.
  */
@@ -11,7 +11,7 @@ export declare const NONCE_FAILURE_EVENT = "waas.signed_session.nonce_failure";
 /**
  * Coarse cause of a signed-session nonce rejection. `invalid_nonce_signature`
  * and `invalid_session_signature` (a bad/stale signing key that diverged from
- * the JWT-embedded session key — surfaced as a 401 since DYNT-1282) cannot be
+ * the JWT-embedded session key — surfaced as a 403 since DYNT-1282) cannot be
  * fixed by refreshing the nonce, whereas `nonce_already_used` (a consumed
  * replay nonce, a 400) can — so splitting them tells us whether the
  * refresh-and-retry path can actually help.