@dynamatix/cat-shared 0.0.91 → 0.0.92

package/middlewares/audit.middleware.js

@@ -135,7 +135,7 @@ function applyAuditMiddleware(schema, collectionName) {
                 });
             }
         }
-
+        logs = logs.filter(log => log.newValue !== log.oldValue);
         if (logs.length) {
             await AuditLog.insertMany(logs);
             await updateContextAuditCount(contextId, logs.length);
@@ -208,7 +208,7 @@ function applyAuditMiddleware(schema, collectionName) {
                 }
             }
         }
-
+        logs = logs.filter(log => log.newValue !== log.oldValue);
         if (logs.length) {
             await AuditLog.insertMany(logs);
             await updateContextAuditCount(contextId, logs.length);
@@ -220,9 +220,17 @@ function applyAuditMiddleware(schema, collectionName) {
 
     // Handle delete audits
     schema.pre(['findOneAndDelete', 'findByIdAndDelete', 'deleteOne', 'deleteMany'], async function (next) {
-        // Store the query to fetch document before deletion
-        this._deleteQuery = this.getQuery();
-        next();
+        try {
+            // Fetch the document before deletion
+            const docToDelete = await this.model.findOne(this.getQuery()).lean();
+            if (docToDelete) {
+                // Store the document for use in post middleware
+                this._docToDelete = docToDelete;
+            }
+            next();
+        } catch (error) {
+            next(error);
+        }
     });
 
     schema.post(['findOneAndDelete', 'findByIdAndDelete', 'deleteOne', 'deleteMany'], async function (result) {
@@ -231,16 +239,12 @@ function applyAuditMiddleware(schema, collectionName) {
         const auditConfig = await AuditConfigModel.findOne({ collectionName });
         if (!auditConfig?.trackDeletion) return;
 
-        // Fetch the document before it was deleted
-        const deletedDoc = await this.model.findOne(this._deleteQuery).lean();
-        if (!deletedDoc) return;
-
         const context = getContext();
         const userId = context?.userId || 'anonymous';
         const contextId = context?.contextId;
 
-        const entityDescription = await resolveEntityDescription(deletedDoc, auditConfig);
-        const deletionDescription = await resolveDeletionDescription(deletedDoc, auditConfig);
+        const entityDescription = await resolveEntityDescription(this._docToDelete, auditConfig);
+        const deletionDescription = await resolveDeletionDescription(this._docToDelete, auditConfig);
 
         const log = {
             name: deletionDescription || 'Entity Deletion',
@@ -254,7 +258,9 @@ function applyAuditMiddleware(schema, collectionName) {
                 contextId: contextId || deletedDoc._id
             }
         };
-
+        if (log.newValue === log.oldValue) {
+            return;
+        }
         await AuditLog.create(log);
         await updateContextAuditCount(contextId, 1);
         if (onAuditLogCreated) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@dynamatix/cat-shared",
-  "version": "0.0.91",
+  "version": "0.0.92",
   "main": "index.js",
   "scripts": {
     "test": "echo \"Error: no test specified\" && exit 1"