@dxos/shell 0.4.10-main.fe71b4c → 0.4.10-next.169e4e3

package/src/panels/IdentityPanel/IdentityPanel.tsx

@@ -53,8 +53,8 @@ const IdentityHeading = ({
   const fallbackValue = keyToFallback(identity.identityKey);
   const { t } = useTranslation('os');
   const [displayName, setDisplayName] = useState(identity.profile?.displayName ?? '');
-  const [emoji, setEmoji] = useState<string>(getEmojiValue(identity));
-  const [hue, setHue] = useState<string>(getHueValue(identity));
+  const [emoji, setEmojiDirectly] = useState<string>(getEmojiValue(identity));
+  const [hue, setHueDirectly] = useState<string>(getHueValue(identity));
   const { textValue, setTextValue } = useClipboardContext();
   const identityHex = identity.identityKey.toHex();
   const copied = textValue === identityHex;
@@ -67,9 +67,15 @@ const IdentityHeading = ({
     return onUpdateProfile?.(nextProfile);
   };
 
-  useEffect(() => {
+  const setEmoji = (nextEmoji: string) => {
+    setEmojiDirectly(nextEmoji);
     void handleUpdateProfile();
-  }, [emoji, hue]);
+  };
+
+  const setHue = (nextHue: string) => {
+    setHueDirectly(nextHue);
+    void handleUpdateProfile();
+  };
 
   const isConnected = connectionState === ConnectionState.ONLINE;
 

package/src/playwright/invitations.spec.ts

@@ -15,7 +15,9 @@ test.describe('Invitations', () => {
   let manager: InvitationsManager;
 
   // TODO(wittjosiah): Storybook takes a bit to be ready for testing against.
-  test.beforeAll(async ({ browser }) => {
+  test.beforeAll(async ({ browser, browserName }) => {
+    // TODO(wittjosiah): Storybook is broken in Safari/Webkit.
+    test.skip(browserName === 'webkit');
     test.setTimeout(60_000);
     manager = new InvitationsManager(browser);
     await manager.init();

package/src/stories/Invitations.e2e-stories.tsx

@@ -216,6 +216,9 @@ const Invitations = (args: { id: number; count: number }) => {
   );
 };
 
+// TODO(wittjosiah): This story fails to start in Safari/Webkit.
+//   The issue appears to be related to dynamic imports during client initialization.
+//   This does not seem to be a problem in other browsers nor in Safari in the app.
 export const Default = {
   render: (args: { id: number }) => (
     <ClipboardProvider>

package/src/testing/shell-manager.ts

@@ -75,7 +75,7 @@ export class ShellManager extends ScopedShellManager {
     await this.shell.getByTestId('device-list-item-current.options').click();
     await this.shell.getByTestId('device-list-item-current.join-existing').click();
     await this.shell.getByTestId('join-new-identity.reset-identity-input').fill('CONFIRM');
-    await this.shell.getByTestId('join-new-identity.reset-identity-input-confirm').click();
+    await this.shell.getByTestId('join-new-identity.reset-identity-confirm').click();
     await this.inputInvitation('device', invitationCode, this.shell);
   }
 
@@ -117,7 +117,8 @@ export class ShellManager extends ScopedShellManager {
 
   private async _onConsoleMessage(message: ConsoleMessage) {
     try {
-      const json = JSON.parse(message.text());
+      const text = message.text();
+      const json = JSON.parse(text.slice(text.indexOf('{')));
       if (json.invitationCode) {
         this._invitationCode.wake(json.invitationCode);
       }