@dxos/react-ui-menu 0.8.4-staging.60fe92afc8 → 0.9.1-main.c7dcc2e112

package/src/translations.ts

@@ -9,7 +9,9 @@ export const translationKey = '@dxos/react-ui-menu';
 export const translations = [
   {
     'en-US': {
-      [translationKey]: {},
+      [translationKey]: {
+        'toolbar-overflow.menu': 'More',
+      },
     },
   },
 ] as const satisfies Resource[];

package/src/types.ts

@@ -18,17 +18,20 @@ export type MenuSeparator = Node.Node<never, Pick<ToolbarSeparatorProps, 'varian
 
 export const isSeparator = (node: Node.Node): node is MenuSeparator => node.type === MenuSeparatorType;
 
-export type MenuSingleSelectActionGroup = { selectCardinality: 'single'; value: string };
-export type MenuMultipleSelectActionGroup = { selectCardinality: 'multiple'; value: string[] };
-
 export type MenuItemGroup<P extends Record<string, any> = Record<string, any>> = Node.ActionGroup<P>;
 
 export const isMenuGroup = (node: Node.Node): node is MenuItemGroup => node.type === Node.ActionGroupType;
 
-export type MenuItem = MenuSeparator | MenuAction | MenuItemGroup;
+/** Graph-sourced menu nodes carry plugin-specific properties validated at runtime. */
+export type GraphMenuItem = Node.Action | Node.ActionGroup;
+
+export type MenuItem = MenuSeparator | MenuAction | MenuItemGroup | GraphMenuItem;
+
+/** Group context for graph-backed dropdown menus (any graph node, not only action groups). */
+export type MenuGroupContext = MenuItemGroup | Node.Node;
 
 /** Atom-family-style accessor: returns an atom of items for a given group (or root when undefined). */
-export type MenuItemsAccessor = (group?: MenuItemGroup) => Atom.Atom<MenuItem[] | null>;
+export type MenuItemsAccessor = (group?: MenuGroupContext) => Atom.Atom<MenuItem[] | null>;
 
 export type ActionExecutor = (action: MenuAction, params: Node.InvokeProps) => void;
 
@@ -39,7 +42,7 @@ export type AddMenuItemsProps = {
   mode: MenuItemsMode;
   priority?: number;
   items: MenuItem[];
-  groupFilter?: (group?: MenuItemGroup) => boolean;
+  groupFilter?: (group?: MenuGroupContext) => boolean;
 };
 
 export type MenuItems = Omit<AddMenuItemsProps, 'priority'> & { priority: number };

package/src/util.ts

@@ -46,12 +46,7 @@ export const createMenuAction = <P extends {} = {}>(
     data: () => Effect.sync(invoke),
   }) satisfies MenuAction;
 
-export const createMenuItemGroup = <
-  P extends MenuItemGroupProperties = MenuItemGroupProperties & Partial<MenuActionProperties>,
->(
-  id: string,
-  properties: P,
-) =>
+export const createMenuItemGroup = <P extends MenuItemGroupProperties>(id: string, properties: P) =>
   ({
     id,
     type: Node.ActionGroupType,